)]}'
{"id":"openstack%2Fpython-openstackclient~254142","triplet_id":"openstack%2Fpython-openstackclient~master~I1e4273aef201fe9d8936e5c365ebb46068039892","project":"openstack/python-openstackclient","branch":"master","topic":"bp/osc-unit-test-framework-improvement","hashtags":[],"change_id":"I1e4273aef201fe9d8936e5c365ebb46068039892","subject":"TestServerGeneral: Add test for _format_servers_list_power_state()","status":"MERGED","created":"2015-12-07 11:59:16.000000000","updated":"2015-12-18 01:44:25.000000000","submitted":"2015-12-17 21:09:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"524f94114984eff8d3c06eeb49e57d24123fa116","_number":254142,"virtual_id_number":254142,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-12-17 21:09:46.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"date":"2015-12-18 01:44:25.000000000","post_submit":true,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"all":[{"value":2,"date":"2015-12-17 20:16:00.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":2,"date":"2015-12-09 09:17:30.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-12-17 19:53:06.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"all":[{"value":1,"date":"2015-12-17 20:16:00.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-12-17 19:53:06.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"date":"2015-12-10 10:00:16.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-09 05:31:37.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-12-10 10:00:16.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-12-17 19:53:06.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-12-17 20:16:00.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2015-12-17 21:09:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"96a3616ba27d1f07c0f80998b35cb3ff2e8f1bda","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-07 11:59:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9b270792b731f5f6e8cd5084958febdbbb7326f4","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-07 12:01:51.000000000","message":"Patch Set 1:\n\nWill add more helper tests soon.","accounts_in_message":[],"_revision_number":1},{"id":"a94f647fca9abf8582a12c430275b444cc94eee2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-07 13:02:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/42/254142/1/check/gate-python-openstackclient-pep8/16ca1df/ : SUCCESS in 1m 22s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/42/254142/1/check/gate-python-openstackclient-docs/83e575d//doc/build/html/ : SUCCESS in 2m 57s\n- gate-python-openstackclient-python27 http://logs.openstack.org/42/254142/1/check/gate-python-openstackclient-python27/fdb23f3/ : SUCCESS in 1m 48s\n- gate-python-openstackclient-python34 http://logs.openstack.org/42/254142/1/check/gate-python-openstackclient-python34/cd71ae2/ : SUCCESS in 2m 22s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/42/254142/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/2b5f97e/ : SUCCESS in 57m 52s\n- gate-osc-dsvm-functional http://logs.openstack.org/42/254142/1/check/gate-osc-dsvm-functional/465038f/ : SUCCESS in 25m 53s","accounts_in_message":[],"_revision_number":1},{"id":"6b4cbcf837a6541d9cbcb1b6be7c8992946ab179","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-08 07:32:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d40e3295bf8c276dcd77eaad3b7657f8e81b8f41","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-08 09:03:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/42/254142/2/check/gate-python-openstackclient-pep8/ff28199/ : SUCCESS in 1m 17s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/42/254142/2/check/gate-python-openstackclient-docs/5180509//doc/build/html/ : SUCCESS in 2m 23s\n- gate-python-openstackclient-python27 http://logs.openstack.org/42/254142/2/check/gate-python-openstackclient-python27/84c64b4/ : SUCCESS in 1m 32s\n- gate-python-openstackclient-python34 http://logs.openstack.org/42/254142/2/check/gate-python-openstackclient-python34/6e34e71/ : SUCCESS in 2m 14s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/42/254142/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/2e298a0/ : SUCCESS in 1h 26m 48s\n- gate-osc-dsvm-functional http://logs.openstack.org/42/254142/2/check/gate-osc-dsvm-functional/fd1e99e/ : SUCCESS in 31m 13s","accounts_in_message":[],"_revision_number":2},{"id":"66628cfe4d0295ba6461daf6b105577250572fe2","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-09 05:31:37.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"42ac6e8fef9434cfc1d54be1d39c04cc84ad5479","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-09 09:17:30.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1fa308ee44ec71ff83f94260271cfb249d628a91","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-09 11:34:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/42/254142/3/check/gate-python-openstackclient-pep8/1358969/ : SUCCESS in 1m 07s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/42/254142/3/check/gate-python-openstackclient-docs/8f92683//doc/build/html/ : SUCCESS in 1m 51s\n- gate-python-openstackclient-python27 http://logs.openstack.org/42/254142/3/check/gate-python-openstackclient-python27/0dd69f3/ : SUCCESS in 1m 22s\n- gate-python-openstackclient-python34 http://logs.openstack.org/42/254142/3/check/gate-python-openstackclient-python34/55eb2a8/ : SUCCESS in 1m 57s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/42/254142/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/0bd2b0a/ : SUCCESS in 1h 05m 39s\n- gate-osc-dsvm-functional http://logs.openstack.org/42/254142/3/check/gate-osc-dsvm-functional/a7f88e7/ : SUCCESS in 25m 36s","accounts_in_message":[],"_revision_number":3},{"id":"2fcbc88be652d4e2d3e8df28b34d8e1ebea46357","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-10 09:59:58.000000000","message":"Patch Set 3: Code-Review-1\n\nIts good to have test on helper fuction, but I don\u0027t think we should be testing private methods too. this seem overtesting to me.","accounts_in_message":[],"_revision_number":3},{"id":"ff90a57eda70767f4267a58c9c41c88e343a1466","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-10 10:09:18.000000000","message":"Patch Set 3:\n\nif our test on public method does not exercise the private method completely, that means a shortcoming on the test of public method. and that could be improved.\n\nAlso, testing on private methods make the code more fragile and hard to refactor later.","accounts_in_message":[],"_revision_number":3},{"id":"e6059320d9ac01c5f8724b08f2892b53517bd928","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-10 11:09:18.000000000","message":"Patch Set 3:\n\nHi Cheng, Steve,\n\nCheng and I have discussed about this a little bit in IRC.\n\nMy concern is, for example, the formatter. For each test, we have to set up the result of the test again and again, formatted output. It is not good to call the formatter because there is no tests to ensure they are correct. If we can provide tests to test the helper functions, then we can call them in other test cases.\n\nAnd as Cheng has mentioned, if we didn\u0027t test fully for each public functions, we cannot ensure the private helper functions are correct.\n\nI agree with Cheng that if we have tested all the other functions fully, we can ensure the private functions are correct. But I think it will be more convenience if we can test the resuable private functions to ensure them correct first, and reuse them in other tests.\n\nSo I suggest, we provide a full test for each helper function, private or public, so that we can call them in other tests, and ensure they are correct at the same time.\n\nThanks.","accounts_in_message":[],"_revision_number":3},{"id":"cf3c0ca99324c89a853edae5c330fd74ab6f9a51","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-17 19:53:06.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nbrought this up in the meeting, for this particular case, the test should be fine.\n\nIn general we don\u0027t need test for private methods, but if its simple and useful we can go ahead.","accounts_in_message":[],"_revision_number":3},{"id":"7b2880068c2a1ff789c4a52d41a3c77bc15b4f71","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-17 19:53:56.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"ac14381a74e701fbf42d34c29e9c94853c9f3ce3","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2015-12-17 20:16:00.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"39627dcb370b255853a8f82622d0493d27ec1237","date":"2015-12-17 21:09:46.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"2c84faf9f8143adf122722c1797afbe0ca037f21","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-17 21:09:46.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/42/254142/3/gate/gate-python-openstackclient-docs/5a50402//doc/build/html/ : SUCCESS in 2m 07s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/42/254142/3/gate/gate-python-openstackclient-pep8/ca2823d/ : SUCCESS in 1m 19s\n- gate-python-openstackclient-python27 http://logs.openstack.org/42/254142/3/gate/gate-python-openstackclient-python27/c45b3e0/ : SUCCESS in 2m 39s\n- gate-python-openstackclient-python34 http://logs.openstack.org/42/254142/3/gate/gate-python-openstackclient-python34/f4468f3/ : SUCCESS in 2m 10s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/42/254142/3/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/471587b/ : SUCCESS in 1h 14m 41s\n- gate-osc-dsvm-functional http://logs.openstack.org/42/254142/3/gate/gate-osc-dsvm-functional/c32f875/ : SUCCESS in 29m 40s","accounts_in_message":[],"_revision_number":3},{"id":"130c7436f1530aed71a7e207846bb8e24d9f426f","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-18 01:44:25.000000000","message":"Patch Set 3:\n\nHi Cheng,\n\nThank you for bringing this to the meeting. I\u0027m sorry I didn\u0027t attend the meeting because it is at 3::00 am for me. :)\n\nWill try to attend once. :)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"a8ba54562b4e31c5a02c9aef19e1c016129e30f4","revisions":{"783a076735a2f3d29eafec378a5976926a014327":{"kind":"REWORK","_number":1,"created":"2015-12-07 11:59:16.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/42/254142/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/42/254142/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/254142/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/254142/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/254142/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/42/254142/1"}}},"commit":{"parents":[{"commit":"695500496cb0b5682d8de8d60fc74ffe311445f8","subject":"Merge \"Use formatter in server.py for \"server list\" tests.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/695500496cb0b5682d8de8d60fc74ffe311445f8"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-08 11:16:59.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-08 11:16:59.000000000","tz":480},"subject":"TestServerGeneral: Add test for _format_servers_list_power_state()","message":"TestServerGeneral: Add test for _format_servers_list_power_state()\n\nIf we have tests for each helper function, then we can call them\nin other tests without worrying about error.\n\nChange-Id: I1e4273aef201fe9d8936e5c365ebb46068039892\nImplements: blueprint osc-unit-test-framework-improvement\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/783a076735a2f3d29eafec378a5976926a014327"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/783a076735a2f3d29eafec378a5976926a014327"}]},"branch":"refs/heads/master"},"3b2ed39df255027806378ad9762bf7ae2273a3ad":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-12-08 07:32:56.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/42/254142/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/42/254142/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/254142/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/254142/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/254142/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/42/254142/2"}}},"commit":{"parents":[{"commit":"85d6aeea32e1d208b4af1247012fe63e68922a7d","subject":"Trivial: Coding style fix in test_flavor.py","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/85d6aeea32e1d208b4af1247012fe63e68922a7d"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-08 11:16:59.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-09 02:48:32.000000000","tz":480},"subject":"TestServerGeneral: Add test for _format_servers_list_power_state()","message":"TestServerGeneral: Add test for _format_servers_list_power_state()\n\nIf we have tests for each helper function, then we can call them\nin other tests without worrying about error.\n\nChange-Id: I1e4273aef201fe9d8936e5c365ebb46068039892\nImplements: blueprint osc-unit-test-framework-improvement\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3b2ed39df255027806378ad9762bf7ae2273a3ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3b2ed39df255027806378ad9762bf7ae2273a3ad"}]},"branch":"refs/heads/master"},"a8ba54562b4e31c5a02c9aef19e1c016129e30f4":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2015-12-09 09:17:30.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/42/254142/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/42/254142/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/254142/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/254142/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/254142/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/42/254142/3"}}},"commit":{"parents":[{"commit":"ccbffb2ef9cfad3398e66be9156cd155880193d8","subject":"Merge \"Use FakeVolume in server test cases.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ccbffb2ef9cfad3398e66be9156cd155880193d8"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-08 11:16:59.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-10 09:11:41.000000000","tz":480},"subject":"TestServerGeneral: Add test for _format_servers_list_power_state()","message":"TestServerGeneral: Add test for _format_servers_list_power_state()\n\nIf we have tests for each helper function, then we can call them\nin other tests without worrying about error.\n\nChange-Id: I1e4273aef201fe9d8936e5c365ebb46068039892\nImplements: blueprint osc-unit-test-framework-improvement\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a8ba54562b4e31c5a02c9aef19e1c016129e30f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a8ba54562b4e31c5a02c9aef19e1c016129e30f4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}