)]}'
{"id":"openstack%2Fpython-openstackclient~254593","triplet_id":"openstack%2Fpython-openstackclient~master~Ie0b83c42a5c3bbba630a064d28374d07e2ce9caf","project":"openstack/python-openstackclient","branch":"master","topic":"bp/osc-unit-test-framework-improvement","hashtags":[],"change_id":"Ie0b83c42a5c3bbba630a064d28374d07e2ce9caf","subject":"TestServerGeneral: Add test for _prep_server_detail()","status":"MERGED","created":"2015-12-08 07:32:56.000000000","updated":"2015-12-22 04:10:53.000000000","submitted":"2015-12-22 04:10:53.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9651b8b9933e75ac79b52601e3090d42c584019d","_number":254593,"virtual_id_number":254593,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-12-22 04:10:53.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-12-19 03:35:06.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-12-19 03:35:06.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":2,"date":"2015-12-21 16:53:43.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":1,"date":"2015-12-21 16:53:43.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-18 06:50:40.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-12-18 12:51:33.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-12-21 16:53:43.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-12-22 04:10:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4fec2b5d97308f688addb7e8039a88288795fa60","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-08 07:32:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f8699934ee9331cca6f5eea940942b82fd7b44b9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-08 08:56:21.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/254593/1/check/gate-python-openstackclient-pep8/c565b34/ : FAILURE in 1m 21s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/254593/1/check/gate-python-openstackclient-docs/fcd8d14//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/254593/1/check/gate-python-openstackclient-python27/187238e/ : SUCCESS in 1m 26s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/254593/1/check/gate-python-openstackclient-python34/95d7ea6/ : SUCCESS in 2m 11s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/254593/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/efd5846/ : SUCCESS in 1h 19m 54s\n- gate-osc-dsvm-functional http://logs.openstack.org/93/254593/1/check/gate-osc-dsvm-functional/4c08d4e/ : SUCCESS in 38m 24s","accounts_in_message":[],"_revision_number":1},{"id":"d0bc7bdb14c3b6697b7235975cd5ad9c1868e1af","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-08 09:06:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5f239a13f88ae439ed0ccc540e9a6dadef4ee5ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-08 10:22:37.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/254593/2/check/gate-python-openstackclient-pep8/ca04cfd/ : SUCCESS in 1m 08s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/254593/2/check/gate-python-openstackclient-docs/bbae443//doc/build/html/ : SUCCESS in 2m 00s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/254593/2/check/gate-python-openstackclient-python27/088b825/ : SUCCESS in 1m 32s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/254593/2/check/gate-python-openstackclient-python34/486942e/ : SUCCESS in 2m 08s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/254593/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/48e0cd8/ : SUCCESS in 1h 07m 52s\n- gate-osc-dsvm-functional http://logs.openstack.org/93/254593/2/check/gate-osc-dsvm-functional/dad47bd/ : SUCCESS in 31m 04s","accounts_in_message":[],"_revision_number":2},{"id":"3ace4a481a1377695efc9d7ab84a5e23672d124e","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-09 05:39:46.000000000","message":"Patch Set 2: Code-Review+2\n\nthis looks fine","accounts_in_message":[],"_revision_number":2},{"id":"95f7307ac118565552843b0748515ed6a4bb25ee","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-09 09:17:30.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1831cb80058c232886cf9f3f580f5eb3be82c4e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-09 11:57:39.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/254593/3/check/gate-python-openstackclient-pep8/c3b84da/ : SUCCESS in 1m 30s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/254593/3/check/gate-python-openstackclient-docs/b06311e//doc/build/html/ : SUCCESS in 1m 52s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/254593/3/check/gate-python-openstackclient-python27/98d4c63/ : SUCCESS in 1m 23s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/254593/3/check/gate-python-openstackclient-python34/29d7abc/ : SUCCESS in 1m 47s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/254593/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/d3a03a7/ : SUCCESS in 1h 30m 44s\n- gate-osc-dsvm-functional http://logs.openstack.org/93/254593/3/check/gate-osc-dsvm-functional/d869f51/ : SUCCESS in 26m 51s","accounts_in_message":[],"_revision_number":3},{"id":"467bf8487e3d3970532b99d82ae5a9b57182193c","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-10 10:02:42.000000000","message":"Patch Set 3: Code-Review-1\n\nsame comment here, I don\u0027t think testing private function is a good idea.\n\nIf we want to test this, it should be on the higher level methods.","accounts_in_message":[],"_revision_number":3},{"id":"6f0ae61354b829642fae4501831380026cf508ac","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-17 20:19:54.000000000","message":"Patch Set 3: -Code-Review","accounts_in_message":[],"_revision_number":3},{"id":"cd65673851f168436de84efb6046b1fee53f4baa","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-17 23:13:31.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"c264131b4b65e51d601c037acf64c71a4a5995c8","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-18 01:55:45.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"d3220dd3fab60a41bfa6a7ef477c6c99a653e327","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-18 03:16:21.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/254593/4/check/gate-python-openstackclient-pep8/323dc6e/ : SUCCESS in 1m 20s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/254593/4/check/gate-python-openstackclient-docs/2491217//doc/build/html/ : SUCCESS in 2m 57s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/254593/4/check/gate-python-openstackclient-python27/ce3574e/ : SUCCESS in 1m 30s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/254593/4/check/gate-python-openstackclient-python34/dc11756/ : SUCCESS in 2m 37s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/254593/4/check/gate-tempest-dsvm-neutron-src-python-openstackclient/5d698e7/ : SUCCESS in 1h 16m 11s\n- gate-osc-dsvm-functional http://logs.openstack.org/93/254593/4/check/gate-osc-dsvm-functional/439b3ad/ : SUCCESS in 36m 34s","accounts_in_message":[],"_revision_number":4},{"id":"5179fef60e15704448d1d0f07103f1cf1596ff6e","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-18 06:50:40.000000000","message":"Patch Set 4: Code-Review+2\n\ni\u0027m OK with this, but we should focus on testing functions that are not private :)","accounts_in_message":[],"_revision_number":4},{"id":"af6b08773b0a45bf2bf8f2d37d7c458efefb62e3","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-18 12:51:33.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"936875e99e7f8b69476f9369c358635386498eb0","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-19 03:35:06.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"41734dd685c7e7175d50d23e0c3eac07ed1a3b34","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-19 04:39:42.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/254593/5/check/gate-python-openstackclient-pep8/80322e8/ : SUCCESS in 1m 28s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/254593/5/check/gate-python-openstackclient-docs/8946074//doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/254593/5/check/gate-python-openstackclient-python27/34edf1d/ : SUCCESS in 1m 39s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/254593/5/check/gate-python-openstackclient-python34/5977cc6/ : SUCCESS in 2m 09s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/254593/5/check/gate-tempest-dsvm-neutron-src-python-openstackclient/629eb85/ : SUCCESS in 1h 04m 25s\n- gate-osc-dsvm-functional http://logs.openstack.org/93/254593/5/check/gate-osc-dsvm-functional/f93592d/ : SUCCESS in 28m 14s","accounts_in_message":[],"_revision_number":5},{"id":"df1cb23d7f8a5c6473339ad8326faf7e65babf68","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-12-21 16:53:43.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\nI am in favor of testing things that affect compatibility, whether they be private or not.  Especially if it is something that might someday be not-private.","accounts_in_message":[],"_revision_number":5},{"id":"2be9ffd1f09f7e91e6fd0e1e74ecd1e4557ed559","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-22 02:55:45.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"ed3cc119cf888eca0d3375151a73f8cf0396d1f5","date":"2015-12-22 04:10:53.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":5},{"id":"f6618d3a4b9e080ee5a7d26f065910089246c83c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-22 04:10:53.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/254593/5/gate/gate-python-openstackclient-docs/c2ca26b//doc/build/html/ : SUCCESS in 2m 23s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/254593/5/gate/gate-python-openstackclient-pep8/bea8916/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/254593/5/gate/gate-python-openstackclient-python27/b3cadef/ : SUCCESS in 1m 32s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/254593/5/gate/gate-python-openstackclient-python34/65c31c7/ : SUCCESS in 2m 36s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/254593/5/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/30ef743/ : SUCCESS in 1h 13m 32s\n- gate-osc-dsvm-functional http://logs.openstack.org/93/254593/5/gate/gate-osc-dsvm-functional/b16b289/ : SUCCESS in 25m 30s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"17f3685a83d29f33f79c0626eceefae029c2aaf5","revisions":{"810477e653e24bc670b659cb70a1bb26c0b4001d":{"kind":"REWORK","_number":1,"created":"2015-12-08 07:32:56.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/93/254593/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/93/254593/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/1"}}},"commit":{"parents":[{"commit":"43cab4dc0b2307b5d347cf3e947c7d1565600dea","subject":"TestServerGeneral: Add test for _format_servers_list_networks()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/43cab4dc0b2307b5d347cf3e947c7d1565600dea"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-09 03:20:34.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-09 04:22:22.000000000","tz":480},"subject":"TestServerGeneral: Add test for _prep_server_detail()","message":"TestServerGeneral: Add test for _prep_server_detail()\n\n1. Make TestServerGeneral inherit from TestServer because\n   we need to use servers_mock, image_mock and flavor_mock\n   in compute_client.\n2. Create a dict containing all info of a server in the\n   original format, and pass it to _prep_server_detail().\n3. Compare the original and formatted dict.\n\nChange-Id: Ie0b83c42a5c3bbba630a064d28374d07e2ce9caf\nImplements: blueprint osc-unit-test-framework-improvement\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/810477e653e24bc670b659cb70a1bb26c0b4001d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/810477e653e24bc670b659cb70a1bb26c0b4001d"}]},"branch":"refs/heads/master"},"2fa23178da6327cc6fe5963b01e9ae3115c91062":{"kind":"REWORK","_number":2,"created":"2015-12-08 09:06:31.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/93/254593/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/93/254593/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/2"}}},"commit":{"parents":[{"commit":"43cab4dc0b2307b5d347cf3e947c7d1565600dea","subject":"TestServerGeneral: Add test for _format_servers_list_networks()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/43cab4dc0b2307b5d347cf3e947c7d1565600dea"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-09 03:20:34.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-09 04:22:22.000000000","tz":480},"subject":"TestServerGeneral: Add test for _prep_server_detail()","message":"TestServerGeneral: Add test for _prep_server_detail()\n\n1. Make TestServerGeneral inherit from TestServer because\n   we need to use servers_mock, image_mock and flavor_mock\n   in compute_client.\n2. Create a dict containing all info of a server in the\n   original format, and pass it to _prep_server_detail().\n3. Compare the original and formatted dict.\n\nChange-Id: Ie0b83c42a5c3bbba630a064d28374d07e2ce9caf\nImplements: blueprint osc-unit-test-framework-improvement\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2fa23178da6327cc6fe5963b01e9ae3115c91062"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2fa23178da6327cc6fe5963b01e9ae3115c91062"}]},"branch":"refs/heads/master"},"990327296b7419a03f56f2ed2565909b19965870":{"kind":"REWORK","_number":3,"created":"2015-12-09 09:17:30.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/93/254593/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/93/254593/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/3"}}},"commit":{"parents":[{"commit":"3876c32ade16756d94046344b2bc28288400436b","subject":"TestServerGeneral: Add test for _format_servers_list_networks()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3876c32ade16756d94046344b2bc28288400436b"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-09 03:20:34.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-10 09:16:22.000000000","tz":480},"subject":"TestServerGeneral: Add test for _prep_server_detail()","message":"TestServerGeneral: Add test for _prep_server_detail()\n\n1. Make TestServerGeneral inherit from TestServer because\n   we need to use servers_mock, image_mock and flavor_mock\n   in compute_client.\n2. Create a dict containing all info of a server in the\n   original format, and pass it to _prep_server_detail().\n3. Compare the original and formatted dict.\n\nChange-Id: Ie0b83c42a5c3bbba630a064d28374d07e2ce9caf\nImplements: blueprint osc-unit-test-framework-improvement\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/990327296b7419a03f56f2ed2565909b19965870"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/990327296b7419a03f56f2ed2565909b19965870"}]},"branch":"refs/heads/master"},"178a10149d0be6c656355d3356b87267029d26dd":{"kind":"REWORK","_number":4,"created":"2015-12-18 01:55:45.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/93/254593/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/93/254593/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/4"}}},"commit":{"parents":[{"commit":"35a12630bd3bbcc1ce0c6524a8c0bdbd73aba2f4","subject":"TestServerGeneral: Add test for _format_servers_list_networks()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/35a12630bd3bbcc1ce0c6524a8c0bdbd73aba2f4"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-09 03:20:34.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-19 01:54:33.000000000","tz":480},"subject":"TestServerGeneral: Add test for _prep_server_detail()","message":"TestServerGeneral: Add test for _prep_server_detail()\n\n1. Make TestServerGeneral inherit from TestServer because\n   we need to use servers_mock, image_mock and flavor_mock\n   in compute_client.\n2. Create a dict containing all info of a server in the\n   original format, and pass it to _prep_server_detail().\n3. Compare the original and formatted dict.\n\nChange-Id: Ie0b83c42a5c3bbba630a064d28374d07e2ce9caf\nImplements: blueprint osc-unit-test-framework-improvement\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/178a10149d0be6c656355d3356b87267029d26dd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/178a10149d0be6c656355d3356b87267029d26dd"}]},"branch":"refs/heads/master"},"17f3685a83d29f33f79c0626eceefae029c2aaf5":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2015-12-19 03:35:06.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/93/254593/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/93/254593/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/93/254593/5"}}},"commit":{"parents":[{"commit":"b4660fec7dc1e1df53268e45e905d63f558cc383","subject":"TestServerGeneral: Add test for _format_servers_list_networks()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b4660fec7dc1e1df53268e45e905d63f558cc383"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-09 03:20:34.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-20 03:33:46.000000000","tz":480},"subject":"TestServerGeneral: Add test for _prep_server_detail()","message":"TestServerGeneral: Add test for _prep_server_detail()\n\n1. Make TestServerGeneral inherit from TestServer because\n   we need to use servers_mock, image_mock and flavor_mock\n   in compute_client.\n2. Create a dict containing all info of a server in the\n   original format, and pass it to _prep_server_detail().\n3. Compare the original and formatted dict.\n\nChange-Id: Ie0b83c42a5c3bbba630a064d28374d07e2ce9caf\nImplements: blueprint osc-unit-test-framework-improvement\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/17f3685a83d29f33f79c0626eceefae029c2aaf5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/17f3685a83d29f33f79c0626eceefae029c2aaf5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
