)]}'
{"id":"openstack%2Fpython-openstackclient~255531","triplet_id":"openstack%2Fpython-openstackclient~master~I733fd3ad5a825f06563c72aa430122e1a0e3b3b0","project":"openstack/python-openstackclient","branch":"master","topic":"bug-1524406","hashtags":[],"change_id":"I733fd3ad5a825f06563c72aa430122e1a0e3b3b0","subject":"Make --image parameter optional in \"server rebuild\"","status":"MERGED","created":"2015-12-09 21:21:57.000000000","updated":"2016-01-15 17:44:02.000000000","submitted":"2016-01-15 17:44:01.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"485326d61d617efa59b5ccc8c72525915e39cc62","_number":255531,"virtual_id_number":255531,"owner":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-01-15 17:44:01.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-12-10 15:54:33.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-12-10 14:59:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":1,"date":"2015-12-28 12:38:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":2,"date":"2016-01-15 15:49:30.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":1,"date":"2016-01-15 15:49:30.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-10 04:39:37.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2015-12-10 15:54:33.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-12-28 12:38:33.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2016-01-15 15:49:30.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-01-15 17:44:01.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2d368edd0b54915a5b158a8354e51fcacfbabd9a","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-12-09 21:21:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5881680a4340c31ae8ab7b7357a9b8a5a3be80e9","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-12-09 21:23:02.000000000","message":"Patch Set 1:\n\nSo.. I am unable to get the tests to pass, getting these failures and was hoping you could help me as it looks entirely unrelated to the patch. http://paste.openstack.org/show/481387/","accounts_in_message":[],"_revision_number":1},{"id":"85344fc045f81af9493d11c740eae211d3405e2e","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-09 22:05:53.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\n1 suggestion to the code to make it shorter:\n\nalso update the command docs to reflect changes to help: https://github.com/openstack/python-openstackclient/blob/master/doc/source/command-objects/server.rst","accounts_in_message":[],"_revision_number":1},{"id":"846728064aa9a4a37a2148e9a243294cb251ea56","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-09 23:07:49.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/31/255531/1/check/gate-python-openstackclient-pep8/e676912/ : FAILURE in 1m 31s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/31/255531/1/check/gate-python-openstackclient-docs/06a5e16//doc/build/html/ : SUCCESS in 2m 15s\n- gate-python-openstackclient-python27 http://logs.openstack.org/31/255531/1/check/gate-python-openstackclient-python27/c2807f2/ : FAILURE in 1m 36s\n- gate-python-openstackclient-python34 http://logs.openstack.org/31/255531/1/check/gate-python-openstackclient-python34/1f69643/ : FAILURE in 2m 00s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/31/255531/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/5994b17/ : SUCCESS in 1h 18m 05s\n- gate-osc-dsvm-functional http://logs.openstack.org/31/255531/1/check/gate-osc-dsvm-functional/b6241ba/ : SUCCESS in 40m 41s","accounts_in_message":[],"_revision_number":1},{"id":"ebb09c1e59e71eedcc8110e3d9af18dc788358d1","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-10 01:46:06.000000000","message":"Patch Set 1: Code-Review-1\n\n(10 comments)\n\nSorry, some problems in tests. So -1 for this version. But they are very easy to fix. \n\nThx. :)","accounts_in_message":[],"_revision_number":1},{"id":"9e8bd0f1430f3597448b763a76a4288164fc663f","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-10 02:22:07.000000000","message":"Patch Set 1:\n\nHi David,\n\nThis error is because server.rebuild() returns a server object. But you set this in the beginning:\n\n\tmethods \u003d {\t738\n            \u0027rebuild\u0027: None\t739\n        }\n\nmethods is a dict with: function_name: return_value\n\nSo you should set the rebuild() return value to a new server.","accounts_in_message":[],"_revision_number":1},{"id":"8cb5cae5eed25d2adfe3acae225a4545a7da8689","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-12-10 04:16:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d9ff07a0fd9845fcc373fd68e81857af83c08146","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-12-10 04:19:42.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c05777f35cf29930e5fbd66dddfc08cf0e10a190","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-12-10 04:21:50.000000000","message":"Patch Set 3:\n\nHere\u0027s what I can do for tests - I already spent way more time on this than I would had liked, I\u0027m not very good at unit tests but thanks for your help.\n\nIf you feel it\u0027s a fair attempt, I would appreciate if we could merge this as is and create a bug to add tests in the future for when an image is specified. I was not able to get it to work without a bunch of unclean code.","accounts_in_message":[],"_revision_number":3},{"id":"b3ffb9cd17db2ef8a78ea5aa5e6c2a72399e5775","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-10 04:39:37.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nHi David, \n\nI still have some comments to it. But I can take it over and repost a new version if you don\u0027t mind. Your author sign will be kept.","accounts_in_message":[],"_revision_number":3},{"id":"5afa1290eb60e30f74962ce9b64270501ec5d9df","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-10 04:41:34.000000000","message":"Patch Set 3: Code-Review-1\n\n-1 for this version and I will post a new version soon. Please help to review at that time, David.","accounts_in_message":[],"_revision_number":3},{"id":"8a19196ace6553453d47f615f40a2bad3234f03e","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-12-10 05:07:09.000000000","message":"Patch Set 3:\n\nHi Tang, sure, feel free to improve the tests !\n\nFor the networks attr, I have found it required or tests were failing like this otherwise: http://paste.openstack.org/show/481418/","accounts_in_message":[],"_revision_number":3},{"id":"eae07c65b78f4fc3c052ed0f5f7eb236ca15632a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-10 05:29:18.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/31/255531/3/check/gate-python-openstackclient-pep8/497ce91/ : FAILURE in 1m 17s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/31/255531/3/check/gate-python-openstackclient-docs/9d75b82//doc/build/html/ : SUCCESS in 2m 35s\n- gate-python-openstackclient-python27 http://logs.openstack.org/31/255531/3/check/gate-python-openstackclient-python27/566b139/ : SUCCESS in 1m 36s\n- gate-python-openstackclient-python34 http://logs.openstack.org/31/255531/3/check/gate-python-openstackclient-python34/be053f9/ : SUCCESS in 2m 12s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/31/255531/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/d8b639d/ : SUCCESS in 1h 08m 54s\n- gate-osc-dsvm-functional http://logs.openstack.org/31/255531/3/check/gate-osc-dsvm-functional/d61c1ad/ : SUCCESS in 29m 59s","accounts_in_message":[],"_revision_number":3},{"id":"5332b295288774dc30c41498aff8503e07873aaf","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-10 07:08:35.000000000","message":"Patch Set 3: Code-Review-1\n\n(3 comments)\n\nlooks good, just need a little extra love","accounts_in_message":[],"_revision_number":3},{"id":"face4d6b2cbcb15a95373e2343c00d5870f175ed","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-10 07:33:15.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"f2ea658c94a4e48767b66d52fec19599e7efe99a","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-10 11:00:22.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"cf88f47542da9a4570f7fc41ac8aa9e2348fd50f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-10 12:36:04.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/31/255531/4/check/gate-python-openstackclient-pep8/e954d41/ : SUCCESS in 1m 06s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/31/255531/4/check/gate-python-openstackclient-docs/496c1dc//doc/build/html/ : SUCCESS in 2m 24s\n- gate-python-openstackclient-python27 http://logs.openstack.org/31/255531/4/check/gate-python-openstackclient-python27/6f773de/ : SUCCESS in 1m 44s\n- gate-python-openstackclient-python34 http://logs.openstack.org/31/255531/4/check/gate-python-openstackclient-python34/3d1de24/ : SUCCESS in 2m 05s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/31/255531/4/check/gate-tempest-dsvm-neutron-src-python-openstackclient/0b8b231/ : SUCCESS in 1h 22m 25s\n- gate-osc-dsvm-functional http://logs.openstack.org/31/255531/4/check/gate-osc-dsvm-functional/082a912/ : SUCCESS in 25m 23s","accounts_in_message":[],"_revision_number":4},{"id":"e95af6b0119a2a79fab67ebfbea77b20aee0e4f1","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-12-10 14:59:28.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"6b3e77718fde5ec3f931f702dedb1aaff359634f","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-10 15:54:33.000000000","message":"Patch Set 4: Code-Review+2\n\ni\u0027m good with this","accounts_in_message":[],"_revision_number":4},{"id":"72523b36281dfdd10d41038947a3e0eca4dfc0e9","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-12-14 18:13:44.000000000","message":"Patch Set 4: Code-Review+1\n\nI\u0027m OK with the code, would like some clarification in the help text.\n\nIs \u0027currently used one\u0027 actually the image originally used in server create?  I think that wording can be cleaned up a bit.\n\nAlso, what error is thrown if that image is no longer available and do we handle it cleanly?","accounts_in_message":[],"_revision_number":4},{"id":"7fb0b4191c1c49fd5eb49cfc51bed98924b50e0e","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-17 15:49:38.000000000","message":"Patch Set 4:\n\nHi Dean,\n\nThe \"currently used one\" may be not the original one used in \"server create\", if the server was rebuilt before.\n\nAnd if the image is no longer usable. osc does not throw any exception. The glance server side will throw an exception. It is the same process when user specifies an unusable image.\n\nIn most of the commands in osc, we are not handling exceptions thrown by server side. And the exception thrown by server will be print out as it is. So, I do think we need to improve osc\u0027s error handling, not to throw new exceptions, but improve the output so that users will be easier to understand.\n\nI met this problem when I was trying to implement \"router set\" to set a router to ha. Still working on it. I think I need some time to figure a better way to handle errors.","accounts_in_message":[],"_revision_number":4},{"id":"83c01610e68d4a831c24075d809c43af7a0c422a","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-28 12:38:33.000000000","message":"Patch Set 4: Code-Review+1\n\nIf the image that is used by the server is already deleted, the glance lookup will throw an error (call to utils.find_resource()).","accounts_in_message":[],"_revision_number":4},{"id":"ab27f14921f9ef9cd4afc12081f9ae4d79c2e689","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-01-15 15:49:30.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"251ee4ee1431a80eebb6113795bcd083509fbd5a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-15 15:49:38.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"d14246ad8a8bce2ffffe4535feae6de7efbfe354","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-15 17:44:01.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/31/255531/4/gate/gate-python-openstackclient-docs/c5652e9//doc/build/html/ : SUCCESS in 1m 52s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/31/255531/4/gate/gate-python-openstackclient-pep8/77cec1b/ : SUCCESS in 1m 19s\n- gate-python-openstackclient-python27 http://logs.openstack.org/31/255531/4/gate/gate-python-openstackclient-python27/f91d1e8/ : SUCCESS in 1m 40s\n- gate-python-openstackclient-python34 http://logs.openstack.org/31/255531/4/gate/gate-python-openstackclient-python34/d0cd5fd/ : SUCCESS in 2m 15s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/31/255531/4/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/681f45a/ : SUCCESS in 1h 49m 17s\n- gate-osc-dsvm-functional http://logs.openstack.org/31/255531/4/gate/gate-osc-dsvm-functional/95b4d46/ : SUCCESS in 27m 58s","accounts_in_message":[],"_revision_number":4},{"id":"db04e65fe067eec307396d7eadad7f78b634bf45","date":"2016-01-15 17:44:02.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"a5267772186add4e37c454c5a97d0ea3a1c88a81","revisions":{"dda34539b7d9cd463f51898eeae5411dc609ecda":{"kind":"REWORK","_number":1,"created":"2015-12-09 21:21:57.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/31/255531/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/31/255531/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/1"}}},"commit":{"parents":[{"commit":"ccbffb2ef9cfad3398e66be9156cd155880193d8","subject":"Merge \"Use FakeVolume in server test cases.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ccbffb2ef9cfad3398e66be9156cd155880193d8"}]}],"author":{"name":"David Moreau Simard","email":"dms@redhat.com","date":"2015-12-09 21:18:54.000000000","tz":-300},"committer":{"name":"David Moreau Simard","email":"dms@redhat.com","date":"2015-12-09 21:21:56.000000000","tz":-300},"subject":"Make --image parameter optional in openstack server rebuild","message":"Make --image parameter optional in openstack server rebuild\n\nThe command will now default to the image currently in-use by\nthe server, effectively making the --image parameter optional.\n\nThis commit also adds tests for ServerRebuild since there\nwasn\u0027t any.\n\nChange-Id: I733fd3ad5a825f06563c72aa430122e1a0e3b3b0\nCloses-bug: #1524406\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/dda34539b7d9cd463f51898eeae5411dc609ecda"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/dda34539b7d9cd463f51898eeae5411dc609ecda"}]},"branch":"refs/heads/master"},"d54b276bd16eb49189044b8073527ac8b1b6780f":{"kind":"REWORK","_number":2,"created":"2015-12-10 04:16:58.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/31/255531/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/31/255531/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/2"}}},"commit":{"parents":[{"commit":"ccbffb2ef9cfad3398e66be9156cd155880193d8","subject":"Merge \"Use FakeVolume in server test cases.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ccbffb2ef9cfad3398e66be9156cd155880193d8"}]}],"author":{"name":"David Moreau Simard","email":"dms@redhat.com","date":"2015-12-09 21:18:54.000000000","tz":-300},"committer":{"name":"David Moreau Simard","email":"dms@redhat.com","date":"2015-12-10 04:16:50.000000000","tz":-300},"subject":"Make --image parameter optional in openstack server rebuild","message":"Make --image parameter optional in openstack server rebuild\n\nThe command will now default to the image currently in-use by\nthe server, effectively making the --image parameter optional.\n\nThis commit also adds tests for ServerRebuild since there\nwasn\u0027t any.\n\nChange-Id: I733fd3ad5a825f06563c72aa430122e1a0e3b3b0\nCloses-bug: #1524406\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d54b276bd16eb49189044b8073527ac8b1b6780f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d54b276bd16eb49189044b8073527ac8b1b6780f"}]},"branch":"refs/heads/master"},"832e2823c4dbea145bc6a004428c288041b3b746":{"kind":"REWORK","_number":3,"created":"2015-12-10 04:19:42.000000000","uploader":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"ref":"refs/changes/31/255531/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/31/255531/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/3"}}},"commit":{"parents":[{"commit":"ccbffb2ef9cfad3398e66be9156cd155880193d8","subject":"Merge \"Use FakeVolume in server test cases.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ccbffb2ef9cfad3398e66be9156cd155880193d8"}]}],"author":{"name":"David Moreau Simard","email":"dms@redhat.com","date":"2015-12-09 21:18:54.000000000","tz":-300},"committer":{"name":"David Moreau Simard","email":"dms@redhat.com","date":"2015-12-10 04:19:37.000000000","tz":-300},"subject":"Make --image parameter optional in openstack server rebuild","message":"Make --image parameter optional in openstack server rebuild\n\nThe command will now default to the image currently in-use by\nthe server, effectively making the --image parameter optional.\n\nThis commit also adds tests for ServerRebuild since there\nwasn\u0027t any.\n\nChange-Id: I733fd3ad5a825f06563c72aa430122e1a0e3b3b0\nCloses-bug: #1524406\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/832e2823c4dbea145bc6a004428c288041b3b746"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/832e2823c4dbea145bc6a004428c288041b3b746"}]},"branch":"refs/heads/master"},"a5267772186add4e37c454c5a97d0ea3a1c88a81":{"kind":"REWORK","_number":4,"created":"2015-12-10 11:00:22.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/31/255531/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/31/255531/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/31/255531/4"}}},"commit":{"parents":[{"commit":"f65f82e4350757fcae93891c42ed8b01bb8577f2","subject":"Fix poorly named test mocks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f65f82e4350757fcae93891c42ed8b01bb8577f2"}]}],"author":{"name":"David Moreau Simard","email":"dms@redhat.com","date":"2015-12-09 21:18:54.000000000","tz":-300},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-11 07:34:26.000000000","tz":480},"subject":"Make --image parameter optional in \"server rebuild\"","message":"Make --image parameter optional in \"server rebuild\"\n\nThe command will now default to the image currently in-use by\nthe server, effectively making the --image parameter optional.\n\nThis commit also adds basic tests for ServerRebuild since there\nwasn\u0027t any. Will add more full tests for it.\n\nChange-Id: I733fd3ad5a825f06563c72aa430122e1a0e3b3b0\nCloses-bug: #1524406\nCo-Authored-By: David Moreau Simard \u003cdms@redhat.com\u003e\nCo-Authored-By: Tang Chen \u003ctangchen@cn.fujitsu.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a5267772186add4e37c454c5a97d0ea3a1c88a81"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a5267772186add4e37c454c5a97d0ea3a1c88a81"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}