)]}'
{"id":"openstack%2Fpython-openstackclient~255756","triplet_id":"openstack%2Fpython-openstackclient~master~I2c52f48a7b3c005c185a4ac64abbb3e18d5fb3de","project":"openstack/python-openstackclient","branch":"master","topic":"trivial","hashtags":[],"change_id":"I2c52f48a7b3c005c185a4ac64abbb3e18d5fb3de","subject":"Trivial: Improve unclear comments in test_server.py","status":"MERGED","created":"2015-12-10 09:24:20.000000000","updated":"2015-12-14 22:47:37.000000000","submitted":"2015-12-14 22:47:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1f41c4707d881a5bbccf01610ff2387944dc56cf","_number":255756,"virtual_id_number":255756,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-12-14 22:47:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-12-10 09:43:25.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":1,"date":"2015-12-11 15:02:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":2,"date":"2015-12-14 17:47:20.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"date":"2015-12-14 19:50:10.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"date":"2015-12-11 14:58:47.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2015-12-14 17:47:20.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-10 09:43:25.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2015-12-11 14:58:47.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2015-12-14 17:47:20.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2015-12-14 19:50:10.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-12-14 22:47:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5be4a3667d8c67fe5a333b25c5b4b121cb66e482","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-10 09:24:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3c01f680444669e52fbb749c1ffc69eceb4d6437","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2015-12-10 09:43:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"936b30434346cba26a90148c3ee88e6564b1916f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-10 10:41:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/56/255756/1/check/gate-python-openstackclient-pep8/aedc2fb/ : SUCCESS in 1m 12s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/56/255756/1/check/gate-python-openstackclient-docs/9589600//doc/build/html/ : SUCCESS in 2m 27s\n- gate-python-openstackclient-python27 http://logs.openstack.org/56/255756/1/check/gate-python-openstackclient-python27/3a16c93/ : SUCCESS in 1m 43s\n- gate-python-openstackclient-python34 http://logs.openstack.org/56/255756/1/check/gate-python-openstackclient-python34/bf3a985/ : SUCCESS in 2m 14s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/56/255756/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/fe2930f/ : SUCCESS in 1h 05m 26s\n- gate-osc-dsvm-functional http://logs.openstack.org/56/255756/1/check/gate-osc-dsvm-functional/9169c55/ : SUCCESS in 27m 16s","accounts_in_message":[],"_revision_number":1},{"id":"668f950cbf2ad2e8f4d59d37c746bd7d3dd4f1b6","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2015-12-11 15:02:09.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"60d1a6694b3d47719a1b42906c7e213b789faec7","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-12-14 17:47:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"fd0d79dfbd0c04ef51ceea9584841a0f24abaa21","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-14 17:47:26.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"8b1e8e2a9449ae580c1bb9b8cef8d385a9b578c9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-14 19:09:28.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/56/255756/1/gate/gate-python-openstackclient-docs/595287a//doc/build/html/ : SUCCESS in 2m 30s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/56/255756/1/gate/gate-python-openstackclient-pep8/8ab164a/ : SUCCESS in 1m 30s\n- gate-python-openstackclient-python27 http://logs.openstack.org/56/255756/1/gate/gate-python-openstackclient-python27/814e372/ : SUCCESS in 1m 47s\n- gate-python-openstackclient-python34 http://logs.openstack.org/56/255756/1/gate/gate-python-openstackclient-python34/a14546f/ : SUCCESS in 2m 19s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/56/255756/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/4ed9784/ : FAILURE in 1h 01m 50s\n- gate-osc-dsvm-functional http://logs.openstack.org/56/255756/1/gate/gate-osc-dsvm-functional/be143ca/ : SUCCESS in 27m 14s","accounts_in_message":[],"_revision_number":1},{"id":"22c2f85b4c6a8ad8f089c83085a494861fd4557a","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-14 19:50:10.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"72dcb7e5087c3491d3363b6000a51d662351ada4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-14 21:19:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/56/255756/1/check/gate-python-openstackclient-pep8/79181cf/ : SUCCESS in 1m 52s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/56/255756/1/check/gate-python-openstackclient-docs/fa2dc88//doc/build/html/ : SUCCESS in 2m 42s\n- gate-python-openstackclient-python27 http://logs.openstack.org/56/255756/1/check/gate-python-openstackclient-python27/9ef95ed/ : SUCCESS in 2m 14s\n- gate-python-openstackclient-python34 http://logs.openstack.org/56/255756/1/check/gate-python-openstackclient-python34/ae088bd/ : SUCCESS in 2m 19s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/56/255756/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/b0c091a/ : SUCCESS in 1h 08m 29s\n- gate-osc-dsvm-functional http://logs.openstack.org/56/255756/1/check/gate-osc-dsvm-functional/a618fb8/ : SUCCESS in 27m 44s","accounts_in_message":[],"_revision_number":1},{"id":"9961018f7891cc29d97ebd24123d1c6cf882db91","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-14 21:20:04.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5faaf13cb8e8e218ff55c10eb2c762be3d2385a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-14 22:47:35.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/56/255756/1/gate/gate-python-openstackclient-docs/1c3e838//doc/build/html/ : SUCCESS in 1m 40s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/56/255756/1/gate/gate-python-openstackclient-pep8/6f23d07/ : SUCCESS in 59s\n- gate-python-openstackclient-python27 http://logs.openstack.org/56/255756/1/gate/gate-python-openstackclient-python27/8ea4e49/ : SUCCESS in 1m 24s\n- gate-python-openstackclient-python34 http://logs.openstack.org/56/255756/1/gate/gate-python-openstackclient-python34/e1ed2d0/ : SUCCESS in 1m 51s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/56/255756/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/07fac1c/ : SUCCESS in 1h 25m 51s\n- gate-osc-dsvm-functional http://logs.openstack.org/56/255756/1/gate/gate-osc-dsvm-functional/4ac9ed3/ : SUCCESS in 31m 44s","accounts_in_message":[],"_revision_number":1},{"id":"56f4c03f1f2e53356deee669c764a2073fd3b508","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-14 22:47:37.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6f7c705d4a4c9b4f7d618619cecef4c6e36c2b74","revisions":{"6f7c705d4a4c9b4f7d618619cecef4c6e36c2b74":{"kind":"REWORK","_number":1,"created":"2015-12-10 09:24:20.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/56/255756/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/56/255756/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/56/255756/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/56/255756/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/56/255756/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/56/255756/1"}}},"commit":{"parents":[{"commit":"f65f82e4350757fcae93891c42ed8b01bb8577f2","subject":"Fix poorly named test mocks","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f65f82e4350757fcae93891c42ed8b01bb8577f2"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-11 09:18:28.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-11 09:18:28.000000000","tz":480},"subject":"Trivial: Improve unclear comments in test_server.py","message":"Trivial: Improve unclear comments in test_server.py\n\nIn test_server.py, there are two ImageManagers are faked:\n1. the one in compute client\n2. the one in image client\nBut the comments are the same. And so is volume.\n\nThis patch makes the comments more clear.\n\nChange-Id: I2c52f48a7b3c005c185a4ac64abbb3e18d5fb3de\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6f7c705d4a4c9b4f7d618619cecef4c6e36c2b74"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6f7c705d4a4c9b4f7d618619cecef4c6e36c2b74"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}