)]}'
{"id":"openstack%2Fpython-openstackclient~257129","triplet_id":"openstack%2Fpython-openstackclient~master~Ib044ebd4ddedbcd805f46334a7fe99e4ebb5b249","project":"openstack/python-openstackclient","branch":"master","topic":"get-body-20160202","hashtags":[],"change_id":"Ib044ebd4ddedbcd805f46334a7fe99e4ebb5b249","subject":"Network: Abstract get_body() out to be a private helper.","status":"MERGED","created":"2015-12-14 05:34:32.000000000","updated":"2016-02-03 21:01:24.000000000","submitted":"2016-02-03 21:01:23.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"76c5684c5b710c74ecc9a4fdb036e3a1b5b56972","_number":257129,"virtual_id_number":257129,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-02-03 21:01:23.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-02-02 06:31:52.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":1,"date":"2016-02-02 18:56:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":2,"date":"2016-02-03 17:08:02.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2016-02-03 18:29:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2016-02-03 17:08:02.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-02 06:31:52.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-02-02 18:56:22.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-02-03 17:08:02.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-02-03 18:29:22.000000000","updated_by":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"reviewer":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"state":"REVIEWER"},{"updated":"2016-02-03 21:01:23.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ecf2d3fe61ecb9026ffc253419a300c4e995ceab","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-14 05:34:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ba820b6e760e9f8ea155a14f5be0a066de36e6bd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-14 06:31:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/29/257129/1/check/gate-python-openstackclient-pep8/ec98069/ : SUCCESS in 1m 20s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/29/257129/1/check/gate-python-openstackclient-docs/05ffb2b//doc/build/html/ : SUCCESS in 2m 26s\n- gate-python-openstackclient-python27 http://logs.openstack.org/29/257129/1/check/gate-python-openstackclient-python27/0b124a6/ : SUCCESS in 1m 35s\n- gate-python-openstackclient-python34 http://logs.openstack.org/29/257129/1/check/gate-python-openstackclient-python34/11cdca0/ : SUCCESS in 2m 13s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/29/257129/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/e295d78/ : SUCCESS in 56m 52s\n- gate-osc-dsvm-functional http://logs.openstack.org/29/257129/1/check/gate-osc-dsvm-functional/2589baa/ : SUCCESS in 25m 11s","accounts_in_message":[],"_revision_number":1},{"id":"986912bdf591089fa2f0c8411b7cb7442b68fe7e","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2015-12-15 13:33:27.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"39bb972d1e150b20fb31baa94481d9b8f762eb9f","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-15 16:42:23.000000000","message":"Patch Set 2: Commit message was updated","accounts_in_message":[],"_revision_number":2},{"id":"c4c8a47260f2b02e314ef02e30ca1a6d9a7a9a79","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2015-12-15 16:44:23.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"029ac56f52e884c639151ff21d6dadca22473ff2","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-15 16:49:15.000000000","message":"Patch Set 2: Code-Review+2\n\nnice clean up \"body\" always bugged me","accounts_in_message":[],"_revision_number":2},{"id":"7ddb14ca805b92da3c58d1d07603f9c1e4c90e19","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-15 20:47:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/29/257129/2/check/gate-python-openstackclient-pep8/88aea58/ : SUCCESS in 1m 16s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/29/257129/2/check/gate-python-openstackclient-docs/2d1503e//doc/build/html/ : SUCCESS in 2m 22s\n- gate-python-openstackclient-python27 http://logs.openstack.org/29/257129/2/check/gate-python-openstackclient-python27/8350e94/ : SUCCESS in 1m 36s\n- gate-python-openstackclient-python34 http://logs.openstack.org/29/257129/2/check/gate-python-openstackclient-python34/93fc754/ : SUCCESS in 2m 11s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/29/257129/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/11e55fd/ : SUCCESS in 58m 49s\n- gate-osc-dsvm-functional http://logs.openstack.org/29/257129/2/check/gate-osc-dsvm-functional/6bcb47f/ : SUCCESS in 25m 56s","accounts_in_message":[],"_revision_number":2},{"id":"2031e20bc29559d4ffa312019294098daf7ce0f7","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2015-12-15 22:25:14.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nI saw the debate about testing private methods, I come down on the side of doing the most granular testing for unit tests and would prefer to see these tested directly as it will be fewer tests overall to get full coverage.\n\nWhen I find that conversation again I\u0027ll repeat this there...","accounts_in_message":[],"_revision_number":2},{"id":"b441baa0596e04fed9e49f459318912590ab304b","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-17 07:33:50.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"62ee1f4f4bd794cdf4bb778b0fa8153f7e12c902","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-17 19:45:51.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"c4d9a6bf83b7b37313b5ebd7802fe8bce9e5348a","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-02 03:58:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4f25e674c45e33e04e618b1ed7efaf499082b199","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-02 05:53:57.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/29/257129/3/check/gate-python-openstackclient-pep8/db1c347/ : FAILURE in 1m 30s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/29/257129/3/check/gate-python-openstackclient-docs/3e158a5//doc/build/html/ : SUCCESS in 2m 28s\n- gate-python-openstackclient-python27 http://logs.openstack.org/29/257129/3/check/gate-python-openstackclient-python27/aff081e/ : SUCCESS in 1m 35s\n- gate-python-openstackclient-python34 http://logs.openstack.org/29/257129/3/check/gate-python-openstackclient-python34/0177dc6/ : SUCCESS in 2m 22s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/29/257129/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/cc708f1/ : SUCCESS in 57m 32s\n- check-osc-plugins http://logs.openstack.org/29/257129/3/check/check-osc-plugins/0418d01/ : SUCCESS in 1m 53s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/29/257129/3/check/gate-osc-dsvm-functional/add085d/ : SUCCESS in 32m 32s","accounts_in_message":[],"_revision_number":3},{"id":"a83479c8ad9b3e8fde300c33d4b21d5fb72ebe86","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-02 06:08:45.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"bf3d94594483630c8ad64abf0bcbf3bcd87f888d","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-02-02 06:31:52.000000000","message":"Patch Set 4: Code-Review+2\n\nstill lgtm","accounts_in_message":[],"_revision_number":4},{"id":"9b469872f159bbf04d4129e59bce4b660294564d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-02 07:03:17.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/29/257129/4/check/gate-python-openstackclient-pep8/3a31a54/ : SUCCESS in 1m 26s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/29/257129/4/check/gate-python-openstackclient-docs/ba0b451//doc/build/html/ : SUCCESS in 2m 03s\n- gate-python-openstackclient-python27 http://logs.openstack.org/29/257129/4/check/gate-python-openstackclient-python27/92ecd01/ : SUCCESS in 1m 34s\n- gate-python-openstackclient-python34 http://logs.openstack.org/29/257129/4/check/gate-python-openstackclient-python34/8858757/ : SUCCESS in 2m 14s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/29/257129/4/check/gate-tempest-dsvm-neutron-src-python-openstackclient/293c132/ : SUCCESS in 54m 20s\n- check-osc-plugins http://logs.openstack.org/29/257129/4/check/check-osc-plugins/5386bf9/ : SUCCESS in 1m 47s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/29/257129/4/check/gate-osc-dsvm-functional/d491777/ : SUCCESS in 22m 17s","accounts_in_message":[],"_revision_number":4},{"id":"866f55b3fa7b92f8ab431a0020fed334c765c79d","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-02-02 18:56:22.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"4fecfad4d2060e68cb837f512cf384584ea86f03","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-02-03 17:08:02.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"e5737439a8162594a3336d36e72b40b6bc10af7b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-03 17:10:46.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"49af638a8f417850425bf26475e898e586894b84","author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"date":"2016-02-03 18:29:22.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"ae2c44e8ae9ac1a11a548eeaf95e77225f45a957","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-03 21:01:23.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/29/257129/4/gate/gate-python-openstackclient-docs/7d45d6b//doc/build/html/ : SUCCESS in 1m 47s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/29/257129/4/gate/gate-python-openstackclient-pep8/9244c89/ : SUCCESS in 1m 12s\n- gate-python-openstackclient-python27 http://logs.openstack.org/29/257129/4/gate/gate-python-openstackclient-python27/0bb1ba3/ : SUCCESS in 1m 59s\n- gate-python-openstackclient-python34 http://logs.openstack.org/29/257129/4/gate/gate-python-openstackclient-python34/9668259/ : SUCCESS in 2m 19s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/29/257129/4/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/fc5bc5c/ : SUCCESS in 1h 03m 11s\n- gate-osc-dsvm-functional http://logs.openstack.org/29/257129/4/gate/gate-osc-dsvm-functional/a5cace6/ : SUCCESS in 31m 11s","accounts_in_message":[],"_revision_number":4},{"id":"21ecccd7cc5a1961aab555e1d8b98c00df6f96a9","date":"2016-02-03 21:01:24.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"a83c1f0a4244d6c422a68cf5bf2bbaa3e4617b78","revisions":{"91ec75126bba616747e6703c3222fec90893fb92":{"kind":"REWORK","_number":1,"created":"2015-12-14 05:34:32.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/29/257129/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/29/257129/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/1"}}},"commit":{"parents":[{"commit":"1ee5191cec53df588d51a7cee31cfe9cf3a57a1b","subject":"Merge \"Deprecated tox -downloadcache option removed\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1ee5191cec53df588d51a7cee31cfe9cf3a57a1b"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-15 03:40:23.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-15 03:40:23.000000000","tz":480},"subject":"Network: Abstract get_body() out to be a provate helper.","message":"Network: Abstract get_body() out to be a provate helper.\n\nget_body() is needed in each network files to construct a dict\nto pass to sdk proxy. And it is also used by several functions\nin each file. So define it as a file level private helper function.\n\nThe unified prototype should be:\n\n    def _get_attrs(client_manager, parsed_args):\n\n1. The name, in sdk, the parameter passed to proxy is named \"attrs\".\n   And it is a private method. So let\u0027s call it _get_attrs().\n2. The parameters, besides parsed_args, when we deal with project\n   and project_domain, we have to make use of identity_client. So\n   let\u0027s pass in the client manager.\n\nChange-Id: Ib044ebd4ddedbcd805f46334a7fe99e4ebb5b249\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/91ec75126bba616747e6703c3222fec90893fb92"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/91ec75126bba616747e6703c3222fec90893fb92"}]},"branch":"refs/heads/master"},"7edb97ea1ec2753d8261fe298ed61c0374a7eb14":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-12-15 16:42:23.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/29/257129/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/29/257129/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/2"}}},"commit":{"parents":[{"commit":"1ee5191cec53df588d51a7cee31cfe9cf3a57a1b","subject":"Merge \"Deprecated tox -downloadcache option removed\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1ee5191cec53df588d51a7cee31cfe9cf3a57a1b"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-15 03:40:23.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-15 16:42:23.000000000","tz":0},"subject":"Network: Abstract get_body() out to be a private helper.","message":"Network: Abstract get_body() out to be a private helper.\n\nget_body() is needed in each network files to construct a dict\nto pass to sdk proxy. And it is also used by several functions\nin each file. So define it as a file level private helper function.\n\nThe unified prototype should be:\n\n    def _get_attrs(client_manager, parsed_args):\n\n1. The name, in sdk, the parameter passed to proxy is named \"attrs\".\n   And it is a private method. So let\u0027s call it _get_attrs().\n2. The parameters, besides parsed_args, when we deal with project\n   and project_domain, we have to make use of identity_client. So\n   let\u0027s pass in the client manager.\n\nChange-Id: Ib044ebd4ddedbcd805f46334a7fe99e4ebb5b249\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7edb97ea1ec2753d8261fe298ed61c0374a7eb14"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7edb97ea1ec2753d8261fe298ed61c0374a7eb14"}]},"branch":"refs/heads/master"},"a8074b69dc907bf13f3a5e56df0221a943450038":{"kind":"REWORK","_number":3,"created":"2016-02-02 03:58:22.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/29/257129/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/29/257129/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/3"}}},"commit":{"parents":[{"commit":"258c1102cc6b93a860bcd7cc083d4e14ae0025ce","subject":"log take_action parameters in a single place","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/258c1102cc6b93a860bcd7cc083d4e14ae0025ce"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2015-12-15 03:40:23.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-02 03:53:20.000000000","tz":480},"subject":"Network: Abstract get_body() out to be a private helper.","message":"Network: Abstract get_body() out to be a private helper.\n\nget_body() is needed in each network files to construct a dict\nto pass to sdk proxy. And it is also used by several functions\nin each file. So define it as a file level private helper function.\n\nThe unified prototype should be:\n\n    def _get_attrs(client_manager, parsed_args):\n\n1. The name, in sdk, the parameter passed to proxy is named \"attrs\".\n   And it is a private method. So let\u0027s call it _get_attrs().\n2. The parameters, besides parsed_args, when we deal with project\n   and project_domain, we have to make use of identity_client. So\n   let\u0027s pass in the client manager.\n\nChange-Id: Ib044ebd4ddedbcd805f46334a7fe99e4ebb5b249\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a8074b69dc907bf13f3a5e56df0221a943450038"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a8074b69dc907bf13f3a5e56df0221a943450038"}]},"branch":"refs/heads/master"},"a83c1f0a4244d6c422a68cf5bf2bbaa3e4617b78":{"kind":"REWORK","_number":4,"created":"2016-02-02 06:08:45.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/29/257129/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/29/257129/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/29/257129/4"}}},"commit":{"parents":[{"commit":"ceb17e11a9ca0a2dc6c6d72466ad2c7b31a29878","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ceb17e11a9ca0a2dc6c6d72466ad2c7b31a29878"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2015-12-15 03:40:23.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-02 05:58:43.000000000","tz":480},"subject":"Network: Abstract get_body() out to be a private helper.","message":"Network: Abstract get_body() out to be a private helper.\n\nget_body() is needed in each network files to construct a dict\nto pass to sdk proxy. And it is also used by several functions\nin each file. So define it as a file level private helper function.\n\nThe unified prototype should be:\n\n    def _get_attrs(client_manager, parsed_args):\n\n1. The name, in sdk, the parameter passed to proxy is named \"attrs\".\n   And it is a private method. So let\u0027s call it _get_attrs().\n2. The parameters, besides parsed_args, when we deal with project\n   and project_domain, we have to make use of identity_client. So\n   let\u0027s pass in the client manager.\n\nChange-Id: Ib044ebd4ddedbcd805f46334a7fe99e4ebb5b249\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a83c1f0a4244d6c422a68cf5bf2bbaa3e4617b78"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a83c1f0a4244d6c422a68cf5bf2bbaa3e4617b78"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}