)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1e70604700a132133cdb469eefb17163c904b392","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds \"router set\" command to osc using sdk."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"NOTE: Setting ha property of a router is not supported for now."},{"line_number":12,"context_line":"      Will suppport it in another patch."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9c15249ae61a87291f0728ad1c8f0a98aa8119bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a710552_1906b3ce","line":11,"updated":"2015-12-15 17:21:52.000000000","message":"nit... you could update this note to include the other properties on the TODO list.","commit_id":"1697a08d739bc3416493d66c443b5a1bb53beab2"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"62e3fab5976393d4f129fef19ebb93a1dbcb8b2e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds \"router set\" command to osc using sdk."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"NOTE: Setting ha property of a router is not supported for now."},{"line_number":12,"context_line":"      Will suppport it in another patch."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9c15249ae61a87291f0728ad1c8f0a98aa8119bf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a710552_34861666","line":11,"in_reply_to":"5a710552_1906b3ce","updated":"2015-12-15 17:40:14.000000000","message":"Done","commit_id":"1697a08d739bc3416493d66c443b5a1bb53beab2"}],"doc/source/command-objects/router.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dee9e56acaa3957e0d8cbd7ad02c5e88ce94aa79","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    os router set"},{"line_number":92,"context_line":"        [--name \u003cname\u003e]"},{"line_number":93,"context_line":"        [--enable | --disable]"},{"line_number":94,"context_line":"        [--distributed | --no-distributed]"},{"line_number":95,"context_line":"        \u003crouter\u003e"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a710552_4c48325c","line":94,"updated":"2015-12-14 20:45:33.000000000","message":"Missing support for the following neutron CLI options:\n\n[--route destination\u003dCIDR,nexthop\u003dIP_ADDR | --no-routes]","commit_id":"d3834fc639ff91b22fb29ea383cd6c1b9ad77d16"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1271e312d48f5ba1a9243a8352f7101255aaf181","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    os router set"},{"line_number":92,"context_line":"        [--name \u003cname\u003e]"},{"line_number":93,"context_line":"        [--enable | --disable]"},{"line_number":94,"context_line":"        [--distributed | --no-distributed]"},{"line_number":95,"context_line":"        \u003crouter\u003e"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a710552_baa3fa9d","line":94,"in_reply_to":"5a710552_4c48325c","updated":"2015-12-15 04:14:23.000000000","message":"I would like to add this support with the patches which are going to support external_gateway_info and routes options in \"router create\" command. And also the test cases.\n\nIf I implements them here, it will make this patch too large to rebase or refactor. Sorry, I like smaller patches, and sorry again I didn\u0027t mention this in the commit msg.  :)\n\nWill add it to the commit msg. Thx. :)","commit_id":"d3834fc639ff91b22fb29ea383cd6c1b9ad77d16"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dee9e56acaa3957e0d8cbd7ad02c5e88ce94aa79","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":".. option:: --no-distributed"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    Reset router from distributed mode (disabled router only)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. _router_set-router:"},{"line_number":118,"context_line":".. describe:: \u003crouter\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a710552_6f3ac0cf","line":115,"updated":"2015-12-14 20:45:33.000000000","message":"Neutron code and messages use the term \"centralized\" for a router that is not distributed.  I think it would be good to do the same here.  Although, it appears that the neutron code does not allow a router to move from distributed to centralized (see l3_dvr_db.py code).  Have you been able to test this?","commit_id":"d3834fc639ff91b22fb29ea383cd6c1b9ad77d16"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1271e312d48f5ba1a9243a8352f7101255aaf181","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":".. option:: --no-distributed"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    Reset router from distributed mode (disabled router only)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. _router_set-router:"},{"line_number":118,"context_line":".. describe:: \u003crouter\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a710552_1ab00ef4","line":115,"in_reply_to":"5a710552_6f3ac0cf","updated":"2015-12-15 04:14:23.000000000","message":"I didn\u0027t dig too much neutron code. But indeed, I failed to set a distributed router to centralized one. And I tried neutron client, it also failed.","commit_id":"d3834fc639ff91b22fb29ea383cd6c1b9ad77d16"}],"openstackclient/network/v2/router.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dee9e56acaa3957e0d8cbd7ad02c5e88ce94aa79","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d parsed_args.admin_state_up"},{"line_number":51,"context_line":"    if parsed_args.distributed is not None:"},{"line_number":52,"context_line":"        attrs[\u0027distributed\u0027] \u003d parsed_args.distributed"},{"line_number":53,"context_line":"    # \"router set\" command doesn\u0027t support setting ha."},{"line_number":54,"context_line":"    if \u0027ha\u0027 in parsed_args and parsed_args.ha is not None:"},{"line_number":55,"context_line":"        attrs[\u0027ha\u0027] \u003d parsed_args.ha"},{"line_number":56,"context_line":"    # \"router set\" command doesn\u0027t support setting project."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_af7bc87a","line":53,"updated":"2015-12-14 20:45:33.000000000","message":"It appears that changing the ha state is supported by neutron under certain conditions.  See l3_hamode_db.py code for details.","commit_id":"d3834fc639ff91b22fb29ea383cd6c1b9ad77d16"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1271e312d48f5ba1a9243a8352f7101255aaf181","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d parsed_args.admin_state_up"},{"line_number":51,"context_line":"    if parsed_args.distributed is not None:"},{"line_number":52,"context_line":"        attrs[\u0027distributed\u0027] \u003d parsed_args.distributed"},{"line_number":53,"context_line":"    # \"router set\" command doesn\u0027t support setting ha."},{"line_number":54,"context_line":"    if \u0027ha\u0027 in parsed_args and parsed_args.ha is not None:"},{"line_number":55,"context_line":"        attrs[\u0027ha\u0027] \u003d parsed_args.ha"},{"line_number":56,"context_line":"    # \"router set\" command doesn\u0027t support setting project."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_dd484030","line":53,"in_reply_to":"5a710552_7e74affc","updated":"2015-12-15 04:14:23.000000000","message":"OK. Let\u0027s remove ha setting from this version. And do it more clearly in another patch.","commit_id":"d3834fc639ff91b22fb29ea383cd6c1b9ad77d16"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ab571a7be3b7cd189f6eb9b0c224fcb9112bcfc8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d parsed_args.admin_state_up"},{"line_number":51,"context_line":"    if parsed_args.distributed is not None:"},{"line_number":52,"context_line":"        attrs[\u0027distributed\u0027] \u003d parsed_args.distributed"},{"line_number":53,"context_line":"    # \"router set\" command doesn\u0027t support setting ha."},{"line_number":54,"context_line":"    if \u0027ha\u0027 in parsed_args and parsed_args.ha is not None:"},{"line_number":55,"context_line":"        attrs[\u0027ha\u0027] \u003d parsed_args.ha"},{"line_number":56,"context_line":"    # \"router set\" command doesn\u0027t support setting project."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_7e74affc","line":53,"in_reply_to":"5a710552_af7bc87a","updated":"2015-12-14 23:13:38.000000000","message":"the HA bits and missing fields can go in a separate commit if necessary","commit_id":"d3834fc639ff91b22fb29ea383cd6c1b9ad77d16"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ab571a7be3b7cd189f6eb9b0c224fcb9112bcfc8","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            help\u003d\"Set router to distributed mode (disabled router only)\","},{"line_number":250,"context_line":"        )"},{"line_number":251,"context_line":"        distribute_group.add_argument("},{"line_number":252,"context_line":"            \u0027--no-distributed\u0027,"},{"line_number":253,"context_line":"            dest\u003d\u0027distributed\u0027,"},{"line_number":254,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":255,"context_line":"            help\u003d\"Reset router from distributed mode (disabled router only)\","}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_de8283c8","line":252,"updated":"2015-12-14 23:13:38.000000000","message":"++ for \"centralized\" instead of \"no-distributed\"","commit_id":"d3834fc639ff91b22fb29ea383cd6c1b9ad77d16"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1271e312d48f5ba1a9243a8352f7101255aaf181","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            help\u003d\"Set router to distributed mode (disabled router only)\","},{"line_number":250,"context_line":"        )"},{"line_number":251,"context_line":"        distribute_group.add_argument("},{"line_number":252,"context_line":"            \u0027--no-distributed\u0027,"},{"line_number":253,"context_line":"            dest\u003d\u0027distributed\u0027,"},{"line_number":254,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":255,"context_line":"            help\u003d\"Reset router from distributed mode (disabled router only)\","}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_3ab62add","line":252,"in_reply_to":"5a710552_de8283c8","updated":"2015-12-15 04:14:23.000000000","message":"Done","commit_id":"d3834fc639ff91b22fb29ea383cd6c1b9ad77d16"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ca0878cd1a5c7a710aa1351393826d0196081da7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        ).id"},{"line_number":61,"context_line":"        attrs[\u0027tenant_id\u0027] \u003d project_id"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    # TODO(tangchen): Support setting \u0027ha\u0027 property in \u0027router set\u0027 command."},{"line_number":64,"context_line":"    # It appears that changing the ha state is supported by neutron under"},{"line_number":65,"context_line":"    # certain conditions."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_995dd1eb","line":63,"updated":"2015-12-15 14:00:00.000000000","message":"Please add a TODO for the route and external gateway properties as well.","commit_id":"71b96af7bea131051feff657f6251f32ed225fc7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d1f6d870a5f7109e3a5edcb28d15f75632a3dcd0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        ).id"},{"line_number":61,"context_line":"        attrs[\u0027tenant_id\u0027] \u003d project_id"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    # TODO(tangchen): Support setting \u0027ha\u0027 property in \u0027router set\u0027 command."},{"line_number":64,"context_line":"    # It appears that changing the ha state is supported by neutron under"},{"line_number":65,"context_line":"    # certain conditions."},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_651ceec1","line":63,"in_reply_to":"5a710552_995dd1eb","updated":"2015-12-15 16:21:19.000000000","message":"Done","commit_id":"71b96af7bea131051feff657f6251f32ed225fc7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ca0878cd1a5c7a710aa1351393826d0196081da7","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            help\u003d\"Set router to centralized mode (disabled router only)\","},{"line_number":251,"context_line":"        )"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        # TODO(tangchen): Support setting \u0027ha\u0027 property in \u0027router set\u0027"},{"line_number":254,"context_line":"        # command. It appears that changing the ha state is supported by"},{"line_number":255,"context_line":"        # neutron under certain conditions."},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_1901e1ae","line":253,"updated":"2015-12-15 14:00:00.000000000","message":"Similar comment as above.","commit_id":"71b96af7bea131051feff657f6251f32ed225fc7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d1f6d870a5f7109e3a5edcb28d15f75632a3dcd0","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            help\u003d\"Set router to centralized mode (disabled router only)\","},{"line_number":251,"context_line":"        )"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        # TODO(tangchen): Support setting \u0027ha\u0027 property in \u0027router set\u0027"},{"line_number":254,"context_line":"        # command. It appears that changing the ha state is supported by"},{"line_number":255,"context_line":"        # neutron under certain conditions."},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_c58362cb","line":253,"in_reply_to":"5a710552_1901e1ae","updated":"2015-12-15 16:21:19.000000000","message":"Done","commit_id":"71b96af7bea131051feff657f6251f32ed225fc7"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"b0f0d5605eb25ac046ac627a42f889c002c1f430","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        client.update_router(obj, **attrs)"},{"line_number":276,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_73082a2e","line":276,"updated":"2015-12-15 21:56:24.000000000","message":"not necessary","commit_id":"354a248a0d5171a8e2950daa1e9329756a4d3a8b"}],"openstackclient/tests/network/v2/test_router.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ca0878cd1a5c7a710aa1351393826d0196081da7","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        arglist \u003d ["},{"line_number":239,"context_line":"            self._router.name,"},{"line_number":240,"context_line":"            \u0027--disable\u0027,"},{"line_number":241,"context_line":"            \u0027--distributed\u0027,"},{"line_number":242,"context_line":"        ]"},{"line_number":243,"context_line":"        verifylist \u003d ["},{"line_number":244,"context_line":"            (\u0027router\u0027, self._router.name),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_39e85de2","line":241,"updated":"2015-12-15 14:00:00.000000000","message":"Please add a test for the --centralized option.","commit_id":"71b96af7bea131051feff657f6251f32ed225fc7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d1f6d870a5f7109e3a5edcb28d15f75632a3dcd0","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        arglist \u003d ["},{"line_number":239,"context_line":"            self._router.name,"},{"line_number":240,"context_line":"            \u0027--disable\u0027,"},{"line_number":241,"context_line":"            \u0027--distributed\u0027,"},{"line_number":242,"context_line":"        ]"},{"line_number":243,"context_line":"        verifylist \u003d ["},{"line_number":244,"context_line":"            (\u0027router\u0027, self._router.name),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_257d86e7","line":241,"in_reply_to":"5a710552_39e85de2","updated":"2015-12-15 16:21:19.000000000","message":"Done","commit_id":"71b96af7bea131051feff657f6251f32ed225fc7"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"2d0803efa8504a17a45cdedfb822c850c1add59e","unresolved":false,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        try:"},{"line_number":275,"context_line":"            # Argument parse failing should bail here"},{"line_number":276,"context_line":"            parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":277,"context_line":"        except tests_utils.ParserException:"},{"line_number":278,"context_line":"            pass"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_f677289d","line":276,"updated":"2015-12-15 21:59:12.000000000","message":"pep8 failed - unused variable","commit_id":"354a248a0d5171a8e2950daa1e9329756a4d3a8b"}]}