)]}'
{"doc/source/command-objects/router.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"62b0cca1a484c46b388d3a041f7840919bae4d5e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    Router to modify (name or ID)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"router show"},{"line_number":123,"context_line":"------------"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Display router details"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a710552_9e54fb54","line":123,"updated":"2015-12-14 23:14:35.000000000","message":"nit, one extra -","commit_id":"e5c078d02f41bea18999ed1e2a257854542a9777"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"0f50bd63e38e09be190712ac4faeb056ecc6c0a4","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    Router to modify (name or ID)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"router show"},{"line_number":118,"context_line":"------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Display router details"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a710552_b0178dec","line":118,"updated":"2015-12-15 10:38:00.000000000","message":"nit: remove extra -","commit_id":"c46ab616bac84d2dda5150840559cda276d7ea12"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"f126f72107ea81e4c9bd7e803376f965cdb0f588","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    Router to modify (name or ID)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"router show"},{"line_number":118,"context_line":"------------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Display router details"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a710552_e287825f","line":118,"in_reply_to":"5a710552_b0178dec","updated":"2015-12-15 12:29:41.000000000","message":"Done","commit_id":"c46ab616bac84d2dda5150840559cda276d7ea12"}],"openstackclient/network/v2/router.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"ada4d0e7b507c2420693259a74fd5d21114c5fc8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    return \u0027UP\u0027 if state else \u0027DOWN\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _format_external_gateway_info(info):"},{"line_number":33,"context_line":"    try:"},{"line_number":34,"context_line":"        return json.dumps(info)"},{"line_number":35,"context_line":"    except (TypeError, KeyError):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_8fffec33","line":32,"updated":"2015-12-14 20:55:41.000000000","message":"Maybe a \"if info:\" here","commit_id":"e5c078d02f41bea18999ed1e2a257854542a9777"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"57930c2aae9722a80ba649b2ba7de0f47b39ce96","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":290,"context_line":"        obj \u003d client.find_router(parsed_args.router, ignore_missing\u003dFalse)"},{"line_number":291,"context_line":"        columns \u003d sorted(obj.keys())"},{"line_number":292,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":293,"context_line":"        return (tuple(columns), data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_2a8d8631","line":292,"updated":"2015-12-14 21:09:44.000000000","message":"Shouldn\u0027t the data be sanitized to change tenant to project and possibly other changes to align with \"router list\" before returning?","commit_id":"e5c078d02f41bea18999ed1e2a257854542a9777"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ec23716b65dae151aafe30f4748f79596ad7d502","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":290,"context_line":"        obj \u003d client.find_router(parsed_args.router, ignore_missing\u003dFalse)"},{"line_number":291,"context_line":"        columns \u003d sorted(obj.keys())"},{"line_number":292,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":293,"context_line":"        return (tuple(columns), data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_f4930ca1","line":292,"updated":"2015-12-14 15:45:51.000000000","message":"When external_gateway_info is None, it will raise an exception like \"NoneType object is not iterable\" here. I don\u0027t quite understand why this happens, and I haven\u0027t find a property way to deal with it. But even so, the unit tests will pass.","commit_id":"e5c078d02f41bea18999ed1e2a257854542a9777"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"12e31952e2e3ea0626b357724811532b4293f536","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":290,"context_line":"        obj \u003d client.find_router(parsed_args.router, ignore_missing\u003dFalse)"},{"line_number":291,"context_line":"        columns \u003d sorted(obj.keys())"},{"line_number":292,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":293,"context_line":"        return (tuple(columns), data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_9b740ed0","line":292,"in_reply_to":"5a710552_2a8d8631","updated":"2015-12-14 22:29:21.000000000","message":"For neutron, we could use a generic tenant-\u003eproject mapping, but I think that could be in another patch","commit_id":"e5c078d02f41bea18999ed1e2a257854542a9777"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"0f50bd63e38e09be190712ac4faeb056ecc6c0a4","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"class ShowRouter(show.ShowOne):"},{"line_number":274,"context_line":"    \"\"\"Show router details\"\"\""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ShowRouter\u0027)"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_b0ef8daf","line":274,"updated":"2015-12-15 10:38:00.000000000","message":"\"Display\"  router details, to match the term used in docs","commit_id":"c46ab616bac84d2dda5150840559cda276d7ea12"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"f126f72107ea81e4c9bd7e803376f965cdb0f588","unresolved":false,"context_lines":[{"line_number":271,"context_line":""},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"class ShowRouter(show.ShowOne):"},{"line_number":274,"context_line":"    \"\"\"Show router details\"\"\""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ShowRouter\u0027)"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_42977690","line":274,"in_reply_to":"5a710552_b0ef8daf","updated":"2015-12-15 12:29:41.000000000","message":"Done","commit_id":"c46ab616bac84d2dda5150840559cda276d7ea12"}]}
