)]}'
{"doc/source/command-objects/image.rst":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a11f383ed06916723054bf1930e5d47c06dd85d3","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    Reactivate the image."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    .. versionadded:: 2"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":".. describe:: \u003cimage\u003e"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    Image to modify (name or ID)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5a710552_fc3aa797","line":401,"updated":"2015-12-15 22:48:20.000000000","message":"These need to be added to the synposis starting on line ~220.","commit_id":"0c31a0f6f57d9ae57ff231a490465fb0c2ca4f53"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"124e7a33faa61d918dcde48c7955e01c7b4a7cfa","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        [--os-version \u003cos-version\u003e]"},{"line_number":245,"context_line":"        [--ramdisk-id \u003cramdisk-id\u003e]"},{"line_number":246,"context_line":"        [--activate]"},{"line_number":247,"context_line":"        [--deactivate]"},{"line_number":248,"context_line":"        \u003cimage\u003e"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a710552_cc727549","line":247,"updated":"2015-12-16 13:33:31.000000000","message":"It should look like this in help:\n\n  [--activate|--deactivate]","commit_id":"1527e7caadf9f9bf8a7652a4508122687320d0f5"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"124e7a33faa61d918dcde48c7955e01c7b4a7cfa","unresolved":false,"context_lines":[{"line_number":391,"context_line":""},{"line_number":392,"context_line":".. option:: --activate"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    Reactivate the image."},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    .. versionadded:: 2"},{"line_number":397,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a710552_aca049a0","line":394,"updated":"2015-12-16 13:33:31.000000000","message":"Activate","commit_id":"1527e7caadf9f9bf8a7652a4508122687320d0f5"}],"openstackclient/image/v2/image.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8d7ea3b64c75cf07aa52c0266531539e0ceeb3e4","unresolved":false,"context_lines":[{"line_number":781,"context_line":"            image \u003d image_client.images.update(image.id, **kwargs)"},{"line_number":782,"context_line":"        except Exception as e:"},{"line_number":783,"context_line":"            if parsed_args.deactivate or parsed_args.reactivate:"},{"line_number":784,"context_line":"                print(\"Image was de/reactivated.\")"},{"line_number":785,"context_line":"            raise e"},{"line_number":786,"context_line":""},{"line_number":787,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_b6ba4e6d","line":784,"updated":"2015-12-14 18:27:45.000000000","message":"include the image name and id in the message, it\u0027s already available as \"image\" on line 764 -- hmm, i wonder why we set image \u003d update result. it\u0027s pointless.\n\nAlso, it\u0027s easy enough to differentiate between reactivate and deactivate, suggest breaking those up","commit_id":"62fa4a298f8dcac0ea0f20e8d1cf9cc946b99260"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a11f383ed06916723054bf1930e5d47c06dd85d3","unresolved":false,"context_lines":[{"line_number":700,"context_line":"            help\u003d\"Deactivate the image\","},{"line_number":701,"context_line":"        )"},{"line_number":702,"context_line":"        deactivate_group.add_argument("},{"line_number":703,"context_line":"            \"--reactivate\","},{"line_number":704,"context_line":"            action\u003d\"store_true\","},{"line_number":705,"context_line":"            help\u003d\"Reactivate the image\","},{"line_number":706,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_9c0fe3e0","line":703,"updated":"2015-12-15 22:48:20.000000000","message":"Maybe --activate is better?","commit_id":"0c31a0f6f57d9ae57ff231a490465fb0c2ca4f53"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"a11f383ed06916723054bf1930e5d47c06dd85d3","unresolved":false,"context_lines":[{"line_number":765,"context_line":"            image_client.images, parsed_args.image)"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"        if parsed_args.deactivate:"},{"line_number":768,"context_line":"            image_client.images.deactivate(image.id)"},{"line_number":769,"context_line":"            activation_status \u003d \"deactivated\""},{"line_number":770,"context_line":"        if parsed_args.reactivate:"},{"line_number":771,"context_line":"            image_client.images.reactivate(image.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_7c78f72b","line":768,"updated":"2015-12-15 22:48:20.000000000","message":"we should catch errors here and either bail on the whole thing (which is what I suppose happens now, is the message sane?) or continue with the update.  I\u0027m not sure which is the Right Thing though.  I think continuing, as that is what it would appear to the user if the update below fails but these succeed.  The operations should be idempotent so re-running the whole command should not be harmful.","commit_id":"0c31a0f6f57d9ae57ff231a490465fb0c2ca4f53"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"dbdd87cf3e8c8458eadae125cd4c524bb09dc37b","unresolved":false,"context_lines":[{"line_number":765,"context_line":"            image_client.images, parsed_args.image)"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"        if parsed_args.deactivate:"},{"line_number":768,"context_line":"            image_client.images.deactivate(image.id)"},{"line_number":769,"context_line":"            activation_status \u003d \"deactivated\""},{"line_number":770,"context_line":"        if parsed_args.reactivate:"},{"line_number":771,"context_line":"            image_client.images.reactivate(image.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_dd478949","line":768,"in_reply_to":"5a710552_7c78f72b","updated":"2015-12-16 12:04:29.000000000","message":"The reason it was done this way is so if the user tries to (de)activate an image and they can\u0027t the image update does not get ran. This is like how a command would work now with something like --public. It would then be up to the user to remove the command so the rest of the changes will work.\n\nI know the commands are idempotent, however I think we should minimise continuing regardless as it breaks what the user would be expecting with normal usage.\n\nWith this the only change to what a user would be used to would be the fact that if they (de)activate an image and then another command won\u0027t run then the (de)activate part does get run. This is the least we can run without it all being correct. I think this therefore is the most favourable solution.","commit_id":"0c31a0f6f57d9ae57ff231a490465fb0c2ca4f53"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"124e7a33faa61d918dcde48c7955e01c7b4a7cfa","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        deactivate_group.add_argument("},{"line_number":703,"context_line":"            \"--activate\","},{"line_number":704,"context_line":"            action\u003d\"store_true\","},{"line_number":705,"context_line":"            help\u003d\"Reactivate the image\","},{"line_number":706,"context_line":"        )"},{"line_number":707,"context_line":"        for deadopt in self.deadopts:"},{"line_number":708,"context_line":"            parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a710552_6ca261b0","line":705,"updated":"2015-12-16 13:33:31.000000000","message":"Activate","commit_id":"1527e7caadf9f9bf8a7652a4508122687320d0f5"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"993debf8a59aee996b8339271c935ff32adcbaca","unresolved":false,"context_lines":[{"line_number":773,"context_line":""},{"line_number":774,"context_line":"        # Check if need to do the actual update"},{"line_number":775,"context_line":"        if not kwargs:"},{"line_number":776,"context_line":"            return {}, {}"},{"line_number":777,"context_line":""},{"line_number":778,"context_line":"        if parsed_args.tags:"},{"line_number":779,"context_line":"            # Tags should be extended, but duplicates removed"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_00eaa10f","line":776,"updated":"2015-12-17 19:13:10.000000000","message":"Shouldn\u0027t this just return, I though set returned nothing","commit_id":"b3943d714275b276a973de9c52307e82c90be8bc"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7f80cc3de32a8be760023bcd802de67337ec8fa0","unresolved":false,"context_lines":[{"line_number":773,"context_line":""},{"line_number":774,"context_line":"        # Check if need to do the actual update"},{"line_number":775,"context_line":"        if not kwargs:"},{"line_number":776,"context_line":"            return {}, {}"},{"line_number":777,"context_line":""},{"line_number":778,"context_line":"        if parsed_args.tags:"},{"line_number":779,"context_line":"            # Tags should be extended, but duplicates removed"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_40c5093a","line":776,"in_reply_to":"3a7e1126_00eaa10f","updated":"2015-12-17 19:17:41.000000000","message":"yeah, but command.Command doesn\u0027t nothing with the result, so it doesn\u0027t matter","commit_id":"b3943d714275b276a973de9c52307e82c90be8bc"}]}