)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"83f07cdb4effc61ed21a25c17c27ae22c13ea8dd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ability to set key value pairs in groups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add supporto of extra key value pairs for groups"},{"line_number":10,"context_line":"* Added option --property key\u003dvalue to create and set commands"},{"line_number":11,"context_line":"* Support for versions v3"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_e9c1b52f","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":12},"updated":"2015-12-23 10:07:47.000000000","message":"typo: support\n\nSupport extra key value pairs for groups ??","commit_id":"6d9177a71f3151c1eb4c88513d6b2e8c4de46a2b"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"63509639aa531f83218112852fcac5f79700bb2a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ability to set key value pairs in groups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add supporto of extra key value pairs for groups"},{"line_number":10,"context_line":"* Added option --property key\u003dvalue to create and set commands"},{"line_number":11,"context_line":"* Support for versions v3"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_ec444275","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":12},"in_reply_to":"1a7b0d38_e9c1b52f","updated":"2015-12-24 06:31:27.000000000","message":"Done","commit_id":"6d9177a71f3151c1eb4c88513d6b2e8c4de46a2b"}],"doc/source/command-objects/group.rst":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"c986de3bcd1158b66e1267171d2d84df9d478d80","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. option:: --property \u003ckey\u003dvalue\u003e"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    Add a property to :ref:`\\\u003cname\\\u003e \u003cgroup_create-name\u003e`"},{"line_number":105,"context_line":"    (repeat option to set multiple properties)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. option:: --or-show"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dae33548_9adcc174","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":4},"updated":"2016-02-17 03:34:27.000000000","message":"make this match the help in https://review.openstack.org/#/c/260911/7/openstackclient/identity/v3/group.py","commit_id":"5f27a07aaeab72b339130afb97348cd1d1de86ff"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"3567d59d36037a9ab7c0157120b7bc2596772c2e","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. option:: --property \u003ckey\u003dvalue\u003e"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    Add a property to :ref:`\\\u003cname\\\u003e \u003cgroup_create-name\u003e`"},{"line_number":105,"context_line":"    (repeat option to set multiple properties)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":".. option:: --or-show"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dae33548_f65be6f4","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":4},"in_reply_to":"dae33548_9adcc174","updated":"2016-02-19 03:10:36.000000000","message":"Done","commit_id":"5f27a07aaeab72b339130afb97348cd1d1de86ff"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"c986de3bcd1158b66e1267171d2d84df9d478d80","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":".. option:: --property \u003ckey\u003dvalue\u003e"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    Add a property to :ref:`\\\u003cname\\\u003e \u003cgroup_set-name\u003e`"},{"line_number":235,"context_line":"    (repeat option to set multiple properties)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":".. describe:: \u003cgroup\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dae33548_fae50d38","line":234,"range":{"start_line":234,"start_character":4,"end_line":234,"end_character":7},"updated":"2016-02-17 03:34:27.000000000","message":"same comment here","commit_id":"5f27a07aaeab72b339130afb97348cd1d1de86ff"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"3567d59d36037a9ab7c0157120b7bc2596772c2e","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":".. option:: --property \u003ckey\u003dvalue\u003e"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    Add a property to :ref:`\\\u003cname\\\u003e \u003cgroup_set-name\u003e`"},{"line_number":235,"context_line":"    (repeat option to set multiple properties)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":".. describe:: \u003cgroup\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"dae33548_5671f276","line":234,"range":{"start_line":234,"start_character":4,"end_line":234,"end_character":7},"in_reply_to":"dae33548_fae50d38","updated":"2016-02-19 03:10:36.000000000","message":"Done","commit_id":"5f27a07aaeab72b339130afb97348cd1d1de86ff"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"c986de3bcd1158b66e1267171d2d84df9d478d80","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":".. option:: --property \u003ckey\u003e"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    Property key to remove from group (repeat option to remove multiple properties)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":".. describe:: \u003cgroup\u003e"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dae33548_ba4d4540","line":275,"range":{"start_line":275,"start_character":4,"end_line":275,"end_character":12},"updated":"2016-02-17 03:34:27.000000000","message":"same here","commit_id":"5f27a07aaeab72b339130afb97348cd1d1de86ff"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"3567d59d36037a9ab7c0157120b7bc2596772c2e","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":".. option:: --property \u003ckey\u003e"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    Property key to remove from group (repeat option to remove multiple properties)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":".. describe:: \u003cgroup\u003e"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dae33548_76687688","line":275,"range":{"start_line":275,"start_character":4,"end_line":275,"end_character":12},"in_reply_to":"dae33548_ba4d4540","updated":"2016-02-19 03:10:36.000000000","message":"Done","commit_id":"5f27a07aaeab72b339130afb97348cd1d1de86ff"}],"openstackclient/identity/v3/group.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"35018be721b2e798979124e5115a92d23f1dcbfc","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            \u0027--property\u0027,"},{"line_number":146,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":147,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":148,"context_line":"            help\u003d\u0027Property to add for this project \u0027"},{"line_number":149,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":150,"context_line":"        )"},{"line_number":151,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_366a7ab4","line":148,"range":{"start_line":148,"start_character":43,"end_line":148,"end_character":50},"updated":"2015-12-25 08:06:27.000000000","message":"s/project/group?","commit_id":"9ad64e157dc0fe537f35563c2f4f649fb59b3779"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"833ea83895f049ca9b8226dafd46f1460bf3a637","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            \u0027--property\u0027,"},{"line_number":146,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":147,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":148,"context_line":"            help\u003d\u0027Property to add for this project \u0027"},{"line_number":149,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":150,"context_line":"        )"},{"line_number":151,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_35c7c746","line":148,"range":{"start_line":148,"start_character":43,"end_line":148,"end_character":50},"in_reply_to":"1a7b0d38_366a7ab4","updated":"2015-12-25 14:29:42.000000000","message":"Done","commit_id":"9ad64e157dc0fe537f35563c2f4f649fb59b3779"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"35018be721b2e798979124e5115a92d23f1dcbfc","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            \u0027--property\u0027,"},{"line_number":346,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":347,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":348,"context_line":"            help\u003d\u0027Property to add for this project \u0027"},{"line_number":349,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":350,"context_line":"        )"},{"line_number":351,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_f66392da","line":348,"range":{"start_line":348,"start_character":43,"end_line":348,"end_character":50},"updated":"2015-12-25 08:06:27.000000000","message":"ditto","commit_id":"9ad64e157dc0fe537f35563c2f4f649fb59b3779"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"833ea83895f049ca9b8226dafd46f1460bf3a637","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            \u0027--property\u0027,"},{"line_number":346,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":347,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":348,"context_line":"            help\u003d\u0027Property to add for this project \u0027"},{"line_number":349,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":350,"context_line":"        )"},{"line_number":351,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_d5f3e39c","line":348,"range":{"start_line":348,"start_character":43,"end_line":348,"end_character":50},"in_reply_to":"1a7b0d38_f66392da","updated":"2015-12-25 14:29:42.000000000","message":"Done","commit_id":"9ad64e157dc0fe537f35563c2f4f649fb59b3779"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"35018be721b2e798979124e5115a92d23f1dcbfc","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                                  parsed_args.domain)"},{"line_number":358,"context_line":"        kwargs \u003d {}"},{"line_number":359,"context_line":"        if parsed_args.property:"},{"line_number":360,"context_line":"            kwargs \u003d parsed_args.property.copy()"},{"line_number":361,"context_line":"        if parsed_args.name:"},{"line_number":362,"context_line":"            kwargs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":363,"context_line":"        if parsed_args.description:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_b69c2ac1","line":360,"range":{"start_line":360,"start_character":33,"end_line":360,"end_character":41},"updated":"2015-12-25 08:06:27.000000000","message":"why do we need to do copying here?","commit_id":"9ad64e157dc0fe537f35563c2f4f649fb59b3779"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"833ea83895f049ca9b8226dafd46f1460bf3a637","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                                  parsed_args.domain)"},{"line_number":358,"context_line":"        kwargs \u003d {}"},{"line_number":359,"context_line":"        if parsed_args.property:"},{"line_number":360,"context_line":"            kwargs \u003d parsed_args.property.copy()"},{"line_number":361,"context_line":"        if parsed_args.name:"},{"line_number":362,"context_line":"            kwargs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":363,"context_line":"        if parsed_args.description:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_d54a03c5","line":360,"range":{"start_line":360,"start_character":33,"end_line":360,"end_character":41},"in_reply_to":"1a7b0d38_b69c2ac1","updated":"2015-12-25 14:29:42.000000000","message":"I\u0027m not sure. 70e6333e7d4b3fa87496ff3a888527693875273b did it.","commit_id":"9ad64e157dc0fe537f35563c2f4f649fb59b3779"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"cd019f42038f31733da00c4a98591dfd5ff9ef55","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":147,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":148,"context_line":"            help\u003d\u0027Property to add for this group \u0027"},{"line_number":149,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":150,"context_line":"        )"},{"line_number":151,"context_line":"        return parser"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_1c23d306","line":149,"range":{"start_line":149,"start_character":25,"end_line":149,"end_character":26},"updated":"2015-12-25 15:27:25.000000000","message":"change into \u0027repeat this option\u0027?","commit_id":"c2ca4f00a6c22dc177c9a3972ce6a8b3ed38c3b0"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"4c63c3c53a502044303d7cf05488ec21e982101f","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":147,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":148,"context_line":"            help\u003d\u0027Property to add for this group \u0027"},{"line_number":149,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":150,"context_line":"        )"},{"line_number":151,"context_line":"        return parser"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_24c8e8a7","line":149,"range":{"start_line":149,"start_character":25,"end_line":149,"end_character":26},"in_reply_to":"1a7b0d38_1c23d306","updated":"2015-12-27 05:35:27.000000000","message":"Done","commit_id":"c2ca4f00a6c22dc177c9a3972ce6a8b3ed38c3b0"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e45ac2f8a99a568c00f7f4b9166d5e069afe3206","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            domain \u003d common.find_domain(identity_client,"},{"line_number":152,"context_line":"                                        parsed_args.domain).id"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        try:"},{"line_number":155,"context_line":"            group \u003d identity_client.groups.create("},{"line_number":156,"context_line":"                name\u003dparsed_args.name,"},{"line_number":157,"context_line":"                domain\u003ddomain,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_893f8ed5","side":"PARENT","line":154,"updated":"2016-01-04 14:47:54.000000000","message":"Why copy?","commit_id":"8210ba7a557a44c322ff3adddcbc98072a978e11"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"a93a99a47368b8a32c3212d2f76756208fcffcbf","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            domain \u003d common.find_domain(identity_client,"},{"line_number":152,"context_line":"                                        parsed_args.domain).id"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        try:"},{"line_number":155,"context_line":"            group \u003d identity_client.groups.create("},{"line_number":156,"context_line":"                name\u003dparsed_args.name,"},{"line_number":157,"context_line":"                domain\u003ddomain,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_cbb79a38","side":"PARENT","line":154,"in_reply_to":"fa69d971_893f8ed5","updated":"2016-01-05 14:26:16.000000000","message":"I\u0027m not sure. 70e6333e7d4b3fa87496ff3a888527693875273b did it.\nThe next commit doesn\u0027t have it.","commit_id":"8210ba7a557a44c322ff3adddcbc98072a978e11"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9ee9856d14315f66aea9f3a97ca4b5c33e047a61","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from cliff import command"},{"line_number":23,"context_line":"from cliff import lister"},{"line_number":24,"context_line":"from cliff import show"},{"line_number":25,"context_line":"from keystoneauth1 import exceptions as ks_exc"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from openstackclient.common import parseractions"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_2a31255a","line":24,"range":{"start_line":22,"start_character":0,"end_line":24,"end_character":22},"updated":"2016-02-02 03:47:44.000000000","message":"Refactoring on logging [1] has landed.\nAs a result, these three line should be:\n\n  from openstackclient.common import command\n\n[1] commit 258c1102cc6b93a860bcd7cc083d4e14ae0025ce","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"ece083b0ed7864cafd3fa7460918835d16ed153a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import six"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from cliff import command"},{"line_number":23,"context_line":"from cliff import lister"},{"line_number":24,"context_line":"from cliff import show"},{"line_number":25,"context_line":"from keystoneauth1 import exceptions as ks_exc"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from openstackclient.common import parseractions"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_cfbefcd3","line":24,"range":{"start_line":22,"start_character":0,"end_line":24,"end_character":22},"in_reply_to":"7a5de9d1_2a31255a","updated":"2016-02-15 01:27:12.000000000","message":"Done","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d270af0caaf96c6ecad62d81bb9da1c0094d6016","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                                  parsed_args.domain)"},{"line_number":363,"context_line":"        kwargs \u003d {}"},{"line_number":364,"context_line":"        if parsed_args.property:"},{"line_number":365,"context_line":"            for key, value in six.iteritems(parsed_args.property):"},{"line_number":366,"context_line":"                if key not in RESERVED_PROPERTY:"},{"line_number":367,"context_line":"                    kwargs[key] \u003d value"},{"line_number":368,"context_line":"        if parsed_args.name:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_05724e11","line":365,"range":{"start_line":365,"start_character":30,"end_line":365,"end_character":65},"updated":"2016-01-25 00:45:59.000000000","message":"parsed_args.property is usually expected to be short.\nDo you really need to use iteritems?\nDoesn\u0027t items() work?","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"37b39c84cd106a542bbd98ef8e5040119ee110cd","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                                  parsed_args.domain)"},{"line_number":363,"context_line":"        kwargs \u003d {}"},{"line_number":364,"context_line":"        if parsed_args.property:"},{"line_number":365,"context_line":"            for key, value in six.iteritems(parsed_args.property):"},{"line_number":366,"context_line":"                if key not in RESERVED_PROPERTY:"},{"line_number":367,"context_line":"                    kwargs[key] \u003d value"},{"line_number":368,"context_line":"        if parsed_args.name:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_0a50e030","line":365,"range":{"start_line":365,"start_character":30,"end_line":365,"end_character":65},"in_reply_to":"9a68dd71_05724e11","updated":"2016-01-26 03:07:00.000000000","message":"items() may work, but six.iteritems() look major in python-openstackclient, so I\u0027ve used it.","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9ee9856d14315f66aea9f3a97ca4b5c33e047a61","unresolved":false,"context_lines":[{"line_number":411,"context_line":"class UnsetGroup(command.Command):"},{"line_number":412,"context_line":"    \"\"\"Unset group properties\"\"\""},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.UnsetGroup\u0027)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def get_parser(self, prog_name):"},{"line_number":417,"context_line":"        parser \u003d super(UnsetGroup, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_2a1845d2","line":414,"range":{"start_line":414,"start_character":3,"end_line":414,"end_character":53},"updated":"2016-02-02 03:47:44.000000000","message":"unnecessary now.","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"ece083b0ed7864cafd3fa7460918835d16ed153a","unresolved":false,"context_lines":[{"line_number":411,"context_line":"class UnsetGroup(command.Command):"},{"line_number":412,"context_line":"    \"\"\"Unset group properties\"\"\""},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.UnsetGroup\u0027)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def get_parser(self, prog_name):"},{"line_number":417,"context_line":"        parser \u003d super(UnsetGroup, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_ef781f92","line":414,"range":{"start_line":414,"start_character":3,"end_line":414,"end_character":53},"in_reply_to":"7a5de9d1_2a1845d2","updated":"2016-02-15 01:27:12.000000000","message":"Done","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9ee9856d14315f66aea9f3a97ca4b5c33e047a61","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        )"},{"line_number":432,"context_line":"        return parser"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    @utils.log_method(log)"},{"line_number":435,"context_line":"    def take_action(self, parsed_args):"},{"line_number":436,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":437,"context_line":"        group \u003d utils.find_resource("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a5de9d1_ca0ad178","line":434,"range":{"start_line":434,"start_character":3,"end_line":434,"end_character":26},"updated":"2016-02-02 03:47:44.000000000","message":"unnecessary now.","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"ece083b0ed7864cafd3fa7460918835d16ed153a","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        )"},{"line_number":432,"context_line":"        return parser"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    @utils.log_method(log)"},{"line_number":435,"context_line":"    def take_action(self, parsed_args):"},{"line_number":436,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":437,"context_line":"        group \u003d utils.find_resource("}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_ef9f7fb2","line":434,"range":{"start_line":434,"start_character":3,"end_line":434,"end_character":26},"in_reply_to":"7a5de9d1_ca0ad178","updated":"2016-02-15 01:27:12.000000000","message":"Done","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d270af0caaf96c6ecad62d81bb9da1c0094d6016","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            parsed_args.group,"},{"line_number":440,"context_line":"        )"},{"line_number":441,"context_line":"        if not parsed_args.property:"},{"line_number":442,"context_line":"            self.app.log.error(\"No changes requested\\n\")"},{"line_number":443,"context_line":"        else:"},{"line_number":444,"context_line":"            kwargs \u003d {}"},{"line_number":445,"context_line":"            for key in parsed_args.property:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_2571920f","line":442,"updated":"2016-01-25 00:45:59.000000000","message":"Is a newline required?","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"37b39c84cd106a542bbd98ef8e5040119ee110cd","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            parsed_args.group,"},{"line_number":440,"context_line":"        )"},{"line_number":441,"context_line":"        if not parsed_args.property:"},{"line_number":442,"context_line":"            self.app.log.error(\"No changes requested\\n\")"},{"line_number":443,"context_line":"        else:"},{"line_number":444,"context_line":"            kwargs \u003d {}"},{"line_number":445,"context_line":"            for key in parsed_args.property:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_a5f1c702","line":442,"in_reply_to":"9a68dd71_2571920f","updated":"2016-01-26 03:07:00.000000000","message":"No. Actually, it\u0027s a copy of pre-existing code.\nI\u0027ll fix it.","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"ece083b0ed7864cafd3fa7460918835d16ed153a","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            parsed_args.group,"},{"line_number":440,"context_line":"        )"},{"line_number":441,"context_line":"        if not parsed_args.property:"},{"line_number":442,"context_line":"            self.app.log.error(\"No changes requested\\n\")"},{"line_number":443,"context_line":"        else:"},{"line_number":444,"context_line":"            kwargs \u003d {}"},{"line_number":445,"context_line":"            for key in parsed_args.property:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_6fac0fee","line":442,"in_reply_to":"9a68dd71_a5f1c702","updated":"2016-02-15 01:27:12.000000000","message":"Done","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d270af0caaf96c6ecad62d81bb9da1c0094d6016","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        else:"},{"line_number":444,"context_line":"            kwargs \u003d {}"},{"line_number":445,"context_line":"            for key in parsed_args.property:"},{"line_number":446,"context_line":"                if key in (\u0027id\u0027, \u0027name\u0027, \u0027domain_id\u0027, \u0027links\u0027):"},{"line_number":447,"context_line":"                    continue"},{"line_number":448,"context_line":"                if key in group._info:"},{"line_number":449,"context_line":"                    kwargs[key] \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_4525a606","line":446,"range":{"start_line":446,"start_character":26,"end_line":446,"end_character":63},"updated":"2016-01-25 00:45:59.000000000","message":"Why is it different from RESERVED_PROPERTY?","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8df479ce2d61dc6ff0849365d487403f46324857","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        else:"},{"line_number":444,"context_line":"            kwargs \u003d {}"},{"line_number":445,"context_line":"            for key in parsed_args.property:"},{"line_number":446,"context_line":"                if key in (\u0027id\u0027, \u0027name\u0027, \u0027domain_id\u0027, \u0027links\u0027):"},{"line_number":447,"context_line":"                    continue"},{"line_number":448,"context_line":"                if key in group._info:"},{"line_number":449,"context_line":"                    kwargs[key] \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_c07dc96d","line":446,"range":{"start_line":446,"start_character":26,"end_line":446,"end_character":63},"in_reply_to":"9a68dd71_25dab717","updated":"2016-01-26 03:48:15.000000000","message":"Thanks for the clarification. Anyway, it is better to define a tuple constant with a reasonable name.","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"37b39c84cd106a542bbd98ef8e5040119ee110cd","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        else:"},{"line_number":444,"context_line":"            kwargs \u003d {}"},{"line_number":445,"context_line":"            for key in parsed_args.property:"},{"line_number":446,"context_line":"                if key in (\u0027id\u0027, \u0027name\u0027, \u0027domain_id\u0027, \u0027links\u0027):"},{"line_number":447,"context_line":"                    continue"},{"line_number":448,"context_line":"                if key in group._info:"},{"line_number":449,"context_line":"                    kwargs[key] \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_85704373","line":446,"range":{"start_line":446,"start_character":26,"end_line":446,"end_character":63},"in_reply_to":"9a68dd71_4525a606","updated":"2016-01-26 03:07:00.000000000","message":"Hmm... looks just a mistake. I\u0027ll replace it with RESERVED_PROPERTY.","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"392b2ca36db5133ccaa28f7141d8e129635bb7ec","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        else:"},{"line_number":444,"context_line":"            kwargs \u003d {}"},{"line_number":445,"context_line":"            for key in parsed_args.property:"},{"line_number":446,"context_line":"                if key in (\u0027id\u0027, \u0027name\u0027, \u0027domain_id\u0027, \u0027links\u0027):"},{"line_number":447,"context_line":"                    continue"},{"line_number":448,"context_line":"                if key in group._info:"},{"line_number":449,"context_line":"                    kwargs[key] \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_25dab717","line":446,"range":{"start_line":446,"start_character":26,"end_line":446,"end_character":63},"in_reply_to":"9a68dd71_85704373","updated":"2016-01-26 03:16:48.000000000","message":"I found the reason. They are non-nullable parameters and an automatic-generated parameter, so making them null is not allowed.","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"ece083b0ed7864cafd3fa7460918835d16ed153a","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        else:"},{"line_number":444,"context_line":"            kwargs \u003d {}"},{"line_number":445,"context_line":"            for key in parsed_args.property:"},{"line_number":446,"context_line":"                if key in (\u0027id\u0027, \u0027name\u0027, \u0027domain_id\u0027, \u0027links\u0027):"},{"line_number":447,"context_line":"                    continue"},{"line_number":448,"context_line":"                if key in group._info:"},{"line_number":449,"context_line":"                    kwargs[key] \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_2fcfa7b1","line":446,"range":{"start_line":446,"start_character":26,"end_line":446,"end_character":63},"in_reply_to":"9a68dd71_c07dc96d","updated":"2016-02-15 01:27:12.000000000","message":"Done","commit_id":"4dfb9c5a97c13ddf8c9b1de0ba1d95f4e144d9c7"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"c986de3bcd1158b66e1267171d2d84df9d478d80","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            \u0027--property\u0027,"},{"line_number":139,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":140,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":141,"context_line":"            help\u003d\u0027Property to add for this group \u0027"},{"line_number":142,"context_line":"                 \u0027(repeat this option to set multiple properties)\u0027,"},{"line_number":143,"context_line":"        )"},{"line_number":144,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_1a89d175","line":141,"range":{"start_line":141,"start_character":16,"end_line":141,"end_character":18},"updated":"2016-02-17 03:34:27.000000000","message":"for consistency use: \"Set a property on this group (repeat this option to set multiple properties)\"","commit_id":"5f27a07aaeab72b339130afb97348cd1d1de86ff"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"3567d59d36037a9ab7c0157120b7bc2596772c2e","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            \u0027--property\u0027,"},{"line_number":139,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":140,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":141,"context_line":"            help\u003d\u0027Property to add for this group \u0027"},{"line_number":142,"context_line":"                 \u0027(repeat this option to set multiple properties)\u0027,"},{"line_number":143,"context_line":"        )"},{"line_number":144,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_1b6cb307","line":141,"range":{"start_line":141,"start_character":16,"end_line":141,"end_character":18},"in_reply_to":"dae33548_1a89d175","updated":"2016-02-19 03:10:36.000000000","message":"Done","commit_id":"5f27a07aaeab72b339130afb97348cd1d1de86ff"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"c986de3bcd1158b66e1267171d2d84df9d478d80","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            \u0027--property\u0027,"},{"line_number":329,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":330,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":331,"context_line":"            help\u003d\u0027Property to add for this group \u0027"},{"line_number":332,"context_line":"                 \u0027(repeat this option to set multiple properties)\u0027,"},{"line_number":333,"context_line":"        )"},{"line_number":334,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_9a95e188","line":331,"updated":"2016-02-17 03:34:27.000000000","message":"for consistency use: \"Property to add or modify for this group... \"","commit_id":"5f27a07aaeab72b339130afb97348cd1d1de86ff"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"3567d59d36037a9ab7c0157120b7bc2596772c2e","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            \u0027--property\u0027,"},{"line_number":329,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":330,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":331,"context_line":"            help\u003d\u0027Property to add for this group \u0027"},{"line_number":332,"context_line":"                 \u0027(repeat this option to set multiple properties)\u0027,"},{"line_number":333,"context_line":"        )"},{"line_number":334,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_bb4dc79b","line":331,"in_reply_to":"dae33548_9a95e188","updated":"2016-02-19 03:10:36.000000000","message":"Done","commit_id":"5f27a07aaeab72b339130afb97348cd1d1de86ff"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"c986de3bcd1158b66e1267171d2d84df9d478d80","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            metavar\u003d\u0027\u003ckey\u003e\u0027,"},{"line_number":398,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":399,"context_line":"            default\u003d[],"},{"line_number":400,"context_line":"            help\u003d_(\u0027Unset a group property \u0027"},{"line_number":401,"context_line":"                   \u0027(repeat option to unset multiple properties)\u0027),"},{"line_number":402,"context_line":"            required\u003dTrue,"},{"line_number":403,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_bac6e597","line":400,"range":{"start_line":400,"start_character":18,"end_line":400,"end_character":20},"updated":"2016-02-17 03:34:27.000000000","message":"for consistency: \"Property to remove from group...\"\n\ndon\u0027t need to wrap in _(), most of the help are not translatable anyway","commit_id":"5f27a07aaeab72b339130afb97348cd1d1de86ff"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"3567d59d36037a9ab7c0157120b7bc2596772c2e","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            metavar\u003d\u0027\u003ckey\u003e\u0027,"},{"line_number":398,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":399,"context_line":"            default\u003d[],"},{"line_number":400,"context_line":"            help\u003d_(\u0027Unset a group property \u0027"},{"line_number":401,"context_line":"                   \u0027(repeat option to unset multiple properties)\u0027),"},{"line_number":402,"context_line":"            required\u003dTrue,"},{"line_number":403,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_7b2b3f95","line":400,"range":{"start_line":400,"start_character":18,"end_line":400,"end_character":20},"in_reply_to":"dae33548_bac6e597","updated":"2016-02-19 03:10:36.000000000","message":"Done","commit_id":"5f27a07aaeab72b339130afb97348cd1d1de86ff"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"c2fc9eefe45d0a587bdac7d8f7a544e52a07bec5","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        kwargs \u003d {}"},{"line_number":154,"context_line":"        if parsed_args.property:"},{"line_number":155,"context_line":"            for key, value in six.iteritems(parsed_args.property):"},{"line_number":156,"context_line":"                if key not in RESERVED_PROPERTY:"},{"line_number":157,"context_line":"                    kwargs[key] \u003d value"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_2ccd6e66","line":156,"range":{"start_line":156,"start_character":30,"end_line":156,"end_character":47},"updated":"2016-02-23 08:41:23.000000000","message":"can we log this or just fail the command?","commit_id":"157ad006b72d4f493a1752502f802d0b64f0c24b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"04a5ddc7da1d3fc4984866a73644c0a7f2fbcaaf","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        kwargs \u003d {}"},{"line_number":154,"context_line":"        if parsed_args.property:"},{"line_number":155,"context_line":"            for key, value in six.iteritems(parsed_args.property):"},{"line_number":156,"context_line":"                if key not in RESERVED_PROPERTY:"},{"line_number":157,"context_line":"                    kwargs[key] \u003d value"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_9f3553f9","line":156,"in_reply_to":"bae84128_2ccd6e66","updated":"2016-02-25 17:05:06.000000000","message":"I think a warning would be appropriate here as the user\u0027s intent is not being performed","commit_id":"157ad006b72d4f493a1752502f802d0b64f0c24b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"c2fc9eefe45d0a587bdac7d8f7a544e52a07bec5","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        kwargs \u003d {}"},{"line_number":341,"context_line":"        if parsed_args.property:"},{"line_number":342,"context_line":"            for key, value in six.iteritems(parsed_args.property):"},{"line_number":343,"context_line":"                if key not in RESERVED_PROPERTY:"},{"line_number":344,"context_line":"                    kwargs[key] \u003d value"},{"line_number":345,"context_line":"        if parsed_args.name:"},{"line_number":346,"context_line":"            kwargs[\u0027name\u0027] \u003d parsed_args.name"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_acdfbe0b","line":343,"range":{"start_line":343,"start_character":29,"end_line":343,"end_character":30},"updated":"2016-02-23 08:41:23.000000000","message":"log it or fail the command?","commit_id":"157ad006b72d4f493a1752502f802d0b64f0c24b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"c2fc9eefe45d0a587bdac7d8f7a544e52a07bec5","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            parsed_args.group,"},{"line_number":411,"context_line":"        )"},{"line_number":412,"context_line":"        if not parsed_args.property:"},{"line_number":413,"context_line":"            self.app.log.error(\"No changes requested\")"},{"line_number":414,"context_line":"        else:"},{"line_number":415,"context_line":"            kwargs \u003d {}"},{"line_number":416,"context_line":"            for key in parsed_args.property:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_4cd712ed","line":413,"range":{"start_line":413,"start_character":25,"end_line":413,"end_character":30},"updated":"2016-02-23 08:41:23.000000000","message":"I don\u0027t know, if we can return 1 to indicate the command failed?","commit_id":"157ad006b72d4f493a1752502f802d0b64f0c24b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"04a5ddc7da1d3fc4984866a73644c0a7f2fbcaaf","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            parsed_args.group,"},{"line_number":411,"context_line":"        )"},{"line_number":412,"context_line":"        if not parsed_args.property:"},{"line_number":413,"context_line":"            self.app.log.error(\"No changes requested\")"},{"line_number":414,"context_line":"        else:"},{"line_number":415,"context_line":"            kwargs \u003d {}"},{"line_number":416,"context_line":"            for key in parsed_args.property:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_bf62d714","line":413,"in_reply_to":"bae84128_4cd712ed","updated":"2016-02-25 17:05:06.000000000","message":"a) I don\u0027t like these kind of messages; b) did something fail here?  Since property is required, this is never going to be hit.  Actually, I\u0027d rather not have --property be required, should we add other options it might not be...","commit_id":"157ad006b72d4f493a1752502f802d0b64f0c24b"}],"openstackclient/tests/identity/v3/test_group.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"35018be721b2e798979124e5115a92d23f1dcbfc","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        # Get the command object to test"},{"line_number":293,"context_line":"        self.cmd \u003d group.SetGroup(self.app, None)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_group_set_no_options(self):"},{"line_number":296,"context_line":"        arglist \u003d ["},{"line_number":297,"context_line":"            \u0027--name\u0027, \u0027over\u0027,"},{"line_number":298,"context_line":"            identity_fakes.group_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_767d626d","line":295,"range":{"start_line":295,"start_character":8,"end_line":295,"end_character":33},"updated":"2015-12-25 08:06:27.000000000","message":"what do u mean by no option? --name is not one?","commit_id":"9ad64e157dc0fe537f35563c2f4f649fb59b3779"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"833ea83895f049ca9b8226dafd46f1460bf3a637","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        # Get the command object to test"},{"line_number":293,"context_line":"        self.cmd \u003d group.SetGroup(self.app, None)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_group_set_no_options(self):"},{"line_number":296,"context_line":"        arglist \u003d ["},{"line_number":297,"context_line":"            \u0027--name\u0027, \u0027over\u0027,"},{"line_number":298,"context_line":"            identity_fakes.group_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_356a671b","line":295,"range":{"start_line":295,"start_character":8,"end_line":295,"end_character":33},"in_reply_to":"1a7b0d38_767d626d","updated":"2015-12-25 14:29:42.000000000","message":"Right... I\u0027ll fix it.","commit_id":"9ad64e157dc0fe537f35563c2f4f649fb59b3779"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e45ac2f8a99a568c00f7f4b9166d5e069afe3206","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self.assertEqual(datalist, tuple(data))"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"class TestGroupCreate(TestGroup):"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def setUp(self):"},{"line_number":199,"context_line":"        super(TestGroupCreate, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_842453af","line":196,"updated":"2016-01-04 14:47:54.000000000","message":"These classes should be in alphabetical order","commit_id":"e099d1a1388116684d05f4273fbbea73835e6726"},{"author":{"_account_id":659,"name":"Akira Yoshiyama","email":"akirayoshiyama@gmail.com","username":"yosshy"},"change_message_id":"a93a99a47368b8a32c3212d2f76756208fcffcbf","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self.assertEqual(datalist, tuple(data))"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"class TestGroupCreate(TestGroup):"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def setUp(self):"},{"line_number":199,"context_line":"        super(TestGroupCreate, self).setUp()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_cb9d5a67","line":196,"in_reply_to":"fa69d971_842453af","updated":"2016-01-05 14:26:16.000000000","message":"Done","commit_id":"e099d1a1388116684d05f4273fbbea73835e6726"}]}