)]}'
{"id":"openstack%2Fpython-openstackclient~261825","triplet_id":"openstack%2Fpython-openstackclient~master~Ia2ed7c9e46bf6baabbd62b9d50511c5e8103e5e2","project":"openstack/python-openstackclient","branch":"master","topic":"bp/neutron-client","hashtags":[],"change_id":"Ia2ed7c9e46bf6baabbd62b9d50511c5e8103e5e2","subject":"Refactor: Initialize parser in setUp() in TestKeyValueAction","status":"MERGED","created":"2015-12-27 09:37:03.000000000","updated":"2015-12-27 18:18:45.000000000","submitted":"2015-12-27 18:18:45.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7e562de8ee9f22389902a4a1cc4f30a9eb84fbfa","_number":261825,"virtual_id_number":261825,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-12-27 18:18:45.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2015-12-27 17:21:51.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2015-12-27 17:21:51.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-27 17:21:51.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-12-27 18:18:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8082717e2e00487651f07eba17b934a03408a211","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-27 09:37:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f319f2bcc39369545e6f19f84d71d78bac437d32","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-27 09:46:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1f9e742880f4cf7238456612f3342de06e09c3f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-27 10:44:05.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/25/261825/1/check/gate-python-openstackclient-pep8/70207eb/ : FAILURE in 1m 03s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/25/261825/1/check/gate-python-openstackclient-docs/96d6783//doc/build/html/ : SUCCESS in 2m 07s\n- gate-python-openstackclient-python27 http://logs.openstack.org/25/261825/1/check/gate-python-openstackclient-python27/386b97b/ : SUCCESS in 2m 10s\n- gate-python-openstackclient-python34 http://logs.openstack.org/25/261825/1/check/gate-python-openstackclient-python34/9bce92b/ : FAILURE in 2m 17s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/25/261825/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/18ed31c/ : SUCCESS in 1h 06m 44s\n- gate-osc-dsvm-functional http://logs.openstack.org/25/261825/1/check/gate-osc-dsvm-functional/2f857d8/ : SUCCESS in 23m 16s","accounts_in_message":[],"_revision_number":1},{"id":"906285bb38760f0445d647be52ca9d566d3add98","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-27 12:04:11.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2a5dccf5c98e63bb9f628e6dfd31b7eff5103f39","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-27 13:42:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/25/261825/2/check/gate-python-openstackclient-pep8/9ea5b01/ : SUCCESS in 1m 03s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/25/261825/2/check/gate-python-openstackclient-docs/4bf2e3a//doc/build/html/ : SUCCESS in 1m 58s\n- gate-python-openstackclient-python27 http://logs.openstack.org/25/261825/2/check/gate-python-openstackclient-python27/829eb31/ : SUCCESS in 1m 26s\n- gate-python-openstackclient-python34 http://logs.openstack.org/25/261825/2/check/gate-python-openstackclient-python34/4c010ab/ : SUCCESS in 2m 01s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/25/261825/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/2ab79c3/ : SUCCESS in 54m 09s\n- gate-osc-dsvm-functional http://logs.openstack.org/25/261825/2/check/gate-osc-dsvm-functional/b55a16c/ : SUCCESS in 29m 47s","accounts_in_message":[],"_revision_number":2},{"id":"876369077d85564a4d2b5bb466e83c385f5a179f","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-27 17:16:58.000000000","message":"Patch Set 2:\n\nHi Steve,\n\nPlease help to reconfirm this one.\n\nThx.","accounts_in_message":[],"_revision_number":2},{"id":"4b9a1fc597bb8182ead1e6d42f34311dae17558b","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-12-27 17:21:51.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nlets kick it off","accounts_in_message":[],"_revision_number":2},{"id":"475db1f71187848f9872353ae7a6590f5173dfdc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-27 17:21:56.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"cb67c39e5055b38acefefaa1adf74e6ce71bede2","date":"2015-12-27 18:18:45.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"2ed8b260440af79a5ba77fc5c3561b1d624fc89b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-27 18:18:45.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/25/261825/2/gate/gate-python-openstackclient-docs/3a55046//doc/build/html/ : SUCCESS in 1m 57s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/25/261825/2/gate/gate-python-openstackclient-pep8/d247f14/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-python27 http://logs.openstack.org/25/261825/2/gate/gate-python-openstackclient-python27/60b317c/ : SUCCESS in 1m 41s\n- gate-python-openstackclient-python34 http://logs.openstack.org/25/261825/2/gate/gate-python-openstackclient-python34/0f9c9ca/ : SUCCESS in 2m 05s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/25/261825/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/2b7242a/ : SUCCESS in 56m 40s\n- gate-osc-dsvm-functional http://logs.openstack.org/25/261825/2/gate/gate-osc-dsvm-functional/9fa04dc/ : SUCCESS in 23m 11s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f0a3b175a1a7a8d537f6f8023dd8ff8155375f60","revisions":{"90bc5315b16ec766fc1f1f32a52442786c98ba3a":{"kind":"REWORK","_number":1,"created":"2015-12-27 09:37:03.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/25/261825/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/25/261825/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/25/261825/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/25/261825/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/25/261825/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/25/261825/1"}}},"commit":{"parents":[{"commit":"8210ba7a557a44c322ff3adddcbc98072a978e11","subject":"Replace assertEqual(None, *) with assertIsNone(*)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8210ba7a557a44c322ff3adddcbc98072a978e11"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-28 09:28:04.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-28 09:28:04.000000000","tz":480},"subject":"Refactor: Initialize parser in setUp() in TestKeyValueAction","message":"Refactor: Initialize parser in setUp() in TestKeyValueAction\n\nNo need to initialize parser in each test case. Do it in setUp().\nAlso remove the test_default_values case because it could be tested\nin the test_good_values case.\n\nChange-Id: Ia2ed7c9e46bf6baabbd62b9d50511c5e8103e5e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/90bc5315b16ec766fc1f1f32a52442786c98ba3a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/90bc5315b16ec766fc1f1f32a52442786c98ba3a"}]},"branch":"refs/heads/master"},"f0a3b175a1a7a8d537f6f8023dd8ff8155375f60":{"kind":"REWORK","_number":2,"created":"2015-12-27 12:04:11.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/25/261825/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/25/261825/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/25/261825/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/25/261825/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/25/261825/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/25/261825/2"}}},"commit":{"parents":[{"commit":"8210ba7a557a44c322ff3adddcbc98072a978e11","subject":"Replace assertEqual(None, *) with assertIsNone(*)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8210ba7a557a44c322ff3adddcbc98072a978e11"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-28 09:28:04.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-28 09:28:04.000000000","tz":480},"subject":"Refactor: Initialize parser in setUp() in TestKeyValueAction","message":"Refactor: Initialize parser in setUp() in TestKeyValueAction\n\nNo need to initialize parser in each test case. Do it in setUp().\nAlso remove the test_default_values case because it could be tested\nin the test_good_values case.\n\nChange-Id: Ia2ed7c9e46bf6baabbd62b9d50511c5e8103e5e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f0a3b175a1a7a8d537f6f8023dd8ff8155375f60"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f0a3b175a1a7a8d537f6f8023dd8ff8155375f60"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
