)]}'
{"id":"openstack%2Fpython-openstackclient~261877","triplet_id":"openstack%2Fpython-openstackclient~master~Ic1f63480c806bf7bcc9f541fc806eed297ddf718","project":"openstack/python-openstackclient","branch":"master","topic":"trivial","hashtags":[],"change_id":"Ic1f63480c806bf7bcc9f541fc806eed297ddf718","subject":"Trivial: Remove useless string_to_bool()","status":"MERGED","created":"2015-12-28 02:56:07.000000000","updated":"2016-01-08 06:23:32.000000000","submitted":"2016-01-08 06:23:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f14d3ad4c2ff471cc20d0031d07eda15fd1866dc","_number":261877,"virtual_id_number":261877,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-01-08 06:23:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-01-08 05:13:01.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-04 20:23:05.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":1,"date":"2016-01-04 13:35:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2016-01-08 05:13:01.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-04 13:35:53.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-01-04 20:23:05.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2016-01-08 05:13:01.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-01-08 06:23:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"effa934149764a25941e9fce24e41f1aa41d422a","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-28 02:56:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fd54bfe900425f1646ec840e9dd4d66cb92c7953","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2015-12-28 02:56:50.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"ec35b5e0a6b4ac5db2f1ba9acb98b2273ed1a5a9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-28 03:56:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/77/261877/2/check/gate-python-openstackclient-pep8/a437074/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/77/261877/2/check/gate-python-openstackclient-docs/6e8442e//doc/build/html/ : SUCCESS in 2m 12s\n- gate-python-openstackclient-python27 http://logs.openstack.org/77/261877/2/check/gate-python-openstackclient-python27/21cd54a/ : SUCCESS in 1m 38s\n- gate-python-openstackclient-python34 http://logs.openstack.org/77/261877/2/check/gate-python-openstackclient-python34/a4e97ea/ : SUCCESS in 1m 50s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/77/261877/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/1b5a462/ : SUCCESS in 59m 17s\n- gate-osc-dsvm-functional http://logs.openstack.org/77/261877/2/check/gate-osc-dsvm-functional/6f3a5dd/ : SUCCESS in 24m 26s","accounts_in_message":[],"_revision_number":2},{"id":"18bfb06d37c662df891fdf2ccbe230b18d5cc416","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-01-04 13:35:53.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d1fdbf95d1c82b34fa66b8f174b7849a671581e6","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2016-01-04 20:23:05.000000000","message":"Patch Set 2: Code-Review+2\n\nthis is similar to bool_from_string() in oslo_utils. we should remove this. thanks","accounts_in_message":[],"_revision_number":2},{"id":"f3ada3bb6f06348578964138651c68d55dc4dfbf","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-01-08 05:12:43.000000000","message":"Patch Set 2:\n\ncheck experimental","accounts_in_message":[],"_revision_number":2},{"id":"da8473089da7ded825c18e981f60b56790b41e88","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-01-08 05:13:01.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"3e814dc3f06c7ddd924a65b316a1230bd9fd1d59","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 05:14:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"cf17d8a6df91d716fb55ed4f837a7fe79ff3ba03","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 05:22:15.000000000","message":"Patch Set 2:\n\nBuild succeeded (experimental pipeline).\n\n- check-osc-plugins http://logs.openstack.org/77/261877/2/experimental/check-osc-plugins/ba8e494/ : SUCCESS in 1m 11s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d9c9171b91f1b3df38e76e18a6a9129bf1cedc70","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 06:23:31.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/77/261877/2/gate/gate-python-openstackclient-docs/07b6548//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/77/261877/2/gate/gate-python-openstackclient-pep8/8302084/ : SUCCESS in 1m 16s\n- gate-python-openstackclient-python27 http://logs.openstack.org/77/261877/2/gate/gate-python-openstackclient-python27/7b6540b/ : SUCCESS in 1m 41s\n- gate-python-openstackclient-python34 http://logs.openstack.org/77/261877/2/gate/gate-python-openstackclient-python34/20c52c8/ : SUCCESS in 2m 16s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/77/261877/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/d1eeb1a/ : SUCCESS in 1h 03m 21s\n- gate-osc-dsvm-functional http://logs.openstack.org/77/261877/2/gate/gate-osc-dsvm-functional/996ee66/ : SUCCESS in 30m 40s","accounts_in_message":[],"_revision_number":2},{"id":"434749887db0af86b079254a853b2646afbbcf55","date":"2016-01-08 06:23:32.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5f0147ad12b83c01b2a098a99239b574729b99f0","revisions":{"55838629189b3d179b35b308e0c8d54fd0728f96":{"kind":"REWORK","_number":1,"created":"2015-12-28 02:56:07.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/77/261877/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/77/261877/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/261877/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/261877/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/261877/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/77/261877/1"}}},"commit":{"parents":[{"commit":"8d718e9d6796b0ff115698a19f330113a80d09ef","subject":"Refactor: Initialize parser in setUp() in TestNonNegativeAction","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8d718e9d6796b0ff115698a19f330113a80d09ef"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-29 02:50:44.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-29 02:50:44.000000000","tz":480},"subject":"Trivial: Remove useless","message":"Trivial: Remove useless\n\nstring_to_bool() is not used by anyone.\nFurthermore, it is not well designed. It tries to convirt \u0027t\u0027, \u00271\u0027\nto True, which could be confused.\n\nSo remove it. If we need something similar, let\u0027s make a better one.\n\nChange-Id: Ic1f63480c806bf7bcc9f541fc806eed297ddf718\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/55838629189b3d179b35b308e0c8d54fd0728f96"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/55838629189b3d179b35b308e0c8d54fd0728f96"}]},"branch":"refs/heads/master"},"5f0147ad12b83c01b2a098a99239b574729b99f0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-12-28 02:56:50.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/77/261877/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/77/261877/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/261877/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/261877/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/261877/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/77/261877/2"}}},"commit":{"parents":[{"commit":"8d718e9d6796b0ff115698a19f330113a80d09ef","subject":"Refactor: Initialize parser in setUp() in TestNonNegativeAction","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8d718e9d6796b0ff115698a19f330113a80d09ef"}]}],"author":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-29 02:50:44.000000000","tz":480},"committer":{"name":"Tang Chen","email":"tangchen@cn.fujitsu.com","date":"2015-12-29 02:50:44.000000000","tz":480},"subject":"Trivial: Remove useless string_to_bool()","message":"Trivial: Remove useless string_to_bool()\n\nstring_to_bool() is not used by anyone.\nFurthermore, it is not well designed. It tries to convirt \u0027t\u0027, \u00271\u0027\nto True, which could be confused.\n\nSo remove it. If we need something similar, let\u0027s make a better one.\n\nChange-Id: Ic1f63480c806bf7bcc9f541fc806eed297ddf718\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5f0147ad12b83c01b2a098a99239b574729b99f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5f0147ad12b83c01b2a098a99239b574729b99f0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}