)]}'
{"openstackclient/compute/v2/security_group.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"07dfc07406828a73b74a198779090a49150ce6b3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"def _xform_and_trim_security_group_rule(sgroup):"},{"line_number":66,"context_line":"    info \u003d _xform_security_group_rule(sgroup)"},{"line_number":67,"context_line":"    # Trim parent security group ID since caller has this information."},{"line_number":68,"context_line":"    info.pop(\u0027parent_group_id\u0027)"},{"line_number":69,"context_line":"    # Trim keys with empty string values."},{"line_number":70,"context_line":"    keys_to_trim \u003d ["},{"line_number":71,"context_line":"        \u0027ip_protocol\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_5e6583b2","line":68,"range":{"start_line":68,"start_character":9,"end_line":68,"end_character":31},"updated":"2016-01-05 22:17:46.000000000","message":"you could make this fail proof by doing .pop(key, None), and on the odd chance the key is not there, then the code still flows and the user doesn\u0027t get a syntax/runtime error","commit_id":"70826817f8bc15ff908d55c28a334c86179bd819"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3f26e3c54850225f39c24e221df1744056e48d6e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"def _xform_and_trim_security_group_rule(sgroup):"},{"line_number":66,"context_line":"    info \u003d _xform_security_group_rule(sgroup)"},{"line_number":67,"context_line":"    # Trim parent security group ID since caller has this information."},{"line_number":68,"context_line":"    info.pop(\u0027parent_group_id\u0027)"},{"line_number":69,"context_line":"    # Trim keys with empty string values."},{"line_number":70,"context_line":"    keys_to_trim \u003d ["},{"line_number":71,"context_line":"        \u0027ip_protocol\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_ffc21584","line":68,"range":{"start_line":68,"start_character":9,"end_line":68,"end_character":31},"in_reply_to":"fa69d971_5e6583b2","updated":"2016-01-06 14:22:42.000000000","message":"Done","commit_id":"70826817f8bc15ff908d55c28a334c86179bd819"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"07dfc07406828a73b74a198779090a49150ce6b3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \u0027remote_security_group\u0027,"},{"line_number":75,"context_line":"    ]"},{"line_number":76,"context_line":"    for key in keys_to_trim:"},{"line_number":77,"context_line":"        if not info[key]:"},{"line_number":78,"context_line":"            info.pop(key)"},{"line_number":79,"context_line":"    return info"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_5e0ca3ec","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":25},"updated":"2016-01-05 22:17:46.000000000","message":"again here, you could check:\n\n  if key in info and not info[key]:\n\nto reduce runtime errors if the key is not present","commit_id":"70826817f8bc15ff908d55c28a334c86179bd819"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3f26e3c54850225f39c24e221df1744056e48d6e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \u0027remote_security_group\u0027,"},{"line_number":75,"context_line":"    ]"},{"line_number":76,"context_line":"    for key in keys_to_trim:"},{"line_number":77,"context_line":"        if not info[key]:"},{"line_number":78,"context_line":"            info.pop(key)"},{"line_number":79,"context_line":"    return info"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_bfb81d12","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":25},"in_reply_to":"fa69d971_5e0ca3ec","updated":"2016-01-06 14:22:42.000000000","message":"Done","commit_id":"70826817f8bc15ff908d55c28a334c86179bd819"}]}