)]}'
{"functional/tests/common/test_availability_zone.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"62b35a54d00482675468224fe0004555e8d4163a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        # not counting the header."},{"line_number":25,"context_line":"        output_list \u003d raw_output.split(\u0027\\n\u0027)"},{"line_number":26,"context_line":"        self.assertGreater(len(output_list), 1)"},{"line_number":27,"context_line":"        self.assertTrue(output_list[1])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_50161056","line":27,"range":{"start_line":27,"start_character":13,"end_line":27,"end_character":23},"updated":"2016-01-13 18:12:42.000000000","message":"assert true here? its list output, how about assertIsNotNone?","commit_id":"44e8ff4cdb15cdf342bd34d5d5dce1e4c75688b3"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8b2f085f1add39f870291a801f919766d8d8fcca","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        # not counting the header."},{"line_number":25,"context_line":"        output_list \u003d raw_output.split(\u0027\\n\u0027)"},{"line_number":26,"context_line":"        self.assertGreater(len(output_list), 1)"},{"line_number":27,"context_line":"        self.assertTrue(output_list[1])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_da69babf","line":27,"range":{"start_line":27,"start_character":13,"end_line":27,"end_character":23},"in_reply_to":"da6ed579_50161056","updated":"2016-01-13 18:59:13.000000000","message":"I tried assertIsNotNone originally but that would pass when output_list[1] was an empty string.  assertTrue will ensure that the availability zone name is not an empty string.","commit_id":"44e8ff4cdb15cdf342bd34d5d5dce1e4c75688b3"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3e1313bfbd9685e7c46ff3424cab7a9592d82e65","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        # not counting the header."},{"line_number":25,"context_line":"        output_list \u003d raw_output.split(\u0027\\n\u0027)"},{"line_number":26,"context_line":"        self.assertGreater(len(output_list), 1)"},{"line_number":27,"context_line":"        self.assertTrue(output_list[1])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_421fe16b","line":27,"in_reply_to":"da6ed579_690c53ed","updated":"2016-01-14 17:43:23.000000000","message":"I agree this is confusing.  It is probably best to check for sane output instead of not empty.  Compute, volume and network all use the same default availability zone name of \u0027nova\u0027.  I update the patch set to check for the name.","commit_id":"44e8ff4cdb15cdf342bd34d5d5dce1e4c75688b3"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c29391abcea3ed6c56b442ddebdbaad782763732","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        # not counting the header."},{"line_number":25,"context_line":"        output_list \u003d raw_output.split(\u0027\\n\u0027)"},{"line_number":26,"context_line":"        self.assertGreater(len(output_list), 1)"},{"line_number":27,"context_line":"        self.assertTrue(output_list[1])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_690c53ed","line":27,"in_reply_to":"da6ed579_da69babf","updated":"2016-01-14 15:35:57.000000000","message":"A comment to the effect of why assertTrue is used here will be appreciated down the road.  Should it actually check for sane output though and not just not-empty?","commit_id":"44e8ff4cdb15cdf342bd34d5d5dce1e4c75688b3"}]}