)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a46e0fe2f6a5f0f457d45171107021ed69232aac","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug:#1535213"},{"line_number":13,"context_line":"Change-Id: I5bc1c7e81b8ba61c37f4bfd209fc86c5857fb050"},{"line_number":14,"context_line":"Co-Authored-By: Huanxuan Ao \u003chuanxuan.ao@easystack.cn\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bacf61ea_41b471d0","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":53},"updated":"2016-08-03 04:24:07.000000000","message":"thanks for adding yourself +1","commit_id":"20ae54045cef136a8d0665aab0d45698e12ed21c"}],"doc/source/command-objects/volume.rst":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e14aa2ab669d6399da2a83bf6f6574042806b306","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    Property to add or modify for this volume (repeat option to set multiple properties)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":".. option:: --state \u003cstate\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    Set volume state"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da6ed579_a56c1009","line":186,"updated":"2016-01-18 17:23:39.000000000","message":"This needs to be marked as a v2 only option\n\nAlso, should we give any indication on what a valid state is/looks like?","commit_id":"70b8edb071f814f4a7c5d28d3165dafb9258c86e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4637444053bfcb70d018c4fcab642d8954dadc56","unresolved":false,"context_lines":[{"line_number":186,"context_line":".. option:: --state \u003cstate\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    Set volume state."},{"line_number":189,"context_line":"    Valid values are \"available\", \"error\", \"creating\", \"deleting\", "},{"line_number":190,"context_line":"    \"in-use\", \"attaching\", \"detaching\", \"error_deleting\" and \"maintenance\"."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    *Volume version 2 only*"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a68dd71_407aaf78","line":189,"updated":"2016-01-22 14:02:13.000000000","message":"nit...trailing blank space","commit_id":"edbda9ec9007097455e90e4d46c1f00bc632a8e7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2f802e16f139c2c4bc3dd482e2fdfe0500afb983","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":".. option:: --state \u003cstate\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    Set volume state."},{"line_number":189,"context_line":"    Valid values are \"available\", \"error\", \"creating\", \"deleting\","},{"line_number":190,"context_line":"    \"in-use\", \"attaching\", \"detaching\", \"error_deleting\" and \"maintenance\"."},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"bae84128_055b5b2f","line":188,"range":{"start_line":188,"start_character":4,"end_line":188,"end_character":21},"updated":"2016-02-22 05:57:42.000000000","message":"to be consistent, this should be: \"New volume state\"","commit_id":"9a5e153a56d66be37e5055a5292aac2d7c15841b"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"60fa6f1cd7057fd70a4b22eec4217007863bf237","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":".. option:: --state \u003cstate\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    Set volume state."},{"line_number":189,"context_line":"    Valid values are \"available\", \"error\", \"creating\", \"deleting\","},{"line_number":190,"context_line":"    \"in-use\", \"attaching\", \"detaching\", \"error_deleting\" and \"maintenance\"."},{"line_number":191,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_eed8f4f1","line":188,"range":{"start_line":188,"start_character":4,"end_line":188,"end_character":21},"in_reply_to":"bae84128_055b5b2f","updated":"2016-03-08 03:49:39.000000000","message":"Done","commit_id":"9a5e153a56d66be37e5055a5292aac2d7c15841b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2f802e16f139c2c4bc3dd482e2fdfe0500afb983","unresolved":false,"context_lines":[{"line_number":186,"context_line":".. option:: --state \u003cstate\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    Set volume state."},{"line_number":189,"context_line":"    Valid values are \"available\", \"error\", \"creating\", \"deleting\","},{"line_number":190,"context_line":"    \"in-use\", \"attaching\", \"detaching\", \"error_deleting\" and \"maintenance\"."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    *Volume version 2 only*"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"bae84128_256f7fc6","line":190,"range":{"start_line":189,"start_character":4,"end_line":190,"end_character":75},"updated":"2016-02-22 05:57:42.000000000","message":"We should try to include this in the actual help output too.","commit_id":"9a5e153a56d66be37e5055a5292aac2d7c15841b"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"60fa6f1cd7057fd70a4b22eec4217007863bf237","unresolved":false,"context_lines":[{"line_number":186,"context_line":".. option:: --state \u003cstate\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    Set volume state."},{"line_number":189,"context_line":"    Valid values are \"available\", \"error\", \"creating\", \"deleting\","},{"line_number":190,"context_line":"    \"in-use\", \"attaching\", \"detaching\", \"error_deleting\" and \"maintenance\"."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    *Volume version 2 only*"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_2ee3fca4","line":190,"range":{"start_line":189,"start_character":4,"end_line":190,"end_character":75},"in_reply_to":"bae84128_256f7fc6","updated":"2016-03-08 03:49:39.000000000","message":"Done","commit_id":"9a5e153a56d66be37e5055a5292aac2d7c15841b"}],"openstackclient/tests/volume/v2/test_volume.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2f802e16f139c2c4bc3dd482e2fdfe0500afb983","unresolved":false,"context_lines":[{"line_number":752,"context_line":"        self.assertEqual(volume_fakes.VOLUME_data, data)"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"class TestVolumeSet(TestVolume):"},{"line_number":756,"context_line":"    def setUp(self):"},{"line_number":757,"context_line":"        super(TestVolumeSet, self).setUp()"},{"line_number":758,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_050d1b37","line":755,"range":{"start_line":755,"start_character":0,"end_line":755,"end_character":32},"updated":"2016-02-22 05:57:42.000000000","message":"nit: alphabetically, Set comes before Show.","commit_id":"9a5e153a56d66be37e5055a5292aac2d7c15841b"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"60fa6f1cd7057fd70a4b22eec4217007863bf237","unresolved":false,"context_lines":[{"line_number":752,"context_line":"        self.assertEqual(volume_fakes.VOLUME_data, data)"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"class TestVolumeSet(TestVolume):"},{"line_number":756,"context_line":"    def setUp(self):"},{"line_number":757,"context_line":"        super(TestVolumeSet, self).setUp()"},{"line_number":758,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_eece3459","line":755,"range":{"start_line":755,"start_character":0,"end_line":755,"end_character":32},"in_reply_to":"bae84128_050d1b37","updated":"2016-03-08 03:49:39.000000000","message":"Done","commit_id":"9a5e153a56d66be37e5055a5292aac2d7c15841b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"d8d82da95fe19a2e88f0ab95d942831f9c731f55","unresolved":false,"context_lines":[{"line_number":742,"context_line":"    def test_volume_set_state_to_error(self):"},{"line_number":743,"context_line":"        arglist \u003d ["},{"line_number":744,"context_line":"            volume_fakes.volume_id,"},{"line_number":745,"context_line":"            \u0027--state\u0027, \u0027error\u0027"},{"line_number":746,"context_line":"        ]"},{"line_number":747,"context_line":"        verifylist \u003d ["},{"line_number":748,"context_line":"            (\u0027volume\u0027, volume_fakes.volume_id),"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_f79f1201","line":745,"updated":"2016-03-08 15:01:58.000000000","message":"options should be before positional arguments","commit_id":"7dff8574cefe63c014fc1b8ca139f9343f49e699"}],"openstackclient/volume/v2/volume.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2f802e16f139c2c4bc3dd482e2fdfe0500afb983","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        parser.add_argument("},{"line_number":349,"context_line":"            \"--state\","},{"line_number":350,"context_line":"            metavar\u003d\"\u003cstate\u003e\","},{"line_number":351,"context_line":"            help\u003d\"Set volume state to \u003cstate\u003e\""},{"line_number":352,"context_line":"        )"},{"line_number":353,"context_line":"        return parser"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_a5354fdb","line":351,"range":{"start_line":351,"start_character":18,"end_line":351,"end_character":45},"updated":"2016-02-22 05:57:42.000000000","message":"we try to make this text match the text from the rst file. So, include the different states that are available.\n\nHow about `New volume state. Valid values are \"available\", \"error\", \"creating\", \"deleting\", \"in-use\", \"attaching\", \"detaching\", \"error_deleting\" and \"maintenance\".`","commit_id":"9a5e153a56d66be37e5055a5292aac2d7c15841b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9cb06b319cda47e4ce20e9164d7a7b2319785e7d","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        parser.add_argument("},{"line_number":349,"context_line":"            \"--state\","},{"line_number":350,"context_line":"            metavar\u003d\"\u003cstate\u003e\","},{"line_number":351,"context_line":"            help\u003d\"Set volume state to \u003cstate\u003e\""},{"line_number":352,"context_line":"        )"},{"line_number":353,"context_line":"        return parser"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_c50853dc","line":351,"range":{"start_line":351,"start_character":18,"end_line":351,"end_character":45},"in_reply_to":"bae84128_a5354fdb","updated":"2016-02-22 06:06:23.000000000","message":"+1","commit_id":"9a5e153a56d66be37e5055a5292aac2d7c15841b"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"60fa6f1cd7057fd70a4b22eec4217007863bf237","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        parser.add_argument("},{"line_number":349,"context_line":"            \"--state\","},{"line_number":350,"context_line":"            metavar\u003d\"\u003cstate\u003e\","},{"line_number":351,"context_line":"            help\u003d\"Set volume state to \u003cstate\u003e\""},{"line_number":352,"context_line":"        )"},{"line_number":353,"context_line":"        return parser"},{"line_number":354,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_4ec5a83a","line":351,"range":{"start_line":351,"start_character":18,"end_line":351,"end_character":45},"in_reply_to":"bae84128_c50853dc","updated":"2016-03-08 03:49:39.000000000","message":"Done","commit_id":"9a5e153a56d66be37e5055a5292aac2d7c15841b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9cb06b319cda47e4ce20e9164d7a7b2319785e7d","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        if kwargs:"},{"line_number":382,"context_line":"            volume_client.volumes.update(volume.id, **kwargs)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        if (not kwargs and not parsed_args.property and not parsed_args.size"},{"line_number":385,"context_line":"                and not parsed_args.state):"},{"line_number":386,"context_line":"            self.app.log.error(\"No changes requested\\n\")"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bae84128_451c4313","line":384,"updated":"2016-02-22 06:06:23.000000000","message":"Does this line mean that we cannot update only the NAME or the DESC of the volume?\nIf so, that may not be correct, isnt it?","commit_id":"9a5e153a56d66be37e5055a5292aac2d7c15841b"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"60fa6f1cd7057fd70a4b22eec4217007863bf237","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        if kwargs:"},{"line_number":382,"context_line":"            volume_client.volumes.update(volume.id, **kwargs)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        if (not kwargs and not parsed_args.property and not parsed_args.size"},{"line_number":385,"context_line":"                and not parsed_args.state):"},{"line_number":386,"context_line":"            self.app.log.error(\"No changes requested\\n\")"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_eec75443","line":384,"in_reply_to":"bae84128_451c4313","updated":"2016-03-08 03:49:39.000000000","message":"If we want to update only NAME or DESC, the new value is put into kwargs. So if kwargs is not empty, this check will not pass.","commit_id":"9a5e153a56d66be37e5055a5292aac2d7c15841b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"d8d82da95fe19a2e88f0ab95d942831f9c731f55","unresolved":false,"context_lines":[{"line_number":351,"context_line":"            choices\u003d[\u0027available\u0027, \u0027error\u0027, \u0027creating\u0027, \u0027deleting\u0027,"},{"line_number":352,"context_line":"                     \u0027in-use\u0027, \u0027attaching\u0027, \u0027detaching\u0027, \u0027error_deleting\u0027,"},{"line_number":353,"context_line":"                     \u0027maintenance\u0027],"},{"line_number":354,"context_line":"            help\u003d\u0027Set volume state to \u003cstate\u003e. Valid values are: available, \u0027"},{"line_number":355,"context_line":"                 \u0027error, creating, deleting, in-use, attaching, detaching, \u0027"},{"line_number":356,"context_line":"                 \u0027error_deleting, maintenance.\u0027,"},{"line_number":357,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_f7b6f288","line":354,"updated":"2016-03-08 15:01:58.000000000","message":"This doesn\u0027t match the documentation.","commit_id":"7dff8574cefe63c014fc1b8ca139f9343f49e699"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"c825e2820ba942e63aebab68c7e14050f456b54d","unresolved":false,"context_lines":[{"line_number":351,"context_line":"            choices\u003d[\u0027available\u0027, \u0027error\u0027, \u0027creating\u0027, \u0027deleting\u0027,"},{"line_number":352,"context_line":"                     \u0027in-use\u0027, \u0027attaching\u0027, \u0027detaching\u0027, \u0027error_deleting\u0027,"},{"line_number":353,"context_line":"                     \u0027maintenance\u0027],"},{"line_number":354,"context_line":"            help\u003d\u0027New volume state. Valid values are available, error, \u0027"},{"line_number":355,"context_line":"                 \u0027creating, deleting, in-use, attaching, detaching, \u0027"},{"line_number":356,"context_line":"                 \u0027error_deleting, maintenance.\u0027,"},{"line_number":357,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_8aa8e1dc","line":354,"updated":"2016-03-09 14:26:45.000000000","message":"Doc uses quotes around the values.","commit_id":"87e5ccc9018d699db40e016d054395761574d674"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a46e0fe2f6a5f0f457d45171107021ed69232aac","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            choices\u003d[\u0027available\u0027, \u0027error\u0027, \u0027creating\u0027, \u0027deleting\u0027,"},{"line_number":385,"context_line":"                     \u0027in-use\u0027, \u0027attaching\u0027, \u0027detaching\u0027, \u0027error_deleting\u0027,"},{"line_number":386,"context_line":"                     \u0027maintenance\u0027],"},{"line_number":387,"context_line":"            help\u003d_(\u0027New volume state (\"available\", \"error\", \"creating\", \u0027"},{"line_number":388,"context_line":"                   \u0027\"deleting\", \"in-use\", \"attaching\", \"detaching\", \u0027"},{"line_number":389,"context_line":"                   \u0027\"error_deleting\" or \"maintenance\")\u0027),"},{"line_number":390,"context_line":"        )"},{"line_number":391,"context_line":"        return parser"},{"line_number":392,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_21b5fdcf","line":389,"range":{"start_line":387,"start_character":20,"end_line":389,"end_character":57},"updated":"2016-08-03 04:24:07.000000000","message":"matches the docs: http://docs.openstack.org/developer/python-openstackclient/command-options.html#id1","commit_id":"20ae54045cef136a8d0665aab0d45698e12ed21c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2e841dce7ed65b26787a7fe18c4d62ab003b3f56","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            volume_client.volumes.set_image_metadata("},{"line_number":412,"context_line":"                volume.id, parsed_args.image_property)"},{"line_number":413,"context_line":"        if parsed_args.state:"},{"line_number":414,"context_line":"            volume_client.volumes.reset_state(volume.id, parsed_args.state)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        kwargs \u003d {}"},{"line_number":417,"context_line":"        if parsed_args.name:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_04ece3f1","line":414,"updated":"2016-08-04 16:49:44.000000000","message":"The command should be updated to handle multiple REST API calls per http://docs.openstack.org/developer/python-openstackclient/command-errors.html.  But I am okay with a separate patch.","commit_id":"20ae54045cef136a8d0665aab0d45698e12ed21c"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"624070acb076d9e6d6d1c38567455e9fa6812ee0","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            volume_client.volumes.set_image_metadata("},{"line_number":412,"context_line":"                volume.id, parsed_args.image_property)"},{"line_number":413,"context_line":"        if parsed_args.state:"},{"line_number":414,"context_line":"            volume_client.volumes.reset_state(volume.id, parsed_args.state)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        kwargs \u003d {}"},{"line_number":417,"context_line":"        if parsed_args.name:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_7b49d530","line":414,"in_reply_to":"bacf61ea_04ece3f1","updated":"2016-08-05 11:12:01.000000000","message":"Hi, Richard, I have committed a new patch for this:\nhttps://review.openstack.org/#/c/351662/1","commit_id":"20ae54045cef136a8d0665aab0d45698e12ed21c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"63c878276e7010feadc47a6db454681dc70af7de","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            volume_client.volumes.set_image_metadata("},{"line_number":412,"context_line":"                volume.id, parsed_args.image_property)"},{"line_number":413,"context_line":"        if parsed_args.state:"},{"line_number":414,"context_line":"            volume_client.volumes.reset_state(volume.id, parsed_args.state)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        kwargs \u003d {}"},{"line_number":417,"context_line":"        if parsed_args.name:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_cde2c89f","line":414,"in_reply_to":"bacf61ea_7b49d530","updated":"2016-08-05 11:37:15.000000000","message":"Thank you very much.","commit_id":"20ae54045cef136a8d0665aab0d45698e12ed21c"}]}