)]}'
{"id":"openstack%2Fpython-openstackclient~269596","triplet_id":"openstack%2Fpython-openstackclient~master~I502ef078d5fb6fa0e37a17287d4910380e067e0a","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1535704","hashtags":[],"change_id":"I502ef078d5fb6fa0e37a17287d4910380e067e0a","subject":"Support setting volume bootable flag","status":"ABANDONED","created":"2016-01-19 12:35:41.000000000","updated":"2017-08-24 19:20:41.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"eeee09c38bd10d6f8212f6d0e5fe95b849eb00dd","_number":269596,"virtual_id_number":269596,"owner":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":-1,"date":"2016-02-03 06:56:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-01-20 07:28:02.000000000","_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":-1,"date":"2016-08-02 00:11:18.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},{"value":-1,"date":"2016-01-19 16:08:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-19 16:08:48.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-02-03 06:56:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-08-02 00:11:18.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"}],"messages":[{"id":"4c9286e54debf01285e390e58ac66d99d1e0faf3","author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"date":"2016-01-19 12:35:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6c80dbefecc1564983f4b041da60e25b5cba90fe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-19 14:40:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/96/269596/1/check/gate-python-openstackclient-pep8/ee9c6ec/ : SUCCESS in 1m 26s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/96/269596/1/check/gate-python-openstackclient-docs/25442e3//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-openstackclient-python27 http://logs.openstack.org/96/269596/1/check/gate-python-openstackclient-python27/8fcbc6a/ : SUCCESS in 1m 28s\n- gate-python-openstackclient-python34 http://logs.openstack.org/96/269596/1/check/gate-python-openstackclient-python34/08d4b4e/ : SUCCESS in 2m 31s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/96/269596/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/a6e2108/ : SUCCESS in 1h 48m 04s\n- check-osc-plugins http://logs.openstack.org/96/269596/1/check/check-osc-plugins/d355bb0/ : SUCCESS in 2m 10s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/96/269596/1/check/gate-osc-dsvm-functional/8cfa41e/ : SUCCESS in 31m 19s","accounts_in_message":[],"_revision_number":1},{"id":"9fb9292206b2e07d2adf70130448b54d2ce2d88b","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-01-19 16:08:48.000000000","message":"Patch Set 1: Code-Review-1\n\nWe do not do boolean arguments like this.  You need to have a pair of booleans that represent each state, such as --bootable and --not-bootable.  Look at how --enable|--disable are implemented in other commands (such as user create) for an example.","accounts_in_message":[],"_revision_number":1},{"id":"8ede8bfe9080d33db1a29e92291d3a335311c1ff","author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"date":"2016-01-20 07:28:02.000000000","message":"Patch Set 1:\n\n@Dean\nThis is not a boolean type. Just a string of \"True\" or \"False\".","accounts_in_message":[],"_revision_number":1},{"id":"23a1f48244f773364cc507bf72dc4d4e2298f37e","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-01-20 20:31:18.000000000","message":"Patch Set 1:\n\nRepresenting a value of True or False _is_ a boolean, represented in string form.  The point is that you have an option that can only have a value of True or False.  This is not how we handle those in OSC.","accounts_in_message":[],"_revision_number":1},{"id":"c94c7b57d1c4b5ad458c956d9200db147251fa70","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-03 06:56:22.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"bf9919229cba2f04f1e545a3d76f3f816c6daa5a","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-08-02 00:11:18.000000000","message":"Patch Set 1: Code-Review-1\n\nlet\u0027s treat this the same way we do all booleans, as CLI flags.\n\n  $ osc volume create --bootable\n\nwill be saved in parsed_args.bootable, and will default to false, let\u0027s just pass that into the client call","accounts_in_message":[],"_revision_number":1},{"id":"3802a7086c1794c8715d281d55252e8e9c4d147e","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-08-24 19:20:41.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3c96c4826e7c0ec014bbb7bc7d5bab10ce42c441","revisions":{"3c96c4826e7c0ec014bbb7bc7d5bab10ce42c441":{"kind":"REWORK","_number":1,"created":"2016-01-19 12:35:41.000000000","uploader":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"ref":"refs/changes/96/269596/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/96/269596/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/96/269596/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/96/269596/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/96/269596/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/96/269596/1"}}},"commit":{"parents":[{"commit":"86fcd67468708a1edd23f3ff6eb852b43bc618bd","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/86fcd67468708a1edd23f3ff6eb852b43bc618bd"}]}],"author":{"name":"Xi Yang","email":"yang.xi@99cloud.net","date":"2016-01-19 12:08:42.000000000","tz":480},"committer":{"name":"Xi Yang","email":"yang.xi@99cloud.net","date":"2016-01-19 12:34:51.000000000","tz":480},"subject":"Support setting volume bootable flag","message":"Support setting volume bootable flag\n\nAdd the functionality of setting volume bootable\nflag which indicates whether user can boot a VM\nfrom the volume.\n\nCloses-Bug:#1535704\nChange-Id: I502ef078d5fb6fa0e37a17287d4910380e067e0a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3c96c4826e7c0ec014bbb7bc7d5bab10ce42c441"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3c96c4826e7c0ec014bbb7bc7d5bab10ce42c441"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}