)]}'
{"id":"openstack%2Fpython-openstackclient~272840","triplet_id":"openstack%2Fpython-openstackclient~master~Ib44c49dc1739ce7d881432e482dd16f8928eef49","project":"openstack/python-openstackclient","branch":"master","topic":"bp/neutron-client","hashtags":[],"change_id":"Ib44c49dc1739ce7d881432e482dd16f8928eef49","subject":"Use correct terminology for subnets","status":"MERGED","created":"2016-01-26 23:45:21.000000000","updated":"2017-03-14 05:26:35.000000000","submitted":"2016-01-27 23:29:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"73d07666a3efe3c9b42a86964deb11bb35643389","_number":272840,"virtual_id_number":272840,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"date":"2017-03-14 05:26:35.000000000","post_submit":true,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-01-27 23:29:05.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"all":[{"value":2,"date":"2016-01-27 16:37:04.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":2,"date":"2016-01-27 22:33:56.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":1,"date":"2016-01-27 15:17:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":1,"date":"2016-01-27 22:33:56.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-27 01:47:44.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2016-01-27 15:17:22.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-01-27 16:37:04.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2016-01-27 22:33:56.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-01-27 23:29:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-03-14 05:26:35.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"}],"messages":[{"id":"413ed8e0399d14d8e9a5e2e63b0a348b7c256cbc","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-01-26 23:45:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a4bf2f83ce9773007318f1c3649c4a653d92c9f0","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2016-01-26 23:47:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"78bb77e800c7b2c9a4be1700ae3364922befd433","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2016-01-27 01:47:44.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"cc0b26d7e58351ce5d6c802fc35743cfb401dc51","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-27 02:07:55.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/40/272840/1/check/gate-python-openstackclient-pep8/ae85605/ : SUCCESS in 1m 21s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/40/272840/1/check/gate-python-openstackclient-docs/f46f896//doc/build/html/ : SUCCESS in 2m 43s\n- gate-python-openstackclient-python27 http://logs.openstack.org/40/272840/1/check/gate-python-openstackclient-python27/49a3418/ : FAILURE in 1m 41s\n- gate-python-openstackclient-python34 http://logs.openstack.org/40/272840/1/check/gate-python-openstackclient-python34/18f6683/ : FAILURE in 2m 07s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/40/272840/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/41855b7/ : SUCCESS in 1h 00m 01s\n- check-osc-plugins http://logs.openstack.org/40/272840/1/check/check-osc-plugins/98c5600/ : FAILURE in 1m 32s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/40/272840/1/check/gate-osc-dsvm-functional/0967168/ : SUCCESS in 36m 18s","accounts_in_message":[],"_revision_number":1},{"id":"421c827b08a91e82b3d8ca05d78c2f49823505be","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-01-27 05:51:49.000000000","message":"Patch Set 1: Code-Review-1\n\ngotta update the tests!","accounts_in_message":[],"_revision_number":1},{"id":"c5ebf89913a7ba268f19f8c6e81da6a16512bc44","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-01-27 13:38:43.000000000","message":"Patch Set 1:\n\nThanks Dean.  Looks good to me pending test updates.","accounts_in_message":[],"_revision_number":1},{"id":"08fc93b9f162738b746bfd4647013f9a19d0df83","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-01-27 15:14:22.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f10da1c860221bb56151779b23a155b3b0d53dd4","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-01-27 15:15:22.000000000","message":"Patch Set 2:\n\nAnd this my friends is why we have tests, and why checking in when in a hurry to get to dinner is a bad idea...","accounts_in_message":[],"_revision_number":2},{"id":"e3f9bc3e5383c617d2365460e3ea448fac001653","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-01-27 15:17:22.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"187a7a92622c7ca10446260ae4d05e5d7b4fa185","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-27 16:29:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/40/272840/2/check/gate-python-openstackclient-pep8/423bc44/ : SUCCESS in 1m 18s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/40/272840/2/check/gate-python-openstackclient-docs/45ef312//doc/build/html/ : SUCCESS in 2m 10s\n- gate-python-openstackclient-python27 http://logs.openstack.org/40/272840/2/check/gate-python-openstackclient-python27/406c66c/ : SUCCESS in 1m 33s\n- gate-python-openstackclient-python34 http://logs.openstack.org/40/272840/2/check/gate-python-openstackclient-python34/11f2abc/ : SUCCESS in 2m 43s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/40/272840/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/cab3a53/ : SUCCESS in 54m 38s\n- check-osc-plugins http://logs.openstack.org/40/272840/2/check/check-osc-plugins/89bb9c7/ : FAILURE in 1m 34s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/40/272840/2/check/gate-osc-dsvm-functional/c448a6f/ : SUCCESS in 23m 27s","accounts_in_message":[],"_revision_number":2},{"id":"42adefff68c1ebbc7004f9734d2e8d08eed881b0","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2016-01-27 16:37:04.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"39f6014f39529e3108826728624d1481e48e4675","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-01-27 22:33:56.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"49aa00784b8af2bf555a24308b6aa73f7a7a5293","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-27 22:34:03.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"92597279c13675b8d01e82f76e1e90ed8402548e","date":"2016-01-27 23:29:05.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"1544a31383d8cd0c4f4f3e70a316eabe9ad62f0d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-27 23:29:05.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/40/272840/2/gate/gate-python-openstackclient-docs/b65a4b6//doc/build/html/ : SUCCESS in 1m 58s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/40/272840/2/gate/gate-python-openstackclient-pep8/a078d87/ : SUCCESS in 1m 18s\n- gate-python-openstackclient-python27 http://logs.openstack.org/40/272840/2/gate/gate-python-openstackclient-python27/947ed19/ : SUCCESS in 1m 40s\n- gate-python-openstackclient-python34 http://logs.openstack.org/40/272840/2/gate/gate-python-openstackclient-python34/2b67241/ : SUCCESS in 2m 04s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/40/272840/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/0a0de3f/ : SUCCESS in 54m 51s\n- gate-osc-dsvm-functional http://logs.openstack.org/40/272840/2/gate/gate-osc-dsvm-functional/1cc3855/ : SUCCESS in 24m 19s","accounts_in_message":[],"_revision_number":2},{"id":"97e8008274f2d50b78938f4d201becd222b1255d","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2017-03-14 05:26:35.000000000","message":"Patch Set 2:\n\nIMHO , we are REALLY missing a release note here....","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"db458d7dec6b2cf712a14e54a76305258aedb700","revisions":{"abb646f1fa0079436e3c968698dcd188c195a23f":{"kind":"REWORK","_number":1,"created":"2016-01-26 23:45:21.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/40/272840/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/40/272840/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/40/272840/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/40/272840/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/40/272840/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/40/272840/1"}}},"commit":{"parents":[{"commit":"ffcfff6f3eda2cc9022b7924aa1d08739d63aaa1","subject":"Subnet List","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ffcfff6f3eda2cc9022b7924aa1d08739d63aaa1"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2016-01-26 23:42:41.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2016-01-26 23:42:49.000000000","tz":-360},"subject":"Use correct terminology for subnets","message":"Use correct terminology for subnets\n\nOpenStack uses \u0027CIDR\u0027 incorrectly in many places.  We are not going\nto perpetuate that usage.  The correct name here is simply \u0027subnet\u0027\nas the data is the network address for the subnet, in CIDR notation.\n\nAlso, some additional cleanups as suggested in comments to\nhttps://review.openstack.org/#/c/84782\n\nDepends-on: I3c0748074a6511ff92500516b3129886d2476eed\nChange-Id: Ib44c49dc1739ce7d881432e482dd16f8928eef49\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/abb646f1fa0079436e3c968698dcd188c195a23f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/abb646f1fa0079436e3c968698dcd188c195a23f"}]},"branch":"refs/heads/master"},"db458d7dec6b2cf712a14e54a76305258aedb700":{"kind":"REWORK","_number":2,"created":"2016-01-27 15:14:22.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/40/272840/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/40/272840/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/40/272840/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/40/272840/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/40/272840/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/40/272840/2"}}},"commit":{"parents":[{"commit":"ffcfff6f3eda2cc9022b7924aa1d08739d63aaa1","subject":"Subnet List","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ffcfff6f3eda2cc9022b7924aa1d08739d63aaa1"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2016-01-26 23:42:41.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2016-01-27 15:13:46.000000000","tz":-360},"subject":"Use correct terminology for subnets","message":"Use correct terminology for subnets\n\nOpenStack uses \u0027CIDR\u0027 incorrectly in many places.  We are not going\nto perpetuate that usage.  The correct name here is simply \u0027subnet\u0027\nas the data is the network address for the subnet, in CIDR notation.\n\nAlso, some additional cleanups as suggested in comments to\nhttps://review.openstack.org/#/c/84782\n\nDepends-on: I3c0748074a6511ff92500516b3129886d2476eed\nChange-Id: Ib44c49dc1739ce7d881432e482dd16f8928eef49\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/db458d7dec6b2cf712a14e54a76305258aedb700"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/db458d7dec6b2cf712a14e54a76305258aedb700"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}