)]}'
{"id":"openstack%2Fpython-openstackclient~273653","triplet_id":"openstack%2Fpython-openstackclient~master~Iab56cd1166028caed4f1e657e0b1ee81af3f48d8","project":"openstack/python-openstackclient","branch":"master","topic":"fix-wait-for-delete","hashtags":[],"change_id":"Iab56cd1166028caed4f1e657e0b1ee81af3f48d8","subject":"Allow wait_for_delete to work for all clients","status":"MERGED","created":"2016-01-28 16:57:47.000000000","updated":"2016-02-04 00:39:47.000000000","submitted":"2016-02-04 00:39:47.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4c0125db81503b4388700c8de185e0bdf586dc72","_number":273653,"virtual_id_number":273653,"owner":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-02-04 00:39:47.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11832,"name":"Bryan Jones","email":"jonesbr@us.ibm.com","username":"jonesbr"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-01-28 18:35:01.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-01-29 15:26:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11832,"name":"Bryan Jones","email":"jonesbr@us.ibm.com","username":"jonesbr"},{"value":1,"date":"2016-01-29 15:05:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":2,"date":"2016-02-03 21:39:21.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11832,"name":"Bryan Jones","email":"jonesbr@us.ibm.com","username":"jonesbr"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2016-02-03 21:39:21.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":11832,"name":"Bryan Jones","email":"jonesbr@us.ibm.com","username":"jonesbr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-28 18:35:01.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-01-29 15:05:33.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-01-29 15:26:26.000000000","updated_by":{"_account_id":11832,"name":"Bryan Jones","email":"jonesbr@us.ibm.com","username":"jonesbr"},"reviewer":{"_account_id":11832,"name":"Bryan Jones","email":"jonesbr@us.ibm.com","username":"jonesbr"},"state":"REVIEWER"},{"updated":"2016-02-03 21:39:21.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-02-04 00:39:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"966563facf456b90cd8fee2f2fa461f6343e7829","author":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"date":"2016-01-28 16:57:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1c8a81241777b55b813dd816997b9078bdbd06bd","author":{"_account_id":1112,"name":"Everett Toews","email":"everett.toews@rackspace.com","username":"everett-toews"},"date":"2016-01-28 17:05:25.000000000","message":"Patch Set 1:\n\nFWIW, we also have this function in the SDK [1]. Could that really be used here? \n\nI have no idea but I thought I\u0027d at least make you aware of it. \n\n[1] http://git.openstack.org/cgit/openstack/python-openstacksdk/tree/openstack/proxy.py#n284","accounts_in_message":[],"_revision_number":1},{"id":"7dc0ef79502cb85fbc20b402eead3cb18634ee67","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-01-28 18:06:17.000000000","message":"Patch Set 1:\n\nThanks Mark, this looks good so far.\n\nEverett, the SDK function is only usable on SDK resources, so at this point only OSC Network commands.  As we eliminate the project libs we will be able to stop parsing exception messages and do this properly...","accounts_in_message":[],"_revision_number":1},{"id":"f2e9aac646d919ca96116c48d3f06c00c9118dc2","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-01-28 18:35:01.000000000","message":"Patch Set 1: Code-Review+2\n\nthis seems completely fine to me","accounts_in_message":[],"_revision_number":1},{"id":"2859a528bfe466d8037f7b6a83f9e8e256c754d2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-28 20:14:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/53/273653/1/check/gate-python-openstackclient-pep8/6478f37/ : SUCCESS in 1m 32s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/53/273653/1/check/gate-python-openstackclient-docs/edb6ccf//doc/build/html/ : SUCCESS in 1m 57s\n- gate-python-openstackclient-python27 http://logs.openstack.org/53/273653/1/check/gate-python-openstackclient-python27/5a1fddb/ : SUCCESS in 1m 51s\n- gate-python-openstackclient-python34 http://logs.openstack.org/53/273653/1/check/gate-python-openstackclient-python34/396de94/ : SUCCESS in 2m 16s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/53/273653/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/fb72d59/ : SUCCESS in 59m 40s\n- check-osc-plugins http://logs.openstack.org/53/273653/1/check/check-osc-plugins/fb3c6a6/ : SUCCESS in 1m 49s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/53/273653/1/check/gate-osc-dsvm-functional/a5d5319/ : SUCCESS in 27m 58s","accounts_in_message":[],"_revision_number":1},{"id":"9253fdf022bb46dbb807775f64c7131ccc6a1fe3","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-01-29 15:05:33.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4e47ca168f57f42cc69b698c757ad78584b02e8a","author":{"_account_id":11832,"name":"Bryan Jones","email":"jonesbr@us.ibm.com","username":"jonesbr"},"date":"2016-01-29 15:26:26.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nJust a nit, otherwise LGTM","accounts_in_message":[],"_revision_number":1},{"id":"ba170b1351e74480b605f177dbfc82474681561c","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-02-03 21:39:21.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1fc5ae185f25169eb9c164475d7721a1d0ca53e6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-03 21:39:27.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"973db47ca85d754bf406ce5c3f732c323af40ee4","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-02-03 21:49:14.000000000","message":"Patch Set 1:\n\nI followed up Bryan\u0027s comment in https://review.openstack.org/275941 to change the self.assertFalse(mock_sleep.called) occurrances here.","accounts_in_message":[],"_revision_number":1},{"id":"1431ae5446e2043e2f8bf4d119903a41b6a4d371","date":"2016-02-04 00:39:47.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"5b98ffd6e8a82a028ae3d371b1b49af5e6f4b0e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-04 00:39:47.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/53/273653/1/gate/gate-python-openstackclient-docs/29204bf//doc/build/html/ : SUCCESS in 2m 30s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/53/273653/1/gate/gate-python-openstackclient-pep8/fb1e6df/ : SUCCESS in 1m 14s\n- gate-python-openstackclient-python27 http://logs.openstack.org/53/273653/1/gate/gate-python-openstackclient-python27/d72b149/ : SUCCESS in 2m 22s\n- gate-python-openstackclient-python34 http://logs.openstack.org/53/273653/1/gate/gate-python-openstackclient-python34/35018a6/ : SUCCESS in 2m 34s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/53/273653/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/a7a007d/ : SUCCESS in 1h 14m 10s\n- gate-osc-dsvm-functional http://logs.openstack.org/53/273653/1/gate/gate-osc-dsvm-functional/43ba521/ : SUCCESS in 32m 01s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5903ffff8a56481e124aa4fe8144c16348f6f8b9","revisions":{"5903ffff8a56481e124aa4fe8144c16348f6f8b9":{"kind":"REWORK","_number":1,"created":"2016-01-28 16:57:47.000000000","uploader":{"_account_id":7128,"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","username":"kramvan"},"ref":"refs/changes/53/273653/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/53/273653/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/53/273653/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/53/273653/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/53/273653/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/53/273653/1"}}},"commit":{"parents":[{"commit":"636b4de6df77923424f7cac62322b546d65a5269","subject":"Merge \"Remove the Tuskar client\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/636b4de6df77923424f7cac62322b546d65a5269"}]}],"author":{"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","date":"2016-01-28 16:52:45.000000000","tz":-360},"committer":{"name":"Mark Vanderwiel","email":"vanderwl@us.ibm.com","date":"2016-01-28 16:52:45.000000000","tz":-360},"subject":"Allow wait_for_delete to work for all clients","message":"Allow wait_for_delete to work for all clients\n\nAllow the exception and error status\nstrings to be passed in such that other plugins can\nmake use of this function.\n\nThere is a comment in find_resource:\n  The exception to catch here is dependent on which\n  client library the manager passed in belongs to.\n  Eventually this should be pulled from a common set\n  of client exceptions.\n\nSince I think that is a long ways off, this change will\nwork now and also work when a common exception is defined\nand used.\n\nChange-Id: Iab56cd1166028caed4f1e657e0b1ee81af3f48d8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5903ffff8a56481e124aa4fe8144c16348f6f8b9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5903ffff8a56481e124aa4fe8144c16348f6f8b9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}