)]}'
{"id":"openstack%2Fpython-openstackclient~276084","triplet_id":"openstack%2Fpython-openstackclient~master~Idb593236c0aaf8b4418a6a29cd66bcbd6f2bc889","project":"openstack/python-openstackclient","branch":"master","topic":"refactor-compute-client-20160204","hashtags":[],"change_id":"Idb593236c0aaf8b4418a6a29cd66bcbd6f2bc889","subject":"Use existing security_groups mock in TestSecurityGroupRule","status":"ABANDONED","created":"2016-02-04 08:06:24.000000000","updated":"2016-02-04 17:54:13.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"008f18d5321de78a33b3eb7ca334a37614a8c52a","_number":276084,"virtual_id_number":276084,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-02-04 17:53:19.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"date":"2016-02-04 17:36:59.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2016-02-04 16:59:10.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-04 12:19:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-02-04 16:59:10.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-02-04 17:36:59.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"}],"messages":[{"id":"017849d09bbdce1f77cbd9dc6d9da74a2a05de69","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-04 08:06:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9452ff21066cfed241d2cd53e562a7a78eb76829","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-04 09:10:42.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/84/276084/1/check/gate-python-openstackclient-pep8/92baa2c/ : FAILURE in 1m 21s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/84/276084/1/check/gate-python-openstackclient-docs/07c2a8b//doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-openstackclient-python27 http://logs.openstack.org/84/276084/1/check/gate-python-openstackclient-python27/2369600/ : SUCCESS in 1m 36s\n- gate-python-openstackclient-python34 http://logs.openstack.org/84/276084/1/check/gate-python-openstackclient-python34/7b354a6/ : SUCCESS in 2m 07s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/84/276084/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/6c9cbaa/ : SUCCESS in 1h 03m 04s\n- check-osc-plugins http://logs.openstack.org/84/276084/1/check/check-osc-plugins/7f53be2/ : SUCCESS in 1m 45s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/84/276084/1/check/gate-osc-dsvm-functional/6b3ae49/ : SUCCESS in 30m 18s","accounts_in_message":[],"_revision_number":1},{"id":"6386db36bec16e844322ae4d8c410eb83b86b846","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-04 10:52:05.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"33c9b0e21cc5168ecb8c5666b85ce5b492c40e22","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-04 12:19:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/84/276084/2/check/gate-python-openstackclient-pep8/0cdcf92/ : SUCCESS in 1m 16s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/84/276084/2/check/gate-python-openstackclient-docs/3e3e3ce//doc/build/html/ : SUCCESS in 3m 31s\n- gate-python-openstackclient-python27 http://logs.openstack.org/84/276084/2/check/gate-python-openstackclient-python27/43b9d91/ : SUCCESS in 1m 45s\n- gate-python-openstackclient-python34 http://logs.openstack.org/84/276084/2/check/gate-python-openstackclient-python34/771a344/ : SUCCESS in 2m 44s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/84/276084/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/55e9342/ : SUCCESS in 1h 19m 37s\n- check-osc-plugins http://logs.openstack.org/84/276084/2/check/check-osc-plugins/0cf4f8a/ : SUCCESS in 1m 48s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/84/276084/2/check/gate-osc-dsvm-functional/2ca85a0/ : SUCCESS in 27m 08s","accounts_in_message":[],"_revision_number":2},{"id":"d7cbba3d95fb40a9df9469a8b646bba037c99469","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-02-04 16:07:50.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0fbb0ae972e819580b83ed3788fbfc7f8d89d5b2","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-04 16:55:06.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"355da7c31beb8fa51bc365033b3aa587d0d1a141","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-04 16:56:21.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"401d267f050eaa3e8bbc7b163246ab980a0a879e","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-02-04 16:59:10.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"523479160f937dad7f8ca7c3a2c93bec33a5b15b","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-02-04 17:36:59.000000000","message":"Patch Set 3:\n\nYou could have done all three of these security groups test changes in a single review.  They fit together and I think it would be easier to review them as a unit for consistency, etc.","accounts_in_message":[],"_revision_number":3},{"id":"c18464474724833380f1301a91e3a1c4bd4111f5","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-04 17:53:19.000000000","message":"Patch Set 3:\n\nHi Dean, \n\nI squash the first and the third reviews together as they are actually the same thing. But I\u0027d like to keep the second one separate because projects_mock and security_groups_mock are different.","accounts_in_message":[],"_revision_number":3},{"id":"67aaef057491785ebeb539d5bd1dc084721e33d4","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-04 17:54:13.000000000","message":"Abandoned\n\nSquash with another patch.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"83020b51db1c3492e4760f713ef4812e60da48a8","revisions":{"0dbb45f0f6752fb1c355cca7fe3716f106e49601":{"kind":"REWORK","_number":1,"created":"2016-02-04 08:06:24.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/84/276084/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/84/276084/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/276084/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/276084/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/276084/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/84/276084/1"}}},"commit":{"parents":[{"commit":"40c8b2be79d2ca54c9ed8e7b6ebf038cac2bb361","subject":"Remove useless definition of identity_client.prijects mock in TestSecurityGroup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/40c8b2be79d2ca54c9ed8e7b6ebf038cac2bb361"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-04 07:54:47.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-04 07:54:47.000000000","tz":480},"subject":"Use security_groups mock defined in FakeComputev2Client in TestSecurityGroupRule","message":"Use security_groups mock defined in FakeComputev2Client in TestSecurityGroupRule\n\nsecurity_groups mock has been defined in FakeComputev2Client. Use it directly.\n\nChange-Id: Idb593236c0aaf8b4418a6a29cd66bcbd6f2bc889\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0dbb45f0f6752fb1c355cca7fe3716f106e49601"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0dbb45f0f6752fb1c355cca7fe3716f106e49601"}]},"branch":"refs/heads/master"},"5eedc95488ec58e13cfb1a697764775ebcde30d1":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2016-02-04 10:52:05.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/84/276084/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/84/276084/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/276084/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/276084/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/276084/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/84/276084/2"}}},"commit":{"parents":[{"commit":"a17ea8a95fbbca494f0109c1cfb0e27b83b70fd1","subject":"Remove useless definition of identity_client.prijects mock in TestSecurityGroup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a17ea8a95fbbca494f0109c1cfb0e27b83b70fd1"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-04 07:54:47.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-04 10:47:47.000000000","tz":480},"subject":"Use security_groups mock defined in FakeComputev2Client in TestSecurityGroupRule","message":"Use security_groups mock defined in FakeComputev2Client in TestSecurityGroupRule\n\nsecurity_groups mock has been defined in FakeComputev2Client. Use it directly.\n\nChange-Id: Idb593236c0aaf8b4418a6a29cd66bcbd6f2bc889\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5eedc95488ec58e13cfb1a697764775ebcde30d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5eedc95488ec58e13cfb1a697764775ebcde30d1"}]},"branch":"refs/heads/master"},"83020b51db1c3492e4760f713ef4812e60da48a8":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2016-02-04 16:56:21.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/84/276084/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/84/276084/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/276084/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/276084/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/84/276084/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/84/276084/3"}}},"commit":{"parents":[{"commit":"b1ff48e1a1d05c85eca90b30fcc32ff78f8a0ec1","subject":"Remove identity_client.projects definition in TestSecurityGroup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b1ff48e1a1d05c85eca90b30fcc32ff78f8a0ec1"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-04 07:54:47.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-04 16:53:49.000000000","tz":480},"subject":"Use existing security_groups mock in TestSecurityGroupRule","message":"Use existing security_groups mock in TestSecurityGroupRule\n\nsecurity_groups mock has been defined in FakeComputev2Client.\nUse it directly.\n\nChange-Id: Idb593236c0aaf8b4418a6a29cd66bcbd6f2bc889\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/83020b51db1c3492e4760f713ef4812e60da48a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/83020b51db1c3492e4760f713ef4812e60da48a8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}