)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ac6b04bc64594740a6abd6a45c22ce23e657989a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add \"os subnet show\" command using SDK"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement the openstack client subnet show command using SDK"},{"line_number":10,"context_line":"calls.  This shows the details of a specific subnet"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Terry Howe \u003cterrylhowe@gmail.com\u003e"},{"line_number":13,"context_line":"Partially implements: blueprint neutron-client"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dae33548_7d92574d","line":10,"updated":"2016-02-18 02:41:30.000000000","message":"nit : period/fullstop here at the end of the line","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"31c9620e2168e27d3f739ea2631efddce2572400","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add \"os subnet show\" command using SDK"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement the openstack client subnet show command using SDK"},{"line_number":10,"context_line":"calls.  This shows the details of a specific subnet"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Terry Howe \u003cterrylhowe@gmail.com\u003e"},{"line_number":13,"context_line":"Partially implements: blueprint neutron-client"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dae33548_6119d721","line":10,"in_reply_to":"dae33548_7d92574d","updated":"2016-02-18 22:48:21.000000000","message":"Done","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"}],"doc/source/command-objects/subnet.rst":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2c4e27595e3dd57bf9995c8f650274fea032fbb0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"subnet show"},{"line_number":23,"context_line":"------------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Display subnet details"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. program:: subnet show"},{"line_number":28,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a57f1b5_951a1c7c","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":7},"updated":"2016-02-12 01:10:28.000000000","message":"nit: Display --\u003e Show","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"bcba898ed8dd6059e734d31aa2b7665ee0122614","unresolved":false,"context_lines":[{"line_number":22,"context_line":"subnet show"},{"line_number":23,"context_line":"------------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Display subnet details"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. program:: subnet show"},{"line_number":28,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae33548_216b4fb8","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":7},"in_reply_to":"3a57f1b5_951a1c7c","updated":"2016-02-18 22:44:40.000000000","message":"Done","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2c4e27595e3dd57bf9995c8f650274fea032fbb0","unresolved":false,"context_lines":[{"line_number":33,"context_line":".. _subnet_show-subnet:"},{"line_number":34,"context_line":".. describe:: \u003csubnet\u003e"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Subnet to display (name or ID)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a57f1b5_75152047","line":36,"range":{"start_line":36,"start_character":14,"end_line":36,"end_character":21},"updated":"2016-02-12 01:10:28.000000000","message":"nit: display --\u003e show","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"bcba898ed8dd6059e734d31aa2b7665ee0122614","unresolved":false,"context_lines":[{"line_number":33,"context_line":".. _subnet_show-subnet:"},{"line_number":34,"context_line":".. describe:: \u003csubnet\u003e"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Subnet to display (name or ID)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae33548_01660bec","line":36,"range":{"start_line":36,"start_character":14,"end_line":36,"end_character":21},"in_reply_to":"3a57f1b5_75152047","updated":"2016-02-18 22:44:40.000000000","message":"Done","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1e603ba5cddea2b9612a4d4535cb9722230ca9b1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    List additional fields in output"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"subnet show"},{"line_number":23,"context_line":"------------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Show subnet details"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"dae33548_4dcafc6f","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":12},"updated":"2016-02-19 05:12:25.000000000","message":"nit: Please remove one \"-\" to align to the line above.","commit_id":"0453cead37638d97d0eb023da9afc06dd5a1f376"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a6444e07da256719ac1d6d94ffa25807f45c51d8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    List additional fields in output"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"subnet show"},{"line_number":23,"context_line":"------------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Display subnet details"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"bae84128_bc72cc7a","line":23,"updated":"2016-02-19 15:48:07.000000000","message":"nit...extra dash","commit_id":"53b80ab8cc2a534fa3fffc21a722ff004e712e3d"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"b93d69224c51c33f2fbd1717fc71b7bc905b3fdd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    List additional fields in output"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"subnet show"},{"line_number":23,"context_line":"------------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Display subnet details"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"bae84128_9a420f0f","line":23,"in_reply_to":"bae84128_bc72cc7a","updated":"2016-02-22 16:19:20.000000000","message":"Done","commit_id":"53b80ab8cc2a534fa3fffc21a722ff004e712e3d"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"75ee4e0c7f942d94bfae43f9c9cbc7f78529ee75","unresolved":false,"context_lines":[{"line_number":22,"context_line":"subnet show"},{"line_number":23,"context_line":"-----------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Display subnet details"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. program:: subnet show"},{"line_number":28,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bae84128_3c7ad8f1","line":25,"updated":"2016-02-22 18:23:12.000000000","message":"Code uses \"Show\" instead of \"Display\".","commit_id":"d8d060eea0f6086c034931ac55eae0ee6832afb7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ea1974cfb62fc19e62bdd601de7531306a1931ea","unresolved":false,"context_lines":[{"line_number":33,"context_line":".. _subnet_show-subnet:"},{"line_number":34,"context_line":".. describe:: \u003csubnet\u003e"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Subnet to show (name or ID)"}],"source_content_type":"text/x-rst","patch_set":10,"id":"bae84128_f26377da","line":36,"updated":"2016-02-22 18:54:33.000000000","message":"The code still uses \"display\".","commit_id":"924d1acacf2919ed7365d2fd2835311ce65ef0e1"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"5e78964b2ab4de67896a375ea8211de582c492ff","unresolved":false,"context_lines":[{"line_number":33,"context_line":".. _subnet_show-subnet:"},{"line_number":34,"context_line":".. describe:: \u003csubnet\u003e"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Subnet to show (name or ID)"}],"source_content_type":"text/x-rst","patch_set":10,"id":"bae84128_3205df79","line":36,"in_reply_to":"bae84128_f26377da","updated":"2016-02-22 19:06:05.000000000","message":"Missed that one.  I just made the change in subnet.py to use show, so hopefully it is consistent now.","commit_id":"924d1acacf2919ed7365d2fd2835311ce65ef0e1"}],"openstackclient/network/v2/subnet.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3158fe0438b016528c668b2c2cd7b2aeaed28d26","unresolved":false,"context_lines":[{"line_number":76,"context_line":"class ShowSubnet(command.ShowOne):"},{"line_number":77,"context_line":"    \"\"\"Show subnet details\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ShowSubnet\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_parser(self, prog_name):"},{"line_number":82,"context_line":"        parser \u003d super(ShowSubnet, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_9c1f9d07","line":79,"updated":"2016-02-05 16:14:24.000000000","message":"Logging is not part of the parent class so this can be removed.","commit_id":"4b55e4bece8eb6289dba791b186a087083083351"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3158fe0438b016528c668b2c2cd7b2aeaed28d26","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        return parser"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def take_action(self, parsed_args):"},{"line_number":91,"context_line":"        self.log.debug(\u0027take_action(%s)\u0027 % parsed_args)"},{"line_number":92,"context_line":"        obj \u003d self.app.client_manager.network.find_subnet(parsed_args.subnet,"},{"line_number":93,"context_line":"                                                          ignore_missing\u003dFalse)"},{"line_number":94,"context_line":"        columns \u003d _get_columns(obj)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_3c18e91d","line":91,"updated":"2016-02-05 16:14:24.000000000","message":"Logging is not part of the parent class so this can be removed.","commit_id":"4b55e4bece8eb6289dba791b186a087083083351"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2c4e27595e3dd57bf9995c8f650274fea032fbb0","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def take_action(self, parsed_args):"},{"line_number":87,"context_line":"        obj \u003d self.app.client_manager.network.find_subnet(parsed_args.subnet,"},{"line_number":88,"context_line":"                                                          ignore_missing\u003dFalse)"},{"line_number":89,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":90,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":91,"context_line":"        return (tuple(columns), data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_d57f34a9","line":88,"range":{"start_line":88,"start_character":58,"end_line":88,"end_character":79},"updated":"2016-02-12 01:10:28.000000000","message":"Shall we drop this for now to keep the consistence ?  I\u0027d like to handle them all in a refactor.","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"bcba898ed8dd6059e734d31aa2b7665ee0122614","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def take_action(self, parsed_args):"},{"line_number":87,"context_line":"        obj \u003d self.app.client_manager.network.find_subnet(parsed_args.subnet,"},{"line_number":88,"context_line":"                                                          ignore_missing\u003dFalse)"},{"line_number":89,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":90,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":91,"context_line":"        return (tuple(columns), data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_e1a327fe","line":88,"range":{"start_line":88,"start_character":58,"end_line":88,"end_character":79},"in_reply_to":"3a57f1b5_50758f61","updated":"2016-02-18 22:44:40.000000000","message":"I agree with Richard, we should raise the exception if the subnet doesn\u0027t exist.  If there is a better way to handle this, it can be done in a separate patch","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0941c2ab0245df3b40a13b0d1898679bf85e4436","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def take_action(self, parsed_args):"},{"line_number":87,"context_line":"        obj \u003d self.app.client_manager.network.find_subnet(parsed_args.subnet,"},{"line_number":88,"context_line":"                                                          ignore_missing\u003dFalse)"},{"line_number":89,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":90,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":91,"context_line":"        return (tuple(columns), data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_50758f61","line":88,"range":{"start_line":88,"start_character":58,"end_line":88,"end_character":79},"in_reply_to":"3a57f1b5_d57f34a9","updated":"2016-02-12 02:50:13.000000000","message":"We shouldn\u0027t ignore missing just like is done in ShowNetwork and ShowRouter.  If the subnet doesn\u0027t exist, an exception should be raised.","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2c4e27595e3dd57bf9995c8f650274fea032fbb0","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                                          ignore_missing\u003dFalse)"},{"line_number":89,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":90,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":91,"context_line":"        return (tuple(columns), data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_f5535037","line":91,"range":{"start_line":91,"start_character":16,"end_line":91,"end_character":21},"updated":"2016-02-12 01:10:28.000000000","message":"Not needed. Return value of _get_columns() is a tuple.","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"bcba898ed8dd6059e734d31aa2b7665ee0122614","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                                          ignore_missing\u003dFalse)"},{"line_number":89,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":90,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":91,"context_line":"        return (tuple(columns), data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_415c9318","line":91,"range":{"start_line":91,"start_character":16,"end_line":91,"end_character":21},"in_reply_to":"3a57f1b5_f5535037","updated":"2016-02-18 22:44:40.000000000","message":"Done","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a6444e07da256719ac1d6d94ffa25807f45c51d8","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class ShowSubnet(command.ShowOne):"},{"line_number":75,"context_line":"    \"\"\"Show subnet details\"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_parser(self, prog_name):"},{"line_number":78,"context_line":"        parser \u003d super(ShowSubnet, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_3c04fc7c","line":75,"updated":"2016-02-19 15:48:07.000000000","message":"\"Show\" should be \"Display\" to align with the doc.","commit_id":"53b80ab8cc2a534fa3fffc21a722ff004e712e3d"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"b93d69224c51c33f2fbd1717fc71b7bc905b3fdd","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class ShowSubnet(command.ShowOne):"},{"line_number":75,"context_line":"    \"\"\"Show subnet details\"\"\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def get_parser(self, prog_name):"},{"line_number":78,"context_line":"        parser \u003d super(ShowSubnet, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_4f2f2bf6","line":75,"in_reply_to":"bae84128_3c04fc7c","updated":"2016-02-22 16:19:20.000000000","message":"I changed the doc to be \"Show\", so I\u0027ll leave this comment as is","commit_id":"53b80ab8cc2a534fa3fffc21a722ff004e712e3d"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"eceb588eb694c08ef46f1467d6f7d7f3013be497","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                                          ignore_missing\u003dFalse)"},{"line_number":89,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":90,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":91,"context_line":"        return (tuple(columns), data)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae33548_6fe36f06","line":91,"range":{"start_line":91,"start_character":16,"end_line":91,"end_character":21},"updated":"2016-02-19 08:36:31.000000000","message":"Not needed. _get_columns() returns a tuple.","commit_id":"53b80ab8cc2a534fa3fffc21a722ff004e712e3d"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"b93d69224c51c33f2fbd1717fc71b7bc905b3fdd","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                                                          ignore_missing\u003dFalse)"},{"line_number":89,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":90,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":91,"context_line":"        return (tuple(columns), data)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_ba47131c","line":91,"range":{"start_line":91,"start_character":16,"end_line":91,"end_character":21},"in_reply_to":"dae33548_6fe36f06","updated":"2016-02-22 16:19:20.000000000","message":"Done","commit_id":"53b80ab8cc2a534fa3fffc21a722ff004e712e3d"}],"openstackclient/tests/network/v2/fakes.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a6444e07da256719ac1d6d94ffa25807f45c51d8","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        subnet \u003d fakes.FakeResource(info\u003dcopy.deepcopy(subnet_attrs),"},{"line_number":585,"context_line":"                                    methods\u003dcopy.deepcopy(subnet_methods),"},{"line_number":586,"context_line":"                                    loaded\u003dTrue)"},{"line_number":587,"context_line":"        subnet.project_id \u003d project_id"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        return subnet"},{"line_number":590,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_3c887c22","line":587,"updated":"2016-02-19 15:48:07.000000000","message":"I suggest adding a comment similar to what is in the port fake.  Also, this should probably be set to subnet_attrs[\u0027tenant_id\u0027] to account for possible default attribute overrides above.","commit_id":"53b80ab8cc2a534fa3fffc21a722ff004e712e3d"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"b93d69224c51c33f2fbd1717fc71b7bc905b3fdd","unresolved":false,"context_lines":[{"line_number":584,"context_line":"        subnet \u003d fakes.FakeResource(info\u003dcopy.deepcopy(subnet_attrs),"},{"line_number":585,"context_line":"                                    methods\u003dcopy.deepcopy(subnet_methods),"},{"line_number":586,"context_line":"                                    loaded\u003dTrue)"},{"line_number":587,"context_line":"        subnet.project_id \u003d project_id"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"        return subnet"},{"line_number":590,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_dac5b78e","line":587,"in_reply_to":"bae84128_3c887c22","updated":"2016-02-22 16:19:20.000000000","message":"Done","commit_id":"53b80ab8cc2a534fa3fffc21a722ff004e712e3d"}],"openstackclient/tests/network/v2/test_subnet.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3158fe0438b016528c668b2c2cd7b2aeaed28d26","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        try:"},{"line_number":163,"context_line":"            # Missing required args should bail here"},{"line_number":164,"context_line":"            self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":165,"context_line":"        except tests_utils.ParserException:"},{"line_number":166,"context_line":"            pass"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_1ce40ddf","line":164,"updated":"2016-02-05 16:14:24.000000000","message":"This test will pass even if an exception isn\u0027t raised.  Please see the test_port.py code for an example on how to fix.","commit_id":"4b55e4bece8eb6289dba791b186a087083083351"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2c4e27595e3dd57bf9995c8f650274fea032fbb0","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class TestShowSubnet(TestSubnet):"},{"line_number":113,"context_line":"    # The subnets to be shown"},{"line_number":114,"context_line":"    _subnet \u003d network_fakes.FakeSubnet.create_one_subnet()"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    columns \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_a0283887","line":113,"range":{"start_line":113,"start_character":10,"end_line":113,"end_character":17},"updated":"2016-02-12 01:10:28.000000000","message":"nit: subnets --\u003e subnet","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"bcba898ed8dd6059e734d31aa2b7665ee0122614","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class TestShowSubnet(TestSubnet):"},{"line_number":113,"context_line":"    # The subnets to be shown"},{"line_number":114,"context_line":"    _subnet \u003d network_fakes.FakeSubnet.create_one_subnet()"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    columns \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_41b3f34c","line":113,"range":{"start_line":113,"start_character":10,"end_line":113,"end_character":17},"in_reply_to":"3a57f1b5_a0283887","updated":"2016-02-18 22:44:40.000000000","message":"Done","commit_id":"74152902d99b59b6758556fb0a18295b0a0343a7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1e603ba5cddea2b9612a4d4535cb9722230ca9b1","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        self.network.find_subnet.assert_called_with(self._subnet.name,"},{"line_number":179,"context_line":"                                                    ignore_missing\u003dFalse)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        self.assertEqual(tuple(self.columns), columns)"},{"line_number":182,"context_line":"        self.assertEqual(list(self.data), list(data))"}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_00b43bcf","line":181,"range":{"start_line":181,"start_character":25,"end_line":181,"end_character":30},"updated":"2016-02-19 05:12:25.000000000","message":"Unnecessary. self.columns is a tuple itself.","commit_id":"0453cead37638d97d0eb023da9afc06dd5a1f376"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"eceb588eb694c08ef46f1467d6f7d7f3013be497","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        self.network.find_subnet.assert_called_with(self._subnet.name,"},{"line_number":179,"context_line":"                                                    ignore_missing\u003dFalse)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        self.assertEqual(tuple(self.columns), columns)"},{"line_number":182,"context_line":"        self.assertEqual(list(self.data), list(data))"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_c0fede04","line":181,"range":{"start_line":181,"start_character":25,"end_line":181,"end_character":30},"updated":"2016-02-19 08:36:31.000000000","message":"Not needed. self.columns is a tuple.","commit_id":"53b80ab8cc2a534fa3fffc21a722ff004e712e3d"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"b93d69224c51c33f2fbd1717fc71b7bc905b3fdd","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        self.network.find_subnet.assert_called_with(self._subnet.name,"},{"line_number":179,"context_line":"                                                    ignore_missing\u003dFalse)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        self.assertEqual(tuple(self.columns), columns)"},{"line_number":182,"context_line":"        self.assertEqual(list(self.data), list(data))"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_dafad7bc","line":181,"range":{"start_line":181,"start_character":25,"end_line":181,"end_character":30},"in_reply_to":"bae84128_c0fede04","updated":"2016-02-22 16:19:20.000000000","message":"Done","commit_id":"53b80ab8cc2a534fa3fffc21a722ff004e712e3d"}],"setup.cfg":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"eceb588eb694c08ef46f1467d6f7d7f3013be497","unresolved":false,"context_lines":[{"line_number":341,"context_line":"    security_group_delete \u003d openstackclient.network.v2.security_group:DeleteSecurityGroup"},{"line_number":342,"context_line":"    security_group_rule_delete \u003d openstackclient.network.v2.security_group_rule:DeleteSecurityGroupRule"},{"line_number":343,"context_line":"    subnet_list \u003d openstackclient.network.v2.subnet:ListSubnet"},{"line_number":344,"context_line":"    subnet_pool_delete \u003d openstackclient.network.v2.subnet_pool:DeleteSubnetPool"},{"line_number":345,"context_line":"    subnet_show \u003d openstackclient.network.v2.subnet:ShowSubnet"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"dae33548_4f578bca","line":344,"range":{"start_line":344,"start_character":4,"end_line":344,"end_character":22},"updated":"2016-02-19 08:36:31.000000000","message":"Please fix this in any patch of this serie. Move \"subnet pool\" command downwards.","commit_id":"53b80ab8cc2a534fa3fffc21a722ff004e712e3d"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"b93d69224c51c33f2fbd1717fc71b7bc905b3fdd","unresolved":false,"context_lines":[{"line_number":341,"context_line":"    security_group_delete \u003d openstackclient.network.v2.security_group:DeleteSecurityGroup"},{"line_number":342,"context_line":"    security_group_rule_delete \u003d openstackclient.network.v2.security_group_rule:DeleteSecurityGroupRule"},{"line_number":343,"context_line":"    subnet_list \u003d openstackclient.network.v2.subnet:ListSubnet"},{"line_number":344,"context_line":"    subnet_pool_delete \u003d openstackclient.network.v2.subnet_pool:DeleteSubnetPool"},{"line_number":345,"context_line":"    subnet_show \u003d openstackclient.network.v2.subnet:ShowSubnet"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"bae84128_5a2d2745","line":344,"range":{"start_line":344,"start_character":4,"end_line":344,"end_character":22},"in_reply_to":"dae33548_4f578bca","updated":"2016-02-22 16:19:20.000000000","message":"Done","commit_id":"53b80ab8cc2a534fa3fffc21a722ff004e712e3d"}]}