)]}'
{"id":"openstack%2Fpython-openstackclient~276985","triplet_id":"openstack%2Fpython-openstackclient~master~I4df224ec82b5d82a3d6d3f366c0f68a7ea0d87cd","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1477199","hashtags":[],"change_id":"I4df224ec82b5d82a3d6d3f366c0f68a7ea0d87cd","subject":"Compute: Fix DisplayCommandBase comments for cliff ShowOne subclass tests","status":"MERGED","created":"2016-02-06 02:51:17.000000000","updated":"2016-02-08 16:21:01.000000000","submitted":"2016-02-08 16:21:00.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8467a275fadefae27bf956fe54fab7476bcf2415","_number":276985,"virtual_id_number":276985,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-02-08 16:21:00.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":2,"date":"2016-02-08 15:25:04.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"date":"2016-02-08 02:55:00.000000000","_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":1,"date":"2016-02-08 15:25:04.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2016-02-08 02:54:50.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-08 02:54:50.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-02-08 02:55:00.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2016-02-08 15:25:04.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-02-08 16:21:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3b87553737063d0b4b6c75320150f6141aaebd15","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-06 02:51:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"af70c291662d7b44d67744c6ae82f3c00d9c5c8a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-06 03:41:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/85/276985/1/check/gate-python-openstackclient-pep8/feea99c/ : SUCCESS in 1m 00s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/85/276985/1/check/gate-python-openstackclient-docs/3c088a3//doc/build/html/ : SUCCESS in 1m 56s\n- gate-python-openstackclient-python27 http://logs.openstack.org/85/276985/1/check/gate-python-openstackclient-python27/d1321b2/ : SUCCESS in 1m 29s\n- gate-python-openstackclient-python34 http://logs.openstack.org/85/276985/1/check/gate-python-openstackclient-python34/c0255a3/ : SUCCESS in 2m 11s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/85/276985/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/86199d5/ : SUCCESS in 49m 49s\n- check-osc-plugins http://logs.openstack.org/85/276985/1/check/check-osc-plugins/d412ef2/ : SUCCESS in 1m 20s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/85/276985/1/check/gate-osc-dsvm-functional/9afa3ef/ : SUCCESS in 21m 34s","accounts_in_message":[],"_revision_number":1},{"id":"4657cb1528985a859d348654e1027e46331cc952","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-02-08 06:46:56.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nis this all the comments in the code base?","accounts_in_message":[],"_revision_number":1},{"id":"d26002c7c1476381dd98481bbb76c41f566007a7","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-08 09:12:59.000000000","message":"Patch Set 1:\n\nNo, Steve, these 3 patches fixed only those comments in compute. If this is OK, then I\u0027ll fix all the rest in another 3 patches.\n\nThanks.","accounts_in_message":[],"_revision_number":1},{"id":"f3aaa39b9d2d89ef1ee03be8f8a7b93d081d73b0","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-02-08 15:25:04.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nthanks for the explanation tang","accounts_in_message":[],"_revision_number":1},{"id":"0405e93a5a62b0b2e90adddd8f9d0f933361af02","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-08 15:25:10.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"2cf88f944a3b470cd5cc76d7df6d1b70db7b8a43","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-08 16:21:00.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/85/276985/1/gate/gate-python-openstackclient-docs/b3a1e4a//doc/build/html/ : SUCCESS in 1m 42s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/85/276985/1/gate/gate-python-openstackclient-pep8/a640b5c/ : SUCCESS in 1m 07s\n- gate-python-openstackclient-python27 http://logs.openstack.org/85/276985/1/gate/gate-python-openstackclient-python27/5fc9de5/ : SUCCESS in 1m 29s\n- gate-python-openstackclient-python34 http://logs.openstack.org/85/276985/1/gate/gate-python-openstackclient-python34/2e0f4ce/ : SUCCESS in 2m 22s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/85/276985/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/34e1cd0/ : SUCCESS in 55m 14s\n- gate-osc-dsvm-functional http://logs.openstack.org/85/276985/1/gate/gate-osc-dsvm-functional/86ddcd5/ : SUCCESS in 21m 54s","accounts_in_message":[],"_revision_number":1},{"id":"b8dd543f59155d65ec0b10a3bac78f7dd546dfa4","date":"2016-02-08 16:21:01.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"23faa33b1b2914bbc3e103fca75fde70eb317021","revisions":{"23faa33b1b2914bbc3e103fca75fde70eb317021":{"kind":"REWORK","_number":1,"created":"2016-02-06 02:51:17.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/85/276985/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/85/276985/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/276985/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/276985/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/276985/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/85/276985/1"}}},"commit":{"parents":[{"commit":"3c67e8dd6ed20f9a3d6c1f8f000214cc7a8f384e","subject":"Compute: Fix DisplayCommandBase comments for cliff Lister subclass tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3c67e8dd6ed20f9a3d6c1f8f000214cc7a8f384e"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-06 02:47:56.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-06 02:47:56.000000000","tz":480},"subject":"Compute: Fix DisplayCommandBase comments for cliff ShowOne subclass tests","message":"Compute: Fix DisplayCommandBase comments for cliff ShowOne subclass tests\n\nAs bug #1477199 describes, the wrong comment below is all over the\nunit test code of OSC.\n\n    # DisplayCommandBase.take_action() returns two tuples\n\nThere is no such class named DisplayCommandBase in OSC. It is in cliff.\n\nAll OSC command classes inherit from the base classes in cliff,\nclass Command, class Lister and class ShowOne. It is like this:\n\nObject\n|--\u003e Command\n     |--\u003e DisplayCommandBase\n         |--\u003e Lister\n         |--\u003e ShowOne\n\ntake_action() is an abstract method of class Command, and generally is\noverwritten by subclasses.\n\n* Command.take_action() returns nothing.\n* Lister.take_action() returns a tuple which contains a tuple of\n  columns and a generator used to generate the data.\n* ShowOne.take_action() returns an iterator which contains a tuple\n  of columns and a tuple of data\n\nSo, this problem should be fixed in 3 steps:\n1. Remove all DisplayCommandBase comments for tests of classes\n   inheriting from class Command in cliff as it returns nothing.\n2. Fix all DisplayCommandBase comments for tests of classes\n   inheriting from class Lister in cliff. Lister.take_action()\n   returns a tuple and a generator.\n3. Fix all DisplayCommandBase comments for tests of classes\n   inheriting from class ShowOne in cliff. ShowOne.take_action()\n   returns two tuples.\n\nThis patch finishes step 3 in compute tests.\n\nChange-Id: I4df224ec82b5d82a3d6d3f366c0f68a7ea0d87cd\nPartial-bug: #1477199\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/23faa33b1b2914bbc3e103fca75fde70eb317021"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/23faa33b1b2914bbc3e103fca75fde70eb317021"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}