)]}'
{"id":"openstack%2Fpython-openstackclient~277823","triplet_id":"openstack%2Fpython-openstackclient~master~I00f38d12f55abe20fa708f6349073da658622f8d","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1477199","hashtags":[],"change_id":"I00f38d12f55abe20fa708f6349073da658622f8d","subject":"Fix DisplayCommandBase comments for cliff Lister subclass tests","status":"MERGED","created":"2016-02-09 13:16:45.000000000","updated":"2016-02-10 09:07:21.000000000","submitted":"2016-02-10 09:07:21.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cef6361a98968f19c12a34a332813c1e833d3575","_number":277823,"virtual_id_number":277823,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-02-10 09:07:21.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":2,"date":"2016-02-10 08:14:18.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":1,"date":"2016-02-10 08:14:18.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-09 13:21:44.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-02-09 13:21:53.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2016-02-09 13:21:58.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2016-02-09 13:22:02.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-02-10 08:14:18.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-02-10 09:07:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"69b679601aeca3a32d2b45ead8638061d605de6f","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-09 13:16:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b93e2b262ed7fea22a7ce6c7fda30a437bb90824","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-09 13:20:27.000000000","message":"Patch Set 1:\n\nThis series of patches fixed the comments in all tests except those in dir tests/identity. There are about 150+ bad comments in dir tests/identity. So I intend to fix them all in another patch.","accounts_in_message":[],"_revision_number":1},{"id":"645ac6e1fa81b7cd35056acc1154eb34f51a95dc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-09 14:33:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/23/277823/1/check/gate-python-openstackclient-pep8/644929a/ : SUCCESS in 54s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/23/277823/1/check/gate-python-openstackclient-docs/7ec299c//doc/build/html/ : SUCCESS in 1m 47s\n- gate-python-openstackclient-python27 http://logs.openstack.org/23/277823/1/check/gate-python-openstackclient-python27/de74a4d/ : SUCCESS in 1m 08s\n- gate-python-openstackclient-python34 http://logs.openstack.org/23/277823/1/check/gate-python-openstackclient-python34/b506127/ : SUCCESS in 1m 52s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/23/277823/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/60dcf62/ : SUCCESS in 1h 11m 10s\n- check-osc-plugins http://logs.openstack.org/23/277823/1/check/check-osc-plugins/ca1b5a4/ : SUCCESS in 1m 02s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/23/277823/1/check/gate-osc-dsvm-functional/a785e74/ : SUCCESS in 23m 07s","accounts_in_message":[],"_revision_number":1},{"id":"9ce56edd340eab50b8f7e77ce2b3871bbb3a4c32","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-02-09 16:07:35.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6374ac35af7d33665738392c5f2352515292b93e","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-10 03:40:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8ff3caa351f6bd8ce97b6484d694a318ae90b6e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-10 04:31:06.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/23/277823/2/check/gate-python-openstackclient-pep8/4c271f6/ : FAILURE in 37s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/23/277823/2/check/gate-python-openstackclient-docs/1f47526//doc/build/html/ : SUCCESS in 1m 15s\n- gate-python-openstackclient-python27 http://logs.openstack.org/23/277823/2/check/gate-python-openstackclient-python27/23b2026/ : SUCCESS in 1m 16s\n- gate-python-openstackclient-python34 http://logs.openstack.org/23/277823/2/check/gate-python-openstackclient-python34/e255f59/ : SUCCESS in 2m 16s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/23/277823/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/0e665e7/ : SUCCESS in 48m 18s\n- check-osc-plugins http://logs.openstack.org/23/277823/2/check/check-osc-plugins/ff906d0/ : SUCCESS in 1m 00s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/23/277823/2/check/gate-osc-dsvm-functional/4b83168/ : SUCCESS in 19m 45s","accounts_in_message":[],"_revision_number":2},{"id":"72b5f99b12c2d61bf45cc762fed06016d3974bd0","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-10 05:32:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"60f05bec7eff1afb91e2a99ff3cfcc74e7221497","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-10 06:23:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/23/277823/3/check/gate-python-openstackclient-pep8/47de3e8/ : SUCCESS in 44s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/23/277823/3/check/gate-python-openstackclient-docs/6591c5d//doc/build/html/ : SUCCESS in 1m 24s\n- gate-python-openstackclient-python27 http://logs.openstack.org/23/277823/3/check/gate-python-openstackclient-python27/be310ba/ : SUCCESS in 1m 01s\n- gate-python-openstackclient-python34 http://logs.openstack.org/23/277823/3/check/gate-python-openstackclient-python34/51f2bc1/ : SUCCESS in 1m 49s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/23/277823/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/e19ebe5/ : SUCCESS in 44m 06s\n- check-osc-plugins http://logs.openstack.org/23/277823/3/check/check-osc-plugins/71d156b/ : SUCCESS in 59s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/23/277823/3/check/gate-osc-dsvm-functional/6e32b80/ : SUCCESS in 19m 02s","accounts_in_message":[],"_revision_number":3},{"id":"5919de28d57d29a37b5d097df52cbc7b9a9d9e7e","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-02-10 08:14:18.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"3ef089a05daaf7b6bd5a9528c1da32fbc26b11de","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-10 08:15:04.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"0b67e378dd4a047e41c179a7544082c6f0d05492","date":"2016-02-10 09:07:21.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"d9e8fac7bd7d79dc72b6878c225391b648f7b4ea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-10 09:07:21.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/23/277823/3/gate/gate-python-openstackclient-docs/8bfb7bf//doc/build/html/ : SUCCESS in 2m 21s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/23/277823/3/gate/gate-python-openstackclient-pep8/ef2ec0f/ : SUCCESS in 48s\n- gate-python-openstackclient-python27 http://logs.openstack.org/23/277823/3/gate/gate-python-openstackclient-python27/936cb5a/ : SUCCESS in 1m 22s\n- gate-python-openstackclient-python34 http://logs.openstack.org/23/277823/3/gate/gate-python-openstackclient-python34/df4ecfa/ : SUCCESS in 2m 25s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/23/277823/3/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/1888717/ : SUCCESS in 48m 46s\n- gate-osc-dsvm-functional http://logs.openstack.org/23/277823/3/gate/gate-osc-dsvm-functional/e783ac8/ : SUCCESS in 18m 37s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e69b88ef525445325843c129e1a113a92ed98e3a","revisions":{"487142cca00e50cf66c2b780709895fb9316ffb0":{"kind":"REWORK","_number":1,"created":"2016-02-09 13:16:45.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/23/277823/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/23/277823/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/277823/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/277823/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/277823/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/23/277823/1"}}},"commit":{"parents":[{"commit":"43f80505cbaa0945380e366a8cada71b55296463","subject":"Fix DisplayCommandBase comments for cliff Command subclass tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/43f80505cbaa0945380e366a8cada71b55296463"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-09 09:30:39.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-09 12:28:18.000000000","tz":480},"subject":"Fix DisplayCommandBase comments for cliff Lister subclass tests","message":"Fix DisplayCommandBase comments for cliff Lister subclass tests\n\nAs bug #1477199 describes, the wrong comment below is all over the\nunit test code of OSC.\n\n    # DisplayCommandBase.take_action() returns two tuples\n\nThere is no such class named DisplayCommandBase in OSC. It is in cliff.\n\nAll OSC command classes inherit from the base classes in cliff,\nclass Command, class Lister and class ShowOne. It is like this:\n\nObject\n|--\u003e Command\n     |--\u003e DisplayCommandBase\n          |--\u003e Lister\n          |--\u003e ShowOne\n\ntake_action() is an abstract method of class Command, and generally is\noverwritten by subclasses.\n* Command.take_action() returns nothing.\n* Lister.take_action() returns a tuple which contains a tuple of columns\n  and a generator used to generate the data.\n* ShowOne.take_action() returns an iterator which contains a tuple of\n  columns and a tuple of data.\n\nSo, this problem should be fixed in 3 steps:\n1. Remove all DisplayCommandBase comments for tests of classes inheriting\n   from class Command in cliff as it returns nothing.\n2. Fix all DisplayCommandBase comments for tests of classes inheriting\n   from class Lister in cliff. Lister.take_action() returns a tuple and\n   a generator.\n3. Fix all DisplayCommandBase comments for tests of classes inheriting\n   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.\n\nThis patch finishes step 2 in all but identity tests. There are too many\nsuch comments in identity tests. So fix them all in another patch.\n\nChange-Id: I00f38d12f55abe20fa708f6349073da658622f8d\nPartial-bug: #1477199\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/487142cca00e50cf66c2b780709895fb9316ffb0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/487142cca00e50cf66c2b780709895fb9316ffb0"}]},"branch":"refs/heads/master"},"45f50c9393ba2c018dd6b06499c7253221d27a53":{"kind":"REWORK","_number":2,"created":"2016-02-10 03:40:27.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/23/277823/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/23/277823/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/277823/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/277823/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/277823/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/23/277823/2"}}},"commit":{"parents":[{"commit":"43f80505cbaa0945380e366a8cada71b55296463","subject":"Fix DisplayCommandBase comments for cliff Command subclass tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/43f80505cbaa0945380e366a8cada71b55296463"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-09 09:30:39.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-09 12:28:18.000000000","tz":480},"subject":"Fix DisplayCommandBase comments for cliff Lister subclass tests","message":"Fix DisplayCommandBase comments for cliff Lister subclass tests\n\nAs bug #1477199 describes, the wrong comment below is all over the\nunit test code of OSC.\n\n    # DisplayCommandBase.take_action() returns two tuples\n\nThere is no such class named DisplayCommandBase in OSC. It is in cliff.\n\nAll OSC command classes inherit from the base classes in cliff,\nclass Command, class Lister and class ShowOne. It is like this:\n\nObject\n|--\u003e Command\n     |--\u003e DisplayCommandBase\n          |--\u003e Lister\n          |--\u003e ShowOne\n\ntake_action() is an abstract method of class Command, and generally is\noverwritten by subclasses.\n* Command.take_action() returns nothing.\n* Lister.take_action() returns a tuple which contains a tuple of columns\n  and a generator used to generate the data.\n* ShowOne.take_action() returns an iterator which contains a tuple of\n  columns and a tuple of data.\n\nSo, this problem should be fixed in 3 steps:\n1. Remove all DisplayCommandBase comments for tests of classes inheriting\n   from class Command in cliff as it returns nothing.\n2. Fix all DisplayCommandBase comments for tests of classes inheriting\n   from class Lister in cliff. Lister.take_action() returns a tuple and\n   a generator.\n3. Fix all DisplayCommandBase comments for tests of classes inheriting\n   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.\n\nThis patch finishes step 2 in all but identity tests. There are too many\nsuch comments in identity tests. So fix them all in another patch.\n\nChange-Id: I00f38d12f55abe20fa708f6349073da658622f8d\nPartial-bug: #1477199\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/45f50c9393ba2c018dd6b06499c7253221d27a53"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/45f50c9393ba2c018dd6b06499c7253221d27a53"}]},"branch":"refs/heads/master"},"e69b88ef525445325843c129e1a113a92ed98e3a":{"kind":"REWORK","_number":3,"created":"2016-02-10 05:32:22.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/23/277823/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/23/277823/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/277823/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/277823/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/277823/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/23/277823/3"}}},"commit":{"parents":[{"commit":"43f80505cbaa0945380e366a8cada71b55296463","subject":"Fix DisplayCommandBase comments for cliff Command subclass tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/43f80505cbaa0945380e366a8cada71b55296463"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-09 09:30:39.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-09 12:28:18.000000000","tz":480},"subject":"Fix DisplayCommandBase comments for cliff Lister subclass tests","message":"Fix DisplayCommandBase comments for cliff Lister subclass tests\n\nAs bug #1477199 describes, the wrong comment below is all over the\nunit test code of OSC.\n\n    # DisplayCommandBase.take_action() returns two tuples\n\nThere is no such class named DisplayCommandBase in OSC. It is in cliff.\n\nAll OSC command classes inherit from the base classes in cliff,\nclass Command, class Lister and class ShowOne. It is like this:\n\nObject\n|--\u003e Command\n     |--\u003e DisplayCommandBase\n          |--\u003e Lister\n          |--\u003e ShowOne\n\ntake_action() is an abstract method of class Command, and generally is\noverwritten by subclasses.\n* Command.take_action() returns nothing.\n* Lister.take_action() returns a tuple which contains a tuple of columns\n  and a generator used to generate the data.\n* ShowOne.take_action() returns an iterator which contains a tuple of\n  columns and a tuple of data.\n\nSo, this problem should be fixed in 3 steps:\n1. Remove all DisplayCommandBase comments for tests of classes inheriting\n   from class Command in cliff as it returns nothing.\n2. Fix all DisplayCommandBase comments for tests of classes inheriting\n   from class Lister in cliff. Lister.take_action() returns a tuple and\n   a generator.\n3. Fix all DisplayCommandBase comments for tests of classes inheriting\n   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.\n\nThis patch finishes step 2 in all but identity tests. There are too many\nsuch comments in identity tests. So fix them all in another patch.\n\nChange-Id: I00f38d12f55abe20fa708f6349073da658622f8d\nPartial-bug: #1477199\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e69b88ef525445325843c129e1a113a92ed98e3a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e69b88ef525445325843c129e1a113a92ed98e3a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}