)]}'
{"id":"openstack%2Fpython-openstackclient~278443","triplet_id":"openstack%2Fpython-openstackclient~master~Id7180d10c050c6286b2c05cd990e2e275fbc3d38","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1477199","hashtags":[],"change_id":"Id7180d10c050c6286b2c05cd990e2e275fbc3d38","subject":"Identity: Fix DisplayCommandBase comments for cliff Command subclass tests","status":"MERGED","created":"2016-02-10 15:28:48.000000000","updated":"2016-02-13 06:11:16.000000000","submitted":"2016-02-13 06:11:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"230584b4b95b05b22dd79f2b4a2cbdd5ca8c5e31","_number":278443,"virtual_id_number":278443,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-02-13 06:11:16.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-02-13 05:14:51.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-02-13 03:25:02.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":1,"date":"2016-02-11 13:41:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2016-02-13 05:14:51.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-11 13:41:30.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-02-13 03:25:02.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2016-02-13 05:14:51.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-02-13 06:11:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"92361a31ce30d36afc1309ff26c85462d9a0f05f","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-10 15:28:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a9366416a36728cbc3d5458418b99d650c1a1033","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-10 18:08:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/43/278443/1/check/gate-python-openstackclient-pep8/4d447a5/ : SUCCESS in 51s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/43/278443/1/check/gate-python-openstackclient-docs/51001f1//doc/build/html/ : SUCCESS in 2m 00s\n- gate-python-openstackclient-python27 http://logs.openstack.org/43/278443/1/check/gate-python-openstackclient-python27/c5f1cca/ : SUCCESS in 1m 17s\n- gate-python-openstackclient-python34 http://logs.openstack.org/43/278443/1/check/gate-python-openstackclient-python34/7a2ce48/ : SUCCESS in 3m 05s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/43/278443/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/65abbe1/ : SUCCESS in 54m 18s\n- check-osc-plugins http://logs.openstack.org/43/278443/1/check/check-osc-plugins/db9ade7/ : SUCCESS in 1m 23s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/43/278443/1/check/gate-osc-dsvm-functional/fc0a3a3/ : SUCCESS in 18m 31s","accounts_in_message":[],"_revision_number":1},{"id":"e08475130ce094e72efa08b20ed77eff2028cb9b","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-02-11 13:41:30.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"890123ab500cd123b302b82f3664688eabd91acd","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-12 02:02:47.000000000","message":"Patch Set 1:\n\nHi Steve,\n\nWould you please help to confirm this serie ?  Then the bug is closed.","accounts_in_message":[],"_revision_number":1},{"id":"dcebec9a7b69ba1e6c0518275d10a212a84397f2","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2016-02-13 03:25:02.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c505a5fa91b04b36ac3ba64ba129587f55a32b93","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-02-13 05:14:51.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b1b9f66ccb37e07ce8801cf2cad7c9fc04876277","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-13 05:14:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d1c1d70e6b6d16225746c600140ee6174e3a7ba4","date":"2016-02-13 06:11:16.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"b4b70ab21d6bafa0e2e9340be8df5c4332308281","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-13 06:11:16.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/43/278443/1/gate/gate-python-openstackclient-docs/70a3ef5//doc/build/html/ : SUCCESS in 1m 37s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/43/278443/1/gate/gate-python-openstackclient-pep8/a532f48/ : SUCCESS in 1m 37s\n- gate-python-openstackclient-python27 http://logs.openstack.org/43/278443/1/gate/gate-python-openstackclient-python27/4cdbba3/ : SUCCESS in 1m 17s\n- gate-python-openstackclient-python34 http://logs.openstack.org/43/278443/1/gate/gate-python-openstackclient-python34/1115e13/ : SUCCESS in 12m 32s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/43/278443/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/36a6877/ : SUCCESS in 56m 18s\n- gate-osc-dsvm-functional http://logs.openstack.org/43/278443/1/gate/gate-osc-dsvm-functional/443e313/ : SUCCESS in 16m 29s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1225ad5f7efc91fda27b7c6a1c84f1c5cadc54a6","revisions":{"1225ad5f7efc91fda27b7c6a1c84f1c5cadc54a6":{"kind":"REWORK","_number":1,"created":"2016-02-10 15:28:48.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/43/278443/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/43/278443/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/43/278443/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/43/278443/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/43/278443/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/43/278443/1"}}},"commit":{"parents":[{"commit":"e1feed52217012da285ef94144ed82704b20d4e7","subject":"Trivial: Fix \"abstractmethod\" to \"abstract method\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e1feed52217012da285ef94144ed82704b20d4e7"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-10 11:15:37.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-10 11:15:37.000000000","tz":480},"subject":"Identity: Fix DisplayCommandBase comments for cliff Command subclass tests","message":"Identity: Fix DisplayCommandBase comments for cliff Command subclass tests\n\nAs bug #1477199 describes, the wrong comment below is all over the\nunit test code of OSC.\n\n    # DisplayCommandBase.take_action() returns two tuples\n\nThere is no such class named DisplayCommandBase in OSC. It is in cliff.\n\nAll OSC command classes inherit from the base classes in cliff,\nclass Command, class Lister and class ShowOne. It is like this:\n\nObject\n|--\u003e Command\n     |--\u003e DisplayCommandBase\n          |--\u003e Lister\n          |--\u003e ShowOne\n\ntake_action() is an abstract method of class Command, and generally is\noverwritten by subclasses.\n* Command.take_action() returns nothing.\n* Lister.take_action() returns a tuple which contains a tuple of columns\n  and a generator used to generate the data.\n* ShowOne.take_action() returns an iterator which contains a tuple of\n  columns and a tuple of data.\n\nSo, this problem should be fixed in 3 steps:\n1. Remove all DisplayCommandBase comments for tests of classes inheriting\n   from class Command in cliff as it returns nothing.\n2. Fix all DisplayCommandBase comments for tests of classes inheriting\n   from class Lister in cliff. Lister.take_action() returns a tuple and\n   a generator.\n3. Fix all DisplayCommandBase comments for tests of classes inheriting\n   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.\n\nThis patch finishes step 1 in all identity tests.\n\nChange-Id: Id7180d10c050c6286b2c05cd990e2e275fbc3d38\nPartial-bug: #1477199\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1225ad5f7efc91fda27b7c6a1c84f1c5cadc54a6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1225ad5f7efc91fda27b7c6a1c84f1c5cadc54a6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}