)]}'
{"id":"openstack%2Fpython-openstackclient~278444","triplet_id":"openstack%2Fpython-openstackclient~master~I2929ee688b1d7afc52c6ab325982bdc24c60a995","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1477199","hashtags":[],"change_id":"I2929ee688b1d7afc52c6ab325982bdc24c60a995","subject":"Identity: Fix DisplayCommandBase comments for cliff Lister subclass tests","status":"MERGED","created":"2016-02-10 15:28:48.000000000","updated":"2016-02-13 06:11:22.000000000","submitted":"2016-02-13 06:11:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8a8b13133dce25fe76ac59ad54e223885a6bfb2c","_number":278444,"virtual_id_number":278444,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-02-13 06:11:22.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-02-13 05:15:07.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-02-11 13:43:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2016-02-13 05:15:07.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-11 13:43:15.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-02-13 05:15:07.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-02-13 06:11:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0d3e0581848be1e6674839cc8fd42dab4da0a975","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-10 15:28:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f8e1f6085a149f5b10b4623bc2c7ebc40cdcf940","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-10 18:06:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/44/278444/1/check/gate-python-openstackclient-pep8/98360d6/ : SUCCESS in 43s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/44/278444/1/check/gate-python-openstackclient-docs/9e852ed//doc/build/html/ : SUCCESS in 1m 23s\n- gate-python-openstackclient-python27 http://logs.openstack.org/44/278444/1/check/gate-python-openstackclient-python27/b24f0b7/ : SUCCESS in 1m 05s\n- gate-python-openstackclient-python34 http://logs.openstack.org/44/278444/1/check/gate-python-openstackclient-python34/df7b48e/ : SUCCESS in 2m 06s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/44/278444/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/b76df41/ : SUCCESS in 52m 53s\n- check-osc-plugins http://logs.openstack.org/44/278444/1/check/check-osc-plugins/39e3272/ : SUCCESS in 1m 00s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/44/278444/1/check/gate-osc-dsvm-functional/4b85494/ : SUCCESS in 23m 38s","accounts_in_message":[],"_revision_number":1},{"id":"e636da0379ca7eeb14326262f26415bf4250bb9d","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-02-11 13:43:15.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f669ad247fc7546e4dbfe6117297ef89082e77f3","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-02-13 05:15:07.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"70155dd0dd9c3ed81a389709a499914bb9f753b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-13 05:15:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"6039888cdffee0c04bcf9cef14da4bebe944d9c6","date":"2016-02-13 06:11:22.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"8882bd62c0e844454e4ab0033954a40baa8426d1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-13 06:11:22.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/44/278444/1/gate/gate-python-openstackclient-docs/376585f//doc/build/html/ : SUCCESS in 1m 54s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/44/278444/1/gate/gate-python-openstackclient-pep8/d922df2/ : SUCCESS in 41s\n- gate-python-openstackclient-python27 http://logs.openstack.org/44/278444/1/gate/gate-python-openstackclient-python27/2e410b9/ : SUCCESS in 1m 12s\n- gate-python-openstackclient-python34 http://logs.openstack.org/44/278444/1/gate/gate-python-openstackclient-python34/5683cc7/ : SUCCESS in 2m 09s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/44/278444/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/ec3ee7b/ : SUCCESS in 45m 27s\n- gate-osc-dsvm-functional http://logs.openstack.org/44/278444/1/gate/gate-osc-dsvm-functional/d0d572e/ : SUCCESS in 17m 18s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d0c0cefb84b4d7abff23e7e313acd9725df1be9b","revisions":{"d0c0cefb84b4d7abff23e7e313acd9725df1be9b":{"kind":"REWORK","_number":1,"created":"2016-02-10 15:28:48.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/44/278444/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/44/278444/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/44/278444/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/44/278444/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/44/278444/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/44/278444/1"}}},"commit":{"parents":[{"commit":"1225ad5f7efc91fda27b7c6a1c84f1c5cadc54a6","subject":"Identity: Fix DisplayCommandBase comments for cliff Command subclass tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1225ad5f7efc91fda27b7c6a1c84f1c5cadc54a6"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-10 12:51:58.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-10 14:44:29.000000000","tz":480},"subject":"Identity: Fix DisplayCommandBase comments for cliff Lister subclass tests","message":"Identity: Fix DisplayCommandBase comments for cliff Lister subclass tests\n\nAs bug #1477199 describes, the wrong comment below is all over the\nunit test code of OSC.\n\n    # DisplayCommandBase.take_action() returns two tuples\n\nThere is no such class named DisplayCommandBase in OSC. It is in cliff.\n\nAll OSC command classes inherit from the base classes in cliff,\nclass Command, class Lister and class ShowOne. It is like this:\n\nObject\n|--\u003e Command\n     |--\u003e DisplayCommandBase\n          |--\u003e Lister\n          |--\u003e ShowOne\n\ntake_action() is an abstract method of class Command, and generally is\noverwritten by subclasses.\n* Command.take_action() returns nothing.\n* Lister.take_action() returns a tuple which contains a tuple of columns\n  and a generator used to generate the data.\n* ShowOne.take_action() returns an iterator which contains a tuple of\n  columns and a tuple of data.\n\nSo, this problem should be fixed in 3 steps:\n1. Remove all DisplayCommandBase comments for tests of classes inheriting\n   from class Command in cliff as it returns nothing.\n2. Fix all DisplayCommandBase comments for tests of classes inheriting\n   from class Lister in cliff. Lister.take_action() returns a tuple and\n   a generator.\n3. Fix all DisplayCommandBase comments for tests of classes inheriting\n   from class ShowOne in cliff. ShowOne.take_action() returns two tuples.\n\nThis patch finishes step 2 in all identity tests.\n\nChange-Id: I2929ee688b1d7afc52c6ab325982bdc24c60a995\nPartial-bug: #1477199\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d0c0cefb84b4d7abff23e7e313acd9725df1be9b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d0c0cefb84b4d7abff23e7e313acd9725df1be9b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}