)]}'
{"doc/source/command-objects/subnet.rst":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"09bd715d171ce7df4112f4a0250af39691d04720","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    Subnet to display (name or ID)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"subnet set"},{"line_number":133,"context_line":"------------"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Set/Update subnet details"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"dae33548_2fe7a8ad","line":133,"range":{"start_line":133,"start_character":10,"end_line":133,"end_character":12},"updated":"2016-02-19 08:19:24.000000000","message":"nit: 2 more \"--\".","commit_id":"f524ab25065c88300d62869bff3886d70cbc82c3"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"09bd715d171ce7df4112f4a0250af39691d04720","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    Domain the project belongs to (name or ID)."},{"line_number":157,"context_line":"    This can be used in case collisions between project names exist."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":".. option:: --allocation-pool start\u003dlow,end\u003dhigh"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    Updated allocation pool IP addresses for this subnet e.g.:"},{"line_number":162,"context_line":"        start\u003d192.168.199.2,end\u003d192.168.199.254 (This option can be repeated)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dae33548_cf339bf5","line":159,"range":{"start_line":159,"start_character":30,"end_line":159,"end_character":48},"updated":"2016-02-19 08:19:24.000000000","message":"Is \"start\u003dip-address,end\u003dip-address\" better ?","commit_id":"f524ab25065c88300d62869bff3886d70cbc82c3"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"09bd715d171ce7df4112f4a0250af39691d04720","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"     Updated address of the gateway for this subnet"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":".. option:: --host-route destination\u003dCIDR,nexthop\u003dIP_ADDR"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"     Additional route for this subnet e.g.:"},{"line_number":183,"context_line":"         destination\u003d10.10.0.0/16,nexthop\u003d192.168.71.254"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dae33548_2f11685e","line":180,"range":{"start_line":180,"start_character":25,"end_line":180,"end_character":57},"updated":"2016-02-19 08:19:24.000000000","message":"This has been discussed here:\nhttps://review.openstack.org/#/c/276042/\n\nIt should be: destination\u003dsubnet,gateway\u003dip-address \n\nCIDR --\u003e subnet\nnexthop --\u003e gateway","commit_id":"f524ab25065c88300d62869bff3886d70cbc82c3"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"09bd715d171ce7df4112f4a0250af39691d04720","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"     Updated name of the subnet"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":".. _subnet_set-name:"},{"line_number":191,"context_line":".. describe:: \u003cname\u003e"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    ID or Name of subnet to modify"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dae33548_af80d88c","line":190,"range":{"start_line":190,"start_character":15,"end_line":190,"end_character":19},"updated":"2016-02-19 08:19:24.000000000","message":"nit: name --\u003e subnet","commit_id":"f524ab25065c88300d62869bff3886d70cbc82c3"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"09bd715d171ce7df4112f4a0250af39691d04720","unresolved":false,"context_lines":[{"line_number":188,"context_line":"     Updated name of the subnet"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":".. _subnet_set-name:"},{"line_number":191,"context_line":".. describe:: \u003cname\u003e"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    ID or Name of subnet to modify"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"dae33548_cf66fc28","line":191,"range":{"start_line":191,"start_character":15,"end_line":191,"end_character":19},"updated":"2016-02-19 08:19:24.000000000","message":"ditto","commit_id":"f524ab25065c88300d62869bff3886d70cbc82c3"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"09bd715d171ce7df4112f4a0250af39691d04720","unresolved":false,"context_lines":[{"line_number":190,"context_line":".. _subnet_set-name:"},{"line_number":191,"context_line":".. describe:: \u003cname\u003e"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    ID or Name of subnet to modify"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"dae33548_cf4d5c9b","line":193,"range":{"start_line":193,"start_character":4,"end_line":193,"end_character":34},"updated":"2016-02-19 08:19:24.000000000","message":"To keep consistence: Subnet to modify (name or ID)","commit_id":"f524ab25065c88300d62869bff3886d70cbc82c3"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a9a9e36bd6c9236ade01dfdc166bcf15732ef3c8","unresolved":false,"context_lines":[{"line_number":146,"context_line":"subnet set"},{"line_number":147,"context_line":"--------------"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Set/Update subnet details"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":".. program:: subnet set"},{"line_number":152,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1af94dfe_4a130b5d","line":149,"updated":"2016-03-15 12:48:41.000000000","message":"\"Set subnet properties\" for consistency with other commands.","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"58b5720bcaaa359d7addd8b26055dda08bb8ea3b","unresolved":false,"context_lines":[{"line_number":146,"context_line":"subnet set"},{"line_number":147,"context_line":"--------------"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Set/Update subnet details"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":".. program:: subnet set"},{"line_number":152,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1af94dfe_3d30199e","line":149,"in_reply_to":"1af94dfe_4a130b5d","updated":"2016-03-17 08:02:47.000000000","message":"Done","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a9a9e36bd6c9236ade01dfdc166bcf15732ef3c8","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"     DNS name server for this subnet (This option can be repeated)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":".. option:: --gateway \u003cgateway\u003e"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"     Updated information of the gateway for this subnet"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1af94dfe_4f25ddc0","line":190,"updated":"2016-03-15 12:48:41.000000000","message":"Please update to be similar to \"subnet create\"","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"1563ca86b32630267ff50564997f0ab30632e166","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"     DNS name server for this subnet (This option can be repeated)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":".. option:: --gateway \u003cgateway\u003e"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"     Updated information of the gateway for this subnet"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1af94dfe_701d16bd","line":190,"in_reply_to":"1af94dfe_4f25ddc0","updated":"2016-03-15 13:32:09.000000000","message":"Agree.  See my more detailed comment in subnet.py","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a9a9e36bd6c9236ade01dfdc166bcf15732ef3c8","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"     Remove gateway information from the subnet"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":".. option:: --host-route destination\u003dCIDR,nexthop\u003dIP_ADDR"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"     Additional route for this subnet e.g.:"},{"line_number":201,"context_line":"         destination\u003d10.10.0.0/16,nexthop\u003d192.168.71.254"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1af94dfe_ef48298a","line":198,"updated":"2016-03-15 12:48:41.000000000","message":"Please update to be similar to \"subnet create\"","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"58b5720bcaaa359d7addd8b26055dda08bb8ea3b","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"     Remove gateway information from the subnet"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":".. option:: --host-route destination\u003dCIDR,nexthop\u003dIP_ADDR"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"     Additional route for this subnet e.g.:"},{"line_number":201,"context_line":"         destination\u003d10.10.0.0/16,nexthop\u003d192.168.71.254"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1af94dfe_1dc0bd7a","line":198,"in_reply_to":"1af94dfe_ef48298a","updated":"2016-03-17 08:02:47.000000000","message":"Done","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2d24e060c9d6af71a2c687b3a64834ac789b32ae","unresolved":false,"context_lines":[{"line_number":152,"context_line":".. code:: bash"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    os subnet set"},{"line_number":155,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":156,"context_line":"        [--allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e]"},{"line_number":157,"context_line":"        [--dhcp | --no-dhcp]"},{"line_number":158,"context_line":"        [--dns-nameserver \u003cdns_nameserver\u003e]"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1af94dfe_c693dc59","line":155,"updated":"2016-03-18 12:44:14.000000000","message":"I don\u0027t think you can change the project after create.","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"dd76b5e40a7de545255479df88d9900c2ba9d407","unresolved":false,"context_lines":[{"line_number":152,"context_line":".. code:: bash"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    os subnet set"},{"line_number":155,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":156,"context_line":"        [--allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e]"},{"line_number":157,"context_line":"        [--dhcp | --no-dhcp]"},{"line_number":158,"context_line":"        [--dns-nameserver \u003cdns_nameserver\u003e]"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_a2544621","line":155,"in_reply_to":"1af94dfe_c693dc59","updated":"2016-03-22 02:25:55.000000000","message":"Done","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2d24e060c9d6af71a2c687b3a64834ac789b32ae","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":156,"context_line":"        [--allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e]"},{"line_number":157,"context_line":"        [--dhcp | --no-dhcp]"},{"line_number":158,"context_line":"        [--dns-nameserver \u003cdns_nameserver\u003e]"},{"line_number":159,"context_line":"        [--gateway \u003cgateway_ip\u003e]"},{"line_number":160,"context_line":"        [--host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e]"},{"line_number":161,"context_line":"        [--name \u003cnew_name\u003e]"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1af94dfe_c6a11c96","line":158,"updated":"2016-03-18 12:44:14.000000000","message":"Please use - instead of _","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"dd76b5e40a7de545255479df88d9900c2ba9d407","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":156,"context_line":"        [--allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e]"},{"line_number":157,"context_line":"        [--dhcp | --no-dhcp]"},{"line_number":158,"context_line":"        [--dns-nameserver \u003cdns_nameserver\u003e]"},{"line_number":159,"context_line":"        [--gateway \u003cgateway_ip\u003e]"},{"line_number":160,"context_line":"        [--host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e]"},{"line_number":161,"context_line":"        [--name \u003cnew_name\u003e]"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_02325210","line":158,"in_reply_to":"1af94dfe_c6a11c96","updated":"2016-03-22 02:25:55.000000000","message":"Done","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2d24e060c9d6af71a2c687b3a64834ac789b32ae","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        [--allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e]"},{"line_number":157,"context_line":"        [--dhcp | --no-dhcp]"},{"line_number":158,"context_line":"        [--dns-nameserver \u003cdns_nameserver\u003e]"},{"line_number":159,"context_line":"        [--gateway \u003cgateway_ip\u003e]"},{"line_number":160,"context_line":"        [--host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e]"},{"line_number":161,"context_line":"        [--name \u003cnew_name\u003e]"},{"line_number":162,"context_line":"        \u003csubnet\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1af94dfe_46bcecba","line":159,"updated":"2016-03-18 12:44:14.000000000","message":"Please use - instead of _","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"dd76b5e40a7de545255479df88d9900c2ba9d407","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        [--allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e]"},{"line_number":157,"context_line":"        [--dhcp | --no-dhcp]"},{"line_number":158,"context_line":"        [--dns-nameserver \u003cdns_nameserver\u003e]"},{"line_number":159,"context_line":"        [--gateway \u003cgateway_ip\u003e]"},{"line_number":160,"context_line":"        [--host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e]"},{"line_number":161,"context_line":"        [--name \u003cnew_name\u003e]"},{"line_number":162,"context_line":"        \u003csubnet\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_e2347efc","line":159,"in_reply_to":"1af94dfe_46bcecba","updated":"2016-03-22 02:25:55.000000000","message":"Done","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2d24e060c9d6af71a2c687b3a64834ac789b32ae","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        [--dns-nameserver \u003cdns_nameserver\u003e]"},{"line_number":159,"context_line":"        [--gateway \u003cgateway_ip\u003e]"},{"line_number":160,"context_line":"        [--host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e]"},{"line_number":161,"context_line":"        [--name \u003cnew_name\u003e]"},{"line_number":162,"context_line":"        \u003csubnet\u003e"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1af94dfe_46e34cd9","line":161,"updated":"2016-03-18 12:44:14.000000000","message":"Please use - instead of _","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"dd76b5e40a7de545255479df88d9900c2ba9d407","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        [--dns-nameserver \u003cdns_nameserver\u003e]"},{"line_number":159,"context_line":"        [--gateway \u003cgateway_ip\u003e]"},{"line_number":160,"context_line":"        [--host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e]"},{"line_number":161,"context_line":"        [--name \u003cnew_name\u003e]"},{"line_number":162,"context_line":"        \u003csubnet\u003e"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_423c4ae2","line":161,"in_reply_to":"1af94dfe_46e34cd9","updated":"2016-03-22 02:25:55.000000000","message":"Done","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2d24e060c9d6af71a2c687b3a64834ac789b32ae","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":".. option:: --gateway \u003cgateway\u003e"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"     Updated information of the gateway for this subnet"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":".. option:: --host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1af94dfe_06edc4b6","line":192,"updated":"2016-03-18 12:44:14.000000000","message":"Please update to be similar to create.","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"dd76b5e40a7de545255479df88d9900c2ba9d407","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":".. option:: --gateway \u003cgateway\u003e"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"     Updated information of the gateway for this subnet"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":".. option:: --host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_c2597a5c","line":192,"in_reply_to":"1af94dfe_06edc4b6","updated":"2016-03-22 02:25:55.000000000","message":"Updated - Similar to create","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"79e8e3b0fe959d7c7c17c0845d8ef2ae1506dd4c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        [--allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e]"},{"line_number":156,"context_line":"        [--dhcp | --no-dhcp]"},{"line_number":157,"context_line":"        [--dns-nameserver \u003cdns-nameserver\u003e]"},{"line_number":158,"context_line":"        [--gateway \u003cgateway-ip\u003e]"},{"line_number":159,"context_line":"        [--host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e]"},{"line_number":160,"context_line":"        [--name \u003cnew-name\u003e]"},{"line_number":161,"context_line":"        \u003csubnet\u003e"}],"source_content_type":"text/x-rst","patch_set":13,"id":"fa0719c6_e21c41c3","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":31},"updated":"2016-03-23 02:55:25.000000000","message":"nit: the value should be consistent with \"metavar\" in subnet.py, right?","commit_id":"29522638562e2a0811649df00c13273499143967"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"79e8e3b0fe959d7c7c17c0845d8ef2ae1506dd4c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        [--dns-nameserver \u003cdns-nameserver\u003e]"},{"line_number":158,"context_line":"        [--gateway \u003cgateway-ip\u003e]"},{"line_number":159,"context_line":"        [--host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e]"},{"line_number":160,"context_line":"        [--name \u003cnew-name\u003e]"},{"line_number":161,"context_line":"        \u003csubnet\u003e"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":13,"id":"fa0719c6_427a4df2","line":160,"range":{"start_line":160,"start_character":17,"end_line":160,"end_character":25},"updated":"2016-03-23 02:55:25.000000000","message":"ditto","commit_id":"29522638562e2a0811649df00c13273499143967"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"94a585f087e669557079b780d199b3aaf47b31b3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    List additional fields in output"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"subnet set"},{"line_number":147,"context_line":"--------------"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"Set subnet properties"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"fa0719c6_55cca269","line":147,"updated":"2016-03-23 16:21:36.000000000","message":"nit...extra dashes","commit_id":"477d69e84baed8d06a3aa319eb4eab016058fc35"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"94a585f087e669557079b780d199b3aaf47b31b3","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        [--name \u003cnew-name\u003e]"},{"line_number":161,"context_line":"        \u003csubnet\u003e"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":".. option:: --project \u003cproject\u003e"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    Owner\u0027s project (name or ID)"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"fa0719c6_d5c8b224","line":163,"updated":"2016-03-23 16:21:36.000000000","message":"There is no --project option on set.","commit_id":"477d69e84baed8d06a3aa319eb4eab016058fc35"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"94a585f087e669557079b780d199b3aaf47b31b3","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    Owner\u0027s project (name or ID)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. option:: --project-domain \u003cproject-domain\u003e"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    Domain the project belongs to (name or ID)."},{"line_number":170,"context_line":"    This can be used in case collisions between project names exist."}],"source_content_type":"text/x-rst","patch_set":14,"id":"fa0719c6_95e3daa3","line":167,"updated":"2016-03-23 16:21:36.000000000","message":"There is no --project-domain option on set.","commit_id":"477d69e84baed8d06a3aa319eb4eab016058fc35"}],"openstackclient/network/v2/subnet.py":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"1563ca86b32630267ff50564997f0ab30632e166","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            help\u003d\"Updated information of the gateway for this subnet\""},{"line_number":355,"context_line":"        )"},{"line_number":356,"context_line":"        gateway.add_argument("},{"line_number":357,"context_line":"            \u0027--no-gateway\u0027,"},{"line_number":358,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":359,"context_line":"            help\u003d\"Remove gateway information from the subnet\")"},{"line_number":360,"context_line":"        _get_common_parse_arguments(parser)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_70aa3672","line":357,"updated":"2016-03-15 13:32:09.000000000","message":"In the create we decided to NOT use a \"--no-gateway\" flag, and instead use --gateway auto, --gateway none, or --gateway \u003cip_address\u003e.  For consistency it makes sense to also do that for the \"set\", and NOT have a --no-gateway flag.  I think this can be done by just using the --gateway flag as the create does, with the differences being:\n\n1) on subnet set the user can NOT specify \u0027auto\u0027.  The two valid options are \u0027none\u0027 or an ip address.\n2) on subnet set if the user does not specify --gateway, then that is interpreted as \"no change to current gateway setting\"","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"58b5720bcaaa359d7addd8b26055dda08bb8ea3b","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            help\u003d\"Updated information of the gateway for this subnet\""},{"line_number":355,"context_line":"        )"},{"line_number":356,"context_line":"        gateway.add_argument("},{"line_number":357,"context_line":"            \u0027--no-gateway\u0027,"},{"line_number":358,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":359,"context_line":"            help\u003d\"Remove gateway information from the subnet\")"},{"line_number":360,"context_line":"        _get_common_parse_arguments(parser)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_fdb51131","line":357,"in_reply_to":"1af94dfe_70aa3672","updated":"2016-03-17 08:02:47.000000000","message":"Perfectly understandable","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"b33b75b1de2d3a1d0ef992cb11cf51b87de9addb","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        gateway.add_argument("},{"line_number":357,"context_line":"            \u0027--no-gateway\u0027,"},{"line_number":358,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":359,"context_line":"            help\u003d\"Remove gateway information from the subnet\")"},{"line_number":360,"context_line":"        _get_common_parse_arguments(parser)"},{"line_number":361,"context_line":"        return parser"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3afc51ec_cc2a1f90","line":359,"range":{"start_line":359,"start_character":61,"end_line":359,"end_character":62},"updated":"2016-03-15 05:23:25.000000000","message":"nit: Change a line to keep the consistence.","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"b33b75b1de2d3a1d0ef992cb11cf51b87de9addb","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def take_action(self, parsed_args):"},{"line_number":364,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":365,"context_line":"        obj \u003d client.find_subnet(parsed_args.subnet, ignore_missing\u003dFalse)"},{"line_number":366,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args, False)"},{"line_number":367,"context_line":"        if parsed_args.no_gateway:"},{"line_number":368,"context_line":"            attrs[\u0027gateway_ip\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afc51ec_cf2fb186","line":365,"range":{"start_line":365,"start_character":8,"end_line":365,"end_character":74},"updated":"2016-03-15 05:23:25.000000000","message":"Dean has posted the error handling rules here:\nhttps://review.openstack.org/#/c/290785/\n\nWe\u0027d better follow the rules when doing multiple REST API calls. But since this patch is a little big to me, feel free to enhance it in another patch.\n\nPlease refer to: \nhttps://bugs.launchpad.net/python-openstackclient/+bug/1556719","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8657598a2a97b85b552339294035524904c3906e","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    def take_action(self, parsed_args):"},{"line_number":364,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":365,"context_line":"        obj \u003d client.find_subnet(parsed_args.subnet, ignore_missing\u003dFalse)"},{"line_number":366,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args, False)"},{"line_number":367,"context_line":"        if parsed_args.no_gateway:"},{"line_number":368,"context_line":"            attrs[\u0027gateway_ip\u0027] \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_bba027a7","line":365,"range":{"start_line":365,"start_character":8,"end_line":365,"end_character":74},"in_reply_to":"3afc51ec_cf2fb186","updated":"2016-03-15 11:20:56.000000000","message":"This doesn\u0027t apply here.  If the subnet doesn\u0027t exist, there\u0027s not point in continuing.","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"1563ca86b32630267ff50564997f0ab30632e166","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":365,"context_line":"        obj \u003d client.find_subnet(parsed_args.subnet, ignore_missing\u003dFalse)"},{"line_number":366,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args, False)"},{"line_number":367,"context_line":"        if parsed_args.no_gateway:"},{"line_number":368,"context_line":"            attrs[\u0027gateway_ip\u0027] \u003d None"},{"line_number":369,"context_line":"        elif parsed_args.gateway:"},{"line_number":370,"context_line":"            _get_gateway_params(attrs, parsed_args.gateway.lower())"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_10fe526b","line":367,"updated":"2016-03-15 13:32:09.000000000","message":"See my comment above, I don\u0027t think we should use --no-gateway","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8a27242aba3d6b8388c748f9a60aa55ecd835a94","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                attrs[\u0027gateway_ip\u0027] \u003d None"},{"line_number":152,"context_line":"            else:"},{"line_number":153,"context_line":"                attrs[\u0027gateway_ip\u0027] \u003d gateway"},{"line_number":154,"context_line":"    if \u0027allocation_pools\u0027 in parsed_args and \\"},{"line_number":155,"context_line":"       parsed_args.allocation_pools is not None:"},{"line_number":156,"context_line":"        attrs[\u0027allocation_pools\u0027] \u003d parsed_args.allocation_pools"},{"line_number":157,"context_line":"    if parsed_args.enable_dhcp is not None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_32868365","line":154,"range":{"start_line":154,"start_character":45,"end_line":154,"end_character":46},"updated":"2016-03-17 08:32:57.000000000","message":"please use brackets instead of backslash\n\nref:\n\nhttp://docs.openstack.org/developer/hacking/#general","commit_id":"8ed82fc121622b08c0ac382f86248655986395e3"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8a27242aba3d6b8388c748f9a60aa55ecd835a94","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        attrs[\u0027allocation_pools\u0027] \u003d parsed_args.allocation_pools"},{"line_number":157,"context_line":"    if parsed_args.enable_dhcp is not None:"},{"line_number":158,"context_line":"        attrs[\u0027enable_dhcp\u0027] \u003d parsed_args.enable_dhcp"},{"line_number":159,"context_line":"    if \u0027dns_nameservers\u0027 in parsed_args and \\"},{"line_number":160,"context_line":"       parsed_args.dns_nameservers is not None:"},{"line_number":161,"context_line":"        attrs[\u0027dns_nameservers\u0027] \u003d parsed_args.dns_nameservers"},{"line_number":162,"context_line":"    if \u0027host_routes\u0027 in parsed_args and parsed_args.host_routes is not None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_f2689b89","line":159,"range":{"start_line":159,"start_character":44,"end_line":159,"end_character":45},"updated":"2016-03-17 08:32:57.000000000","message":"ditto","commit_id":"8ed82fc121622b08c0ac382f86248655986395e3"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"655906e9447167a177722720edd712ea62f48d07","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        if not is_create and gateway \u003d\u003d \u0027auto\u0027:"},{"line_number":146,"context_line":"            raise exceptions.CommandError(\"Auto option is not available\""},{"line_number":147,"context_line":"                                          \"for Subnet Set. Valid options are\""},{"line_number":148,"context_line":"                                          \" \u003cip-address\u003e or None\")"},{"line_number":149,"context_line":"        elif gateway !\u003d \u0027auto\u0027:"},{"line_number":150,"context_line":"            if gateway \u003d\u003d \u0027none\u0027:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_c638fcd5","line":147,"range":{"start_line":147,"start_character":43,"end_line":147,"end_character":46},"updated":"2016-03-18 12:38:14.000000000","message":"nit: Need a space here.","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"655906e9447167a177722720edd712ea62f48d07","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":337,"context_line":"            help\u003d\u0027Update Subnet name\u0027,"},{"line_number":338,"context_line":"        )"},{"line_number":339,"context_line":"        dhcp_enable_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":340,"context_line":"        dhcp_enable_group.add_argument("},{"line_number":341,"context_line":"            \u0027--dhcp\u0027,"},{"line_number":342,"context_line":"            dest\u003d\u0027enable_dhcp\u0027,"},{"line_number":343,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":344,"context_line":"            default\u003dNone,"},{"line_number":345,"context_line":"            help\u003d\u0027Enable DHCP\u0027,"},{"line_number":346,"context_line":"        )"},{"line_number":347,"context_line":"        dhcp_enable_group.add_argument("},{"line_number":348,"context_line":"            \u0027--no-dhcp\u0027,"},{"line_number":349,"context_line":"            dest\u003d\u0027enable_dhcp\u0027,"},{"line_number":350,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":351,"context_line":"            help\u003d\u0027Disable DHCP\u0027,"},{"line_number":352,"context_line":"        )"},{"line_number":353,"context_line":"        gateway \u003d parser.add_mutually_exclusive_group()"},{"line_number":354,"context_line":"        gateway.add_argument("},{"line_number":355,"context_line":"            \u0027--gateway\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_0f867ada","line":352,"range":{"start_line":339,"start_character":0,"end_line":352,"end_character":9},"updated":"2016-03-18 12:38:14.000000000","message":"Please refer to http://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options\n\nJust remove dest, and make both action \"store_true\".","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2d24e060c9d6af71a2c687b3a64834ac789b32ae","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":351,"context_line":"            help\u003d\u0027Disable DHCP\u0027,"},{"line_number":352,"context_line":"        )"},{"line_number":353,"context_line":"        gateway \u003d parser.add_mutually_exclusive_group()"},{"line_number":354,"context_line":"        gateway.add_argument("},{"line_number":355,"context_line":"            \u0027--gateway\u0027,"},{"line_number":356,"context_line":"            metavar\u003d\u0027\u003cgateway\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_469b4c18","line":353,"updated":"2016-03-18 12:44:14.000000000","message":"Why a mutually exclusive group when it isn\u0027t used?","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"9798195b8d7249810be941be9c3477bb17eaab33","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":351,"context_line":"            help\u003d\u0027Disable DHCP\u0027,"},{"line_number":352,"context_line":"        )"},{"line_number":353,"context_line":"        gateway \u003d parser.add_mutually_exclusive_group()"},{"line_number":354,"context_line":"        gateway.add_argument("},{"line_number":355,"context_line":"            \u0027--gateway\u0027,"},{"line_number":356,"context_line":"            metavar\u003d\u0027\u003cgateway\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa0719c6_402c5b4a","line":353,"in_reply_to":"1af94dfe_469b4c18","updated":"2016-03-21 15:52:38.000000000","message":"+1.  I think this is just left over from when --no-gateway was an option, and should be removed now","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"dd76b5e40a7de545255479df88d9900c2ba9d407","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":351,"context_line":"            help\u003d\u0027Disable DHCP\u0027,"},{"line_number":352,"context_line":"        )"},{"line_number":353,"context_line":"        gateway \u003d parser.add_mutually_exclusive_group()"},{"line_number":354,"context_line":"        gateway.add_argument("},{"line_number":355,"context_line":"            \u0027--gateway\u0027,"},{"line_number":356,"context_line":"            metavar\u003d\u0027\u003cgateway\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa0719c6_250de037","line":353,"in_reply_to":"fa0719c6_402c5b4a","updated":"2016-03-22 02:25:55.000000000","message":"Done","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"655906e9447167a177722720edd712ea62f48d07","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        gateway.add_argument("},{"line_number":355,"context_line":"            \u0027--gateway\u0027,"},{"line_number":356,"context_line":"            metavar\u003d\u0027\u003cgateway\u003e\u0027,"},{"line_number":357,"context_line":"            help\u003d\"Updated information of the gateway for this subnet\""},{"line_number":358,"context_line":"        )"},{"line_number":359,"context_line":"        _get_common_parse_arguments(parser)"},{"line_number":360,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_efb7ced5","line":357,"range":{"start_line":357,"start_character":18,"end_line":357,"end_character":68},"updated":"2016-03-18 12:38:14.000000000","message":"I suggest add auto and none doc here.","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"9798195b8d7249810be941be9c3477bb17eaab33","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        gateway.add_argument("},{"line_number":355,"context_line":"            \u0027--gateway\u0027,"},{"line_number":356,"context_line":"            metavar\u003d\u0027\u003cgateway\u003e\u0027,"},{"line_number":357,"context_line":"            help\u003d\"Updated information of the gateway for this subnet\""},{"line_number":358,"context_line":"        )"},{"line_number":359,"context_line":"        _get_common_parse_arguments(parser)"},{"line_number":360,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa0719c6_40d3bb38","line":357,"range":{"start_line":357,"start_character":18,"end_line":357,"end_character":68},"in_reply_to":"1af94dfe_efb7ced5","updated":"2016-03-21 15:52:38.000000000","message":"+1.  See CreateSubnet.get_parser() in this file for an example (but remove the \u0027auto\u0027 references)","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"dd76b5e40a7de545255479df88d9900c2ba9d407","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        gateway.add_argument("},{"line_number":355,"context_line":"            \u0027--gateway\u0027,"},{"line_number":356,"context_line":"            metavar\u003d\u0027\u003cgateway\u003e\u0027,"},{"line_number":357,"context_line":"            help\u003d\"Updated information of the gateway for this subnet\""},{"line_number":358,"context_line":"        )"},{"line_number":359,"context_line":"        _get_common_parse_arguments(parser)"},{"line_number":360,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa0719c6_8514ac44","line":357,"range":{"start_line":357,"start_character":18,"end_line":357,"end_character":68},"in_reply_to":"fa0719c6_40d3bb38","updated":"2016-03-22 02:25:55.000000000","message":"Done","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2d24e060c9d6af71a2c687b3a64834ac789b32ae","unresolved":false,"context_lines":[{"line_number":362,"context_line":"    def take_action(self, parsed_args):"},{"line_number":363,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":364,"context_line":"        obj \u003d client.find_subnet(parsed_args.subnet, ignore_missing\u003dFalse)"},{"line_number":365,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args, False)"},{"line_number":366,"context_line":"        if not attrs:"},{"line_number":367,"context_line":"            msg \u003d \"Nothing specified to be set\""},{"line_number":368,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_a9082129","line":365,"updated":"2016-03-18 12:44:14.000000000","message":"nit...the code is more readable when using \"is_create\u003dFalse\" instead of just False.","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"dd76b5e40a7de545255479df88d9900c2ba9d407","unresolved":false,"context_lines":[{"line_number":362,"context_line":"    def take_action(self, parsed_args):"},{"line_number":363,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":364,"context_line":"        obj \u003d client.find_subnet(parsed_args.subnet, ignore_missing\u003dFalse)"},{"line_number":365,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args, False)"},{"line_number":366,"context_line":"        if not attrs:"},{"line_number":367,"context_line":"            msg \u003d \"Nothing specified to be set\""},{"line_number":368,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa0719c6_a519f07b","line":365,"in_reply_to":"1af94dfe_a9082129","updated":"2016-03-22 02:25:55.000000000","message":"Done","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"79e8e3b0fe959d7c7c17c0845d8ef2ae1506dd4c","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        )"},{"line_number":334,"context_line":"        parser.add_argument("},{"line_number":335,"context_line":"            \u0027--name\u0027,"},{"line_number":336,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":337,"context_line":"            help\u003d\u0027Update Subnet name\u0027,"},{"line_number":338,"context_line":"        )"},{"line_number":339,"context_line":"        dhcp_enable_group \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_227d99e7","line":336,"range":{"start_line":336,"start_character":22,"end_line":336,"end_character":26},"updated":"2016-03-23 02:55:25.000000000","message":"here","commit_id":"29522638562e2a0811649df00c13273499143967"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"79e8e3b0fe959d7c7c17c0845d8ef2ae1506dd4c","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        )"},{"line_number":351,"context_line":"        parser.add_argument("},{"line_number":352,"context_line":"            \u0027--gateway\u0027,"},{"line_number":353,"context_line":"            metavar\u003d\u0027\u003cgateway\u003e\u0027,"},{"line_number":354,"context_line":"            help\u003d\"Specify a gateway for the subnet. The options are: \""},{"line_number":355,"context_line":"                 \"  \u003cip-address\u003e: Specific IP address to use as the gateway \""},{"line_number":356,"context_line":"                 \"  \u0027none\u0027:       This subnet will not use a gateway \""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa0719c6_828465d4","line":353,"range":{"start_line":353,"start_character":22,"end_line":353,"end_character":29},"updated":"2016-03-23 02:55:25.000000000","message":"here","commit_id":"29522638562e2a0811649df00c13273499143967"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"94a585f087e669557079b780d199b3aaf47b31b3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    if \u0027name\u0027 in parsed_args and parsed_args.name is not None:"},{"line_number":110,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if \u0027project\u0027 in parsed_args and parsed_args.project is not None:"},{"line_number":113,"context_line":"        identity_client \u003d client_manager.identity"},{"line_number":114,"context_line":"        project_id \u003d identity_common.find_project("},{"line_number":115,"context_line":"            identity_client,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa0719c6_20dbaa50","line":112,"updated":"2016-03-23 16:21:36.000000000","message":"This should be part of is_create group below.","commit_id":"477d69e84baed8d06a3aa319eb4eab016058fc35"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"94a585f087e669557079b780d199b3aaf47b31b3","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        parser.add_argument("},{"line_number":335,"context_line":"            \u0027--name\u0027,"},{"line_number":336,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":337,"context_line":"            help\u003d\u0027Update Subnet name\u0027,"},{"line_number":338,"context_line":"        )"},{"line_number":339,"context_line":"        dhcp_enable_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":340,"context_line":"        dhcp_enable_group.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"fa0719c6_6043e242","line":337,"updated":"2016-03-23 16:21:36.000000000","message":"Please update to match the doc.","commit_id":"477d69e84baed8d06a3aa319eb4eab016058fc35"}],"openstackclient/tests/network/v2/test_subnet.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a9a9e36bd6c9236ade01dfdc166bcf15732ef3c8","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        self.network.find_subnet \u003d mock.Mock(return_value\u003dself._subnet)"},{"line_number":481,"context_line":"        self.cmd \u003d subnet_v2.SetSubnet(self.app, self.namespace)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def test_set_this(self):"},{"line_number":484,"context_line":"        arglist \u003d ["},{"line_number":485,"context_line":"            self._subnet.name,"},{"line_number":486,"context_line":"            \"--name\", \"new_subnet\","}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_aa860f63","line":483,"updated":"2016-03-15 12:48:41.000000000","message":"I think it would be good to test all options if not too much trouble.","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"58b5720bcaaa359d7addd8b26055dda08bb8ea3b","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        self.network.find_subnet \u003d mock.Mock(return_value\u003dself._subnet)"},{"line_number":481,"context_line":"        self.cmd \u003d subnet_v2.SetSubnet(self.app, self.namespace)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def test_set_this(self):"},{"line_number":484,"context_line":"        arglist \u003d ["},{"line_number":485,"context_line":"            self._subnet.name,"},{"line_number":486,"context_line":"            \"--name\", \"new_subnet\","}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_e342943d","line":483,"in_reply_to":"1af94dfe_aa860f63","updated":"2016-03-17 08:02:47.000000000","message":"Except host-routes, everything else is covered I believe.","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a9a9e36bd6c9236ade01dfdc166bcf15732ef3c8","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def test_set_this(self):"},{"line_number":484,"context_line":"        arglist \u003d ["},{"line_number":485,"context_line":"            self._subnet.name,"},{"line_number":486,"context_line":"            \"--name\", \"new_subnet\","},{"line_number":487,"context_line":"            \"--dhcp\","},{"line_number":488,"context_line":"            \"--gateway\", self._subnet.gateway_ip,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_ca739bb3","line":485,"updated":"2016-03-15 12:48:41.000000000","message":"Positional arguments should come after the options.","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"58b5720bcaaa359d7addd8b26055dda08bb8ea3b","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def test_set_this(self):"},{"line_number":484,"context_line":"        arglist \u003d ["},{"line_number":485,"context_line":"            self._subnet.name,"},{"line_number":486,"context_line":"            \"--name\", \"new_subnet\","},{"line_number":487,"context_line":"            \"--dhcp\","},{"line_number":488,"context_line":"            \"--gateway\", self._subnet.gateway_ip,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_3d1659a7","line":485,"in_reply_to":"1af94dfe_ca739bb3","updated":"2016-03-17 08:02:47.000000000","message":"I referred the Create_Subnet class above.. there we have the Positional Argument before the optionals","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a9a9e36bd6c9236ade01dfdc166bcf15732ef3c8","unresolved":false,"context_lines":[{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def test_set_that(self):"},{"line_number":508,"context_line":"        arglist \u003d ["},{"line_number":509,"context_line":"            self._subnet.name,"},{"line_number":510,"context_line":"            \"--name\", \"new_subnet\","},{"line_number":511,"context_line":"            \"--no-dhcp\","},{"line_number":512,"context_line":"            \"--no-gateway\","}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_2a65dfe0","line":509,"updated":"2016-03-15 12:48:41.000000000","message":"Positional arguments should come after the options.","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"b33b75b1de2d3a1d0ef992cb11cf51b87de9addb","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    def test_set_nothing(self):"},{"line_number":532,"context_line":"        arglist \u003d [self._subnet.name, ]"},{"line_number":533,"context_line":"        verifylist \u003d [(\u0027subnet\u0027, self._subnet.name), ]"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":536,"context_line":"        self.assertRaises(exceptions.CommandError, self.cmd.take_action,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afc51ec_8fdc8974","line":533,"range":{"start_line":533,"start_character":51,"end_line":533,"end_character":53},"updated":"2016-03-15 05:23:25.000000000","message":"nit: Do not need an extra \u0027,\u0027 if the list is in one line.","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"58b5720bcaaa359d7addd8b26055dda08bb8ea3b","unresolved":false,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    def test_set_nothing(self):"},{"line_number":532,"context_line":"        arglist \u003d [self._subnet.name, ]"},{"line_number":533,"context_line":"        verifylist \u003d [(\u0027subnet\u0027, self._subnet.name), ]"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":536,"context_line":"        self.assertRaises(exceptions.CommandError, self.cmd.take_action,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1af94dfe_fd1cf1c2","line":533,"range":{"start_line":533,"start_character":51,"end_line":533,"end_character":53},"in_reply_to":"3afc51ec_8fdc8974","updated":"2016-03-17 08:02:47.000000000","message":"Done","commit_id":"0ae1c96accac5197f0258ea53e58e933b6ddd613"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2d24e060c9d6af71a2c687b3a64834ac789b32ae","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        self.assertEqual(self.data_long, list(data))"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"class TestSetSubnet(TestSubnet):"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    _subnet \u003d network_fakes.FakeSubnet.create_one_subnet()"},{"line_number":476,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_6663e842","line":473,"updated":"2016-03-18 12:44:14.000000000","message":"Please also enable the functional test for \"subnet set\".","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"dd76b5e40a7de545255479df88d9900c2ba9d407","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        self.assertEqual(self.data_long, list(data))"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"class TestSetSubnet(TestSubnet):"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    _subnet \u003d network_fakes.FakeSubnet.create_one_subnet()"},{"line_number":476,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa0719c6_e59e48b7","line":473,"in_reply_to":"1af94dfe_6663e842","updated":"2016-03-22 02:25:55.000000000","message":"How?","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"759a856422c81f59df6d86a42a23ae1e7ca9be4d","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        self.assertEqual(self.data_long, list(data))"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"class TestSetSubnet(TestSubnet):"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    _subnet \u003d network_fakes.FakeSubnet.create_one_subnet()"},{"line_number":476,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa0719c6_bc68e988","line":473,"in_reply_to":"fa0719c6_e59e48b7","updated":"2016-03-22 07:17:53.000000000","message":"Functional tests are in functional/tests/. You can refer to the existing tests for help.","commit_id":"2aef5e5ff44714e0ed8c84946fd95596f0695b7a"}],"releasenotes/notes/subnet-set-bbc26ecc16929302.yaml":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"09bd715d171ce7df4112f4a0250af39691d04720","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``subnet set`` command to openstack-client."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dae33548_0f9aa3c5","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":51},"updated":"2016-02-19 08:19:24.000000000","message":"Please also add the bug report link here, like this:\n\nhttps://review.openstack.org/#/c/279918/7/releasenotes/notes/bug-1544589-b9f669ef71aa5e57.yaml","commit_id":"f524ab25065c88300d62869bff3886d70cbc82c3"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8a27242aba3d6b8388c748f9a60aa55ecd835a94","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``subnet create`` command."},{"line_number":5,"context_line":"    [Bug `1542363 \u003chttps://bugs.launchpad.net/bugs/1542363\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1af94dfe_1e31d305","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":24},"updated":"2016-03-17 08:32:57.000000000","message":"nit: s/create/set/","commit_id":"8ed82fc121622b08c0ac382f86248655986395e3"}],"setup.cfg":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"09bd715d171ce7df4112f4a0250af39691d04720","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    security_group_rule_delete \u003d openstackclient.network.v2.security_group_rule:DeleteSecurityGroupRule"},{"line_number":343,"context_line":"    subnet_create \u003d openstackclient.network.v2.subnet:CreateSubnet"},{"line_number":344,"context_line":"    subnet_list \u003d openstackclient.network.v2.subnet:ListSubnet"},{"line_number":345,"context_line":"    subnet_pool_delete \u003d openstackclient.network.v2.subnet_pool:DeleteSubnetPool"},{"line_number":346,"context_line":"    subnet_show \u003d openstackclient.network.v2.subnet:ShowSubnet"},{"line_number":347,"context_line":"    subnet_set \u003d openstackclient.network.v2.subnet:SetSubnet"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"dae33548_2fd048c9","line":345,"range":{"start_line":345,"start_character":4,"end_line":345,"end_character":22},"updated":"2016-02-19 08:19:24.000000000","message":"\"subnet pool\" command should not be between \"subnet\" commands. Please fix it in any patch in this serie.","commit_id":"f524ab25065c88300d62869bff3886d70cbc82c3"}]}