)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"6198c05b0d804fe5e947644a4e26729e2cf299b3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When the openstackclient tries to find a resource from a"},{"line_number":10,"context_line":"project it calls a \u0027get()\u0027 on the manager and passes it the"},{"line_number":11,"context_line":"id_or_name and kwargs. How most get() methods are set up"},{"line_number":12,"context_line":"they only accept an id.  Because this is wrapped in a try"},{"line_number":13,"context_line":"no one has noticed there is a problem. This fix adds another"},{"line_number":14,"context_line":"call to the manager with no kwarks if a TypeError is returned."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dae33548_f3330f12","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":22},"updated":"2016-02-18 16:54:20.000000000","message":"nit: add \"or name, and not kwargs\" Took me a while to realize you were indicating they don\u0027t accept kwargs.","commit_id":"900e48cf073e29312a7fc60402ad5cea1c30a615"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"945411ecbb59a960359ac627492de26ea6f43679","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When the openstackclient tries to find a resource from a"},{"line_number":10,"context_line":"project it calls a \u0027get()\u0027 on the manager and passes it the"},{"line_number":11,"context_line":"id_or_name and kwargs. How most get() methods are set up"},{"line_number":12,"context_line":"they only accept an id.  Because this is wrapped in a try"},{"line_number":13,"context_line":"no one has noticed there is a problem. This fix adds another"},{"line_number":14,"context_line":"call to the manager with no kwarks if a TypeError is returned."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dae33548_d397eae9","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":22},"in_reply_to":"dae33548_f3330f12","updated":"2016-02-18 17:04:49.000000000","message":"Done","commit_id":"900e48cf073e29312a7fc60402ad5cea1c30a615"},{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"6c5ad585156d63a8fdc5775e4ce45d347796cf0d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"id_or_name and kwargs. How most get() methods are set up"},{"line_number":12,"context_line":"they only accept an id.  Because this is wrapped in a try"},{"line_number":13,"context_line":"no one has noticed there is a problem. This fix adds another"},{"line_number":14,"context_line":"call to the manager with no kwarks if a TypeError is returned."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7033239049ff42f6ac615713adfd1a88d9f804af"},{"line_number":17,"context_line":"Closes-Bug: #1546663"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dae33548_a705c514","line":14,"range":{"start_line":14,"start_character":28,"end_line":14,"end_character":34},"updated":"2016-02-18 16:08:26.000000000","message":"kwags*","commit_id":"900e48cf073e29312a7fc60402ad5cea1c30a615"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"945411ecbb59a960359ac627492de26ea6f43679","unresolved":false,"context_lines":[{"line_number":11,"context_line":"id_or_name and kwargs. How most get() methods are set up"},{"line_number":12,"context_line":"they only accept an id.  Because this is wrapped in a try"},{"line_number":13,"context_line":"no one has noticed there is a problem. This fix adds another"},{"line_number":14,"context_line":"call to the manager with no kwarks if a TypeError is returned."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7033239049ff42f6ac615713adfd1a88d9f804af"},{"line_number":17,"context_line":"Closes-Bug: #1546663"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dae33548_f3a02e44","line":14,"range":{"start_line":14,"start_character":28,"end_line":14,"end_character":34},"in_reply_to":"dae33548_7d750e62","updated":"2016-02-18 17:04:49.000000000","message":"Done","commit_id":"900e48cf073e29312a7fc60402ad5cea1c30a615"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"945411ecbb59a960359ac627492de26ea6f43679","unresolved":false,"context_lines":[{"line_number":11,"context_line":"id_or_name and kwargs. How most get() methods are set up"},{"line_number":12,"context_line":"they only accept an id.  Because this is wrapped in a try"},{"line_number":13,"context_line":"no one has noticed there is a problem. This fix adds another"},{"line_number":14,"context_line":"call to the manager with no kwarks if a TypeError is returned."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7033239049ff42f6ac615713adfd1a88d9f804af"},{"line_number":17,"context_line":"Closes-Bug: #1546663"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dae33548_b39a2612","line":14,"range":{"start_line":14,"start_character":28,"end_line":14,"end_character":34},"in_reply_to":"dae33548_a705c514","updated":"2016-02-18 17:04:49.000000000","message":"Done","commit_id":"900e48cf073e29312a7fc60402ad5cea1c30a615"},{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"e9ff7cba2dc67e956038393256505445f1fa40b5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"id_or_name and kwargs. How most get() methods are set up"},{"line_number":12,"context_line":"they only accept an id.  Because this is wrapped in a try"},{"line_number":13,"context_line":"no one has noticed there is a problem. This fix adds another"},{"line_number":14,"context_line":"call to the manager with no kwarks if a TypeError is returned."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7033239049ff42f6ac615713adfd1a88d9f804af"},{"line_number":17,"context_line":"Closes-Bug: #1546663"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dae33548_7d750e62","line":14,"range":{"start_line":14,"start_character":28,"end_line":14,"end_character":34},"in_reply_to":"dae33548_a705c514","updated":"2016-02-18 16:08:54.000000000","message":"Wow, kwargs*","commit_id":"900e48cf073e29312a7fc60402ad5cea1c30a615"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"362e0ef9e41356657c1fc117403eb86d186030c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     da3d6529 (Define FakeFloatingIP class in tests/compute for nova network commands)"},{"line_number":2,"context_line":"Author:     Your Name \u003cyou@example.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-02-17 14:53:48 -0600"},{"line_number":4,"context_line":"Commit:     Tom Cocozzello \u003ctjcocozz@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-18 17:03:42 +0000"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9aed3d3a_c93ac0e6","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":39},"updated":"2016-03-01 06:25:10.000000000","message":"very kind of \"your name\" to submit this patch :)","commit_id":"4f788d290f036b2f112027cb5bcb5d2e8d4163ae"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"915c4ef05c55ed2a0538e2269b4596f1945ac321","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     da3d6529 (Define FakeFloatingIP class in tests/compute for nova network commands)"},{"line_number":2,"context_line":"Author:     Your Name \u003cyou@example.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-02-17 14:53:48 -0600"},{"line_number":4,"context_line":"Commit:     Tom Cocozzello \u003ctjcocozz@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-18 17:03:42 +0000"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7af24918_cc1722ec","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":39},"in_reply_to":"7af24918_6f96ce95","updated":"2016-03-01 16:48:44.000000000","message":"gahh! I tried changing in my commit message when i pulled it down but it wont change here. Do you know how to change it?","commit_id":"4f788d290f036b2f112027cb5bcb5d2e8d4163ae"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"eced3bb06653f627d8209fa4bc54da0092befc0e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     da3d6529 (Define FakeFloatingIP class in tests/compute for nova network commands)"},{"line_number":2,"context_line":"Author:     Your Name \u003cyou@example.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-02-17 14:53:48 -0600"},{"line_number":4,"context_line":"Commit:     Tom Cocozzello \u003ctjcocozz@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-18 17:03:42 +0000"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7af24918_6f96ce95","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":39},"in_reply_to":"9aed3d3a_c93ac0e6","updated":"2016-03-01 16:42:46.000000000","message":"lol","commit_id":"4f788d290f036b2f112027cb5bcb5d2e8d4163ae"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"362e0ef9e41356657c1fc117403eb86d186030c7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TypeError when user show user_id and specifiying the domain"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the openstackclient tries to find a resource from a"},{"line_number":10,"context_line":"project it calls a \u0027get()\u0027 on the manager and passes it the"},{"line_number":11,"context_line":"id_or_name and kwargs. How most get() methods are set up"},{"line_number":12,"context_line":"they only accept an id or name, and not kwargs.  Because this is"},{"line_number":13,"context_line":"wrapped in a try no one has noticed there is a problem. This fix"},{"line_number":14,"context_line":"adds another call to the manager with no kwargs if a TypeError"},{"line_number":15,"context_line":"is returned."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7033239049ff42f6ac615713adfd1a88d9f804af"},{"line_number":18,"context_line":"Closes-Bug: #1546663"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9aed3d3a_a9149c4c","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":12},"updated":"2016-03-01 06:25:10.000000000","message":"i think we need to explain why the current method returns a typeError, and why that is bad... and then explain why performing a secondary .get() without the kwargs is an improvement (does it improve performance?)","commit_id":"4f788d290f036b2f112027cb5bcb5d2e8d4163ae"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"813a4f283bc3126410b01694b85442add49c6314","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TypeError when user show user_id and specifiying the domain"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the openstackclient tries to find a resource from a"},{"line_number":10,"context_line":"project it calls a \u0027get()\u0027 on the manager and passes it the"},{"line_number":11,"context_line":"id_or_name and kwargs. How most get() methods are set up"},{"line_number":12,"context_line":"they only accept an id or name, and not kwargs.  Because this is"},{"line_number":13,"context_line":"wrapped in a try no one has noticed there is a problem. This fix"},{"line_number":14,"context_line":"adds another call to the manager with no kwargs if a TypeError"},{"line_number":15,"context_line":"is returned."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7033239049ff42f6ac615713adfd1a88d9f804af"},{"line_number":18,"context_line":"Closes-Bug: #1546663"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7af24918_27e97f1b","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":12},"in_reply_to":"7af24918_69352045","updated":"2016-03-01 16:58:31.000000000","message":"try doing: `git review --author \"Tom Cocozzello \u003ctjcocozz@us.ibm.com\u003e\"`","commit_id":"4f788d290f036b2f112027cb5bcb5d2e8d4163ae"},{"author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"change_message_id":"eced3bb06653f627d8209fa4bc54da0092befc0e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"TypeError when user show user_id and specifiying the domain"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the openstackclient tries to find a resource from a"},{"line_number":10,"context_line":"project it calls a \u0027get()\u0027 on the manager and passes it the"},{"line_number":11,"context_line":"id_or_name and kwargs. How most get() methods are set up"},{"line_number":12,"context_line":"they only accept an id or name, and not kwargs.  Because this is"},{"line_number":13,"context_line":"wrapped in a try no one has noticed there is a problem. This fix"},{"line_number":14,"context_line":"adds another call to the manager with no kwargs if a TypeError"},{"line_number":15,"context_line":"is returned."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7033239049ff42f6ac615713adfd1a88d9f804af"},{"line_number":18,"context_line":"Closes-Bug: #1546663"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7af24918_69352045","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":12},"in_reply_to":"9aed3d3a_a9149c4c","updated":"2016-03-01 16:42:46.000000000","message":"Done. Since we will need to add a second call to the manager with the correct number of arguments (for some) it won\u0027t improve performance","commit_id":"4f788d290f036b2f112027cb5bcb5d2e8d4163ae"}]}