)]}'
{"id":"openstack%2Fpython-openstackclient~282626","triplet_id":"openstack%2Fpython-openstackclient~master~If187f16bfb305ac4fe6e4177e498a06c49c3f946","project":"openstack/python-openstackclient","branch":"master","topic":"fix_mutable_arguments","hashtags":[],"change_id":"If187f16bfb305ac4fe6e4177e498a06c49c3f946","subject":"Fix Mutable default argument","status":"MERGED","created":"2016-02-20 08:37:58.000000000","updated":"2016-02-21 01:31:35.000000000","submitted":"2016-02-21 01:31:34.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4cc3963013083dbdb4964759079dd2b6dfcddcc2","_number":282626,"virtual_id_number":282626,"owner":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-02-21 01:31:34.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-02-21 00:40:13.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-02-20 09:38:05.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2016-02-21 00:40:13.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-20 09:38:05.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-02-21 00:40:13.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-02-21 01:31:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7f53dc72195beb5b0a1bdc18bdb2ed5ab1a63018","author":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"date":"2016-02-20 08:37:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a978f7658fe773bff0d72b836e06f0130b4857c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-20 09:29:24.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/26/282626/1/check/gate-python-openstackclient-pep8/3a252da/ : SUCCESS in 43s\n- gate-python-openstackclient-docs http://logs.openstack.org/26/282626/1/check/gate-python-openstackclient-docs/d935346/ : FAILURE in 30m 30s\n- gate-python-openstackclient-python27 http://logs.openstack.org/26/282626/1/check/gate-python-openstackclient-python27/fe0846b/ : SUCCESS in 1m 24s\n- gate-python-openstackclient-python34 http://logs.openstack.org/26/282626/1/check/gate-python-openstackclient-python34/c6f1010/ : SUCCESS in 1m 52s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/26/282626/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/3c9dd79/ : SUCCESS in 51m 19s\n- check-osc-plugins http://logs.openstack.org/26/282626/1/check/check-osc-plugins/5f5114d/ : SUCCESS in 1m 13s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/26/282626/1/check/gate-osc-dsvm-functional/73f16d6/ : SUCCESS in 17m 11s","accounts_in_message":[],"_revision_number":1},{"id":"71379fe158b4fcf71107d20cc8567762b40646f6","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-20 09:38:05.000000000","message":"Patch Set 1: Code-Review+2\n\nIt won\u0027t be any problem since the parameter is readonly in these two functions. But I agree that we should fix them IMOO. \n\nBut I also want some advice from other core reviewers.\n\nBTW, I notice that in fake.py under each test dir, there are similar problems. Fortunately, they are all readonly.\n\nThanks. :)","accounts_in_message":[],"_revision_number":1},{"id":"914f5068ea7ccba9ec228729687b95533c894d35","author":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"date":"2016-02-20 10:08:41.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"67bf4c4636857e95356b0362f248ceee7ec36d2f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-20 10:54:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/26/282626/1/check/gate-python-openstackclient-pep8/9c95605/ : SUCCESS in 57s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/26/282626/1/check/gate-python-openstackclient-docs/dbdb09f//doc/build/html/ : SUCCESS in 1m 49s\n- gate-python-openstackclient-python27 http://logs.openstack.org/26/282626/1/check/gate-python-openstackclient-python27/98ec372/ : SUCCESS in 1m 18s\n- gate-python-openstackclient-python34 http://logs.openstack.org/26/282626/1/check/gate-python-openstackclient-python34/14c2e18/ : SUCCESS in 2m 17s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/26/282626/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/5bcb928/ : SUCCESS in 45m 54s\n- check-osc-plugins http://logs.openstack.org/26/282626/1/check/check-osc-plugins/104b4f1/ : SUCCESS in 1m 10s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/26/282626/1/check/gate-osc-dsvm-functional/a68fed8/ : SUCCESS in 20m 29s","accounts_in_message":[],"_revision_number":1},{"id":"73546ddeab7550e4fdccb2ca3efd4c328978997b","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-02-21 00:40:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\ngood call","accounts_in_message":[],"_revision_number":1},{"id":"c74e32e7c37208b2aa8b3da1136a9a42ae0ea80d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-21 00:40:18.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d68e5a5ef4dd1d0d6621664373d7e0687b74ddc1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-21 01:31:34.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/26/282626/1/gate/gate-python-openstackclient-docs/2e7c522//doc/build/html/ : SUCCESS in 1m 58s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/26/282626/1/gate/gate-python-openstackclient-pep8/0728761/ : SUCCESS in 44s\n- gate-python-openstackclient-python27 http://logs.openstack.org/26/282626/1/gate/gate-python-openstackclient-python27/ec2f7ed/ : SUCCESS in 2m 22s\n- gate-python-openstackclient-python34 http://logs.openstack.org/26/282626/1/gate/gate-python-openstackclient-python34/0e45f76/ : SUCCESS in 3m 09s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/26/282626/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/f97bbcf/ : SUCCESS in 51m 15s\n- gate-osc-dsvm-functional http://logs.openstack.org/26/282626/1/gate/gate-osc-dsvm-functional/91b454b/ : SUCCESS in 16m 51s","accounts_in_message":[],"_revision_number":1},{"id":"d6a56d4d59ffe1954b97f2007d9393065b813ebc","date":"2016-02-21 01:31:35.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"dc5a8faddd2f7f7afb29751b7d00eb6b5474857f","revisions":{"dc5a8faddd2f7f7afb29751b7d00eb6b5474857f":{"kind":"REWORK","_number":1,"created":"2016-02-20 08:37:58.000000000","uploader":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"ref":"refs/changes/26/282626/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/26/282626/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/26/282626/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/26/282626/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/26/282626/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/26/282626/1"}}},"commit":{"parents":[{"commit":"ab6ba385a2c292a7a906390ad911db8c59811a07","subject":"Merge \"Subnet Pool: Add \"subnet pool show\" command\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ab6ba385a2c292a7a906390ad911db8c59811a07"}]}],"author":{"name":"ting.wang","email":"ting.wang@easystack.cn","date":"2016-02-20 08:35:11.000000000","tz":480},"committer":{"name":"ting.wang","email":"ting.wang@easystack.cn","date":"2016-02-20 08:35:11.000000000","tz":480},"subject":"Fix Mutable default argument","message":"Fix Mutable default argument\n\nPython’s default arguments are evaluated once when the function is defined,\nnot each time the function is called. This means that if you use a mutable\ndefault argument (like list and dict) and mutate it, you will and have mutated\nthat object for all future calls to the function as well.\n\nmore details about this wrong usage here:\nhttp://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments\n\nChange-Id: If187f16bfb305ac4fe6e4177e498a06c49c3f946\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/dc5a8faddd2f7f7afb29751b7d00eb6b5474857f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/dc5a8faddd2f7f7afb29751b7d00eb6b5474857f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}