)]}'
{"openstackclient/tests/volume/v1/fakes.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"2b04073b3ac140ec13aec39482fd7d5ccfb37d70","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        type_info \u003d {"},{"line_number":164,"context_line":"            \u0027description\u0027: \"fake\" + uuid.uuid4().hex,"},{"line_number":165,"context_line":"            \u0027id\u0027: \u0027type-id\u0027 + uuid.uuid4().hex,"},{"line_number":166,"context_line":"            \u0027name\u0027: \"fake-lvmdriver-\" + uuid.uuid4().hex,"},{"line_number":167,"context_line":"            \u0027is_public\u0027: random.choice([\u0027True\u0027, \u0027False\u0027]),"},{"line_number":168,"context_line":"            \u0027extra_specs\u0027: {"},{"line_number":169,"context_line":"                \u0027key\u0027 + uuid.uuid4().hex: \u0027val\u0027 + uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_7d5bd5f6","line":166,"range":{"start_line":166,"start_character":26,"end_line":166,"end_character":35},"updated":"2016-06-29 07:52:50.000000000","message":"A suggestion:\n\nI think the volume type name should be a more regular one, \"lvmdriver\" looks weird in a fake object.","commit_id":"9d23b85c6d71dbc0b19e383187cbff02d99432d7"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"2b04073b3ac140ec13aec39482fd7d5ccfb37d70","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            \u0027description\u0027: \"fake\" + uuid.uuid4().hex,"},{"line_number":165,"context_line":"            \u0027id\u0027: \u0027type-id\u0027 + uuid.uuid4().hex,"},{"line_number":166,"context_line":"            \u0027name\u0027: \"fake-lvmdriver-\" + uuid.uuid4().hex,"},{"line_number":167,"context_line":"            \u0027is_public\u0027: random.choice([\u0027True\u0027, \u0027False\u0027]),"},{"line_number":168,"context_line":"            \u0027extra_specs\u0027: {"},{"line_number":169,"context_line":"                \u0027key\u0027 + uuid.uuid4().hex: \u0027val\u0027 + uuid.uuid4().hex,"},{"line_number":170,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_bd77fd39","line":167,"range":{"start_line":167,"start_character":25,"end_line":167,"end_character":38},"updated":"2016-06-29 07:52:50.000000000","message":"I don\u0027t think using random value is good idea in unit test, it might change every time when we create a fake volume type, fixed value will avoid strange thing happening in unit test, if we need a value that\u0027s different with default value, \"attrs\" can be used to update it.","commit_id":"9d23b85c6d71dbc0b19e383187cbff02d99432d7"}],"openstackclient/tests/volume/v1/test_type.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"6ab8705a3c133d81ac67e90a39ae9ab9dc0515a3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.cmd \u003d volume_type.CreateVolumeType(self.app, None)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_type_create(self):"},{"line_number":40,"context_line":"        expected_columns \u003d ("},{"line_number":41,"context_line":"            \u0027description\u0027,"},{"line_number":42,"context_line":"            \u0027id\u0027,"},{"line_number":43,"context_line":"            \u0027is_public\u0027,"},{"line_number":44,"context_line":"            \u0027name\u0027,"},{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        expected_datalist \u003d ("},{"line_number":48,"context_line":"            self.new_volume_type.description,"},{"line_number":49,"context_line":"            self.new_volume_type.id,"},{"line_number":50,"context_line":"            self.new_volume_type.is_public,"},{"line_number":51,"context_line":"            self.new_volume_type.name,"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        arglist \u003d ["},{"line_number":54,"context_line":"            self.new_volume_type.name,"},{"line_number":55,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_04065351","line":52,"range":{"start_line":40,"start_character":0,"end_line":52,"end_character":9},"updated":"2016-03-10 09:25:18.000000000","message":"I think we can put these code in setUp() so that they can be reused in other create tests. And name them \"columns\" and \"data\" to keep the consistence with other tests.","commit_id":"34f80346c5f1285dfce6c8d15f8b1673c801feec"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"dc412151bd29d16aa6f5eeee3e4e960f7b283bb1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            create_one_volume_type()"},{"line_number":35,"context_line":"        self.types_mock.create.return_value \u003d self.new_volume_type"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.columns \u003d ("},{"line_number":38,"context_line":"            \u0027description\u0027,"},{"line_number":39,"context_line":"            \u0027id\u0027,"},{"line_number":40,"context_line":"            \u0027is_public\u0027,"},{"line_number":41,"context_line":"            \u0027name\u0027,"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        self.data \u003d ("},{"line_number":45,"context_line":"            self.new_volume_type.description,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_3498af77","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":9},"updated":"2016-03-11 01:29:47.000000000","message":"BTW, I tried the following command, but got different output:\n\n# openstack volume type create aaa\n+---------------------------------+--------------------------------------+\n| Field                           | Value                                |\n+---------------------------------+--------------------------------------+\n| description                     | None                                 |\n| id                              | fc366385-bb14-4734-b8d5-e20fc8c9605b |\n| is_public                       | True                                 |\n| name                            | aaa                                  |\n| os-volume-type-access:is_public | True                                 |\n+---------------------------------+--------------------------------------+\n\n\nIs the \"os-volume-type-access:is_public\" the same as \"is_public\" ? If so, I think we need to fix it.","commit_id":"9d23b85c6d71dbc0b19e383187cbff02d99432d7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bb0ec518c076a2bf3e6d31a3cfacdae14482b086","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            create_one_volume_type()"},{"line_number":35,"context_line":"        self.types_mock.create.return_value \u003d self.new_volume_type"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.columns \u003d ("},{"line_number":38,"context_line":"            \u0027description\u0027,"},{"line_number":39,"context_line":"            \u0027id\u0027,"},{"line_number":40,"context_line":"            \u0027is_public\u0027,"},{"line_number":41,"context_line":"            \u0027name\u0027,"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        self.data \u003d ("},{"line_number":45,"context_line":"            self.new_volume_type.description,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_12d725ee","line":42,"range":{"start_line":37,"start_character":0,"end_line":42,"end_character":9},"in_reply_to":"5aef4532_3498af77","updated":"2016-06-29 02:27:12.000000000","message":"seems like they are the same","commit_id":"9d23b85c6d71dbc0b19e383187cbff02d99432d7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"dc412151bd29d16aa6f5eeee3e4e960f7b283bb1","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.cmd \u003d volume_type.CreateVolumeType(self.app, None)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_type_create(self):"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        arglist \u003d ["},{"line_number":56,"context_line":"            self.new_volume_type.name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_f4a92791","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":24},"updated":"2016-03-11 01:29:47.000000000","message":"We\u0027d better add a test with nothing specified. It must raise an exception. Please refer to:\n\nhttps://review.openstack.org/#/c/289715/5/openstackclient/tests/network/v2/test_subnet_pool.py","commit_id":"9d23b85c6d71dbc0b19e383187cbff02d99432d7"}]}