)]}'
{"doc/source/command-objects/port.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f7b3072ed86b88e7b41aa5936e9c4eea86e95f05","unresolved":false,"context_lines":[{"line_number":107,"context_line":".. code:: bash"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    os port set"},{"line_number":110,"context_line":"        [--fixed-ip subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e]"},{"line_number":111,"context_line":"        [--device-id \u003cdevice-id\u003e]"},{"line_number":112,"context_line":"        [--device-owner \u003cdevice-owner\u003e]"},{"line_number":113,"context_line":"        [--enable | --disable]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_414f5692","line":110,"updated":"2016-03-07 17:11:00.000000000","message":"You are missing some of the options in _add_updatable_args().","commit_id":"d47b113c68dd9801dfb86254164f9e46f37195f8"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"8c5fbd4f90739bff6822f1d2a067b822d1c184bc","unresolved":false,"context_lines":[{"line_number":107,"context_line":".. code:: bash"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    os port set"},{"line_number":110,"context_line":"        [--fixed-ip subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e]"},{"line_number":111,"context_line":"        [--device-id \u003cdevice-id\u003e]"},{"line_number":112,"context_line":"        [--device-owner \u003cdevice-owner\u003e]"},{"line_number":113,"context_line":"        [--enable | --disable]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5aef4532_15bc6804","line":110,"in_reply_to":"5aef4532_414f5692","updated":"2016-03-07 18:03:33.000000000","message":"Done","commit_id":"d47b113c68dd9801dfb86254164f9e46f37195f8"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"941124480f5af4fcbae1bb779ed4a472e7fb7433","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":".. option:: --vnic-type \u003cvnic-type\u003e"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    VNIC type for this port (direct | direct-physical | macvtap | normal(default) | baremetal)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. option:: --binding-profile \u003cbinding-profile\u003e"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_ad51e464","line":135,"updated":"2016-03-07 19:57:10.000000000","message":"Is there really a default on set?","commit_id":"945ad94f878a0302fd6f79c7544aa19efca5b5c8"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"42967437d5fac57834086fdb889462e34a3979cd","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":".. option:: --vnic-type \u003cvnic-type\u003e"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    VNIC type for this port (direct | direct-physical | macvtap | normal(default) | baremetal)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. option:: --binding-profile \u003cbinding-profile\u003e"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_d44b192a","line":135,"in_reply_to":"5aef4532_ad51e464","updated":"2016-03-07 21:33:21.000000000","message":"To be consistent across docs and code, and to preserve flexibility of the _add_updatable_args function, I\u0027ve proposed a new comment to indicate default vnic-type -- \n\n\"If unspecified during port creation, default value will be \u0027normal\u0027.\"\n\nUser might need to be reminded that there is a default, in case they assume nothing was set initially.\nAny thoughts?","commit_id":"945ad94f878a0302fd6f79c7544aa19efca5b5c8"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4e4711513548f2e538f9e43206b4243fef7f20df","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":".. option:: --vnic-type \u003cvnic-type\u003e"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    VNIC type for this port (direct | direct-physical | macvtap | normal(default) | baremetal)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. option:: --binding-profile \u003cbinding-profile\u003e"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_ef6d9b05","line":135,"in_reply_to":"5aef4532_d44b192a","updated":"2016-03-07 22:19:49.000000000","message":"Seems reasonable to me.","commit_id":"945ad94f878a0302fd6f79c7544aa19efca5b5c8"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"42937dfbd3fdebf8e228b6c99bc2813a715d2f65","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        parser.add_argument("},{"line_number":269,"context_line":"            \u0027port\u0027,"},{"line_number":270,"context_line":"            metavar\u003d\"\u003cport\u003e\","},{"line_number":271,"context_line":"            help\u003d(\"Port to modify (name or ID)\")"},{"line_number":272,"context_line":"        )"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_fcc69798","line":271,"range":{"start_line":271,"start_character":17,"end_line":271,"end_character":48},"updated":"2016-02-23 07:01:54.000000000","message":"these ()\u0027s are pointless","commit_id":"08f91f8f69b5229a05d7dd7eb314889de31f0feb"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"9d69efb61cf026c57f4a841c3d05d609fd171b62","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        _prepare_fixed_ips(self.app.client_manager, parsed_args)"},{"line_number":280,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":281,"context_line":"        obj \u003d client.find_port(parsed_args.port)"},{"line_number":282,"context_line":"        client.update_port(obj, **attrs)"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_bf2e6ca2","line":280,"updated":"2016-02-24 13:33:43.000000000","message":"Both network and router set will verify that attrs is not empty.  Should we do the same here for consistency?","commit_id":"08f91f8f69b5229a05d7dd7eb314889de31f0feb"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"42937dfbd3fdebf8e228b6c99bc2813a715d2f65","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        obj \u003d client.find_port(parsed_args.port)"},{"line_number":282,"context_line":"        client.update_port(obj, **attrs)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        return"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"class ShowPort(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_3cbd9f02","line":284,"range":{"start_line":284,"start_character":8,"end_line":284,"end_character":14},"updated":"2016-02-23 07:01:54.000000000","message":"this return statement is also pointless","commit_id":"08f91f8f69b5229a05d7dd7eb314889de31f0feb"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f7b3072ed86b88e7b41aa5936e9c4eea86e95f05","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        _prepare_fixed_ips(self.app.client_manager, parsed_args)"},{"line_number":273,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":274,"context_line":"        obj \u003d client.find_port(parsed_args.port)"},{"line_number":275,"context_line":"        client.update_port(obj, **attrs)"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_81403e58","line":273,"updated":"2016-03-07 17:11:00.000000000","message":"Both network and router set will verify that attrs is not empty. Should we do the same here for consistency?","commit_id":"d47b113c68dd9801dfb86254164f9e46f37195f8"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"8c5fbd4f90739bff6822f1d2a067b822d1c184bc","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        _prepare_fixed_ips(self.app.client_manager, parsed_args)"},{"line_number":273,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":274,"context_line":"        obj \u003d client.find_port(parsed_args.port)"},{"line_number":275,"context_line":"        client.update_port(obj, **attrs)"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_75e96c1a","line":273,"in_reply_to":"5aef4532_81403e58","updated":"2016-03-07 18:03:33.000000000","message":"Done","commit_id":"d47b113c68dd9801dfb86254164f9e46f37195f8"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"941124480f5af4fcbae1bb779ed4a472e7fb7433","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        obj \u003d client.find_port(parsed_args.port, ignore_missing\u003dFalse)"},{"line_number":281,"context_line":"        client.update_port(obj, **attrs)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        return"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"class ShowPort(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_2004bb13","line":283,"updated":"2016-03-07 19:57:10.000000000","message":"not necessary","commit_id":"945ad94f878a0302fd6f79c7544aa19efca5b5c8"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"42967437d5fac57834086fdb889462e34a3979cd","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        obj \u003d client.find_port(parsed_args.port, ignore_missing\u003dFalse)"},{"line_number":281,"context_line":"        client.update_port(obj, **attrs)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        return"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"class ShowPort(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_94e8717e","line":283,"in_reply_to":"5aef4532_2004bb13","updated":"2016-03-07 21:33:21.000000000","message":"removed.","commit_id":"945ad94f878a0302fd6f79c7544aa19efca5b5c8"}],"openstackclient/tests/network/v2/test_port.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f7b3072ed86b88e7b41aa5936e9c4eea86e95f05","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        self.network.update_port.assert_called_with(self._port, **attrs)"},{"line_number":233,"context_line":"        self.assertIsNone(result)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def test_set_this(self):"},{"line_number":236,"context_line":"        arglist \u003d ["},{"line_number":237,"context_line":"            self._port.name,"},{"line_number":238,"context_line":"            \u0027--disable\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_44048414","line":235,"updated":"2016-03-07 17:11:00.000000000","message":"Consider updating the tests so all options are covered.","commit_id":"d47b113c68dd9801dfb86254164f9e46f37195f8"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"8c5fbd4f90739bff6822f1d2a067b822d1c184bc","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        self.network.update_port.assert_called_with(self._port, **attrs)"},{"line_number":233,"context_line":"        self.assertIsNone(result)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def test_set_this(self):"},{"line_number":236,"context_line":"        arglist \u003d ["},{"line_number":237,"context_line":"            self._port.name,"},{"line_number":238,"context_line":"            \u0027--disable\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_3591a49a","line":235,"in_reply_to":"5aef4532_44048414","updated":"2016-03-07 18:03:33.000000000","message":"Done","commit_id":"d47b113c68dd9801dfb86254164f9e46f37195f8"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"941124480f5af4fcbae1bb779ed4a472e7fb7433","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    def test_set_fixed_ip(self):"},{"line_number":218,"context_line":"        arglist \u003d ["},{"line_number":219,"context_line":"            self._port.name,"},{"line_number":220,"context_line":"            \u0027--fixed-ip\u0027, \u0027ip-address\u003d10.0.0.11\u0027"},{"line_number":221,"context_line":"        ]"},{"line_number":222,"context_line":"        verifylist \u003d ["},{"line_number":223,"context_line":"            (\u0027fixed_ip\u0027, [{\u0027ip-address\u0027: \u002710.0.0.11\u0027}]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_e01ad36d","line":220,"updated":"2016-03-07 19:57:10.000000000","message":"options should go before the required port argument.","commit_id":"945ad94f878a0302fd6f79c7544aa19efca5b5c8"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"42967437d5fac57834086fdb889462e34a3979cd","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    def test_set_fixed_ip(self):"},{"line_number":218,"context_line":"        arglist \u003d ["},{"line_number":219,"context_line":"            self._port.name,"},{"line_number":220,"context_line":"            \u0027--fixed-ip\u0027, \u0027ip-address\u003d10.0.0.11\u0027"},{"line_number":221,"context_line":"        ]"},{"line_number":222,"context_line":"        verifylist \u003d ["},{"line_number":223,"context_line":"            (\u0027fixed_ip\u0027, [{\u0027ip-address\u0027: \u002710.0.0.11\u0027}]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_b4ff6d33","line":220,"in_reply_to":"5aef4532_e01ad36d","updated":"2016-03-07 21:33:21.000000000","message":"Done","commit_id":"945ad94f878a0302fd6f79c7544aa19efca5b5c8"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"941124480f5af4fcbae1bb779ed4a472e7fb7433","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    def test_set_this(self):"},{"line_number":236,"context_line":"        arglist \u003d ["},{"line_number":237,"context_line":"            self._port.name,"},{"line_number":238,"context_line":"            \u0027--disable\u0027,"},{"line_number":239,"context_line":"        ]"},{"line_number":240,"context_line":"        verifylist \u003d ["},{"line_number":241,"context_line":"            (\u0027admin_state\u0027, False),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_202b1b84","line":238,"updated":"2016-03-07 19:57:10.000000000","message":"options should go before the required port argument.","commit_id":"945ad94f878a0302fd6f79c7544aa19efca5b5c8"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"42967437d5fac57834086fdb889462e34a3979cd","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    def test_set_this(self):"},{"line_number":236,"context_line":"        arglist \u003d ["},{"line_number":237,"context_line":"            self._port.name,"},{"line_number":238,"context_line":"            \u0027--disable\u0027,"},{"line_number":239,"context_line":"        ]"},{"line_number":240,"context_line":"        verifylist \u003d ["},{"line_number":241,"context_line":"            (\u0027admin_state\u0027, False),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_f4f9f54e","line":238,"in_reply_to":"5aef4532_202b1b84","updated":"2016-03-07 21:33:21.000000000","message":"Done","commit_id":"945ad94f878a0302fd6f79c7544aa19efca5b5c8"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"941124480f5af4fcbae1bb779ed4a472e7fb7433","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    def test_set_that(self):"},{"line_number":254,"context_line":"        arglist \u003d ["},{"line_number":255,"context_line":"            self._port.name,"},{"line_number":256,"context_line":"            \u0027--enable\u0027,"},{"line_number":257,"context_line":"            \u0027--vnic-type\u0027, \u0027macvtap\u0027,"},{"line_number":258,"context_line":"            \u0027--binding-profile\u0027, \u0027foo\u003dbar\u0027,"},{"line_number":259,"context_line":"            \u0027--host-id\u0027, \u0027binding-host-id-xxxx\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_80202f9d","line":256,"updated":"2016-03-07 19:57:10.000000000","message":"options should go before the required port argument.","commit_id":"945ad94f878a0302fd6f79c7544aa19efca5b5c8"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"42967437d5fac57834086fdb889462e34a3979cd","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    def test_set_that(self):"},{"line_number":254,"context_line":"        arglist \u003d ["},{"line_number":255,"context_line":"            self._port.name,"},{"line_number":256,"context_line":"            \u0027--enable\u0027,"},{"line_number":257,"context_line":"            \u0027--vnic-type\u0027, \u0027macvtap\u0027,"},{"line_number":258,"context_line":"            \u0027--binding-profile\u0027, \u0027foo\u003dbar\u0027,"},{"line_number":259,"context_line":"            \u0027--host-id\u0027, \u0027binding-host-id-xxxx\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_549549e2","line":256,"in_reply_to":"5aef4532_80202f9d","updated":"2016-03-07 21:33:21.000000000","message":"Done","commit_id":"945ad94f878a0302fd6f79c7544aa19efca5b5c8"}]}