)]}'
{"doc/source/command-objects/host.rst":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1200b0de288931c840e4fa5d5513c155ead55209","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \u003chost\u003e"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. _host-set:"},{"line_number":53,"context_line":".. describe:: --enable"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    Enable the host"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5aef4532_fd68a8bc","line":53,"range":{"start_line":53,"start_character":3,"end_line":53,"end_character":11},"updated":"2016-03-08 06:10:00.000000000","message":"describe -\u003e option","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1200b0de288931c840e4fa5d5513c155ead55209","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    Enable the host"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. describe:: --disable"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    Disable the host"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5aef4532_3d6330de","line":57,"range":{"start_line":57,"start_character":3,"end_line":57,"end_character":11},"updated":"2016-03-08 06:10:00.000000000","message":"describe -\u003e option","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1200b0de288931c840e4fa5d5513c155ead55209","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    Disable the host"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":".. _maintenance-set:"},{"line_number":62,"context_line":".. describe:: --enable-maintenance"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    Enable maintenance mode for the host"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5aef4532_7d9bf8c9","line":62,"range":{"start_line":62,"start_character":3,"end_line":62,"end_character":11},"updated":"2016-03-08 06:10:00.000000000","message":"describe -\u003e option","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1200b0de288931c840e4fa5d5513c155ead55209","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    Enable maintenance mode for the host"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. describe:: --disable-maintenance"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    Disable maintenance mode for the host"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5aef4532_5da0bcf4","line":66,"range":{"start_line":66,"start_character":3,"end_line":66,"end_character":11},"updated":"2016-03-08 06:10:00.000000000","message":"describe -\u003e option","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"60398694efea9baa8e6475e85c75b612f8e11184","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    Name of host"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"host set"},{"line_number":40,"context_line":"--------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Set host command"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3afc51ec_71800947","line":39,"updated":"2016-03-14 22:37:47.000000000","message":"This needs to be sorted by command","commit_id":"ab4120642cc7b8e6629684d6a5d4e545bbf93e75"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"60f6c8050c8c6cba39cd8742c27bdb5c32345af1","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    Name of host"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"host set"},{"line_number":40,"context_line":"--------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Set host command"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1af94dfe_2507b61d","line":39,"in_reply_to":"3afc51ec_71800947","updated":"2016-03-15 20:30:56.000000000","message":"Done","commit_id":"ab4120642cc7b8e6629684d6a5d4e545bbf93e75"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"3114dea18dbfdcaede758fc1ee20cdc2f5e6d19d","unresolved":false,"context_lines":[{"line_number":37,"context_line":".. _host-set:"},{"line_number":38,"context_line":".. option:: --enable"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Enable the host"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. option:: --disable"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1af94dfe_476f46c5","line":40,"range":{"start_line":40,"start_character":5,"end_line":40,"end_character":19},"updated":"2016-03-16 12:33:12.000000000","message":"default ?","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"aa56c81358a6b152490215590a0b35140d59adcb","unresolved":false,"context_lines":[{"line_number":37,"context_line":".. _host-set:"},{"line_number":38,"context_line":".. option:: --enable"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Enable the host"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. option:: --disable"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1af94dfe_9ab98fce","line":40,"in_reply_to":"1af94dfe_4710e601","updated":"2016-03-16 16:59:47.000000000","message":"We do not enforce defaults for things like this, no, but we do note which is the server default, and deal with the fallout should the server change down the road...","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9c5670fba7dd631b5303a8c1842d9d673489ffe2","unresolved":false,"context_lines":[{"line_number":37,"context_line":".. _host-set:"},{"line_number":38,"context_line":".. option:: --enable"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Enable the host"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. option:: --disable"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1af94dfe_4710e601","line":40,"range":{"start_line":40,"start_character":5,"end_line":40,"end_character":19},"in_reply_to":"1af94dfe_476f46c5","updated":"2016-03-16 12:37:40.000000000","message":"no default value I think","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"bc75e1180a45d8b957f6713de34308be5c14c77e","unresolved":false,"context_lines":[{"line_number":37,"context_line":".. _host-set:"},{"line_number":38,"context_line":".. option:: --enable"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Enable the host"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. option:: --disable"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1af94dfe_eaf54ecb","line":40,"in_reply_to":"1af94dfe_9ab98fce","updated":"2016-03-17 02:09:04.000000000","message":"OK, I think I misunderstood your comments before. I thought you meant to find out the server default, and doc it here.","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"3114dea18dbfdcaede758fc1ee20cdc2f5e6d19d","unresolved":false,"context_lines":[{"line_number":46,"context_line":".. _maintenance-set:"},{"line_number":47,"context_line":".. option:: --enable-maintenance"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Enable maintenance mode for the host"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. option:: --disable-maintenance"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1af94dfe_47a62611","line":49,"range":{"start_line":49,"start_character":5,"end_line":49,"end_character":40},"updated":"2016-03-16 12:33:12.000000000","message":"default ?","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9c5670fba7dd631b5303a8c1842d9d673489ffe2","unresolved":false,"context_lines":[{"line_number":46,"context_line":".. _maintenance-set:"},{"line_number":47,"context_line":".. option:: --enable-maintenance"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Enable maintenance mode for the host"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. option:: --disable-maintenance"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1af94dfe_c704f6c1","line":49,"range":{"start_line":49,"start_character":5,"end_line":49,"end_character":40},"in_reply_to":"1af94dfe_47a62611","updated":"2016-03-16 12:37:40.000000000","message":"no default value","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"aa56c81358a6b152490215590a0b35140d59adcb","unresolved":false,"context_lines":[{"line_number":46,"context_line":".. _maintenance-set:"},{"line_number":47,"context_line":".. option:: --enable-maintenance"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Enable maintenance mode for the host"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. option:: --disable-maintenance"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1af94dfe_1ac61f49","line":49,"in_reply_to":"1af94dfe_c704f6c1","updated":"2016-03-16 16:59:47.000000000","message":"ditto","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"}],"openstackclient/compute/v2/host.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"0f85fadabdedf1c1c8340e1804f19aa8fec978eb","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                ) for s in data))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class SetHost(command.ShowOne):"},{"line_number":75,"context_line":"    \"\"\"Set host command\"\"\""},{"line_number":76,"context_line":"    def get_parser(self, prog_name):"},{"line_number":77,"context_line":"        parser \u003d super(SetHost, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_30194dd8","line":74,"updated":"2016-02-23 00:07:26.000000000","message":"These classes should be sorted","commit_id":"ff27a872028f89e813281c405c87a654a577e78a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c13d6efdef7a1d146820afc3fad1652342d86664","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                ) for s in data))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class SetHost(command.ShowOne):"},{"line_number":75,"context_line":"    \"\"\"Set host command\"\"\""},{"line_number":76,"context_line":"    def get_parser(self, prog_name):"},{"line_number":77,"context_line":"        parser \u003d super(SetHost, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_cc46707a","line":74,"in_reply_to":"bae84128_30194dd8","updated":"2016-02-23 14:29:28.000000000","message":"Done","commit_id":"ff27a872028f89e813281c405c87a654a577e78a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"0f85fadabdedf1c1c8340e1804f19aa8fec978eb","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":81,"context_line":"            help\u003d\"Name of host\")"},{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--status\u0027,"},{"line_number":84,"context_line":"            metavar\u003d\u0027\u003cstatus\u003e\u0027,"},{"line_number":85,"context_line":"            help\u003d\u0027Either enable or disable a host.\u0027,"},{"line_number":86,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_30330dad","line":83,"updated":"2016-02-23 00:07:26.000000000","message":"Please use an --enable|--disable exclusive group for this","commit_id":"ff27a872028f89e813281c405c87a654a577e78a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c13d6efdef7a1d146820afc3fad1652342d86664","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":81,"context_line":"            help\u003d\"Name of host\")"},{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--status\u0027,"},{"line_number":84,"context_line":"            metavar\u003d\u0027\u003cstatus\u003e\u0027,"},{"line_number":85,"context_line":"            help\u003d\u0027Either enable or disable a host.\u0027,"},{"line_number":86,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_6c56442b","line":83,"in_reply_to":"bae84128_30330dad","updated":"2016-02-23 14:29:28.000000000","message":"Done","commit_id":"ff27a872028f89e813281c405c87a654a577e78a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"0f85fadabdedf1c1c8340e1804f19aa8fec978eb","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            help\u003d\u0027Either enable or disable a host.\u0027,"},{"line_number":86,"context_line":"        )"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \"--maintenance\","},{"line_number":89,"context_line":"            metavar\u003d\"\u003cmaintenance\u003e\","},{"line_number":90,"context_line":"            help\u003d\"Either put or resume host to/from maintenance.\","},{"line_number":91,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_50bcd1db","line":88,"updated":"2016-02-23 00:07:26.000000000","message":"This should also have an exclusive group used, I\u0027m not certain what the names should be, maybe --maintenance and --no-maintenance (which is the fallback to traditional GNU long opts names).","commit_id":"ff27a872028f89e813281c405c87a654a577e78a"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"7087709dc8db374ff35d9d4d1698d363fec23687","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            help\u003d\u0027Either enable or disable a host.\u0027,"},{"line_number":86,"context_line":"        )"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \"--maintenance\","},{"line_number":89,"context_line":"            metavar\u003d\"\u003cmaintenance\u003e\","},{"line_number":90,"context_line":"            help\u003d\"Either put or resume host to/from maintenance.\","},{"line_number":91,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_c97154aa","line":88,"in_reply_to":"bae84128_50bcd1db","updated":"2016-02-23 08:07:52.000000000","message":"Just FYI, host maintenance mode is going to be deprecated in Nova. Just not yet.","commit_id":"ff27a872028f89e813281c405c87a654a577e78a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c13d6efdef7a1d146820afc3fad1652342d86664","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            help\u003d\u0027Either enable or disable a host.\u0027,"},{"line_number":86,"context_line":"        )"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \"--maintenance\","},{"line_number":89,"context_line":"            metavar\u003d\"\u003cmaintenance\u003e\","},{"line_number":90,"context_line":"            help\u003d\"Either put or resume host to/from maintenance.\","},{"line_number":91,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_07079118","line":88,"in_reply_to":"bae84128_50bcd1db","updated":"2016-02-23 14:29:28.000000000","message":"ok, let me try this","commit_id":"ff27a872028f89e813281c405c87a654a577e78a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c13d6efdef7a1d146820afc3fad1652342d86664","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            help\u003d\u0027Either enable or disable a host.\u0027,"},{"line_number":86,"context_line":"        )"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \"--maintenance\","},{"line_number":89,"context_line":"            metavar\u003d\"\u003cmaintenance\u003e\","},{"line_number":90,"context_line":"            help\u003d\"Either put or resume host to/from maintenance.\","},{"line_number":91,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_8c6908fc","line":88,"in_reply_to":"bae84128_c97154aa","updated":"2016-02-23 14:29:28.000000000","message":"if it exist in nova client, it should be fine if we\nhave it here","commit_id":"ff27a872028f89e813281c405c87a654a577e78a"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"239abf81fe34bcd48db7849ea132a86400e2fa54","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                ) for s in data))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class SetHost(command.ShowOne):"},{"line_number":48,"context_line":"    \"\"\"Set host command\"\"\""},{"line_number":49,"context_line":"    def get_parser(self, prog_name):"},{"line_number":50,"context_line":"        parser \u003d super(SetHost, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_1e45fa44","line":47,"range":{"start_line":47,"start_character":22,"end_line":47,"end_character":29},"updated":"2016-02-24 01:57:57.000000000","message":"No. All set/unset commands should inherit from command.Command. It gives no output. Please refer to: https://bugs.launchpad.net/python-openstackclient/+bug/1546065","commit_id":"e795be509a3fe2bef88f1b6d7aacd67b61fa2201"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d4852118e23a846c5313bfe22e7e0b3e25fc7c67","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                ) for s in data))"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class SetHost(command.ShowOne):"},{"line_number":48,"context_line":"    \"\"\"Set host command\"\"\""},{"line_number":49,"context_line":"    def get_parser(self, prog_name):"},{"line_number":50,"context_line":"        parser \u003d super(SetHost, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_c468c7f7","line":47,"range":{"start_line":47,"start_character":22,"end_line":47,"end_character":29},"in_reply_to":"bae84128_1e45fa44","updated":"2016-02-24 13:16:57.000000000","message":"ok, that make sense, thanks","commit_id":"e795be509a3fe2bef88f1b6d7aacd67b61fa2201"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"239abf81fe34bcd48db7849ea132a86400e2fa54","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \"host\","},{"line_number":53,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":54,"context_line":"            help\u003d\"Name of host\")"},{"line_number":55,"context_line":"        status \u003d parser.add_mutually_exclusive_group()"},{"line_number":56,"context_line":"        status.add_argument("},{"line_number":57,"context_line":"            \u0027--enable\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_43a5ed44","line":54,"range":{"start_line":54,"start_character":18,"end_line":54,"end_character":30},"updated":"2016-02-24 01:57:57.000000000","message":"Is ID OK too ? please make it like this:\n\nThe host to modify (name or ID)\n\nAnd please also add a doc file in doc/source/command-objects/.","commit_id":"e795be509a3fe2bef88f1b6d7aacd67b61fa2201"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d4852118e23a846c5313bfe22e7e0b3e25fc7c67","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \"host\","},{"line_number":53,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":54,"context_line":"            help\u003d\"Name of host\")"},{"line_number":55,"context_line":"        status \u003d parser.add_mutually_exclusive_group()"},{"line_number":56,"context_line":"        status.add_argument("},{"line_number":57,"context_line":"            \u0027--enable\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_847b5fbd","line":54,"range":{"start_line":54,"start_character":18,"end_line":54,"end_character":30},"in_reply_to":"bae84128_43a5ed44","updated":"2016-02-24 13:16:57.000000000","message":"Done","commit_id":"e795be509a3fe2bef88f1b6d7aacd67b61fa2201"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"239abf81fe34bcd48db7849ea132a86400e2fa54","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            \u0027--enable-maintenance\u0027,"},{"line_number":71,"context_line":"            dest\u003d\"maintenance\","},{"line_number":72,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":73,"context_line":"            help\u003d\u0027Enable maintenance mode for a host.\"\u0027"},{"line_number":74,"context_line":"        )"},{"line_number":75,"context_line":"        maintenance.add_argument("},{"line_number":76,"context_line":"            \u0027--disable-maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_e3b5217e","line":73,"range":{"start_line":73,"start_character":53,"end_line":73,"end_character":54},"updated":"2016-02-24 01:57:57.000000000","message":"nit: redundant","commit_id":"e795be509a3fe2bef88f1b6d7aacd67b61fa2201"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d4852118e23a846c5313bfe22e7e0b3e25fc7c67","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            \u0027--enable-maintenance\u0027,"},{"line_number":71,"context_line":"            dest\u003d\"maintenance\","},{"line_number":72,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":73,"context_line":"            help\u003d\u0027Enable maintenance mode for a host.\"\u0027"},{"line_number":74,"context_line":"        )"},{"line_number":75,"context_line":"        maintenance.add_argument("},{"line_number":76,"context_line":"            \u0027--disable-maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_a480238c","line":73,"range":{"start_line":73,"start_character":53,"end_line":73,"end_character":54},"in_reply_to":"bae84128_e3b5217e","updated":"2016-02-24 13:16:57.000000000","message":"Done","commit_id":"e795be509a3fe2bef88f1b6d7aacd67b61fa2201"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"af6c5480777085bef79f38ab9aec17d957e9aaf4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027--enable\u0027,"},{"line_number":58,"context_line":"            dest\u003d\"status\","},{"line_number":59,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":60,"context_line":"            help\u003d\u0027Enable a host\u0027"},{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":"        status.add_argument("},{"line_number":63,"context_line":"            \u0027--disable\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_3c73114f","line":60,"range":{"start_line":60,"start_character":25,"end_line":60,"end_character":26},"updated":"2016-02-27 03:21:20.000000000","message":"a --\u003e the","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f076d6fe945276fc5146e0d00253b9b5017e8b66","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027--enable\u0027,"},{"line_number":58,"context_line":"            dest\u003d\"status\","},{"line_number":59,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":60,"context_line":"            help\u003d\u0027Enable a host\u0027"},{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":"        status.add_argument("},{"line_number":63,"context_line":"            \u0027--disable\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_21c7c846","line":60,"range":{"start_line":60,"start_character":25,"end_line":60,"end_character":26},"in_reply_to":"9aed3d3a_3c73114f","updated":"2016-03-01 11:21:28.000000000","message":"Done","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"af6c5480777085bef79f38ab9aec17d957e9aaf4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            \u0027--disable\u0027,"},{"line_number":64,"context_line":"            dest\u003d\"status\","},{"line_number":65,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":66,"context_line":"            help\u003d\u0027Disable a host\u0027"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":"        maintenance \u003d parser.add_mutually_exclusive_group()"},{"line_number":69,"context_line":"        maintenance.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_9c905d45","line":66,"range":{"start_line":66,"start_character":26,"end_line":66,"end_character":27},"updated":"2016-02-27 03:21:20.000000000","message":"a --\u003e the","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f076d6fe945276fc5146e0d00253b9b5017e8b66","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            \u0027--disable\u0027,"},{"line_number":64,"context_line":"            dest\u003d\"status\","},{"line_number":65,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":66,"context_line":"            help\u003d\u0027Disable a host\u0027"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":"        maintenance \u003d parser.add_mutually_exclusive_group()"},{"line_number":69,"context_line":"        maintenance.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_81c4dc40","line":66,"range":{"start_line":66,"start_character":26,"end_line":66,"end_character":27},"in_reply_to":"9aed3d3a_9c905d45","updated":"2016-03-01 11:21:28.000000000","message":"Done","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"a52cc3c4c48467b298a04f0743afab432ecc7d39","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            \u0027--enable-maintenance\u0027,"},{"line_number":71,"context_line":"            dest\u003d\"maintenance\","},{"line_number":72,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":73,"context_line":"            help\u003d\u0027Enable maintenance mode for a host.\u0027"},{"line_number":74,"context_line":"        )"},{"line_number":75,"context_line":"        maintenance.add_argument("},{"line_number":76,"context_line":"            \u0027--disable-maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_407287ae","line":73,"range":{"start_line":73,"start_character":50,"end_line":73,"end_character":54},"updated":"2016-02-26 16:24:44.000000000","message":"Remove period for consistency.","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f076d6fe945276fc5146e0d00253b9b5017e8b66","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            \u0027--enable-maintenance\u0027,"},{"line_number":71,"context_line":"            dest\u003d\"maintenance\","},{"line_number":72,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":73,"context_line":"            help\u003d\u0027Enable maintenance mode for a host.\u0027"},{"line_number":74,"context_line":"        )"},{"line_number":75,"context_line":"        maintenance.add_argument("},{"line_number":76,"context_line":"            \u0027--disable-maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_413f7425","line":73,"range":{"start_line":73,"start_character":50,"end_line":73,"end_character":54},"in_reply_to":"9aed3d3a_407287ae","updated":"2016-03-01 11:21:28.000000000","message":"ok","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"55167d469246701b684d616ca18647f37ad8030b","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class SetHost(command.Command):"},{"line_number":48,"context_line":"    \"\"\"Set host command\"\"\""},{"line_number":49,"context_line":"    def get_parser(self, prog_name):"},{"line_number":50,"context_line":"        parser \u003d super(SetHost, self).get_parser(prog_name)"},{"line_number":51,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_be4d6374","line":48,"range":{"start_line":48,"start_character":7,"end_line":48,"end_character":23},"updated":"2016-03-02 12:30:39.000000000","message":"Set host properties.","commit_id":"945a2ca9fb52574ebfc4eb2271d44381be77415e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f0983c4fc67abb9dae165cb081ad682010786f2b","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class SetHost(command.Command):"},{"line_number":48,"context_line":"    \"\"\"Set host command\"\"\""},{"line_number":49,"context_line":"    def get_parser(self, prog_name):"},{"line_number":50,"context_line":"        parser \u003d super(SetHost, self).get_parser(prog_name)"},{"line_number":51,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_c4ecd92b","line":48,"range":{"start_line":48,"start_character":7,"end_line":48,"end_character":23},"in_reply_to":"7af24918_be4d6374","updated":"2016-03-02 13:38:37.000000000","message":"Done","commit_id":"945a2ca9fb52574ebfc4eb2271d44381be77415e"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"55167d469246701b684d616ca18647f37ad8030b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \"host\","},{"line_number":53,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":54,"context_line":"            help\u003d\"The host to modify (name or ID)\")"},{"line_number":55,"context_line":"        status \u003d parser.add_mutually_exclusive_group()"},{"line_number":56,"context_line":"        status.add_argument("},{"line_number":57,"context_line":"            \u0027--enable\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_f33ba4e9","line":54,"range":{"start_line":54,"start_character":50,"end_line":54,"end_character":51},"updated":"2016-03-02 12:30:39.000000000","message":"nit: put this \u0027)\u0027 in the next line. :)","commit_id":"945a2ca9fb52574ebfc4eb2271d44381be77415e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f0983c4fc67abb9dae165cb081ad682010786f2b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \"host\","},{"line_number":53,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":54,"context_line":"            help\u003d\"The host to modify (name or ID)\")"},{"line_number":55,"context_line":"        status \u003d parser.add_mutually_exclusive_group()"},{"line_number":56,"context_line":"        status.add_argument("},{"line_number":57,"context_line":"            \u0027--enable\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_848c9180","line":54,"range":{"start_line":54,"start_character":50,"end_line":54,"end_character":51},"in_reply_to":"7af24918_f33ba4e9","updated":"2016-03-02 13:38:37.000000000","message":"Done","commit_id":"945a2ca9fb52574ebfc4eb2271d44381be77415e"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"55167d469246701b684d616ca18647f37ad8030b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":85,"context_line":"        foundhost \u003d utils.find_resource("},{"line_number":86,"context_line":"            compute_client.hosts,"},{"line_number":87,"context_line":"            parsed_args.host,"},{"line_number":88,"context_line":"        )"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        compute_client.hosts.update("}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_f3444475","line":87,"range":{"start_line":87,"start_character":28,"end_line":87,"end_character":29},"updated":"2016-03-02 12:30:39.000000000","message":"nit: Remove this \u0027,\u0027. :)","commit_id":"945a2ca9fb52574ebfc4eb2271d44381be77415e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f0983c4fc67abb9dae165cb081ad682010786f2b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":85,"context_line":"        foundhost \u003d utils.find_resource("},{"line_number":86,"context_line":"            compute_client.hosts,"},{"line_number":87,"context_line":"            parsed_args.host,"},{"line_number":88,"context_line":"        )"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        compute_client.hosts.update("}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_a491cd9b","line":87,"range":{"start_line":87,"start_character":28,"end_line":87,"end_character":29},"in_reply_to":"7af24918_f3444475","updated":"2016-03-02 13:38:37.000000000","message":"Done","commit_id":"945a2ca9fb52574ebfc4eb2271d44381be77415e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1ee1521478d8a73a72c64619080a115bcfde9b09","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class SetHost(command.Command):"},{"line_number":48,"context_line":"    \"\"\"Set host properties\"\"\""},{"line_number":49,"context_line":"    def get_parser(self, prog_name):"},{"line_number":50,"context_line":"        parser \u003d super(SetHost, self).get_parser(prog_name)"},{"line_number":51,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_cc1f2db6","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":29},"updated":"2016-03-04 23:18:20.000000000","message":"add a new line under here for consistency","commit_id":"9f80b8392c0729685255431d7147cd496aa95f06"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"370eec903d2db9d0e86563aa04bdbf8f44b3beff","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":54,"context_line":"            help\u003d\"The host to modify (name or ID)\""},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        status \u003d parser.add_mutually_exclusive_group()"},{"line_number":57,"context_line":"        status.add_argument("},{"line_number":58,"context_line":"            \u0027--enable\u0027,"},{"line_number":59,"context_line":"            dest\u003d\"status\","}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_7d3efc8c","line":56,"updated":"2016-03-09 15:42:29.000000000","message":"Both of these bollean option sets need to follow the pattern outlined in http://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1200b0de288931c840e4fa5d5513c155ead55209","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def take_action(self, parsed_args):"},{"line_number":85,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":86,"context_line":"        foundhost \u003d utils.find_resource("},{"line_number":87,"context_line":"            compute_client.hosts,"},{"line_number":88,"context_line":"            parsed_args.host"},{"line_number":89,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_42fd7939","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":17},"updated":"2016-03-08 06:10:00.000000000","message":"nit: Can we just call it host ?  To keep the consistence with other commands.","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"91f282876ec5652d90f980cbefb3c2b8c6ed2b5e","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def take_action(self, parsed_args):"},{"line_number":85,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":86,"context_line":"        foundhost \u003d utils.find_resource("},{"line_number":87,"context_line":"            compute_client.hosts,"},{"line_number":88,"context_line":"            parsed_args.host"},{"line_number":89,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afc51ec_593ac4ce","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":17},"in_reply_to":"5aef4532_42fd7939","updated":"2016-03-14 12:57:17.000000000","message":"Done","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1200b0de288931c840e4fa5d5513c155ead55209","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            parsed_args.host"},{"line_number":89,"context_line":"        )"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        compute_client.hosts.update("},{"line_number":92,"context_line":"            foundhost.id,"},{"line_number":93,"context_line":"            status\u003dparsed_args.status,"},{"line_number":94,"context_line":"            maintenance\u003dparsed_args.maintenance"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_7d4db871","line":91,"range":{"start_line":91,"start_character":29,"end_line":91,"end_character":35},"updated":"2016-03-08 06:10:00.000000000","message":"Please check if the user specifies nothing. I think in other set commands, if user specifies nothing to set, an exception will be raised.","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"370eec903d2db9d0e86563aa04bdbf8f44b3beff","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            parsed_args.host"},{"line_number":89,"context_line":"        )"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        compute_client.hosts.update("},{"line_number":92,"context_line":"            foundhost.id,"},{"line_number":93,"context_line":"            status\u003dparsed_args.status,"},{"line_number":94,"context_line":"            maintenance\u003dparsed_args.maintenance"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_7d543cfe","line":91,"in_reply_to":"5aef4532_7d4db871","updated":"2016-03-09 15:42:29.000000000","message":"I think if nothing is specified, then nothing being done is not an error.  That is exactly what was asked for.  We are not currently consistent on this throughout OSC and probably should fix that, no matter which way we go.","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"91f282876ec5652d90f980cbefb3c2b8c6ed2b5e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            parsed_args.host"},{"line_number":89,"context_line":"        )"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        compute_client.hosts.update("},{"line_number":92,"context_line":"            foundhost.id,"},{"line_number":93,"context_line":"            status\u003dparsed_args.status,"},{"line_number":94,"context_line":"            maintenance\u003dparsed_args.maintenance"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afc51ec_19203c9b","line":91,"in_reply_to":"5aef4532_7d543cfe","updated":"2016-03-14 12:57:17.000000000","message":"agree, we do what we were told to do","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"60398694efea9baa8e6475e85c75b612f8e11184","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        if not kwargs:"},{"line_number":94,"context_line":"            raise exceptions.CommandError(\u0027at least one option need to be \u0027"},{"line_number":95,"context_line":"                                          \u0027input.\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":98,"context_line":"        foundhost \u003d utils.find_resource("}],"source_content_type":"text/x-python","patch_set":10,"id":"3afc51ec_d1fabdbc","line":95,"updated":"2016-03-14 22:37:47.000000000","message":"Log a warning if anything must be done, this should not be a fatal condition.  With no options, we are doing exactly what the user asked...","commit_id":"ab4120642cc7b8e6629684d6a5d4e545bbf93e75"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"60f6c8050c8c6cba39cd8742c27bdb5c32345af1","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        if not kwargs:"},{"line_number":94,"context_line":"            raise exceptions.CommandError(\u0027at least one option need to be \u0027"},{"line_number":95,"context_line":"                                          \u0027input.\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":98,"context_line":"        foundhost \u003d utils.find_resource("}],"source_content_type":"text/x-python","patch_set":10,"id":"1af94dfe_e50cae44","line":95,"in_reply_to":"3afc51ec_d1fabdbc","updated":"2016-03-15 20:30:56.000000000","message":"ok, will remove it","commit_id":"ab4120642cc7b8e6629684d6a5d4e545bbf93e75"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"4cf934d9aa2ec11e46b0b1b10ab1f3209291af4d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":"        status.add_argument("},{"line_number":63,"context_line":"            \u0027--disable\u0027,"},{"line_number":64,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":65,"context_line":"            help\u003d\u0027Disable the host\u0027"},{"line_number":66,"context_line":"        )"},{"line_number":67,"context_line":"        maintenance \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af94dfe_9ca6c151","line":64,"range":{"start_line":64,"start_character":20,"end_line":64,"end_character":30},"updated":"2016-03-16 12:29:11.000000000","message":"store_false ?","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"bc75e1180a45d8b957f6713de34308be5c14c77e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":"        status.add_argument("},{"line_number":63,"context_line":"            \u0027--disable\u0027,"},{"line_number":64,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":65,"context_line":"            help\u003d\u0027Disable the host\u0027"},{"line_number":66,"context_line":"        )"},{"line_number":67,"context_line":"        maintenance \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af94dfe_ea6eee94","line":64,"in_reply_to":"1af94dfe_9a150f9d","updated":"2016-03-17 02:09:04.000000000","message":"OK, my mistake. :)","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9c5670fba7dd631b5303a8c1842d9d673489ffe2","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":"        status.add_argument("},{"line_number":63,"context_line":"            \u0027--disable\u0027,"},{"line_number":64,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":65,"context_line":"            help\u003d\u0027Disable the host\u0027"},{"line_number":66,"context_line":"        )"},{"line_number":67,"context_line":"        maintenance \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af94dfe_e7bdb2d8","line":64,"range":{"start_line":64,"start_character":20,"end_line":64,"end_character":30},"in_reply_to":"1af94dfe_9ca6c151","updated":"2016-03-16 12:37:40.000000000","message":"http://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options\nPS 9 has some recommendations to use this","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"aa56c81358a6b152490215590a0b35140d59adcb","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        )"},{"line_number":62,"context_line":"        status.add_argument("},{"line_number":63,"context_line":"            \u0027--disable\u0027,"},{"line_number":64,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":65,"context_line":"            help\u003d\u0027Disable the host\u0027"},{"line_number":66,"context_line":"        )"},{"line_number":67,"context_line":"        maintenance \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af94dfe_9a150f9d","line":64,"in_reply_to":"1af94dfe_e7bdb2d8","updated":"2016-03-16 16:59:47.000000000","message":"this is correct as is","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"4cf934d9aa2ec11e46b0b1b10ab1f3209291af4d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        )"},{"line_number":73,"context_line":"        maintenance.add_argument("},{"line_number":74,"context_line":"            \u0027--disable-maintenance\u0027,"},{"line_number":75,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":76,"context_line":"            help\u003d\u0027Disable maintenance mode for the host\u0027,"},{"line_number":77,"context_line":"        )"},{"line_number":78,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af94dfe_3c6e8d01","line":75,"range":{"start_line":75,"start_character":20,"end_line":75,"end_character":30},"updated":"2016-03-16 12:29:11.000000000","message":"store_false ?","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"aa56c81358a6b152490215590a0b35140d59adcb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        )"},{"line_number":73,"context_line":"        maintenance.add_argument("},{"line_number":74,"context_line":"            \u0027--disable-maintenance\u0027,"},{"line_number":75,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":76,"context_line":"            help\u003d\u0027Disable maintenance mode for the host\u0027,"},{"line_number":77,"context_line":"        )"},{"line_number":78,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":11,"id":"1af94dfe_da8677da","line":75,"in_reply_to":"1af94dfe_3c6e8d01","updated":"2016-03-16 16:59:47.000000000","message":"ditto","commit_id":"ff3a1d3780486d98bd3205c8329576b396e8161f"}],"openstackclient/tests/compute/v2/fakes.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"7087709dc8db374ff35d9d4d1698d363fec23687","unresolved":false,"context_lines":[{"line_number":695,"context_line":"    \"\"\"Fake one host.\"\"\""},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    @staticmethod"},{"line_number":698,"context_line":"    def create_one_host(attrs\u003d{}):"},{"line_number":699,"context_line":"        \"\"\"Create a fake host."},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        :param Dictionary attrs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_499b8472","line":698,"range":{"start_line":698,"start_character":24,"end_line":698,"end_character":32},"updated":"2016-02-23 08:07:52.000000000","message":"Please do something like this:\n\ndef create_one_host(attrs\u003dNone):\n    if attrs is None:\n        attrs \u003d {}\n\nThis could be no problem, but it could be a hidden bomb.\n\nPlease refer to: http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments","commit_id":"ff27a872028f89e813281c405c87a654a577e78a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c13d6efdef7a1d146820afc3fad1652342d86664","unresolved":false,"context_lines":[{"line_number":695,"context_line":"    \"\"\"Fake one host.\"\"\""},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    @staticmethod"},{"line_number":698,"context_line":"    def create_one_host(attrs\u003d{}):"},{"line_number":699,"context_line":"        \"\"\"Create a fake host."},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        :param Dictionary attrs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_a77a2586","line":698,"range":{"start_line":698,"start_character":24,"end_line":698,"end_character":32},"in_reply_to":"bae84128_499b8472","updated":"2016-02-23 14:29:28.000000000","message":"Done","commit_id":"ff27a872028f89e813281c405c87a654a577e78a"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"af6c5480777085bef79f38ab9aec17d957e9aaf4","unresolved":false,"context_lines":[{"line_number":793,"context_line":"            \"local_gb_used\": 10,"},{"line_number":794,"context_line":"            \"hypervisor_type\": \"xen\","},{"line_number":795,"context_line":"            \"hypervisor_version\": 1,"},{"line_number":796,"context_line":"            \"hypervisor_hostname\": \"h1\","},{"line_number":797,"context_line":"            \"free_ram_mb\": 50,"},{"line_number":798,"context_line":"            \"free_disk_gb\": 50,"},{"line_number":799,"context_line":"            \"current_workload\": 10,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_7c8c7935","line":796,"range":{"start_line":796,"start_character":13,"end_line":796,"end_character":32},"updated":"2016-02-27 03:21:20.000000000","message":"There is no name attr here. Not sure if this is the host name. If so, please keep it consistent to the one you used in the unit tests. It is \"devstack1\"","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f076d6fe945276fc5146e0d00253b9b5017e8b66","unresolved":false,"context_lines":[{"line_number":793,"context_line":"            \"local_gb_used\": 10,"},{"line_number":794,"context_line":"            \"hypervisor_type\": \"xen\","},{"line_number":795,"context_line":"            \"hypervisor_version\": 1,"},{"line_number":796,"context_line":"            \"hypervisor_hostname\": \"h1\","},{"line_number":797,"context_line":"            \"free_ram_mb\": 50,"},{"line_number":798,"context_line":"            \"free_disk_gb\": 50,"},{"line_number":799,"context_line":"            \"current_workload\": 10,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_a13598f8","line":796,"range":{"start_line":796,"start_character":13,"end_line":796,"end_character":32},"in_reply_to":"9aed3d3a_7c8c7935","updated":"2016-03-01 11:21:28.000000000","message":"jichen@ubuntuneutron:~$ nova hypervisor-show ubuntuneutron\n+---------------------------+------------------------------------------+\n| Property                  | Value                                    |\n+---------------------------+------------------------------------------+\n.....\n| hypervisor_hostname       | ubuntuneutron                            |\n| hypervisor_type           | QEMU                                     |\n| hypervisor_version        | 2000000                                  |\n\nI think we have this name","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"55167d469246701b684d616ca18647f37ad8030b","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"        # Set default attributes."},{"line_number":710,"context_line":"        host_info \u003d {"},{"line_number":711,"context_line":"            \"id\": 1,"},{"line_number":712,"context_line":"            \"service_id\": 1,"},{"line_number":713,"context_line":"            \"host\": \"host1\","},{"line_number":714,"context_line":"            \"uuid\": \"\","}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_13f45085","line":711,"range":{"start_line":711,"start_character":18,"end_line":711,"end_character":19},"updated":"2016-03-02 12:30:39.000000000","message":"You can use \u0027host-id-\u0027 + uuid.uuid4().hex to fake an ID, to keep the consistence with other fake.py.","commit_id":"945a2ca9fb52574ebfc4eb2271d44381be77415e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f0983c4fc67abb9dae165cb081ad682010786f2b","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"        # Set default attributes."},{"line_number":710,"context_line":"        host_info \u003d {"},{"line_number":711,"context_line":"            \"id\": 1,"},{"line_number":712,"context_line":"            \"service_id\": 1,"},{"line_number":713,"context_line":"            \"host\": \"host1\","},{"line_number":714,"context_line":"            \"uuid\": \"\","}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_c477b99d","line":711,"range":{"start_line":711,"start_character":18,"end_line":711,"end_character":19},"in_reply_to":"7af24918_13f45085","updated":"2016-03-02 13:38:37.000000000","message":"this id is not uuid, it\u0027s integer in db, so we should keep 1 here","commit_id":"945a2ca9fb52574ebfc4eb2271d44381be77415e"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"55167d469246701b684d616ca18647f37ad8030b","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        # Set default attributes."},{"line_number":710,"context_line":"        host_info \u003d {"},{"line_number":711,"context_line":"            \"id\": 1,"},{"line_number":712,"context_line":"            \"service_id\": 1,"},{"line_number":713,"context_line":"            \"host\": \"host1\","},{"line_number":714,"context_line":"            \"uuid\": \"\","},{"line_number":715,"context_line":"            \"vcpus\": 10,"},{"line_number":716,"context_line":"            \"memory_mb\": 100,"},{"line_number":717,"context_line":"            \"local_gb\": 100,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_b312bcb2","line":714,"range":{"start_line":712,"start_character":0,"end_line":714,"end_character":23},"updated":"2016-03-02 12:30:39.000000000","message":"And also all names and IDs.","commit_id":"945a2ca9fb52574ebfc4eb2271d44381be77415e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f0983c4fc67abb9dae165cb081ad682010786f2b","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        # Set default attributes."},{"line_number":710,"context_line":"        host_info \u003d {"},{"line_number":711,"context_line":"            \"id\": 1,"},{"line_number":712,"context_line":"            \"service_id\": 1,"},{"line_number":713,"context_line":"            \"host\": \"host1\","},{"line_number":714,"context_line":"            \"uuid\": \"\","},{"line_number":715,"context_line":"            \"vcpus\": 10,"},{"line_number":716,"context_line":"            \"memory_mb\": 100,"},{"line_number":717,"context_line":"            \"local_gb\": 100,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_a4354ddb","line":714,"range":{"start_line":712,"start_character":0,"end_line":714,"end_character":23},"in_reply_to":"7af24918_b312bcb2","updated":"2016-03-02 13:38:37.000000000","message":"Done","commit_id":"945a2ca9fb52574ebfc4eb2271d44381be77415e"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1200b0de288931c840e4fa5d5513c155ead55209","unresolved":false,"context_lines":[{"line_number":893,"context_line":"        :param Dictionary attrs:"},{"line_number":894,"context_line":"            A dictionary with all attributes"},{"line_number":895,"context_line":"        :return:"},{"line_number":896,"context_line":"            A FakeResource object, with id"},{"line_number":897,"context_line":"        \"\"\""},{"line_number":898,"context_line":"        if attrs is None:"},{"line_number":899,"context_line":"            attrs \u003d {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_62307557","line":896,"range":{"start_line":896,"start_character":35,"end_line":896,"end_character":42},"updated":"2016-03-08 06:10:00.000000000","message":"and other attributes.","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"91f282876ec5652d90f980cbefb3c2b8c6ed2b5e","unresolved":false,"context_lines":[{"line_number":893,"context_line":"        :param Dictionary attrs:"},{"line_number":894,"context_line":"            A dictionary with all attributes"},{"line_number":895,"context_line":"        :return:"},{"line_number":896,"context_line":"            A FakeResource object, with id"},{"line_number":897,"context_line":"        \"\"\""},{"line_number":898,"context_line":"        if attrs is None:"},{"line_number":899,"context_line":"            attrs \u003d {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afc51ec_40d27c01","line":896,"range":{"start_line":896,"start_character":35,"end_line":896,"end_character":42},"in_reply_to":"5aef4532_62307557","updated":"2016-03-14 12:57:17.000000000","message":"Done","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"}],"openstackclient/tests/compute/v2/test_host.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"af6c5480777085bef79f38ab9aec17d957e9aaf4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        arglist \u003d ["},{"line_number":43,"context_line":"            \u0027--enable\u0027,"},{"line_number":44,"context_line":"            \u0027--disable-maintenance\u0027,"},{"line_number":45,"context_line":"            \u0027devstack1\u0027"},{"line_number":46,"context_line":"        ]"},{"line_number":47,"context_line":"        verifylist \u003d ["},{"line_number":48,"context_line":"            (\u0027status\u0027, True),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_5ca1b5a2","line":45,"range":{"start_line":45,"start_character":13,"end_line":45,"end_character":22},"updated":"2016-02-27 03:21:20.000000000","message":"Since you faked self.host_mock.get() to return the host you created, you should use the host.name here.\n\nBut there is no name attr in you FakeHost. Not sure if it is hypervisor_hostname. Please make sure that.","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f076d6fe945276fc5146e0d00253b9b5017e8b66","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        arglist \u003d ["},{"line_number":43,"context_line":"            \u0027--enable\u0027,"},{"line_number":44,"context_line":"            \u0027--disable-maintenance\u0027,"},{"line_number":45,"context_line":"            \u0027devstack1\u0027"},{"line_number":46,"context_line":"        ]"},{"line_number":47,"context_line":"        verifylist \u003d ["},{"line_number":48,"context_line":"            (\u0027status\u0027, True),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_e4720ead","line":45,"range":{"start_line":45,"start_character":13,"end_line":45,"end_character":22},"in_reply_to":"9aed3d3a_5ca1b5a2","updated":"2016-03-01 11:21:28.000000000","message":"will use id to replace the host name, thanks","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"af6c5480777085bef79f38ab9aec17d957e9aaf4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        verifylist \u003d ["},{"line_number":48,"context_line":"            (\u0027status\u0027, True),"},{"line_number":49,"context_line":"            (\u0027maintenance\u0027, False),"},{"line_number":50,"context_line":"            (\u0027host\u0027, \u0027devstack1\u0027)"},{"line_number":51,"context_line":"        ]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_9c897d29","line":50,"range":{"start_line":50,"start_character":22,"end_line":50,"end_character":31},"updated":"2016-02-27 03:21:20.000000000","message":"ditto","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"af6c5480777085bef79f38ab9aec17d957e9aaf4","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.host_mock.update.assert_called_with(self.host.id,"},{"line_number":58,"context_line":"                                                 maintenance\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_7c9f59b4","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":41},"updated":"2016-02-27 03:21:20.000000000","message":"Please also assert this return value is None. Please use:\n\nresult \u003d self.cmd.take_action(parsed_args)\nself.assertIsNone(result)","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f076d6fe945276fc5146e0d00253b9b5017e8b66","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.host_mock.update.assert_called_with(self.host.id,"},{"line_number":58,"context_line":"                                                 maintenance\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_446822bb","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":41},"in_reply_to":"9aed3d3a_7c9f59b4","updated":"2016-03-01 11:21:28.000000000","message":"Done","commit_id":"1211827a2f908b4e72855d908390a3db065bb054"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"55167d469246701b684d616ca18647f37ad8030b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        arglist \u003d ["},{"line_number":43,"context_line":"            \u0027--enable\u0027,"},{"line_number":44,"context_line":"            \u0027--disable-maintenance\u0027,"},{"line_number":45,"context_line":"            str(self.host.id)"},{"line_number":46,"context_line":"        ]"},{"line_number":47,"context_line":"        verifylist \u003d ["},{"line_number":48,"context_line":"            (\u0027status\u0027, True),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_93634041","line":45,"range":{"start_line":45,"start_character":12,"end_line":45,"end_character":15},"updated":"2016-03-02 12:30:39.000000000","message":"No need to use str() here, I think.","commit_id":"945a2ca9fb52574ebfc4eb2271d44381be77415e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f0983c4fc67abb9dae165cb081ad682010786f2b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        arglist \u003d ["},{"line_number":43,"context_line":"            \u0027--enable\u0027,"},{"line_number":44,"context_line":"            \u0027--disable-maintenance\u0027,"},{"line_number":45,"context_line":"            str(self.host.id)"},{"line_number":46,"context_line":"        ]"},{"line_number":47,"context_line":"        verifylist \u003d ["},{"line_number":48,"context_line":"            (\u0027status\u0027, True),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_415a7b51","line":45,"range":{"start_line":45,"start_character":12,"end_line":45,"end_character":15},"in_reply_to":"7af24918_93634041","updated":"2016-03-02 13:38:37.000000000","message":"seems not... otherwise , those will be reported..\n\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n      File \"openstackclient/tests/compute/v2/test_host.py\", line 53, in test_host_set\n        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)\n      File \"openstackclient/tests/utils.py\", line 90, in check_parser\n        parsed_args \u003d cmd_parser.parse_args(args)\n      File \"/usr/lib/python2.7/argparse.py\", line 1688, in parse_args\n        args, argv \u003d self.parse_known_args(args, namespace)\n      File \"/usr/lib/python2.7/argparse.py\", line 1720, in parse_known_args\n        namespace, args \u003d self._parse_known_args(args, namespace)\n      File \"/usr/lib/python2.7/argparse.py\", line 1761, in _parse_known_args\n        option_tuple \u003d self._parse_optional(arg_string)\n      File \"/usr/lib/python2.7/argparse.py\", line 2037, in _parse_optional\n        if not arg_string[0] in self.prefix_chars:\n    TypeError: \u0027int\u0027 object has no attribute \u0027__getitem__\u0027","commit_id":"945a2ca9fb52574ebfc4eb2271d44381be77415e"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1200b0de288931c840e4fa5d5513c155ead55209","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.cmd \u003d host.SetHost(self.app, None)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_host_set(self):"},{"line_number":42,"context_line":"        arglist \u003d ["},{"line_number":43,"context_line":"            \u0027--enable\u0027,"},{"line_number":44,"context_line":"            \u0027--disable-maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_4207391c","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":21},"updated":"2016-03-08 06:10:00.000000000","message":"Please also add a test for setting nothing. We should raise an exception.","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"370eec903d2db9d0e86563aa04bdbf8f44b3beff","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.cmd \u003d host.SetHost(self.app, None)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_host_set(self):"},{"line_number":42,"context_line":"        arglist \u003d ["},{"line_number":43,"context_line":"            \u0027--enable\u0027,"},{"line_number":44,"context_line":"            \u0027--disable-maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5aef4532_7da27cfe","line":41,"in_reply_to":"5aef4532_4207391c","updated":"2016-03-09 15:42:29.000000000","message":"Exception or not, we do usually have tests for no options being included to validate defaults.","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"91f282876ec5652d90f980cbefb3c2b8c6ed2b5e","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.cmd \u003d host.SetHost(self.app, None)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_host_set(self):"},{"line_number":42,"context_line":"        arglist \u003d ["},{"line_number":43,"context_line":"            \u0027--enable\u0027,"},{"line_number":44,"context_line":"            \u0027--disable-maintenance\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afc51ec_b54aa081","line":41,"in_reply_to":"5aef4532_7da27cfe","updated":"2016-03-14 12:57:17.000000000","message":"ok, will add a case","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"}],"releasenotes/notes/add-host-set-0ea29fb31702d697.yaml":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"1200b0de288931c840e4fa5d5513c155ead55209","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for the ``host set`` command."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5aef4532_a240bd57","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":45},"updated":"2016-03-08 06:10:00.000000000","message":"Sorry, I know it is a little late to say so here. Please create a bug report for the missing of \"host set\" command for OSC, like this: https://review.openstack.org/#/c/288441/4/releasenotes/notes/bug-1519502-f72236598d14d350.yaml\n\nAnd link the bug report into this release note.","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"91f282876ec5652d90f980cbefb3c2b8c6ed2b5e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for the ``host set`` command."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3afc51ec_e0b3c8e7","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":45},"in_reply_to":"5aef4532_a240bd57","updated":"2016-03-14 12:57:17.000000000","message":"ok","commit_id":"d481080369fee43d86fbbb5c2e3a6a2f152908af"}],"setup.cfg":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"0f85fadabdedf1c1c8340e1804f19aa8fec978eb","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    host_list \u003d openstackclient.compute.v2.host:ListHost"},{"line_number":82,"context_line":"    host_show \u003d openstackclient.compute.v2.host:ShowHost"},{"line_number":83,"context_line":"    host_set \u003d openstackclient.compute.v2.host:SetHost"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    hypervisor_list \u003d openstackclient.compute.v2.hypervisor:ListHypervisor"},{"line_number":86,"context_line":"    hypervisor_show \u003d openstackclient.compute.v2.hypervisor:ShowHypervisor"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"bae84128_109ec962","line":83,"updated":"2016-02-23 00:07:26.000000000","message":"These should be sorted","commit_id":"ff27a872028f89e813281c405c87a654a577e78a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c13d6efdef7a1d146820afc3fad1652342d86664","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    host_list \u003d openstackclient.compute.v2.host:ListHost"},{"line_number":82,"context_line":"    host_show \u003d openstackclient.compute.v2.host:ShowHost"},{"line_number":83,"context_line":"    host_set \u003d openstackclient.compute.v2.host:SetHost"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    hypervisor_list \u003d openstackclient.compute.v2.hypervisor:ListHypervisor"},{"line_number":86,"context_line":"    hypervisor_show \u003d openstackclient.compute.v2.hypervisor:ShowHypervisor"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"bae84128_e7a70d09","line":83,"in_reply_to":"bae84128_109ec962","updated":"2016-02-23 14:29:28.000000000","message":"Done","commit_id":"ff27a872028f89e813281c405c87a654a577e78a"}]}