)]}'
{"id":"openstack%2Fpython-openstackclient~283285","triplet_id":"openstack%2Fpython-openstackclient~master~I4ee0004934dc2322d43ef07e797a6811e39a812c","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1548530","hashtags":[],"change_id":"I4ee0004934dc2322d43ef07e797a6811e39a812c","subject":"Use instanceof instead of type","status":"MERGED","created":"2016-02-22 22:22:56.000000000","updated":"2016-02-23 08:50:24.000000000","submitted":"2016-02-23 08:50:24.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f630f5d0f73a6149b50ea6d636bc2cda2bd27fab","_number":283285,"virtual_id_number":283285,"owner":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},{"value":2,"date":"2016-02-23 08:50:24.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"recommended":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"all":[{"value":1,"date":"2016-02-23 00:33:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":2,"date":"2016-02-22 23:43:33.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2016-02-22 23:23:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-02-23 07:53:48.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-02-23 07:53:48.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-22 23:23:07.000000000","updated_by":{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},"reviewer":{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},"state":"REVIEWER"},{"updated":"2016-02-22 23:43:33.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-02-23 00:33:52.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-02-23 07:53:48.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-02-23 08:50:24.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3793ccdf1793d67feecd96b0f1dceeafcde2db98","author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"date":"2016-02-22 22:22:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0a1edd37d5452ab3311f02c23e2ccb61c972e065","author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"date":"2016-02-22 22:24:10.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"b33c847a12ea5fe956442fb406f9cdf242ab3d3f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-22 23:21:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/85/283285/2/check/gate-python-openstackclient-pep8/9b162fb/ : SUCCESS in 52s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/85/283285/2/check/gate-python-openstackclient-docs/c49856b//doc/build/html/ : SUCCESS in 1m 58s\n- gate-python-openstackclient-python27 http://logs.openstack.org/85/283285/2/check/gate-python-openstackclient-python27/10fc078/ : SUCCESS in 1m 57s\n- gate-python-openstackclient-python34 http://logs.openstack.org/85/283285/2/check/gate-python-openstackclient-python34/b20c702/ : SUCCESS in 2m 38s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/85/283285/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/49cea94/ : SUCCESS in 57m 07s\n- check-osc-plugins http://logs.openstack.org/85/283285/2/check/check-osc-plugins/b587466/ : SUCCESS in 1m 22s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/85/283285/2/check/gate-osc-dsvm-functional/9c2b90e/ : SUCCESS in 28m 20s","accounts_in_message":[],"_revision_number":2},{"id":"2e8adf7a24fd3fb81c7c751888de39119fdb33b6","author":{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},"date":"2016-02-22 23:23:07.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"c7ad83d19edc0807b4496f092bf7333227ff68d7","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-02-22 23:43:33.000000000","message":"Patch Set 2: Code-Review+2\n\nyeah, instanceof is better, thanks for fixing.","accounts_in_message":[],"_revision_number":2},{"id":"1d8b95fd934843af70618310a14b08225a4a1d3b","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-23 00:33:52.000000000","message":"Patch Set 2: Code-Review+1\n\nCan we submit a hacking rule ?","accounts_in_message":[],"_revision_number":2},{"id":"f136cf7dcf5da45e3ae73956a0a2875df6110d7c","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-23 07:53:48.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9fbf3d79034c60166fdc88e9adad97956e7a83f2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-23 07:53:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"c9d0d7304138bc6b1679785e4744fc190591a300","date":"2016-02-23 08:50:24.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"ce1275d5218216d9931f3805367942a1cd6fec1f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-23 08:50:24.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/85/283285/2/gate/gate-python-openstackclient-docs/d744915//doc/build/html/ : SUCCESS in 2m 28s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/85/283285/2/gate/gate-python-openstackclient-pep8/52586f6/ : SUCCESS in 48s\n- gate-python-openstackclient-python27 http://logs.openstack.org/85/283285/2/gate/gate-python-openstackclient-python27/f3b66a5/ : SUCCESS in 1m 12s\n- gate-python-openstackclient-python34 http://logs.openstack.org/85/283285/2/gate/gate-python-openstackclient-python34/16330ed/ : SUCCESS in 2m 20s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/85/283285/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/4fe5bf5/ : SUCCESS in 56m 25s\n- gate-osc-dsvm-functional http://logs.openstack.org/85/283285/2/gate/gate-osc-dsvm-functional/610d3d3/ : SUCCESS in 18m 23s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"11a8f911affe10bacce41ad3474a28aff3417ec3","revisions":{"720fd4459f94815d0b20522a32d8d3e9c93de876":{"kind":"REWORK","_number":1,"created":"2016-02-22 22:22:56.000000000","uploader":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"ref":"refs/changes/85/283285/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/85/283285/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/283285/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/283285/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/283285/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/85/283285/1"}}},"commit":{"parents":[{"commit":"c57fc41c33df58237f6b3ec8a5b2a0ff9573da2e","subject":"Initialize _keys in __init__() in FakeFlavorResource","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c57fc41c33df58237f6b3ec8a5b2a0ff9573da2e"}]}],"author":{"name":"Brandon Palm","email":"bapalm@us.ibm.com","date":"2016-02-22 22:20:30.000000000","tz":-360},"committer":{"name":"Brandon Palm","email":"bapalm@us.ibm.com","date":"2016-02-22 22:20:30.000000000","tz":-360},"subject":"Adjusted these conditional statements to use instanceof instead of type when comparing variables. Instanceof supports inheritance type checking better than type.","message":"Adjusted these conditional statements to use instanceof instead of\ntype when comparing variables. Instanceof supports inheritance type\nchecking better than type.\n\nChange-Id: I4ee0004934dc2322d43ef07e797a6811e39a812c\nCloses-Bug: 1548530\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/720fd4459f94815d0b20522a32d8d3e9c93de876"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/720fd4459f94815d0b20522a32d8d3e9c93de876"}]},"branch":"refs/heads/master"},"11a8f911affe10bacce41ad3474a28aff3417ec3":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-02-22 22:24:10.000000000","uploader":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"ref":"refs/changes/85/283285/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/85/283285/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/283285/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/283285/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/85/283285/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/85/283285/2"}}},"commit":{"parents":[{"commit":"c57fc41c33df58237f6b3ec8a5b2a0ff9573da2e","subject":"Initialize _keys in __init__() in FakeFlavorResource","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c57fc41c33df58237f6b3ec8a5b2a0ff9573da2e"}]}],"author":{"name":"Brandon Palm","email":"bapalm@us.ibm.com","date":"2016-02-22 22:20:30.000000000","tz":-360},"committer":{"name":"Brandon Palm","email":"bapalm@us.ibm.com","date":"2016-02-22 22:23:23.000000000","tz":-360},"subject":"Use instanceof instead of type","message":"Use instanceof instead of type\n\nAdjusted conditional statements to use instanceof when\ncomparing variables. Instanceof supports inheritance type\nchecking better than type.\n\nChange-Id: I4ee0004934dc2322d43ef07e797a6811e39a812c\nCloses-Bug: 1548530\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/11a8f911affe10bacce41ad3474a28aff3417ec3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/11a8f911affe10bacce41ad3474a28aff3417ec3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}