)]}'
{"openstackclient/tests/compute/v2/fakes.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"575f0387e10d200fb5a61acc4001296d1181cfb1","unresolved":false,"context_lines":[{"line_number":379,"context_line":"            \u0027metadata\u0027: {},"},{"line_number":380,"context_line":"            \u0027image\u0027: {"},{"line_number":381,"context_line":"                \u0027id\u0027: \u0027image-id-\u0027 + uuid.uuid4().hex,"},{"line_number":382,"context_line":"                \u0027links\u0027: []"},{"line_number":383,"context_line":"            },"},{"line_number":384,"context_line":"            \u0027flavor\u0027: {"},{"line_number":385,"context_line":"                \u0027id\u0027: \u0027flavor-id-\u0027 + uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_50775f9f","line":382,"range":{"start_line":382,"start_character":16,"end_line":382,"end_character":27},"updated":"2016-02-24 09:40:12.000000000","message":"Should be removed.","commit_id":"bccc713f57da4d76b5a04a15d088753853c83b3d"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"575f0387e10d200fb5a61acc4001296d1181cfb1","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            },"},{"line_number":384,"context_line":"            \u0027flavor\u0027: {"},{"line_number":385,"context_line":"                \u0027id\u0027: \u0027flavor-id-\u0027 + uuid.uuid4().hex,"},{"line_number":386,"context_line":"                \u0027links\u0027: []"},{"line_number":387,"context_line":"            }"},{"line_number":388,"context_line":"        }"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_3053bb18","line":386,"range":{"start_line":386,"start_character":17,"end_line":386,"end_character":27},"updated":"2016-02-24 09:40:12.000000000","message":"Should be removed.","commit_id":"bccc713f57da4d76b5a04a15d088753853c83b3d"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"5f3d50cb5bb3bc306257961396c99ac0f6cdff93","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            \u0027id\u0027: \u0027server-id-\u0027 + uuid.uuid4().hex,"},{"line_number":378,"context_line":"            \u0027name\u0027: \u0027server-name-\u0027 + uuid.uuid4().hex,"},{"line_number":379,"context_line":"            \u0027metadata\u0027: {},"},{"line_number":380,"context_line":"            \u0027image\u0027: {"},{"line_number":381,"context_line":"                \u0027id\u0027: \u0027image-id-\u0027 + uuid.uuid4().hex,"},{"line_number":382,"context_line":"            },"},{"line_number":383,"context_line":"            \u0027flavor\u0027: {"},{"line_number":384,"context_line":"                \u0027id\u0027: \u0027flavor-id-\u0027 + uuid.uuid4().hex,"},{"line_number":385,"context_line":"            }"},{"line_number":386,"context_line":"        }"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        # Overwrite default attributes."}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_c79ede62","line":385,"range":{"start_line":380,"start_character":0,"end_line":385,"end_character":13},"updated":"2016-02-25 00:59:12.000000000","message":"Yes, we should extend this to support more tests.","commit_id":"e0b6cab09bfe5d83435afe069d08820fcc1c5aa7"}],"openstackclient/tests/compute/v2/test_server.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"60cfa136c1c31d12d846083fc44ead25f9cd2957","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        super(TestServerList, self).setUp()"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        self.image \u003d image_fakes.FakeImage.create_one_image()"},{"line_number":704,"context_line":"        self.cimages_mock.get.return_value \u003d self.image"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        self.flavor \u003d compute_fakes.FakeFlavor.create_one_flavor()"},{"line_number":707,"context_line":"        self.flavors_mock.get.return_value \u003d self.flavor"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_54580156","line":704,"range":{"start_line":704,"start_character":13,"end_line":704,"end_character":25},"updated":"2016-02-24 03:33:30.000000000","message":"cimages_mock?\n\nimages_mock","commit_id":"11a2d9f14e205c4deaee8828354bb659508546e2"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"000d460ece20044a1b99dc232b2a4cac23e8b95e","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        super(TestServerList, self).setUp()"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        self.image \u003d image_fakes.FakeImage.create_one_image()"},{"line_number":704,"context_line":"        self.cimages_mock.get.return_value \u003d self.image"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        self.flavor \u003d compute_fakes.FakeFlavor.create_one_flavor()"},{"line_number":707,"context_line":"        self.flavors_mock.get.return_value \u003d self.flavor"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_a352f264","line":704,"range":{"start_line":704,"start_character":13,"end_line":704,"end_character":25},"in_reply_to":"bae84128_54580156","updated":"2016-02-24 05:42:11.000000000","message":"Hi Steve, \n\nI think it is correct here. compute_client.images is used in the source code.\n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L797","commit_id":"11a2d9f14e205c4deaee8828354bb659508546e2"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"115a4fc8cae8a57e6dfb6a546d9666ce31cc4e8a","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        super(TestServerList, self).setUp()"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        self.image \u003d image_fakes.FakeImage.create_one_image()"},{"line_number":704,"context_line":"        self.cimages_mock.get.return_value \u003d self.image"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        self.flavor \u003d compute_fakes.FakeFlavor.create_one_flavor()"},{"line_number":707,"context_line":"        self.flavors_mock.get.return_value \u003d self.flavor"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_eeb8612c","line":704,"range":{"start_line":704,"start_character":13,"end_line":704,"end_character":25},"in_reply_to":"bae84128_a352f264","updated":"2016-02-24 05:54:50.000000000","message":"hey tang,\n\ni meant naming it \"images_mock\" instead of \"cimages_mock\", i think it was a typo?","commit_id":"11a2d9f14e205c4deaee8828354bb659508546e2"},{"author":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"change_message_id":"78f9cf59a2fd1093bb9630895a7d2ed88542deb9","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        super(TestServerList, self).setUp()"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        self.image \u003d image_fakes.FakeImage.create_one_image()"},{"line_number":704,"context_line":"        self.cimages_mock.get.return_value \u003d self.image"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        self.flavor \u003d compute_fakes.FakeFlavor.create_one_flavor()"},{"line_number":707,"context_line":"        self.flavors_mock.get.return_value \u003d self.flavor"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_2e61a9a9","line":704,"range":{"start_line":704,"start_character":13,"end_line":704,"end_character":25},"in_reply_to":"bae84128_eeb8612c","updated":"2016-02-24 06:01:05.000000000","message":"Thank you for reviewing Steve.\ncimages_mock is different from images_mock.\nBoth have defined already.\nhere: \nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/compute/v2/test_server.py#L38","commit_id":"11a2d9f14e205c4deaee8828354bb659508546e2"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"23355cb41df433b379e0aca74923a9d4d115d541","unresolved":false,"context_lines":[{"line_number":718,"context_line":"            \u0027OS-EXT-AZ:availability_zone\u0027: \u0027availability-zone-xxx\u0027,"},{"line_number":719,"context_line":"            \u0027OS-EXT-SRV-ATTR:host\u0027: \u0027host-name-xxx\u0027,"},{"line_number":720,"context_line":"            \u0027Metadata\u0027: \u0027\u0027,"},{"line_number":721,"context_line":"            \u0027image\u0027: self.image,"},{"line_number":722,"context_line":"            \u0027flavor\u0027: self.flavor,"},{"line_number":723,"context_line":"        }"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        # The servers to be listed."}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_0ed6654e","line":722,"range":{"start_line":721,"start_character":0,"end_line":722,"end_character":34},"updated":"2016-02-24 06:09:32.000000000","message":"I don\u0027t think here should image and flavor objects. They should be dicts I think. Maybe I\u0027m wrong. But please try to print the server returned by \"server list\" command and confirm it.","commit_id":"fc1fb93a629fb127843bf5c8dede59c97ab2ffb9"},{"author":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"change_message_id":"d3180853e74c9d8518115d84494ae08f658f07c0","unresolved":false,"context_lines":[{"line_number":718,"context_line":"            \u0027OS-EXT-AZ:availability_zone\u0027: \u0027availability-zone-xxx\u0027,"},{"line_number":719,"context_line":"            \u0027OS-EXT-SRV-ATTR:host\u0027: \u0027host-name-xxx\u0027,"},{"line_number":720,"context_line":"            \u0027Metadata\u0027: \u0027\u0027,"},{"line_number":721,"context_line":"            \u0027image\u0027: self.image,"},{"line_number":722,"context_line":"            \u0027flavor\u0027: self.flavor,"},{"line_number":723,"context_line":"        }"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        # The servers to be listed."}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_ae8c99da","line":722,"range":{"start_line":721,"start_character":0,"end_line":722,"end_character":34},"in_reply_to":"bae84128_0ed6654e","updated":"2016-02-24 06:29:56.000000000","message":"Chen, I partly agree with you. \nself.image or self.image.id is all right.\nBut,  in source code: utils.find_resource(compute_client.images, parsed_args.image).id\nhere:\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L797\n\nit means, the return value of self.cimages_mock.get must be a object contains arrtibution of id. So here cannot be a dict.\nI think it\u0027s the easiest way.","commit_id":"fc1fb93a629fb127843bf5c8dede59c97ab2ffb9"},{"author":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"change_message_id":"353e0f302331b66eda24bde1cd1abcdc5d7e8f2f","unresolved":false,"context_lines":[{"line_number":718,"context_line":"            \u0027OS-EXT-AZ:availability_zone\u0027: \u0027availability-zone-xxx\u0027,"},{"line_number":719,"context_line":"            \u0027OS-EXT-SRV-ATTR:host\u0027: \u0027host-name-xxx\u0027,"},{"line_number":720,"context_line":"            \u0027Metadata\u0027: \u0027\u0027,"},{"line_number":721,"context_line":"            \u0027image\u0027: self.image,"},{"line_number":722,"context_line":"            \u0027flavor\u0027: self.flavor,"},{"line_number":723,"context_line":"        }"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        # The servers to be listed."}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_09a13ff8","line":722,"range":{"start_line":721,"start_character":0,"end_line":722,"end_character":34},"in_reply_to":"bae84128_ae8c99da","updated":"2016-02-24 06:34:02.000000000","message":"If we use dict here, we have to use the same value in line:793. and how to cope with the return value of self.cimages_mock.get?","commit_id":"fc1fb93a629fb127843bf5c8dede59c97ab2ffb9"}]}