)]}'
{"id":"openstack%2Fpython-openstackclient~284728","triplet_id":"openstack%2Fpython-openstackclient~master~Icc1bf29aa82f54ea8146a250e37be911306d316f","project":"openstack/python-openstackclient","branch":"master","topic":"no-api-version-check","hashtags":[],"change_id":"Icc1bf29aa82f54ea8146a250e37be911306d316f","subject":"Remove API version checks","status":"ABANDONED","created":"2016-02-25 14:12:40.000000000","updated":"2016-06-24 03:19:18.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5a84f70033eadaa9eeac41c310145a1126c38733","_number":284728,"virtual_id_number":284728,"owner":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2016-05-16 22:57:56.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-25 21:20:25.000000000","updated_by":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"reviewer":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"state":"REVIEWER"},{"updated":"2016-02-26 22:04:41.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-05-16 22:57:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ced70bd74d51574abf5c28b08af578d11817b5ea","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2016-02-25 14:12:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9ad1f5c7f416cc75a945240f3ed9997dda16c9f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-25 16:26:04.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/28/284728/1/check/gate-python-openstackclient-pep8/570c155/ : FAILURE in 1m 14s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/28/284728/1/check/gate-python-openstackclient-docs/7cfd79e//doc/build/html/ : SUCCESS in 1m 48s\n- gate-python-openstackclient-python27 http://logs.openstack.org/28/284728/1/check/gate-python-openstackclient-python27/2a67ef7/ : SUCCESS in 1m 31s\n- gate-python-openstackclient-python34 http://logs.openstack.org/28/284728/1/check/gate-python-openstackclient-python34/98356cb/ : SUCCESS in 2m 14s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/28/284728/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/1c59cd1/ : SUCCESS in 54m 48s\n- check-osc-plugins http://logs.openstack.org/28/284728/1/check/check-osc-plugins/60c6140/ : SUCCESS in 1m 36s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/28/284728/1/check/gate-osc-dsvm-functional/1651f17/ : SUCCESS in 35m 56s","accounts_in_message":[],"_revision_number":1},{"id":"886e269fc4ad124cb790c751792284092ddcf074","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2016-02-25 20:54:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"99f0bfad45936c3befe7348f038cb3bd417a4722","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-26 00:45:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/28/284728/2/check/gate-python-openstackclient-pep8/71dd644/ : SUCCESS in 1m 05s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/28/284728/2/check/gate-python-openstackclient-docs/55240af//doc/build/html/ : SUCCESS in 1m 40s\n- gate-python-openstackclient-python27 http://logs.openstack.org/28/284728/2/check/gate-python-openstackclient-python27/fc88c81/ : SUCCESS in 1m 23s\n- gate-python-openstackclient-python34 http://logs.openstack.org/28/284728/2/check/gate-python-openstackclient-python34/d568e2f/ : SUCCESS in 2m 19s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/28/284728/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/0ae425d/ : SUCCESS in 1h 03m 03s\n- check-osc-plugins http://logs.openstack.org/28/284728/2/check/check-osc-plugins/1237ad6/ : SUCCESS in 1m 20s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/28/284728/2/check/gate-osc-dsvm-functional/6a2aa73/ : SUCCESS in 26m 39s","accounts_in_message":[],"_revision_number":2},{"id":"5308bdcb68fe89603f23aba249ca178fbd1f9464","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-02-26 22:04:41.000000000","message":"Patch Set 2:\n\nI haven\u0027t tried this yet, my first question is does it still allow --os-compute-api-version to specify an exact version to use?","accounts_in_message":[],"_revision_number":2},{"id":"b783f2593d13c1fe7bde444251359779ae1f621c","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2016-02-26 22:40:41.000000000","message":"Patch Set 2:\n\nI think so\n\n\njichen@ubuntuneutron:~$ openstack --debug --os-compute-api-version 2.12 server list\n....\nREQ: curl -g -i -X GET http://192.168.122.105:8774/v2.1/1cbcd4ec6bc440e59caeb0882869c085/servers/detail -H \"User-Agent: python-novaclient\" -H \"Accept: application/json\" -H \"X-OpenStack-Nova-API-Version: 2.12\" -H \"X-Auth-Token: {SHA1}7a84171509dfbac6e5dde4d66a6c87e26eff1290\"","accounts_in_message":[],"_revision_number":2},{"id":"8ca0f38c4f0714ad3b8be9244d303c15def017ec","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2016-02-26 22:41:59.000000000","message":"Patch Set 2:\n\noh... wait, I will update my devstack with changes I added and try again,sorry","accounts_in_message":[],"_revision_number":2},{"id":"2c1abff43b480731479716b0dcdc59f2532183f5","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2016-02-26 22:44:25.000000000","message":"Patch Set 2:\n\nto make test easy, I added \u0027return True\u0027 directly\nand test result is same to I pasted before\nthe option can still be used \n\n\n/usr/local/lib/python2.7/dist-packages/openstackclient/compute/client.py\n\n    _compute_api_version \u003d api_versions.get_api_version(check_version)\n\n    return True\n    if _compute_api_version \u003e api_versions.APIVersion(\"2.0\"):\n        if not _compute_api_version.matches(\n            novaclient.API_MIN_VERSION,\n            novaclient.API_MAX_VERSION,\n        ):\n            raise exceptions.CommandError(\n                \"versions supported by client: %s - %s\" % (\n                    novaclient.API_MIN_VERSION.get_string(),\n                    novaclient.API_MAX_VERSION.get_string(),\n                ),\n            )","accounts_in_message":[],"_revision_number":2},{"id":"eeffc8563e75a9ba54c69c59122aa624e0e659de","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2016-04-11 11:02:54.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"9673aa1e3dd7c366b203c513b5f492a19591f7f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-11 12:17:04.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/28/284728/3/check/gate-python-openstackclient-docs/0113251//doc/build/html/ : SUCCESS in 4m 01s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/28/284728/3/check/gate-python-openstackclient-pep8/9c38842/ : SUCCESS in 2m 58s\n- gate-python-openstackclient-python27 http://logs.openstack.org/28/284728/3/check/gate-python-openstackclient-python27/dae5339/ : SUCCESS in 3m 45s\n- gate-python-openstackclient-python34 http://logs.openstack.org/28/284728/3/check/gate-python-openstackclient-python34/d8fb900/ : SUCCESS in 5m 05s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/28/284728/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/e3268c3/ : SUCCESS in 1h 11m 13s\n- check-osc-plugins http://logs.openstack.org/28/284728/3/check/check-osc-plugins/e112f9f/ : SUCCESS in 4m 17s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/28/284728/3/check/gate-osc-dsvm-functional/88af656/ : SUCCESS in 15m 09s","accounts_in_message":[],"_revision_number":3},{"id":"d5d0c9a35fc91ee42a1200131713f48608588521","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-16 22:57:56.000000000","message":"Patch Set 3: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"8ceeb1b5e44dd0821e9a30bf98022fc357f7f0cb","author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"date":"2016-06-24 03:19:18.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"3fde9bb08ba2a19300316f9b32d6d8a3db9e948e","revisions":{"a4ff09ac98fca2729dd9d8703383a3482385758d":{"kind":"REWORK","_number":1,"created":"2016-02-25 14:12:40.000000000","uploader":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"ref":"refs/changes/28/284728/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/28/284728/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/28/284728/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/28/284728/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/28/284728/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/28/284728/1"}}},"commit":{"parents":[{"commit":"ad93e9f9333ad04ad10058332c5a97570bf8f038","subject":"Merge \"Improve tox to show coverage report on same window\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ad93e9f9333ad04ad10058332c5a97570bf8f038"}]}],"author":{"name":"jichenjc","email":"jichenjc@cn.ibm.com","date":"2016-02-20 16:21:12.000000000","tz":480},"committer":{"name":"jichenjc","email":"jichenjc@cn.ibm.com","date":"2016-02-20 16:21:12.000000000","tz":480},"subject":"Remove API version checks","message":"Remove API version checks\n\nThere are version checks in nova with more detailed check\nlike whether server side support compatible versions,\nalso, some check like 2.a1 is not valid version etc\ndon\u0027t need to check in openstackclient side.\n\nChange-Id: Icc1bf29aa82f54ea8146a250e37be911306d316f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a4ff09ac98fca2729dd9d8703383a3482385758d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a4ff09ac98fca2729dd9d8703383a3482385758d"}]},"branch":"refs/heads/master"},"8c940d6272cd2ad7816421d4e4c5354ec2b1b8d2":{"kind":"REWORK","_number":2,"created":"2016-02-25 20:54:53.000000000","uploader":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"ref":"refs/changes/28/284728/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/28/284728/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/28/284728/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/28/284728/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/28/284728/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/28/284728/2"}}},"commit":{"parents":[{"commit":"ad93e9f9333ad04ad10058332c5a97570bf8f038","subject":"Merge \"Improve tox to show coverage report on same window\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ad93e9f9333ad04ad10058332c5a97570bf8f038"}]}],"author":{"name":"jichenjc","email":"jichenjc@cn.ibm.com","date":"2016-02-20 16:21:12.000000000","tz":480},"committer":{"name":"jichenjc","email":"jichenjc@cn.ibm.com","date":"2016-02-20 18:00:43.000000000","tz":480},"subject":"Remove API version checks","message":"Remove API version checks\n\nThere are version checks in nova with more detailed check\nlike whether server side support compatible versions,\nalso, some check like 2.a1 is not valid version etc\ndon\u0027t need to check in openstackclient side.\n\nChange-Id: Icc1bf29aa82f54ea8146a250e37be911306d316f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8c940d6272cd2ad7816421d4e4c5354ec2b1b8d2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8c940d6272cd2ad7816421d4e4c5354ec2b1b8d2"}]},"branch":"refs/heads/master"},"3fde9bb08ba2a19300316f9b32d6d8a3db9e948e":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2016-04-11 11:02:54.000000000","uploader":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"ref":"refs/changes/28/284728/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/28/284728/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/28/284728/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/28/284728/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/28/284728/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/28/284728/3"}}},"commit":{"parents":[{"commit":"cb8f757779ded16b769bce2c990650662dfa5223","subject":"Merge \"Refactor security group rule list to use SDK\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cb8f757779ded16b769bce2c990650662dfa5223"}]}],"author":{"name":"jichenjc","email":"jichenjc@cn.ibm.com","date":"2016-02-20 16:21:12.000000000","tz":480},"committer":{"name":"jichenjc","email":"jichenjc@cn.ibm.com","date":"2016-04-11 11:02:54.000000000","tz":0},"subject":"Remove API version checks","message":"Remove API version checks\n\nThere are version checks in nova with more detailed check\nlike whether server side support compatible versions,\nalso, some check like 2.a1 is not valid version etc\ndon\u0027t need to check in openstackclient side.\n\nChange-Id: Icc1bf29aa82f54ea8146a250e37be911306d316f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3fde9bb08ba2a19300316f9b32d6d8a3db9e948e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3fde9bb08ba2a19300316f9b32d6d8a3db9e948e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}