)]}'
{"id":"openstack%2Fpython-openstackclient~285561","triplet_id":"openstack%2Fpython-openstackclient~master~Ibdede3eab23f0417fe50284ae92ba912af033a9c","project":"openstack/python-openstackclient","branch":"master","topic":"cinderclient_mock","hashtags":[],"change_id":"Ibdede3eab23f0417fe50284ae92ba912af033a9c","subject":"Cinderclient is passed broken mock","status":"ABANDONED","created":"2016-02-26 21:56:06.000000000","updated":"2016-03-02 06:33:11.000000000","total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bf7b53570bf6f1b387b6fd32495b2f59e2d5e796","_number":285561,"virtual_id_number":285561,"owner":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"date":"2016-03-01 16:04:55.000000000","_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":1,"date":"2016-03-01 00:59:12.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-03-01 08:43:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":-1,"date":"2016-03-01 02:34:32.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2016-03-01 03:01:53.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"date":"2016-03-01 03:02:01.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"date":"2016-03-01 03:01:58.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-29 16:36:04.000000000","updated_by":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"reviewer":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"state":"REVIEWER"},{"updated":"2016-03-01 00:59:12.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-03-01 02:34:32.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-03-01 03:01:53.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-03-01 03:01:58.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-03-01 03:02:01.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2016-03-01 08:43:36.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"}],"messages":[{"id":"2eca53b24689e5c208927d6ccf6c2bb12cd1e198","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2016-02-26 21:56:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d9ed9cad19fcb5d730eb9f170428fe141697a938","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-27 01:24:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/61/285561/1/check/gate-python-openstackclient-pep8/9d681df/ : FAILURE in 3m 01s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/61/285561/1/check/gate-python-openstackclient-docs/40576bf//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-openstackclient-python27 http://logs.openstack.org/61/285561/1/check/gate-python-openstackclient-python27/6fa46ec/ : FAILURE in 1m 36s\n- gate-python-openstackclient-python34 http://logs.openstack.org/61/285561/1/check/gate-python-openstackclient-python34/86749d6/ : FAILURE in 2m 06s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/61/285561/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/fc4d58a/ : SUCCESS in 1h 10m 18s\n- check-osc-plugins http://logs.openstack.org/61/285561/1/check/check-osc-plugins/5d77129/ : SUCCESS in 1m 27s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/61/285561/1/check/gate-osc-dsvm-functional/cc8495b/ : SUCCESS in 28m 49s","accounts_in_message":[],"_revision_number":1},{"id":"2299f3e0ae3c7080fc4cfb04f9769126ca9e6fa1","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-02-27 03:26:41.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9a3f72f1fd7b910a80451d2c300722f25179601d","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2016-02-29 14:30:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f169e6b1e4a731c4b3ba3c66eca1a535062bfbc3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-29 19:33:19.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/61/285561/2/check/gate-python-openstackclient-pep8/275959a/ : FAILURE in 55s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/61/285561/2/check/gate-python-openstackclient-docs/16a21ca//doc/build/html/ : SUCCESS in 2m 02s\n- gate-python-openstackclient-python27 http://logs.openstack.org/61/285561/2/check/gate-python-openstackclient-python27/361f428/ : SUCCESS in 1m 16s\n- gate-python-openstackclient-python34 http://logs.openstack.org/61/285561/2/check/gate-python-openstackclient-python34/f850b6a/ : SUCCESS in 2m 19s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/61/285561/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/09c0185/ : SUCCESS in 1h 27m 18s\n- check-osc-plugins http://logs.openstack.org/61/285561/2/check/check-osc-plugins/5f38cfd/ : SUCCESS in 1m 19s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/61/285561/2/check/gate-osc-dsvm-functional/c97f661/ : SUCCESS in 22m 20s","accounts_in_message":[],"_revision_number":2},{"id":"2eac084bce81b7a62da471532d58b171071ca101","author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"date":"2016-02-29 20:11:22.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1c03972eae349a602e2e67ad04dd3bbb81c88662","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2016-02-29 21:23:28.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"376eb1d0e341e09c4866ee856a7af30b96668d09","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2016-02-29 21:33:21.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7bd30c81369d70045118e1e31304b567ab5ea032","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-01 00:59:12.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/61/285561/3/check/gate-python-openstackclient-pep8/da7ee83/ : SUCCESS in 53s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/61/285561/3/check/gate-python-openstackclient-docs/6a51533//doc/build/html/ : SUCCESS in 1m 59s\n- gate-python-openstackclient-python27 http://logs.openstack.org/61/285561/3/check/gate-python-openstackclient-python27/e498c8b/ : SUCCESS in 1m 49s\n- gate-python-openstackclient-python34 http://logs.openstack.org/61/285561/3/check/gate-python-openstackclient-python34/c367441/ : SUCCESS in 2m 09s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/61/285561/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/3c56eff/ : SUCCESS in 1h 00m 35s\n- check-osc-plugins http://logs.openstack.org/61/285561/3/check/check-osc-plugins/d85378a/ : SUCCESS in 1m 33s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/61/285561/3/check/gate-osc-dsvm-functional/52c4641/ : SUCCESS in 22m 49s","accounts_in_message":[],"_revision_number":3},{"id":"cbf7398b386d8626cea03ac538597ad0f8ba067c","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-01 02:34:32.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"d27d063108ea1fb4a2e34ba63cc7847acf8a5274","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2016-03-01 08:43:36.000000000","message":"Patch Set 3: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"2ce2bd253fc410e443b2eacaf6e96873a8b5a566","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2016-03-01 16:04:55.000000000","message":"Patch Set 3:\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"0c880b24130eef65b553d5a7abbeb5cb4486fd20","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2016-03-01 18:50:02.000000000","message":"Patch Set 3:\n\n(2 comments)\n\nmore problems with these tests ...","accounts_in_message":[],"_revision_number":3},{"id":"a706316e2a2510ae18166fb7f45c32a452612354","author":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"date":"2016-03-01 20:03:29.000000000","message":"Abandoned\n\nRui Chen is right, side_effect is the right technique to use here. I was confused on how mock works... at least i know a lot more about mock now.","accounts_in_message":[],"_revision_number":3},{"id":"b40bc6d423dba5a59f78ff7ceb881ce36a4f83d1","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-02 06:33:11.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"92729022d4c668e7b9854795e3b8f66c3e50fba1","revisions":{"0ab57bfe1d039a193349cdf14adfa1a42e682b07":{"kind":"REWORK","_number":1,"created":"2016-02-26 21:56:06.000000000","uploader":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"ref":"refs/changes/61/285561/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/61/285561/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/285561/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/285561/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/285561/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/61/285561/1"}}},"commit":{"parents":[{"commit":"2819450be5d4fa57c6efdb4cd225f59bab894fba","subject":"Merge \"Add shell --profile option to trigger osprofiler from CLI\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2819450be5d4fa57c6efdb4cd225f59bab894fba"}]}],"author":{"name":"Tom Cocozzello","email":"tjcocozz@us.ibm.com","date":"2016-02-26 21:54:08.000000000","tz":-360},"committer":{"name":"Tom Cocozzello","email":"tjcocozz@us.ibm.com","date":"2016-02-26 21:56:00.000000000","tz":-360},"subject":"Cinderclient mock is set up inccorrectly","message":"Cinderclient mock is set up inccorrectly\n\nMock for the cinderclient is causing some interesting functionality.\nEvery time the get() in the VolumeManager is called, mock returns a different\nvalue. The first time it returns the correct value then after that it\nfalls off the track.\n\nChange-Id: Ibdede3eab23f0417fe50284ae92ba912af033a9c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0ab57bfe1d039a193349cdf14adfa1a42e682b07"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0ab57bfe1d039a193349cdf14adfa1a42e682b07"}]},"branch":"refs/heads/master"},"194fffc5d06877145586df0aa6fd2fc96c5f58a3":{"kind":"REWORK","_number":2,"created":"2016-02-29 14:30:12.000000000","uploader":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"ref":"refs/changes/61/285561/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/61/285561/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/285561/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/285561/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/285561/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/61/285561/2"}}},"commit":{"parents":[{"commit":"2819450be5d4fa57c6efdb4cd225f59bab894fba","subject":"Merge \"Add shell --profile option to trigger osprofiler from CLI\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2819450be5d4fa57c6efdb4cd225f59bab894fba"}]}],"author":{"name":"Tom Cocozzello","email":"tjcocozz@us.ibm.com","date":"2016-02-26 21:54:08.000000000","tz":-360},"committer":{"name":"Tom Cocozzello","email":"tjcocozz@us.ibm.com","date":"2016-02-29 14:29:34.000000000","tz":-360},"subject":"Cinderclient is passed broken mock","message":"Cinderclient is passed broken mock\n\nMock for the cinderclient is causing some interesting functionality.\nEvery time the get() in the VolumeManager is called, mock returns a different\nvalue. The first time it returns the correct value then after that it\nfalls off the track.\n\nChange-Id: Ibdede3eab23f0417fe50284ae92ba912af033a9c\nPartial-Bug: #1551252\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/194fffc5d06877145586df0aa6fd2fc96c5f58a3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/194fffc5d06877145586df0aa6fd2fc96c5f58a3"}]},"branch":"refs/heads/master"},"92729022d4c668e7b9854795e3b8f66c3e50fba1":{"kind":"REWORK","_number":3,"created":"2016-02-29 21:33:21.000000000","uploader":{"_account_id":17123,"name":"Tom Cocozzello (tjcocozz)","email":"tjcocozz@us.ibm.com","username":"tcocozzello"},"ref":"refs/changes/61/285561/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/61/285561/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/285561/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/285561/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/285561/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/61/285561/3"}}},"commit":{"parents":[{"commit":"2819450be5d4fa57c6efdb4cd225f59bab894fba","subject":"Merge \"Add shell --profile option to trigger osprofiler from CLI\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2819450be5d4fa57c6efdb4cd225f59bab894fba"}]}],"author":{"name":"Tom Cocozzello","email":"tjcocozz@us.ibm.com","date":"2016-02-26 21:54:08.000000000","tz":-360},"committer":{"name":"Tom Cocozzello","email":"tjcocozz@us.ibm.com","date":"2016-02-29 21:31:41.000000000","tz":-360},"subject":"Cinderclient is passed broken mock","message":"Cinderclient is passed broken mock\n\nMock for the cinderclient is causing some interesting functionality.\nEvery time the get() in the VolumeManager is called, mock returns a different\nvalue. The first time it returns the correct value then after that it\nfalls off the track.\n\nThe problem originated from declaring \u0027side_effect\u0027 as a iterator so every\ntime \u0027side_effect\u0027 was called the return value was dynamically changed [0].\nLuckily no one was actually using \u0027side_effect\u0027 for its real use case and\nit was used get the correct return value. Instead of using \u0027side_effect\u0027\nincorrectly, \u0027return_value\u0027 should be used instead.\n\n[0]: https://docs.python.org/3/library/unittest.mock.html#the-mock-class\n\nChange-Id: Ibdede3eab23f0417fe50284ae92ba912af033a9c\nCloses-Bug: #1551252\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/92729022d4c668e7b9854795e3b8f66c3e50fba1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/92729022d4c668e7b9854795e3b8f66c3e50fba1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}