)]}'
{"openstackclient/compute/v2/server.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8d8ce41a9fbbf691cc430e3f23a7b419f430fc18","unresolved":false,"context_lines":[{"line_number":627,"context_line":"            image_id,"},{"line_number":628,"context_line":"        )"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        return zip(*sorted(six.iteritems(image._info)))"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":""},{"line_number":633,"context_line":"class DeleteServer(command.Command):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_4865d0df","side":"PARENT","line":630,"range":{"start_line":630,"start_character":46,"end_line":630,"end_character":52},"updated":"2016-03-01 12:58:59.000000000","message":"the base class of \u0027image\u0027 is different in glanceclient v1 and v2, so the code work with glanceclient v1, but failed with v2. the glanceclient is backwards incompatible, I prefer to fix it in glanceclient side.\n\nwait for others comments.","commit_id":"7039cd344764da7c1e946cb0746e78b0f501df1c"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8d8ce41a9fbbf691cc430e3f23a7b419f430fc18","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def _prep_image_detail(image_client, image_id):"},{"line_number":165,"context_line":"    \"\"\"Prepare the detailed server dict for printing"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    :param compute_client: a compute client instance"},{"line_number":168,"context_line":"    :param server: id of image created"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_0d83ddcd","line":165,"range":{"start_line":165,"start_character":28,"end_line":165,"end_character":34},"updated":"2016-03-01 12:58:59.000000000","message":"nit: s/server/image/","commit_id":"b8033d036779da780198ce00e9c7f34bd2615950"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8d8ce41a9fbbf691cc430e3f23a7b419f430fc18","unresolved":false,"context_lines":[{"line_number":164,"context_line":"def _prep_image_detail(image_client, image_id):"},{"line_number":165,"context_line":"    \"\"\"Prepare the detailed server dict for printing"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    :param compute_client: a compute client instance"},{"line_number":168,"context_line":"    :param server: id of image created"},{"line_number":169,"context_line":"    :rtype: a dict of image details"},{"line_number":170,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_6d4b81b1","line":167,"range":{"start_line":167,"start_character":11,"end_line":167,"end_character":43},"updated":"2016-03-01 12:58:59.000000000","message":"nit: should be image_client","commit_id":"b8033d036779da780198ce00e9c7f34bd2615950"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8d8ce41a9fbbf691cc430e3f23a7b419f430fc18","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    \"\"\"Prepare the detailed server dict for printing"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    :param compute_client: a compute client instance"},{"line_number":168,"context_line":"    :param server: id of image created"},{"line_number":169,"context_line":"    :rtype: a dict of image details"},{"line_number":170,"context_line":"    \"\"\""},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_6df9c14d","line":168,"range":{"start_line":168,"start_character":11,"end_line":168,"end_character":17},"updated":"2016-03-01 12:58:59.000000000","message":"nit: image_id","commit_id":"b8033d036779da780198ce00e9c7f34bd2615950"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8f5ea89012f31410f821d9d59dec387bae493dab","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        image_client.images,"},{"line_number":174,"context_line":"        image_id,"},{"line_number":175,"context_line":"    )"},{"line_number":176,"context_line":"    # During testing, info value would be FakeResource"},{"line_number":177,"context_line":"    # object. The following condition deals with it."},{"line_number":178,"context_line":"    try:"},{"line_number":179,"context_line":"        info.id"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_8704374a","line":176,"updated":"2016-03-03 15:47:06.000000000","message":"This seems like a test case problem.  I don\u0027t think we should be adding code here specifically for the test case.","commit_id":"e4143aff059632975e42f554a8435f0a9800a7e7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a328694432217766650ed06c35715c6eb71ff387","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    )"},{"line_number":176,"context_line":"    # Glance client V2 doesn\u0027t have _info attribute"},{"line_number":177,"context_line":"    # The following condition deals with it."},{"line_number":178,"context_line":"    try:"},{"line_number":179,"context_line":"        info.id"},{"line_number":180,"context_line":"        return info._info"},{"line_number":181,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_c9664dec","line":178,"updated":"2016-03-03 17:41:18.000000000","message":"How about using getattr() with a default value instead?","commit_id":"b8d183ddbfd901fbd32604bf12b0e1c27d246d8b"}]}