)]}'
{"id":"openstack%2Fpython-openstackclient~287037","triplet_id":"openstack%2Fpython-openstackclient~master~I237ea772f74fa52af2e9aacd35d4b9cfb225c94c","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1550636","hashtags":[],"change_id":"I237ea772f74fa52af2e9aacd35d4b9cfb225c94c","subject":"[Image] Check return value is None in image unit tests.","status":"MERGED","created":"2016-03-02 08:30:12.000000000","updated":"2016-03-02 17:25:19.000000000","submitted":"2016-03-02 17:25:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d3a8b4b6e9762fe2721f4a51a628cf01e6876fdd","_number":287037,"virtual_id_number":287037,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-03-02 17:25:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-03-02 13:32:36.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":2,"date":"2016-03-02 16:14:41.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2016-03-02 16:14:41.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-02 13:32:36.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-03-02 16:14:41.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-03-02 17:25:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"06404ac0926cf7d7aa57bef8e50f9be03e3b3fca","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-02 08:30:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"aab113b9ef1d2ad058134474f8e1df9dca7a9f45","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-02 10:01:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/37/287037/1/check/gate-python-openstackclient-pep8/baef4c2/ : SUCCESS in 1m 17s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/37/287037/1/check/gate-python-openstackclient-docs/c1b3692//doc/build/html/ : SUCCESS in 3m 22s\n- gate-python-openstackclient-python27 http://logs.openstack.org/37/287037/1/check/gate-python-openstackclient-python27/be946eb/ : SUCCESS in 1m 29s\n- gate-python-openstackclient-python34 http://logs.openstack.org/37/287037/1/check/gate-python-openstackclient-python34/3bbe10b/ : SUCCESS in 2m 19s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/37/287037/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/7df8b32/ : SUCCESS in 1h 11m 17s\n- check-osc-plugins http://logs.openstack.org/37/287037/1/check/check-osc-plugins/3bebd68/ : SUCCESS in 1m 37s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/37/287037/1/check/gate-osc-dsvm-functional/822932f/ : SUCCESS in 42m 32s","accounts_in_message":[],"_revision_number":1},{"id":"d06fa52f32b4702ada256d94bc8aa90b61d5be40","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-02 13:32:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7f5ec29c5e5fe381d3e5472e2faaae77be3957d7","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-03-02 16:14:41.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"c39b837579b667e596d74e93956ebfeac164d31c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-02 16:14:48.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"66221a345963e84366e1303426e8fbb1ec4e193a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-02 17:25:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/37/287037/1/gate/gate-python-openstackclient-docs/93cdd4c//doc/build/html/ : SUCCESS in 2m 46s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/37/287037/1/gate/gate-python-openstackclient-pep8/1b999f9/ : SUCCESS in 1m 03s\n- gate-python-openstackclient-python27 http://logs.openstack.org/37/287037/1/gate/gate-python-openstackclient-python27/880ef2a/ : SUCCESS in 1m 30s\n- gate-python-openstackclient-python34 http://logs.openstack.org/37/287037/1/gate/gate-python-openstackclient-python34/f58312b/ : SUCCESS in 4m 09s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/37/287037/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/26a562b/ : SUCCESS in 1h 10m 03s\n- gate-osc-dsvm-functional http://logs.openstack.org/37/287037/1/gate/gate-osc-dsvm-functional/763e7fb/ : SUCCESS in 32m 48s","accounts_in_message":[],"_revision_number":1},{"id":"b14396d7cf6f37e546655c5a1863899b4389ae90","date":"2016-03-02 17:25:19.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fd53a4980f27a72e9a0d39cde9fad01cb5c6744a","revisions":{"fd53a4980f27a72e9a0d39cde9fad01cb5c6744a":{"kind":"REWORK","_number":1,"created":"2016-03-02 08:30:12.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/37/287037/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/37/287037/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/37/287037/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/37/287037/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/37/287037/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/37/287037/1"}}},"commit":{"parents":[{"commit":"f9add0559c52bf3d0866cfbd320982c5143f6ef6","subject":"Merge \"Devref: Options with Choices\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f9add0559c52bf3d0866cfbd320982c5143f6ef6"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-29 06:53:57.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-03-02 08:16:37.000000000","tz":480},"subject":"[Image] Check return value is None in image unit tests.","message":"[Image] Check return value is None in image unit tests.\n\ntake_action() in commands inheriting from Command returns nothing.\nSo we should assert the return is None in the unit tests of\nthese commands.\n\nChange-Id: I237ea772f74fa52af2e9aacd35d4b9cfb225c94c\nPartial-Bug: #1550636\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/fd53a4980f27a72e9a0d39cde9fad01cb5c6744a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/fd53a4980f27a72e9a0d39cde9fad01cb5c6744a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
