)]}'
{"doc/source/command-objects/compute-service.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b90e8ee6147c3ac50d95f574d1dda27f01ba610f","unresolved":false,"context_lines":[{"line_number":50,"context_line":".. program:: compute service set"},{"line_number":51,"context_line":".. code:: bash"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    os compute service list"},{"line_number":54,"context_line":"        [--enable | --disable]"},{"line_number":55,"context_line":"        [--reason reason]"},{"line_number":56,"context_line":"        \u003chost\u003e \u003cservice\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_2a6dd4cc","line":53,"range":{"start_line":53,"start_character":23,"end_line":53,"end_character":27},"updated":"2016-03-04 22:31:05.000000000","message":"looks like an existing typo! feel free to change this to \u0027set\u0027","commit_id":"3da568e4c7e11e54efe4730e7866005d6d3d69a1"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ccc2cf16ec525f0ad296e5e6d3e21c43450b2c4b","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    os compute service set"},{"line_number":54,"context_line":"        [--enable | --disable]"},{"line_number":55,"context_line":"        [--reason reason]"},{"line_number":56,"context_line":"        \u003chost\u003e \u003cservice\u003e"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. _compute-service-set:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_8beeacea","line":55,"range":{"start_line":55,"start_character":18,"end_line":55,"end_character":24},"updated":"2016-03-07 12:36:13.000000000","message":"Include it in a pair of \u003c\u003e, please.","commit_id":"ad6483a8abe649a6e78dbc2f79cdb80899747dca"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4421067fed3bb7b1627fed1122b2cfef96e90ca2","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    os compute service set"},{"line_number":54,"context_line":"        [--enable | --disable]"},{"line_number":55,"context_line":"        [--reason reason]"},{"line_number":56,"context_line":"        \u003chost\u003e \u003cservice\u003e"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. _compute-service-set:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_138600b9","line":55,"range":{"start_line":55,"start_character":18,"end_line":55,"end_character":24},"in_reply_to":"5aef4532_8beeacea","updated":"2016-03-08 20:34:28.000000000","message":"Done","commit_id":"ad6483a8abe649a6e78dbc2f79cdb80899747dca"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ccc2cf16ec525f0ad296e5e6d3e21c43450b2c4b","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Disable service"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. describe:: --reason"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    Reason for disabling the service (in quotas)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_4be4a40c","line":67,"range":{"start_line":67,"start_character":14,"end_line":67,"end_character":22},"updated":"2016-03-07 12:36:13.000000000","message":"This reason is only available when --disable is specified. How about change the name to --disable-reason ?","commit_id":"ad6483a8abe649a6e78dbc2f79cdb80899747dca"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4421067fed3bb7b1627fed1122b2cfef96e90ca2","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Disable service"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. describe:: --reason"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    Reason for disabling the service (in quotas)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_b3962cee","line":67,"range":{"start_line":67,"start_character":14,"end_line":67,"end_character":22},"in_reply_to":"5aef4532_4be4a40c","updated":"2016-03-08 20:34:28.000000000","message":"ok, not a big deal ,thakns","commit_id":"ad6483a8abe649a6e78dbc2f79cdb80899747dca"},{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"bfab478931a335e74b060a35fa0364988f536d99","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. describe:: --reason"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    Reason for disabling the service (in quotas)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":".. describe:: \u003chost\u003e"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_a783cacb","line":69,"range":{"start_line":69,"start_character":41,"end_line":69,"end_character":47},"updated":"2016-03-07 17:37:34.000000000","message":"typo: quotas -\u003e quotes","commit_id":"ad6483a8abe649a6e78dbc2f79cdb80899747dca"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4421067fed3bb7b1627fed1122b2cfef96e90ca2","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. describe:: --reason"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    Reason for disabling the service (in quotas)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":".. describe:: \u003chost\u003e"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_f3a0b445","line":69,"range":{"start_line":69,"start_character":41,"end_line":69,"end_character":47},"in_reply_to":"5aef4532_a783cacb","updated":"2016-03-08 20:34:28.000000000","message":"Done :)","commit_id":"ad6483a8abe649a6e78dbc2f79cdb80899747dca"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"c3ad8e808857e2805fb12e22ce07115cc35ce705","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \u003chost\u003e \u003cservice\u003e"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. _compute-service-set:"},{"line_number":59,"context_line":".. describe:: --enable"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    Enable service (default)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_ad423b0e","line":59,"range":{"start_line":59,"start_character":3,"end_line":59,"end_character":11},"updated":"2016-03-09 02:09:29.000000000","message":"Not \"describe\", it should be \"option\" here. I think \"describe\" is for positioning parameter.","commit_id":"2cd666564f886108bac972b6dc853f85b29878bb"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"c3ad8e808857e2805fb12e22ce07115cc35ce705","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    Enable service (default)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. describe:: --disable"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Disable service"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_8d45bf18","line":63,"range":{"start_line":63,"start_character":3,"end_line":63,"end_character":11},"updated":"2016-03-09 02:09:29.000000000","message":"ditto","commit_id":"2cd666564f886108bac972b6dc853f85b29878bb"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"c3ad8e808857e2805fb12e22ce07115cc35ce705","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Disable service"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. describe:: --disable-reason"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    Reason for disabling the service (in quotes)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5aef4532_cd47c71b","line":67,"range":{"start_line":67,"start_character":3,"end_line":67,"end_character":11},"updated":"2016-03-09 02:09:29.000000000","message":"ditto","commit_id":"2cd666564f886108bac972b6dc853f85b29878bb"}],"openstackclient/compute/v2/service.py":[{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"a42183e80ecb6ba5f252963077d62ef18f753bf3","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            action\u003d\"store_false\")"},{"line_number":98,"context_line":"        parser.add_argument("},{"line_number":99,"context_line":"            \"--reason\","},{"line_number":100,"context_line":"            default\u003d\u0027\u0027,"},{"line_number":101,"context_line":"            metavar\u003d\"\u003creason\u003e\","},{"line_number":102,"context_line":"            help\u003d\"Reason for why the service is disabled\")"},{"line_number":103,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_74c00c7c","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":23},"updated":"2016-03-02 16:29:56.000000000","message":"Suggestion: You may be able to omit \u0027default\u0027 arg. Doing this will set \u0027reason\u0027 to None by default. Then below, you can use \u0027if parsed_args.reason:\u0027 instead of \u0027if len(parsed_args.reason) \u003e 0:\u0027.","commit_id":"1e9d5efba948637d236145d160cd89ee9c1cb8de"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"b6c1bbde123d9232a4f78fe2bf08544ef04c846f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            action\u003d\"store_false\")"},{"line_number":98,"context_line":"        parser.add_argument("},{"line_number":99,"context_line":"            \"--reason\","},{"line_number":100,"context_line":"            default\u003d\u0027\u0027,"},{"line_number":101,"context_line":"            metavar\u003d\"\u003creason\u003e\","},{"line_number":102,"context_line":"            help\u003d\"Reason for why the service is disabled\")"},{"line_number":103,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_be2d0a48","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":23},"in_reply_to":"7af24918_74c00c7c","updated":"2016-03-03 13:56:04.000000000","message":"ok, thanks ,that make sense","commit_id":"1e9d5efba948637d236145d160cd89ee9c1cb8de"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"a42183e80ecb6ba5f252963077d62ef18f753bf3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \"--reason\","},{"line_number":100,"context_line":"            default\u003d\u0027\u0027,"},{"line_number":101,"context_line":"            metavar\u003d\"\u003creason\u003e\","},{"line_number":102,"context_line":"            help\u003d\"Reason for why the service is disabled\")"},{"line_number":103,"context_line":"        return parser"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_145b8855","line":102,"range":{"start_line":102,"start_character":17,"end_line":102,"end_character":57},"updated":"2016-03-02 16:29:56.000000000","message":"This sounds as if the service is disabled prior to providing a reason. Maybe something like \"Reason for disabling the service\" will suit better here? I\u0027m not sure if something similar exists but you might also want to suggest \"(in quotes)\" since this wont work without using quotes.","commit_id":"1e9d5efba948637d236145d160cd89ee9c1cb8de"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"b6c1bbde123d9232a4f78fe2bf08544ef04c846f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \"--reason\","},{"line_number":100,"context_line":"            default\u003d\u0027\u0027,"},{"line_number":101,"context_line":"            metavar\u003d\"\u003creason\u003e\","},{"line_number":102,"context_line":"            help\u003d\"Reason for why the service is disabled\")"},{"line_number":103,"context_line":"        return parser"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_7e742235","line":102,"range":{"start_line":102,"start_character":17,"end_line":102,"end_character":57},"in_reply_to":"7af24918_145b8855","updated":"2016-03-03 13:56:04.000000000","message":"ok for the change on the wording\nwhen you say \u0027won\u0027t work without using quota\u0027 \ncan you give a reference ? thanks a lot","commit_id":"1e9d5efba948637d236145d160cd89ee9c1cb8de"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"4462f6cdebb5757e7104cedc552590a054b8425b","unresolved":false,"context_lines":[{"line_number":99,"context_line":"            \"--reason\","},{"line_number":100,"context_line":"            default\u003d\u0027\u0027,"},{"line_number":101,"context_line":"            metavar\u003d\"\u003creason\u003e\","},{"line_number":102,"context_line":"            help\u003d\"Reason for why the service is disabled\")"},{"line_number":103,"context_line":"        return parser"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_4f240b5f","line":102,"range":{"start_line":102,"start_character":17,"end_line":102,"end_character":57},"in_reply_to":"7af24918_7e742235","updated":"2016-03-03 15:14:03.000000000","message":"Sure, you may test it out if you try:\nos service set --disable --reason my reason vs. os service set --disable --reason \"my reason\"\n\nDo they both work?","commit_id":"1e9d5efba948637d236145d160cd89ee9c1cb8de"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ccc2cf16ec525f0ad296e5e6d3e21c43450b2c4b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                cs.disable(parsed_args.host, parsed_args.service)"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            cs.enable(parsed_args.host, parsed_args.service)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_6b5ec046","line":118,"range":{"start_line":118,"start_character":12,"end_line":118,"end_character":21},"updated":"2016-03-07 12:36:13.000000000","message":"So, if --enable and --reason are specified at the same time, --reason will be ignored. I cannot find a good way to check it. So I suggest, make the options like this:\n\n--enable or --disable reason\u003d\u003creason\u003e\n\nHow do you think ?","commit_id":"ad6483a8abe649a6e78dbc2f79cdb80899747dca"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3468fa4d33b13078d2ea42a5320ed144b384ac63","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                cs.disable(parsed_args.host, parsed_args.service)"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            cs.enable(parsed_args.host, parsed_args.service)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_c847da49","line":118,"range":{"start_line":118,"start_character":12,"end_line":118,"end_character":21},"in_reply_to":"5aef4532_6b5ec046","updated":"2016-03-08 12:32:10.000000000","message":"i\u0027m okay with this... the help does say it\u0027s for disabling the service, it\u0027s harmless. maybe dtroyer has a better suggestion.","commit_id":"ad6483a8abe649a6e78dbc2f79cdb80899747dca"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4421067fed3bb7b1627fed1122b2cfef96e90ca2","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                cs.disable(parsed_args.host, parsed_args.service)"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            cs.enable(parsed_args.host, parsed_args.service)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_33b21c95","line":118,"range":{"start_line":118,"start_character":12,"end_line":118,"end_character":21},"in_reply_to":"5aef4532_6b5ec046","updated":"2016-03-08 20:34:28.000000000","message":"this reason is not mandatory .....you can use \nservice --disable to just disable it without give a reason\nI think we already tell the user it\u0027s \u0027disabling\u0027?","commit_id":"ad6483a8abe649a6e78dbc2f79cdb80899747dca"}],"openstackclient/tests/compute/v2/test_service.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b90e8ee6147c3ac50d95f574d1dda27f01ba610f","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        self.assertIsNone(result)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_service_set_disable_with_reason(self):"},{"line_number":158,"context_line":"        reason \u003d \u0027earthquake\u0027"},{"line_number":159,"context_line":"        arglist \u003d ["},{"line_number":160,"context_line":"            compute_fakes.service_host,"},{"line_number":161,"context_line":"            compute_fakes.service_binary,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_ca85505a","line":158,"range":{"start_line":158,"start_character":18,"end_line":158,"end_character":28},"updated":"2016-03-04 22:31:05.000000000","message":"good reason to disable a service :]","commit_id":"3da568e4c7e11e54efe4730e7866005d6d3d69a1"}]}