)]}'
{"id":"openstack%2Fpython-openstackclient~287763","triplet_id":"openstack%2Fpython-openstackclient~master~I4225179dca4aedf799e1656ec49236bdedc5e9bd","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1519511","hashtags":[],"change_id":"I4225179dca4aedf799e1656ec49236bdedc5e9bd","subject":"Refactor security group set to use SDK","status":"MERGED","created":"2016-03-03 12:34:36.000000000","updated":"2016-03-05 16:19:26.000000000","submitted":"2016-03-05 16:08:20.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"603e1f4dccc495854cfa8a218443114f6e9a518e","_number":287763,"virtual_id_number":287763,"owner":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-03-05 16:08:20.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-03-04 22:59:57.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-03-05 15:06:14.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-03-05 15:06:14.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"date":"2016-03-05 13:17:34.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-04 22:59:57.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-03-05 15:06:14.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-03-05 16:08:20.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f9e4f7c0105db0ec51e8c43182c9cb72670b7340","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-03 12:34:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1943cc05aa15a77bacc6a21dfdf6d9bf37b68a1a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-03 13:34:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/63/287763/1/check/gate-python-openstackclient-pep8/0bac6c6/ : SUCCESS in 53s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/63/287763/1/check/gate-python-openstackclient-docs/9618f3b//doc/build/html/ : SUCCESS in 2m 06s\n- gate-python-openstackclient-python27 http://logs.openstack.org/63/287763/1/check/gate-python-openstackclient-python27/0e0d051/ : SUCCESS in 1m 08s\n- gate-python-openstackclient-python34 http://logs.openstack.org/63/287763/1/check/gate-python-openstackclient-python34/56177e6/ : SUCCESS in 2m 25s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/63/287763/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/8234a5d/ : SUCCESS in 59m 11s\n- check-osc-plugins http://logs.openstack.org/63/287763/1/check/check-osc-plugins/7e7c156/ : SUCCESS in 1m 05s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/63/287763/1/check/gate-osc-dsvm-functional/b18ef5a/ : SUCCESS in 24m 11s","accounts_in_message":[],"_revision_number":1},{"id":"31d90b7c99e0d9db8c203d202e8e2a045b31f4f3","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-03-04 22:59:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9004d295d335dc66e08fc4f207c56c57980c9bb1","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-05 03:28:23.000000000","message":"Patch Set 1: Code-Review+1\n\nI think we\u0027d better add a new release-note for this. It means \"security group set\" command is now available for both nova and neutron network.","accounts_in_message":[],"_revision_number":1},{"id":"b60ed1f2230f344aa98c9a42bd306ee83e9eaddb","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-05 13:07:04.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"371e060d68bb67a7fc327370aaf336eca3f8c008","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-05 13:07:10.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"9ad482e6a873ae4f704efb81ca9fef6443335457","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-05 13:07:10.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"1622dc74682b929c48c4a5351518b9be0c3a5419","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-05 13:09:13.000000000","message":"Patch Set 1:\n\nSorry, fat finger on clicking workflow....\n\nHi Tang, \"os security group set\" has always been available for nova and neutron network.  This simply does the refactor.  The only end user change is that refactoring to use the SDK for neutron allows the name and description to be set to an empty string.  Do you think a release note is appropriate for that?","accounts_in_message":[],"_revision_number":1},{"id":"a08ca8993b8d6b559fc7dfc395302134a89eb44e","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-05 13:15:35.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"2ddddf8db18deee1ae8edaa293f9af1c181de586","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-05 13:17:34.000000000","message":"Patch Set 1: -Workflow\n\nLooks like I cannot undo the approval.  I\u0027m sorry about that.  I can push a follow-up patch set for a release note to cover the behavior change.","accounts_in_message":[],"_revision_number":1},{"id":"4f7e6870e37181883510c59a33240d94b2eded16","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-05 14:18:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/63/287763/1/gate/gate-python-openstackclient-docs/f7395c3//doc/build/html/ : SUCCESS in 3m 41s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/63/287763/1/gate/gate-python-openstackclient-pep8/8823b75/ : SUCCESS in 2m 18s\n- gate-python-openstackclient-python27 http://logs.openstack.org/63/287763/1/gate/gate-python-openstackclient-python27/ad0256d/ : SUCCESS in 3m 15s\n- gate-python-openstackclient-python34 http://logs.openstack.org/63/287763/1/gate/gate-python-openstackclient-python34/d63e330/ : SUCCESS in 4m 39s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/63/287763/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/6dc2897/ : SUCCESS in 1h 11m 43s\n- gate-osc-dsvm-functional http://logs.openstack.org/63/287763/1/gate/gate-osc-dsvm-functional/67ad320/ : SUCCESS in 23m 40s","accounts_in_message":[],"_revision_number":1},{"id":"4d248198d646d22946eb3052a63f16d18bb8059f","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-05 15:06:14.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nok","accounts_in_message":[],"_revision_number":1},{"id":"34cdc9c41da2d490b9052b9fce402fadec9bf491","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-05 15:06:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"95ffb87442843651c1accd3bf490359ded16e177","date":"2016-03-05 16:08:20.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"9393e79395e99d803a620b6ac1cd7f240bdd1fad","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-05 16:08:20.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/63/287763/1/gate/gate-python-openstackclient-docs/0f078e5//doc/build/html/ : SUCCESS in 4m 11s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/63/287763/1/gate/gate-python-openstackclient-pep8/f7b3d21/ : SUCCESS in 2m 15s\n- gate-python-openstackclient-python27 http://logs.openstack.org/63/287763/1/gate/gate-python-openstackclient-python27/2198dd3/ : SUCCESS in 3m 09s\n- gate-python-openstackclient-python34 http://logs.openstack.org/63/287763/1/gate/gate-python-openstackclient-python34/0835ba9/ : SUCCESS in 3m 28s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/63/287763/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/a93a01e/ : SUCCESS in 1h 01m 56s\n- gate-osc-dsvm-functional http://logs.openstack.org/63/287763/1/gate/gate-osc-dsvm-functional/cf36609/ : SUCCESS in 22m 55s","accounts_in_message":[],"_revision_number":1},{"id":"24bb262f4956d9284206035a643adfa234be5f42","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-05 16:19:26.000000000","message":"Patch Set 1:\n\nHere is the release not patch: https://review.openstack.org/#/c/288911/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bac9fb18c1455f6a309e7acff9230a8d6bf7079b","revisions":{"bac9fb18c1455f6a309e7acff9230a8d6bf7079b":{"kind":"REWORK","_number":1,"created":"2016-03-03 12:34:36.000000000","uploader":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"ref":"refs/changes/63/287763/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/63/287763/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/287763/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/287763/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/63/287763/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/63/287763/1"}}},"commit":{"parents":[{"commit":"f9add0559c52bf3d0866cfbd320982c5143f6ef6","subject":"Merge \"Devref: Options with Choices\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f9add0559c52bf3d0866cfbd320982c5143f6ef6"}]}],"author":{"name":"Richard Theis","email":"rtheis@us.ibm.com","date":"2016-03-02 21:45:01.000000000","tz":-360},"committer":{"name":"Richard Theis","email":"rtheis@us.ibm.com","date":"2016-03-03 12:33:15.000000000","tz":-360},"subject":"Refactor security group set to use SDK","message":"Refactor security group set to use SDK\n\nRefactored the \u0027os security group set\u0027 command to use the SDK\nwhen neutron is enabled, but continue to use the nova client\nwhen nova network is enabled.\n\nThis patch set also fixes a compute bug which ignores name\nand description when set to an empty value.\n\nChange-Id: I4225179dca4aedf799e1656ec49236bdedc5e9bd\nPartial-Bug: #1519511\nImplements: blueprint neutron-client\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bac9fb18c1455f6a309e7acff9230a8d6bf7079b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bac9fb18c1455f6a309e7acff9230a8d6bf7079b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}