)]}'
{"id":"openstack%2Fpython-openstackclient~288241","triplet_id":"openstack%2Fpython-openstackclient~master~Idd961a5fa3db825353700837a559621d17f782c5","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1550636","hashtags":[],"change_id":"Idd961a5fa3db825353700837a559621d17f782c5","subject":"[Volume] Check return value is None in volume unit tests","status":"MERGED","created":"2016-03-04 04:03:47.000000000","updated":"2016-03-04 17:55:26.000000000","submitted":"2016-03-04 17:55:25.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f49c801d8592f98be45c6c13dfa1f40bc3dfc882","_number":288241,"virtual_id_number":288241,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-03-04 17:55:25.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-03-04 12:41:38.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":2,"date":"2016-03-04 16:57:48.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2016-03-04 16:57:48.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-04 12:41:38.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-03-04 16:57:48.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-03-04 17:55:25.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7384e1d13ceed76e3c022aceee1a1d3911ed8fe8","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-04 04:03:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"662696eb5281c38fafaab17eb760e1f23f98da0a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-04 05:05:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/41/288241/1/check/gate-python-openstackclient-pep8/2f3a218/ : SUCCESS in 57s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/41/288241/1/check/gate-python-openstackclient-docs/4566d1f//doc/build/html/ : SUCCESS in 1m 56s\n- gate-python-openstackclient-python27 http://logs.openstack.org/41/288241/1/check/gate-python-openstackclient-python27/915a37b/ : FAILURE in 1m 26s\n- gate-python-openstackclient-python34 http://logs.openstack.org/41/288241/1/check/gate-python-openstackclient-python34/ddbbd29/ : FAILURE in 2m 06s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/41/288241/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/f1a1c6d/ : SUCCESS in 1h 01m 15s\n- check-osc-plugins http://logs.openstack.org/41/288241/1/check/check-osc-plugins/be53adf/ : FAILURE in 1m 13s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/41/288241/1/check/gate-osc-dsvm-functional/4650609/ : SUCCESS in 24m 03s","accounts_in_message":[],"_revision_number":1},{"id":"5e5e2138216ea946cadb04433e02141a8405609d","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-04 06:26:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6aa464c3f80a9bd38d4bec00bfebec467d659079","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-04 07:34:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/41/288241/2/check/gate-python-openstackclient-pep8/4ecf703/ : SUCCESS in 1m 09s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/41/288241/2/check/gate-python-openstackclient-docs/4ace207//doc/build/html/ : SUCCESS in 1m 58s\n- gate-python-openstackclient-python27 http://logs.openstack.org/41/288241/2/check/gate-python-openstackclient-python27/5fa6245/ : SUCCESS in 1m 48s\n- gate-python-openstackclient-python34 http://logs.openstack.org/41/288241/2/check/gate-python-openstackclient-python34/d6d742c/ : SUCCESS in 2m 30s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/41/288241/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/1fc4cd9/ : SUCCESS in 1h 07m 42s\n- check-osc-plugins http://logs.openstack.org/41/288241/2/check/check-osc-plugins/5570699/ : FAILURE in 1m 11s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/41/288241/2/check/gate-osc-dsvm-functional/6a4b0e4/ : SUCCESS in 22m 55s","accounts_in_message":[],"_revision_number":2},{"id":"64958849ae16c1319340b5fecd89677a16060a53","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-04 12:41:38.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a2b74f8a29c3955cdd585e47bc3df5cd6a56c5e2","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-03-04 16:57:48.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThanks for doing these in one shot, Tang.","accounts_in_message":[],"_revision_number":2},{"id":"24d3c644fc443c96ba69eedd9729e1604708ba17","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-04 16:57:55.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"b4edb605ba7e9f2878083e790f776c9b9adf7367","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-04 17:55:25.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/41/288241/2/gate/gate-python-openstackclient-docs/6214886//doc/build/html/ : SUCCESS in 1m 53s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/41/288241/2/gate/gate-python-openstackclient-pep8/79960bf/ : SUCCESS in 44s\n- gate-python-openstackclient-python27 http://logs.openstack.org/41/288241/2/gate/gate-python-openstackclient-python27/ba9d681/ : SUCCESS in 1m 22s\n- gate-python-openstackclient-python34 http://logs.openstack.org/41/288241/2/gate/gate-python-openstackclient-python34/61782c5/ : SUCCESS in 1m 51s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/41/288241/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/94500e2/ : SUCCESS in 56m 53s\n- gate-osc-dsvm-functional http://logs.openstack.org/41/288241/2/gate/gate-osc-dsvm-functional/2c9d6fd/ : SUCCESS in 23m 16s","accounts_in_message":[],"_revision_number":2},{"id":"dfbeac1d913ed1098501c0047395db1ea937a05c","date":"2016-03-04 17:55:26.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b58dd4f17f60b3c6347683b619c093b8d1a40c0b","revisions":{"a92bcf156861c97d08cd985373bbb72bad7c525c":{"kind":"REWORK","_number":1,"created":"2016-03-04 04:03:47.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/41/288241/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/41/288241/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/41/288241/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/41/288241/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/41/288241/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/41/288241/1"}}},"commit":{"parents":[{"commit":"977eb4f1a659b7a3ea913eb6f145577975dfe36d","subject":"Merge \"Trivial: Reorder unit tests in alphabetical order in volume tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/977eb4f1a659b7a3ea913eb6f145577975dfe36d"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-29 08:50:54.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-03-03 13:07:08.000000000","tz":480},"subject":"[Volume] Check return value is None in volume unit tests","message":"[Volume] Check return value is None in volume unit tests\n\ntake_action() in commands inheriting from Command returns nothing.\nSo we should assert the return is None in the unit tests of these\ncommands.\n\nChange-Id: Idd961a5fa3db825353700837a559621d17f782c5\nPartial-Bug: #1550636\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a92bcf156861c97d08cd985373bbb72bad7c525c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a92bcf156861c97d08cd985373bbb72bad7c525c"}]},"branch":"refs/heads/master"},"b58dd4f17f60b3c6347683b619c093b8d1a40c0b":{"kind":"REWORK","_number":2,"created":"2016-03-04 06:26:35.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/41/288241/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/41/288241/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/41/288241/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/41/288241/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/41/288241/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/41/288241/2"}}},"commit":{"parents":[{"commit":"977eb4f1a659b7a3ea913eb6f145577975dfe36d","subject":"Merge \"Trivial: Reorder unit tests in alphabetical order in volume tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/977eb4f1a659b7a3ea913eb6f145577975dfe36d"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-02-29 08:50:54.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-03-03 13:07:08.000000000","tz":480},"subject":"[Volume] Check return value is None in volume unit tests","message":"[Volume] Check return value is None in volume unit tests\n\ntake_action() in commands inheriting from Command returns nothing.\nSo we should assert the return is None in the unit tests of these\ncommands.\n\nChange-Id: Idd961a5fa3db825353700837a559621d17f782c5\nPartial-Bug: #1550636\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b58dd4f17f60b3c6347683b619c093b8d1a40c0b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b58dd4f17f60b3c6347683b619c093b8d1a40c0b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}