)]}'
{"id":"openstack%2Fpython-openstackclient~288861","triplet_id":"openstack%2Fpython-openstackclient~master~If07e89953d40ac530f08cbb1ec05f5805171364b","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1553468","hashtags":[],"change_id":"If07e89953d40ac530f08cbb1ec05f5805171364b","subject":"Test take_action() instead of run() in unit tests","status":"MERGED","created":"2016-03-05 10:03:19.000000000","updated":"2016-03-07 16:01:17.000000000","submitted":"2016-03-07 16:01:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c96f45a28d1a63b076b15e53b8ffa89c9a28f308","_number":288861,"virtual_id_number":288861,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-03-07 16:01:16.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-03-06 07:39:15.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":2,"date":"2016-03-07 15:03:17.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2016-03-07 01:38:22.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":1,"date":"2016-03-07 15:03:17.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-06 07:39:15.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-03-07 01:38:22.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2016-03-07 15:03:17.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-03-07 16:01:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"66eb0872ce489d5fb3481dc8a1feed88d0fe6070","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-05 10:03:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"25c699a1a000fdb4775df9d33c5c87d674682ce7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-05 11:05:04.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/61/288861/1/check/gate-python-openstackclient-pep8/2f1f5e9/ : SUCCESS in 2m 25s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/61/288861/1/check/gate-python-openstackclient-docs/37ca445//doc/build/html/ : SUCCESS in 4m 09s\n- gate-python-openstackclient-python27 http://logs.openstack.org/61/288861/1/check/gate-python-openstackclient-python27/cdef80e/ : SUCCESS in 3m 39s\n- gate-python-openstackclient-python34 http://logs.openstack.org/61/288861/1/check/gate-python-openstackclient-python34/1cf2517/ : SUCCESS in 4m 21s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/61/288861/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/d553e58/ : SUCCESS in 1h 01m 37s\n- check-osc-plugins http://logs.openstack.org/61/288861/1/check/check-osc-plugins/a81d4fd/ : FAILURE in 1m 04s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/61/288861/1/check/gate-osc-dsvm-functional/31ad994/ : FAILURE in 1m 54s","accounts_in_message":[],"_revision_number":1},{"id":"be7e2f47aef5ce78bdb3d800d634b41e93e3498e","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-05 15:49:38.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"f1832be59568b182628eba34d4b17da1780cd04b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-05 16:52:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-pep8 http://logs.openstack.org/61/288861/1/check/gate-python-openstackclient-pep8/fef1b8f/ : SUCCESS in 3m 26s\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/61/288861/1/check/gate-python-openstackclient-docs/c7de7e2//doc/build/html/ : SUCCESS in 3m 25s\n- gate-python-openstackclient-python27 http://logs.openstack.org/61/288861/1/check/gate-python-openstackclient-python27/f8f2848/ : SUCCESS in 3m 29s\n- gate-python-openstackclient-python34 http://logs.openstack.org/61/288861/1/check/gate-python-openstackclient-python34/79f888e/ : SUCCESS in 4m 54s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/61/288861/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/cfff905/ : SUCCESS in 1h 02m 47s\n- check-osc-plugins http://logs.openstack.org/61/288861/1/check/check-osc-plugins/6766f14/ : FAILURE in 1m 08s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/61/288861/1/check/gate-osc-dsvm-functional/6e75e86/ : SUCCESS in 29m 56s","accounts_in_message":[],"_revision_number":1},{"id":"e7fded69e5e19cdbd14e8279780950afb2513825","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-03-06 07:39:15.000000000","message":"Patch Set 1: Code-Review+2\n\nNice change. I agree with your reasoning","accounts_in_message":[],"_revision_number":1},{"id":"56a98d248aefad439ef051bf27c2367967ea8bba","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-07 15:03:17.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a21a92efdd672a6d542a264a6807c46495ff2cde","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-07 15:03:23.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"259abc984df1a9392cef884abb112065b28907ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-07 16:01:16.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/61/288861/1/gate/gate-python-openstackclient-docs/f8781aa//doc/build/html/ : SUCCESS in 3m 23s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/61/288861/1/gate/gate-python-openstackclient-pep8/011fb6b/ : SUCCESS in 2m 15s\n- gate-python-openstackclient-python27 http://logs.openstack.org/61/288861/1/gate/gate-python-openstackclient-python27/4d30919/ : SUCCESS in 2m 02s\n- gate-python-openstackclient-python34 http://logs.openstack.org/61/288861/1/gate/gate-python-openstackclient-python34/32352c5/ : SUCCESS in 2m 42s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/61/288861/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/592fba3/ : SUCCESS in 57m 47s\n- gate-osc-dsvm-functional http://logs.openstack.org/61/288861/1/gate/gate-osc-dsvm-functional/dccfade/ : SUCCESS in 37m 00s","accounts_in_message":[],"_revision_number":1},{"id":"d28ae20ec043a0593cbf661bc14312a0668396bd","date":"2016-03-07 16:01:17.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"eb1574281b84e86ee4c4b65d900e1de82c24471e","revisions":{"eb1574281b84e86ee4c4b65d900e1de82c24471e":{"kind":"REWORK","_number":1,"created":"2016-03-05 10:03:19.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/61/288861/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/61/288861/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/288861/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/288861/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/61/288861/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/61/288861/1"}}},"commit":{"parents":[{"commit":"fa3a34322c532c6ae09b7b21c305b6a92d99300a","subject":"Merge \"[compute] Support restore server\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/fa3a34322c532c6ae09b7b21c305b6a92d99300a"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-03-05 09:12:42.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-03-05 09:12:42.000000000","tz":480},"subject":"Test take_action() instead of run() in unit tests","message":"Test take_action() instead of run() in unit tests\n\nSome of the unit tests test run(), but not take_action().\n\nFor example, in openstackclient/tests/volume/v1/test_volume.py, there is:\n\n    def test_volume_set_size_smaller(self):\n        ......\n\n        result \u003d self.cmd.run(parsed_args)\n\n        self.assertEqual(0, result)\n        ......\n\nrun() is defined in class Command in cliff. We don\u0027t need to test it in OSC\nunit tests. On the contrary, we should test take_action(), which is\noverwritten in each command classes in OSC.\n\nChange-Id: If07e89953d40ac530f08cbb1ec05f5805171364b\nCloses-bug: #1553468\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/eb1574281b84e86ee4c4b65d900e1de82c24471e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/eb1574281b84e86ee4c4b65d900e1de82c24471e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}