)]}'
{"doc/source/command-objects/volume.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a8cf3c110370f7c4626aa061366575636bce81c","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":165,"context_line":"        [--size \u003csize\u003e]"},{"line_number":166,"context_line":"        [--property \u003ckey\u003dvalue\u003e [...] ]"},{"line_number":167,"context_line":"        [--image_property \u003ckey\u003dvalue\u003e [...] ]"},{"line_number":168,"context_line":"        \u003cvolume\u003e"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5aef4532_eafb6ebf","line":167,"range":{"start_line":167,"start_character":11,"end_line":167,"end_character":25},"updated":"2016-03-09 12:27:31.000000000","message":"same as below","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a8d95a4bcb5e771811f96232970dd51b98b8197a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":165,"context_line":"        [--size \u003csize\u003e]"},{"line_number":166,"context_line":"        [--property \u003ckey\u003dvalue\u003e [...] ]"},{"line_number":167,"context_line":"        [--image_property \u003ckey\u003dvalue\u003e [...] ]"},{"line_number":168,"context_line":"        \u003cvolume\u003e"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5aef4532_9abcaedd","line":167,"range":{"start_line":167,"start_character":11,"end_line":167,"end_character":25},"in_reply_to":"5aef4532_eafb6ebf","updated":"2016-03-09 15:34:45.000000000","message":"Done","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a8cf3c110370f7c4626aa061366575636bce81c","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    Property to add or modify for this volume (repeat option to set multiple properties)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":".. option:: --image_property \u003ckey\u003dvalue\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    To add or modify Image-property for this volume."},{"line_number":189,"context_line":"    (repeat option to set multiple properties)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5aef4532_2a6b9686","line":186,"range":{"start_line":186,"start_character":14,"end_line":186,"end_character":28},"updated":"2016-03-09 12:27:31.000000000","message":"image-property instead of image_property\n\nwe try to use dashes instead of underscores for two word options","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a8d95a4bcb5e771811f96232970dd51b98b8197a","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    Property to add or modify for this volume (repeat option to set multiple properties)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":".. option:: --image_property \u003ckey\u003dvalue\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    To add or modify Image-property for this volume."},{"line_number":189,"context_line":"    (repeat option to set multiple properties)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5aef4532_facdf285","line":186,"range":{"start_line":186,"start_character":14,"end_line":186,"end_character":28},"in_reply_to":"5aef4532_2a6b9686","updated":"2016-03-09 15:34:45.000000000","message":"Done","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a8cf3c110370f7c4626aa061366575636bce81c","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":".. option:: --image_property \u003ckey\u003dvalue\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    To add or modify Image-property for this volume."},{"line_number":189,"context_line":"    (repeat option to set multiple properties)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":".. describe:: \u003cvolume\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5aef4532_4a0c22ed","line":188,"range":{"start_line":188,"start_character":4,"end_line":188,"end_character":51},"updated":"2016-03-09 12:27:31.000000000","message":"keep this consistent with the actual help text","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a8d95a4bcb5e771811f96232970dd51b98b8197a","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":".. option:: --image_property \u003ckey\u003dvalue\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    To add or modify Image-property for this volume."},{"line_number":189,"context_line":"    (repeat option to set multiple properties)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":".. describe:: \u003cvolume\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5aef4532_5ac7c663","line":188,"range":{"start_line":188,"start_character":4,"end_line":188,"end_character":51},"in_reply_to":"5aef4532_4a0c22ed","updated":"2016-03-09 15:34:45.000000000","message":"Done","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b766068c81a84bac13c77082b4f54674f6f0b4ad","unresolved":false,"context_lines":[{"line_number":186,"context_line":".. option:: --image-property \u003ckey\u003dvalue\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    To add or modify image properties for this volume."},{"line_number":189,"context_line":"    (repeat option to set multiple image properties)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":".. describe:: \u003cvolume\u003e"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_6542cc69","line":189,"updated":"2016-03-09 21:18:09.000000000","message":"If this is a Volume API v2 only feature it should be noted here","commit_id":"49ce9c3693437d76898138e9bb39a61027142bc7"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"fcd22b2726c65a7b3f2254c54c3eff9c13e0ddae","unresolved":false,"context_lines":[{"line_number":186,"context_line":".. option:: --image-property \u003ckey\u003dvalue\u003e"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    To add or modify image properties for this volume."},{"line_number":189,"context_line":"    (repeat option to set multiple image properties)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":".. describe:: \u003cvolume\u003e"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_488eb72e","line":189,"in_reply_to":"5aef4532_6542cc69","updated":"2016-03-10 04:31:24.000000000","message":"Sure, I will update in next patchset.","commit_id":"49ce9c3693437d76898138e9bb39a61027142bc7"}],"openstackclient/tests/volume/v2/test_volume.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b766068c81a84bac13c77082b4f54674f6f0b4ad","unresolved":false,"context_lines":[{"line_number":781,"context_line":"        # In base command class ShowOne in cliff, abstract method take_action()"},{"line_number":782,"context_line":"        # returns nothing"},{"line_number":783,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":784,"context_line":"        self.assertTrue(self.volumes_mock.set_image_metadata.called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_455d1078","line":784,"updated":"2016-03-09 21:18:09.000000000","message":"You should be checking that the proper data is passed here","commit_id":"49ce9c3693437d76898138e9bb39a61027142bc7"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"fcd22b2726c65a7b3f2254c54c3eff9c13e0ddae","unresolved":false,"context_lines":[{"line_number":781,"context_line":"        # In base command class ShowOne in cliff, abstract method take_action()"},{"line_number":782,"context_line":"        # returns nothing"},{"line_number":783,"context_line":"        self.cmd.take_action(parsed_args)"},{"line_number":784,"context_line":"        self.assertTrue(self.volumes_mock.set_image_metadata.called)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a8f2db03","line":784,"in_reply_to":"5aef4532_455d1078","updated":"2016-03-10 04:31:24.000000000","message":"I will udpate the test for verification of operation...","commit_id":"49ce9c3693437d76898138e9bb39a61027142bc7"}],"openstackclient/volume/v2/volume.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a8cf3c110370f7c4626aa061366575636bce81c","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":347,"context_line":"        )"},{"line_number":348,"context_line":"        parser.add_argument("},{"line_number":349,"context_line":"            \u0027--image_property\u0027,"},{"line_number":350,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":351,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":352,"context_line":"            help\u003d\u0027Image_property to add or modify for this volume \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_6a391ea4","line":349,"range":{"start_line":349,"start_character":15,"end_line":349,"end_character":29},"updated":"2016-03-09 12:27:31.000000000","message":"this should be image-property not image_property","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a8d95a4bcb5e771811f96232970dd51b98b8197a","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":347,"context_line":"        )"},{"line_number":348,"context_line":"        parser.add_argument("},{"line_number":349,"context_line":"            \u0027--image_property\u0027,"},{"line_number":350,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":351,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":352,"context_line":"            help\u003d\u0027Image_property to add or modify for this volume \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_1a989e77","line":349,"range":{"start_line":349,"start_character":15,"end_line":349,"end_character":29},"in_reply_to":"5aef4532_6a391ea4","updated":"2016-03-09 15:34:45.000000000","message":"Done","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a8cf3c110370f7c4626aa061366575636bce81c","unresolved":false,"context_lines":[{"line_number":349,"context_line":"            \u0027--image_property\u0027,"},{"line_number":350,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":351,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":352,"context_line":"            help\u003d\u0027Image_property to add or modify for this volume \u0027"},{"line_number":353,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":354,"context_line":"        )"},{"line_number":355,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_ca4af225","line":352,"range":{"start_line":352,"start_character":18,"end_line":352,"end_character":32},"updated":"2016-03-09 12:27:31.000000000","message":"Image property* -- remove the underscore","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a8d95a4bcb5e771811f96232970dd51b98b8197a","unresolved":false,"context_lines":[{"line_number":349,"context_line":"            \u0027--image_property\u0027,"},{"line_number":350,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":351,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":352,"context_line":"            help\u003d\u0027Image_property to add or modify for this volume \u0027"},{"line_number":353,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":354,"context_line":"        )"},{"line_number":355,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_fa94d243","line":352,"range":{"start_line":352,"start_character":18,"end_line":352,"end_character":32},"in_reply_to":"5aef4532_ca4af225","updated":"2016-03-09 15:34:45.000000000","message":"Done","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a8cf3c110370f7c4626aa061366575636bce81c","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        if parsed_args.property:"},{"line_number":374,"context_line":"            volume_client.volumes.set_metadata(volume.id, parsed_args.property)"},{"line_number":375,"context_line":"        if parsed_args.image_property:"},{"line_number":376,"context_line":"            volume_client.volumes.set_image_metadata((volume.id).id, parsed_args.image_property)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        kwargs \u003d {}"},{"line_number":379,"context_line":"        if parsed_args.name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_aac846a9","line":376,"range":{"start_line":376,"start_character":53,"end_line":376,"end_character":67},"updated":"2016-03-09 12:27:31.000000000","message":"looks like you\u0027re getting the id twice?","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a8d95a4bcb5e771811f96232970dd51b98b8197a","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        if parsed_args.property:"},{"line_number":374,"context_line":"            volume_client.volumes.set_metadata(volume.id, parsed_args.property)"},{"line_number":375,"context_line":"        if parsed_args.image_property:"},{"line_number":376,"context_line":"            volume_client.volumes.set_image_metadata((volume.id).id, parsed_args.image_property)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        kwargs \u003d {}"},{"line_number":379,"context_line":"        if parsed_args.name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_3a9bda73","line":376,"range":{"start_line":376,"start_character":53,"end_line":376,"end_character":67},"in_reply_to":"5aef4532_aac846a9","updated":"2016-03-09 15:34:45.000000000","message":"Done","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a8cf3c110370f7c4626aa061366575636bce81c","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        if kwargs:"},{"line_number":384,"context_line":"            volume_client.volumes.update(volume.id, **kwargs)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        if not kwargs and not parsed_args.property and not parsed_args.image_property and not parsed_args.size:"},{"line_number":387,"context_line":"            self.app.log.error(\"No changes requested\\n\")"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_8af62af7","line":386,"range":{"start_line":386,"start_character":0,"end_line":386,"end_character":111},"updated":"2016-03-09 12:27:31.000000000","message":"this line is too long and will fail pep8 check, run tox -e pep8 before submitting the patch to check this","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a8d95a4bcb5e771811f96232970dd51b98b8197a","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        if kwargs:"},{"line_number":384,"context_line":"            volume_client.volumes.update(volume.id, **kwargs)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        if not kwargs and not parsed_args.property and not parsed_args.image_property and not parsed_args.size:"},{"line_number":387,"context_line":"            self.app.log.error(\"No changes requested\\n\")"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_9a8aee19","line":386,"range":{"start_line":386,"start_character":0,"end_line":386,"end_character":111},"in_reply_to":"5aef4532_8af62af7","updated":"2016-03-09 15:34:45.000000000","message":"Done","commit_id":"75300a651c23939c50566b60fe90f290b2946b14"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"50ed2735bd283174895df2bc82d9907cc9beccaa","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        if kwargs:"},{"line_number":385,"context_line":"            volume_client.volumes.update(volume.id, **kwargs)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        if(not kwargs and not parsed_args.property"},{"line_number":388,"context_line":"           and not parsed_args.image_property and not parsed_args.size):"},{"line_number":389,"context_line":"            self.app.log.error(\"No changes requested\\n\")"},{"line_number":390,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1af94dfe_91099e98","line":387,"range":{"start_line":387,"start_character":10,"end_line":387,"end_character":11},"updated":"2016-03-16 04:24:49.000000000","message":"nit: add a space between IF and (\n\ni\u0027m surprised flake8 tests didn\u0027t complain","commit_id":"b901818eff22c55cc1d0fa4f8be34a0a14089089"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a0950ad6f94a4b758d8248f880aef3c70c1ca554","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        if kwargs:"},{"line_number":385,"context_line":"            volume_client.volumes.update(volume.id, **kwargs)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        if(not kwargs and not parsed_args.property"},{"line_number":388,"context_line":"           and not parsed_args.image_property and not parsed_args.size):"},{"line_number":389,"context_line":"            self.app.log.error(\"No changes requested\\n\")"},{"line_number":390,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1af94dfe_5156f629","line":387,"range":{"start_line":387,"start_character":10,"end_line":387,"end_character":11},"in_reply_to":"1af94dfe_91099e98","updated":"2016-03-16 04:42:36.000000000","message":"Done","commit_id":"b901818eff22c55cc1d0fa4f8be34a0a14089089"}],"releasenotes/notes/image-property_add-7f8479791eab45b7.yaml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"50ed2735bd283174895df2bc82d9907cc9beccaa","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    So, this fix enables user to update image properties of volume"},{"line_number":11,"context_line":"    using below command:"},{"line_number":12,"context_line":"    \"volume set --image-property \u003ckey\u003dvalue\u003e \u003cvolume\u003e\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    [Bug \u0027https://bugs.launchpad.net/python-openstackclient/+bug/1554877\u0027_]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1af94dfe_11f62e8f","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":55},"updated":"2016-03-16 04:24:49.000000000","message":"instead of quotes (\") use double backticks (``)","commit_id":"b901818eff22c55cc1d0fa4f8be34a0a14089089"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a0950ad6f94a4b758d8248f880aef3c70c1ca554","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    So, this fix enables user to update image properties of volume"},{"line_number":11,"context_line":"    using below command:"},{"line_number":12,"context_line":"    \"volume set --image-property \u003ckey\u003dvalue\u003e \u003cvolume\u003e\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    [Bug \u0027https://bugs.launchpad.net/python-openstackclient/+bug/1554877\u0027_]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1af94dfe_b1313a0e","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":55},"in_reply_to":"1af94dfe_11f62e8f","updated":"2016-03-16 04:42:36.000000000","message":"Done","commit_id":"b901818eff22c55cc1d0fa4f8be34a0a14089089"}]}