)]}'
{"doc/source/command-objects/port.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5bbfa68c994901695b5f90f61112ac4b5855b478","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":26,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":27,"context_line":"        [--extra-dhcp-opt \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]]"},{"line_number":28,"context_line":"        [--qos-policy \u003cqos-policy-id\u003e]"},{"line_number":29,"context_line":"        [--allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]]"},{"line_number":30,"context_line":"        \u003cname\u003e"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_5fa57202","line":28,"updated":"2016-03-11 20:37:27.000000000","message":"I suggest using qos-policy instead of qos-policy-id.  Then if QoS policies get a name in the future this isn\u0027t confusing.","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"3e124f0e63ce767520184bde4dec7793e208d970","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":26,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":27,"context_line":"        [--extra-dhcp-opt \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]]"},{"line_number":28,"context_line":"        [--qos-policy \u003cqos-policy-id\u003e]"},{"line_number":29,"context_line":"        [--allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]]"},{"line_number":30,"context_line":"        \u003cname\u003e"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_9a02683d","line":28,"in_reply_to":"3afc51ec_5fa57202","updated":"2016-03-11 21:09:28.000000000","message":"Done","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5bbfa68c994901695b5f90f61112ac4b5855b478","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. option:: --security-group \u003csecurity-group\u003e"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    Security group(name or ID) associated with the port"},{"line_number":88,"context_line":"    (this option can be repeated)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. option::  --extra-dhcp-opt \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_1fe92a1b","line":87,"updated":"2016-03-11 20:37:27.000000000","message":"Please move (name or ID) to the end.","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5bbfa68c994901695b5f90f61112ac4b5855b478","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    Security group(name or ID) associated with the port"},{"line_number":88,"context_line":"    (this option can be repeated)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. option::  --extra-dhcp-opt \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    Extra dhcp options to be assigned to this port:"},{"line_number":93,"context_line":"    \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_1f376ab1","line":90,"updated":"2016-03-11 20:37:27.000000000","message":"nit...consider spelling out \u0027opt\u0027 as \u0027option\u0027 throughout","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"3e124f0e63ce767520184bde4dec7793e208d970","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    Security group(name or ID) associated with the port"},{"line_number":88,"context_line":"    (this option can be repeated)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. option::  --extra-dhcp-opt \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    Extra dhcp options to be assigned to this port:"},{"line_number":93,"context_line":"    \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_5ad100cd","line":90,"in_reply_to":"3afc51ec_1f376ab1","updated":"2016-03-11 21:09:28.000000000","message":"Done","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5bbfa68c994901695b5f90f61112ac4b5855b478","unresolved":false,"context_lines":[{"line_number":90,"context_line":".. option::  --extra-dhcp-opt \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    Extra dhcp options to be assigned to this port:"},{"line_number":93,"context_line":"    \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]"},{"line_number":94,"context_line":"    (this option can be repeated)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. option::  --qos-policy \u003cqos-policy-id\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_bf52b6db","line":93,"updated":"2016-03-11 20:37:27.000000000","message":"Can this be any key\u003dvalue pair?","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"3e124f0e63ce767520184bde4dec7793e208d970","unresolved":false,"context_lines":[{"line_number":90,"context_line":".. option::  --extra-dhcp-opt \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    Extra dhcp options to be assigned to this port:"},{"line_number":93,"context_line":"    \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]"},{"line_number":94,"context_line":"    (this option can be repeated)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. option::  --qos-policy \u003cqos-policy-id\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_bab6443b","line":93,"in_reply_to":"3afc51ec_bf52b6db","updated":"2016-03-11 21:09:28.000000000","message":"Yes, appears that they can be any key-value pair.","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5bbfa68c994901695b5f90f61112ac4b5855b478","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. option::  --qos-policy \u003cqos-policy-id\u003e"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    Attach QoS policy(ID) to this port"},{"line_number":99,"context_line":"    (this option requires the Quality of Service extension)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. option::  --allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_7f930ea4","line":98,"updated":"2016-03-11 20:37:27.000000000","message":"Please move (ID) to the end and change to (ID only).  Is name not supported?","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"3e124f0e63ce767520184bde4dec7793e208d970","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. option::  --qos-policy \u003cqos-policy-id\u003e"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    Attach QoS policy(ID) to this port"},{"line_number":99,"context_line":"    (this option requires the Quality of Service extension)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. option::  --allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_3aaa34d5","line":98,"in_reply_to":"3afc51ec_7f930ea4","updated":"2016-03-11 21:09:28.000000000","message":"Name not supported in back-end and cannot be translated due to lack of QoS support in SDK. I put a todo block to update this when support is available.","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5bbfa68c994901695b5f90f61112ac4b5855b478","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        [--binding-profile \u003cbinding-profile\u003e]"},{"line_number":152,"context_line":"        [--host-id \u003chost-id\u003e]"},{"line_number":153,"context_line":"        [--enable | --disable]"},{"line_number":154,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":155,"context_line":"        [--extra-dhcp-opt \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]]"},{"line_number":156,"context_line":"        [--qos-policy \u003cqos-policy-id\u003e]"},{"line_number":157,"context_line":"        [--allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_7fdaee79","line":154,"updated":"2016-03-11 20:37:27.000000000","message":"Similar comments apply here ...","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"3e124f0e63ce767520184bde4dec7793e208d970","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        [--binding-profile \u003cbinding-profile\u003e]"},{"line_number":152,"context_line":"        [--host-id \u003chost-id\u003e]"},{"line_number":153,"context_line":"        [--enable | --disable]"},{"line_number":154,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":155,"context_line":"        [--extra-dhcp-opt \u003copt-name\u003e\u003d\u003copt-value\u003e[,ip-version\u003d{4,6}]]"},{"line_number":156,"context_line":"        [--qos-policy \u003cqos-policy-id\u003e]"},{"line_number":157,"context_line":"        [--allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]]"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_3aed148c","line":154,"in_reply_to":"3afc51ec_7fdaee79","updated":"2016-03-11 21:09:28.000000000","message":"Done","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"80508d1f47387c80122340767da4444bee99530b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        [--enable | --disable]"},{"line_number":24,"context_line":"        [--mac-address \u003cmac-address\u003e]"},{"line_number":25,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":26,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":27,"context_line":"        [--extra-dhcp-option \u003coption-name\u003e\u003d\u003coption-value\u003e[,ip-version\u003d{4,6}]]"},{"line_number":28,"context_line":"        [--qos-policy \u003cqos-policy\u003e]"},{"line_number":29,"context_line":"        [--allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]]"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_55524914","line":26,"updated":"2016-03-21 23:58:13.000000000","message":"How can we remove the security groups?\nCan there be an option of --no-security-groups in Create And/Or Set, so that the user has the option to add/remove them as is necessary?","commit_id":"25219a6c8da26d13702e98757cce97972723e8e5"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"540a00bed2166d5bce76429c47e6acc12461d60c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        [--enable | --disable]"},{"line_number":24,"context_line":"        [--mac-address \u003cmac-address\u003e]"},{"line_number":25,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":26,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":27,"context_line":"        [--extra-dhcp-option \u003coption-name\u003e\u003d\u003coption-value\u003e[,ip-version\u003d{4,6}]]"},{"line_number":28,"context_line":"        [--qos-policy \u003cqos-policy\u003e]"},{"line_number":29,"context_line":"        [--allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]]"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_d3ee608a","line":26,"in_reply_to":"fa0719c6_55524914","updated":"2016-03-22 11:45:36.000000000","message":"Hi Jas, consider using --clear-security-groups for this.  That would be similar to the router command --route and --clear-routes options.  Also it appears that this same comment applies to --qos-policy and --allowed-address-pair options.","commit_id":"25219a6c8da26d13702e98757cce97972723e8e5"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"590034981a62b0838f4e3d38ed9f35124b1400ef","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        [--enable | --disable]"},{"line_number":24,"context_line":"        [--mac-address \u003cmac-address\u003e]"},{"line_number":25,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":26,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":27,"context_line":"        [--extra-dhcp-option \u003coption-name\u003e\u003d\u003coption-value\u003e[,ip-version\u003d{4,6}]]"},{"line_number":28,"context_line":"        [--qos-policy \u003cqos-policy\u003e]"},{"line_number":29,"context_line":"        [--allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]]"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_0a9a5563","line":26,"in_reply_to":"fa0719c6_d3ee608a","updated":"2016-03-22 12:54:43.000000000","message":"Hi Dean, are you okay with using --clear-* for handling such options?  There is an \"unset\" action but that appears to be used for removing attributes.  In this case, I think these attributes stay but the values are cleared.  And --no is reserved for boolean options.","commit_id":"25219a6c8da26d13702e98757cce97972723e8e5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"80508d1f47387c80122340767da4444bee99530b","unresolved":false,"context_lines":[{"line_number":96,"context_line":".. option::  --qos-policy \u003cqos-policy\u003e"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    Attach QoS policy to this port (ID only)"},{"line_number":99,"context_line":"    (this option requires the Quality of Service extension)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. option::  --allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa0719c6_353515da","line":99,"updated":"2016-03-21 23:58:13.000000000","message":"Can we add the word  \"enabled\" here ?\nJust to be perfectly clear about what we want","commit_id":"25219a6c8da26d13702e98757cce97972723e8e5"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"fd2089ba596b8e44ef2283059a5de1a2151fb614","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        [--enable | --disable]"},{"line_number":24,"context_line":"        [--mac-address \u003cmac-address\u003e]"},{"line_number":25,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":26,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":27,"context_line":"        [--extra-dhcp-option \u003coption-name\u003e\u003d\u003coption-value\u003e[,ip-version\u003d{4,6}]]"},{"line_number":28,"context_line":"        [--qos-policy \u003cqos-policy\u003e]"},{"line_number":29,"context_line":"        [--allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]]"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da0c15f0_174f4b93","line":26,"updated":"2016-03-25 14:32:07.000000000","message":"When an option can be repeated we write this as:\n\n  [--security-group \u003csecurity-group\u003e [...] ]","commit_id":"32e4e74102daeffb324bd05cba527be9820e8c9d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"fd2089ba596b8e44ef2283059a5de1a2151fb614","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":27,"context_line":"        [--extra-dhcp-option \u003coption-name\u003e\u003d\u003coption-value\u003e[,ip-version\u003d{4,6}]]"},{"line_number":28,"context_line":"        [--qos-policy \u003cqos-policy\u003e]"},{"line_number":29,"context_line":"        [--allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]]"},{"line_number":30,"context_line":"        \u003cname\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":".. option:: --network \u003cnetwork\u003e"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da0c15f0_37952fe4","line":29,"updated":"2016-03-25 14:32:07.000000000","message":"These and the list below need to be in the same order...and so does the  help output itself.","commit_id":"32e4e74102daeffb324bd05cba527be9820e8c9d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"fd2089ba596b8e44ef2283059a5de1a2151fb614","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        [--host-id \u003chost-id\u003e]"},{"line_number":160,"context_line":"        [--enable | --disable]"},{"line_number":161,"context_line":"        [--extra-dhcp-option \u003coption-name\u003e\u003d\u003coption-value\u003e[,ip-version\u003d{4,6}]]"},{"line_number":162,"context_line":"        [--clear-security-groups | --security-group \u003csecurity-group\u003e]"},{"line_number":163,"context_line":"        [--clear-qos-policy | --qos-policy \u003cqos-policy\u003e]"},{"line_number":164,"context_line":"        [--clear-allowed-address-pairs | --allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]]"},{"line_number":165,"context_line":"        \u003cport\u003e"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da0c15f0_77120764","line":162,"updated":"2016-03-25 14:32:07.000000000","message":"in general, put --clear-NN options last on these lines","commit_id":"32e4e74102daeffb324bd05cba527be9820e8c9d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6749ef5eefb04cebceee5df032199b78f4f47320","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        [--fixed-ip subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e | --no-fixed-ip]"},{"line_number":161,"context_line":"        [--binding-profile \u003cbinding-profile\u003e | --no-binding-profile]"},{"line_number":162,"context_line":"        [--extra-dhcp-option \u003coption-name\u003e\u003d\u003coption-value\u003e[,ip-version\u003d{4,6}]]"},{"line_number":163,"context_line":"        [--security-group \u003csecurity-group\u003e | --no-security-groups]"},{"line_number":164,"context_line":"        [--qos-policy \u003cqos-policy\u003e | --no-qos-policy]"},{"line_number":165,"context_line":"        [--allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]"},{"line_number":166,"context_line":"        | --no-allowed-address-pairs]"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a18252c_0fea02ac","line":163,"updated":"2016-04-14 21:27:10.000000000","message":"singular: --no-security-group","commit_id":"18d3a5611688d2218d1dbb2142bcf8f558ac369b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6749ef5eefb04cebceee5df032199b78f4f47320","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        [--security-group \u003csecurity-group\u003e | --no-security-groups]"},{"line_number":164,"context_line":"        [--qos-policy \u003cqos-policy\u003e | --no-qos-policy]"},{"line_number":165,"context_line":"        [--allowed-address-pair ip-address\u003d\u003cip-address\u003e[,mac-address\u003d\u003cmac-address\u003e]"},{"line_number":166,"context_line":"        | --no-allowed-address-pairs]"},{"line_number":167,"context_line":"        \u003cport\u003e"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":".. option:: --device \u003cdevice-id\u003e"}],"source_content_type":"text/x-rst","patch_set":12,"id":"5a18252c_cf0aca89","line":166,"updated":"2016-04-14 21:27:10.000000000","message":"singular","commit_id":"18d3a5611688d2218d1dbb2142bcf8f558ac369b"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5bbfa68c994901695b5f90f61112ac4b5855b478","unresolved":false,"context_lines":[{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        try:"},{"line_number":438,"context_line":"            obj \u003d client.find_port(parsed_args.port, ignore_missing\u003dFalse)"},{"line_number":439,"context_line":"        except _exceptions.HttpException:"},{"line_number":440,"context_line":"            # Check if this is due to missing extension."},{"line_number":441,"context_line":"            # If not, throw the original exception"},{"line_number":442,"context_line":"            validate_avail_extensions(client, attrs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_1fb64adc","line":439,"updated":"2016-03-11 20:37:27.000000000","message":"You want this around the update not find.","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"80d2c9fa9059b03e044872acd951b1cc13d0d3ae","unresolved":false,"context_lines":[{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        try:"},{"line_number":438,"context_line":"            obj \u003d client.find_port(parsed_args.port, ignore_missing\u003dFalse)"},{"line_number":439,"context_line":"        except _exceptions.HttpException:"},{"line_number":440,"context_line":"            # Check if this is due to missing extension."},{"line_number":441,"context_line":"            # If not, throw the original exception"},{"line_number":442,"context_line":"            validate_avail_extensions(client, attrs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_7fadce30","line":439,"in_reply_to":"3afc51ec_1fb64adc","updated":"2016-03-11 20:41:52.000000000","message":"Oh man, good catch","commit_id":"473278d77d30cc42282a7e011ab2262601b5e60a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"592b94c5c3439071e298c36bc09982222ab71c6f","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"_required_opt_extensions_map \u003d {"},{"line_number":42,"context_line":"    \u0027qos_policy_id\u0027: \u0027qos\u0027,"},{"line_number":43,"context_line":"    \u0027allowed_address_pairs\u0027: \u0027allowed-address-pairs\u0027,"},{"line_number":44,"context_line":"    \u0027extra_dhcp_opts\u0027: \u0027extra_dhcp_opt\u0027,"},{"line_number":45,"context_line":"    \u0027security_groups\u0027: \u0027security-groups\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_04461723","line":42,"updated":"2016-03-15 13:37:25.000000000","message":"Only QoS extension is documented in the help text.  Should the others be documented as well?","commit_id":"453d7167403f0f36ae93ad7f0f91edcda1de5f52"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"592b94c5c3439071e298c36bc09982222ab71c6f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def validate_avail_extensions(client, attrs):"},{"line_number":50,"context_line":"    # If specified option requires extension, then try to"},{"line_number":51,"context_line":"    # find out if it exists. If it does not exist,"},{"line_number":52,"context_line":"    # then an exception with the appropriate message"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_04cf37b1","line":49,"updated":"2016-03-15 13:37:25.000000000","message":"nit...you can add \u0027_\u0027 to this method since it is internal use only.","commit_id":"453d7167403f0f36ae93ad7f0f91edcda1de5f52"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"09063cb463db4f5965e1e66f98f942d6c14a509b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def validate_avail_extensions(client, attrs):"},{"line_number":50,"context_line":"    # If specified option requires extension, then try to"},{"line_number":51,"context_line":"    # find out if it exists. If it does not exist,"},{"line_number":52,"context_line":"    # then an exception with the appropriate message"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_584c2a42","line":49,"in_reply_to":"1af94dfe_04cf37b1","updated":"2016-03-16 18:23:44.000000000","message":"Done","commit_id":"453d7167403f0f36ae93ad7f0f91edcda1de5f52"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"80508d1f47387c80122340767da4444bee99530b","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        parser.add_argument("},{"line_number":252,"context_line":"            \u0027--device-owner\u0027,"},{"line_number":253,"context_line":"            metavar\u003d\u0027\u003cdevice-owner\u003e\u0027,"},{"line_number":254,"context_line":"            help\u003d\u0027Device owner of this port\u0027"},{"line_number":255,"context_line":"        )"},{"line_number":256,"context_line":"        parser.add_argument("},{"line_number":257,"context_line":"            \u0027--vnic-type\u0027,"},{"line_number":258,"context_line":"            metavar\u003d\u0027\u003cvnic-type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa0719c6_f541dd3a","line":255,"range":{"start_line":254,"start_character":44,"end_line":255,"end_character":9},"updated":"2016-03-21 23:58:13.000000000","message":"Is the new line required?","commit_id":"25219a6c8da26d13702e98757cce97972723e8e5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"80508d1f47387c80122340767da4444bee99530b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            help\u003d\"VNIC type for this port (direct | direct-physical |\""},{"line_number":262,"context_line":"                 \" macvtap | normal | baremetal). If unspecified during\""},{"line_number":263,"context_line":"                 \" port creation, default value will be \u0027normal\u0027.\""},{"line_number":264,"context_line":"        )"},{"line_number":265,"context_line":"        parser.add_argument("},{"line_number":266,"context_line":"            \u0027--binding-profile\u0027,"},{"line_number":267,"context_line":"            metavar\u003d\u0027\u003cbinding-profile\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa0719c6_354cf56f","line":264,"updated":"2016-03-21 23:58:13.000000000","message":"ditto","commit_id":"25219a6c8da26d13702e98757cce97972723e8e5"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"fd2089ba596b8e44ef2283059a5de1a2151fb614","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    return attrs"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def _get_attrs_set(client_manager, parsed_args):"},{"line_number":135,"context_line":"    attrs \u003d _get_attrs_common(client_manager, parsed_args)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    if parsed_args.no_allowed_address_pairs:"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_52827153","line":134,"updated":"2016-03-25 14:32:07.000000000","message":"Why bother with these functions when they are only called once?  Put this back into take_action()\n\nSame below with _get_attrs_create()","commit_id":"32e4e74102daeffb324bd05cba527be9820e8c9d"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b42d0e51e804e2e84eed48ea6d73856bf1f9935a","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        parser.add_argument("},{"line_number":230,"context_line":"            \u0027--device-owner\u0027,"},{"line_number":231,"context_line":"            metavar\u003d\u0027\u003cdevice-owner\u003e\u0027,"},{"line_number":232,"context_line":"            help\u003d\u0027Device owner of this port\u0027"},{"line_number":233,"context_line":"        )"},{"line_number":234,"context_line":"        parser.add_argument("},{"line_number":235,"context_line":"            \u0027--vnic-type\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_5f32e3a7","line":232,"updated":"2016-04-20 12:42:54.000000000","message":"Hi Jas, changes went in recently for help translation support.  Please wrap the help text in _().  You\u0027ll see examples when you rebase.","commit_id":"18d3a5611688d2218d1dbb2142bcf8f558ac369b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6749ef5eefb04cebceee5df032199b78f4f47320","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        )"},{"line_number":271,"context_line":"        # Use default parser on \u0027port create\u0027, use mutually"},{"line_number":272,"context_line":"        # exclusive groups for \u0027port update\u0027 because of the"},{"line_number":273,"context_line":"        # addition of the \u0027--clear*\u0027 options"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        _parser \u003d parser"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a18252c_cf664a50","line":273,"updated":"2016-04-14 21:27:10.000000000","message":"Move these back to the command take_action() methods, there is no savings to branch on that here\n\nAlso: s/--clear*/--no*/","commit_id":"18d3a5611688d2218d1dbb2142bcf8f558ac369b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6749ef5eefb04cebceee5df032199b78f4f47320","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            attrs[\u0027network_id\u0027] \u003d _network.id"},{"line_number":414,"context_line":"        if parsed_args.project is not None:"},{"line_number":415,"context_line":"            # TODO(singhj): since \u0027project\u0027 logic is common among"},{"line_number":416,"context_line":"            # router, network, port etc., maybe move it to a common file."},{"line_number":417,"context_line":"            identity_client \u003d self.app.client_manager.identity"},{"line_number":418,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":419,"context_line":"                identity_client,"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a18252c_0feb2279","line":416,"updated":"2016-04-14 21:27:10.000000000","message":"Please, no.  This isn\u0027t enough logic/code to warrant the refactor","commit_id":"18d3a5611688d2218d1dbb2142bcf8f558ac369b"}],"openstackclient/tests/network/v2/test_port.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6749ef5eefb04cebceee5df032199b78f4f47320","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            (\u0027extra_dhcp_opts\u0027, [{\u0027ip-version\u0027: \u00274\u0027, \u0027key0\u0027: \u0027val0\u0027}]),"},{"line_number":162,"context_line":"            (\u0027allowed_address_pairs\u0027, [{\u0027ip-address\u0027: \u002710.0.0.2\u0027,"},{"line_number":163,"context_line":"                                        \u0027mac-address\u0027:"},{"line_number":164,"context_line":"                                            \u0027ff:ff:ff:ff:ff:ff:ff:ff\u0027}]),"},{"line_number":165,"context_line":"            (\u0027security_groups\u0027, [\u0027test-sec-group\u0027]),"},{"line_number":166,"context_line":"            (\u0027name\u0027, \u0027test-port\u0027),"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a18252c_ef32260f","line":164,"updated":"2016-04-14 21:27:10.000000000","message":"This is where this indention style falls over.  You don\u0027t need to change it, but   simple 4 space hanging indents are simpler to read, especially in cases line the above two lines.","commit_id":"18d3a5611688d2218d1dbb2142bcf8f558ac369b"}],"releasenotes/notes/add-port-extensions-support-917a7518cb6fb037.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"50255d59effa49c94f772d44800351cf6750a992","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support for extended ``port`` options:"},{"line_number":5,"context_line":"    support for ``QoS``, ``Security Groups``, ``Allowed Address Pairs`` and ``Extra DHCP Options``"},{"line_number":6,"context_line":"    [Bug `1519909 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1519909\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1af94dfe_50e4c3aa","line":4,"updated":"2016-03-17 19:27:58.000000000","message":"Hi Jas, most of the release notes have called out the commands and options impacted.  I think that would be good here so a user can quickly identify the changes when working with the commands.","commit_id":"255c947f5eb5fb6754576eea6bd9b559bc85ed3f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"80508d1f47387c80122340767da4444bee99530b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add extended options for ``port set`` and ``port create`` commands:"},{"line_number":5,"context_line":"    support for ``--qos-policy``, ``--allowed-address-pair``, ``--security-group`` and ``--extra-dhcp-option``"},{"line_number":6,"context_line":"    [Bug `1519909 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1519909\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa0719c6_356355de","line":5,"range":{"start_line":5,"start_character":83,"end_line":5,"end_character":110},"updated":"2016-03-21 23:58:13.000000000","message":"Can this be brought to the next line?","commit_id":"25219a6c8da26d13702e98757cce97972723e8e5"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"fd2089ba596b8e44ef2283059a5de1a2151fb614","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add extended options for ``port set`` and ``port create`` commands:"},{"line_number":5,"context_line":"    support for ``--qos-policy``, ``--allowed-address-pair``, ``--security-group`` and ``--extra-dhcp-option``"},{"line_number":6,"context_line":"    [Bug `1519909 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1519909\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da0c15f0_522c314a","line":5,"updated":"2016-03-25 14:32:07.000000000","message":"Add the --clear-NN options here too","commit_id":"32e4e74102daeffb324bd05cba527be9820e8c9d"}]}