)]}' {"doc/source/command-objects/network.rst":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c10588fad5b55427b31d780f837d6acd81ab809f","unresolved":false,"context_lines":[{"line_number":17,"context_line":" [--enable | --disable]"},{"line_number":18,"context_line":" [--share | --no-share]"},{"line_number":19,"context_line":" [--availability-zone-hint \u003cavailability-zone\u003e]"},{"line_number":20,"context_line":" [--router:external][--is-default]"},{"line_number":21,"context_line":" \u003cname\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afc51ec_47ef24b0","line":20,"updated":"2016-03-14 16:25:27.000000000","message":"These should be on separate lines.","commit_id":"771c415b0ba21d1eb09abf0c32955a15b4c0fff0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6bf1bfab8acfe8567d53735a5a579bb0a80c5f87","unresolved":false,"context_lines":[{"line_number":17,"context_line":" [--enable | --disable]"},{"line_number":18,"context_line":" [--share | --no-share]"},{"line_number":19,"context_line":" [--availability-zone-hint \u003cavailability-zone\u003e]"},{"line_number":20,"context_line":" [--router:external][--is-default]"},{"line_number":21,"context_line":" \u003cname\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afc51ec_655e8377","line":20,"in_reply_to":"3afc51ec_47ef24b0","updated":"2016-03-15 01:59:53.000000000","message":"Will do so","commit_id":"771c415b0ba21d1eb09abf0c32955a15b4c0fff0"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c10588fad5b55427b31d780f837d6acd81ab809f","unresolved":false,"context_lines":[{"line_number":60,"context_line":" IPv4 subnet for fixed IPs (in CIDR notation)"},{"line_number":61,"context_line":" (Compute v2 network only)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. option:: --router:external"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":" Set the type of network (True sets it as an external network)."},{"line_number":66,"context_line":" Requires the \"external-net\" extension to be enabled."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afc51ec_a7c8a823","line":63,"updated":"2016-03-14 16:25:27.000000000","message":"Please, no colons in option names. Based on the description, --external should be enough, plus the natural complement --internal (or whatever makes sense, see below)","commit_id":"771c415b0ba21d1eb09abf0c32955a15b4c0fff0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6bf1bfab8acfe8567d53735a5a579bb0a80c5f87","unresolved":false,"context_lines":[{"line_number":60,"context_line":" IPv4 subnet for fixed IPs (in CIDR notation)"},{"line_number":61,"context_line":" (Compute v2 network only)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. option:: --router:external"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":" Set the type of network (True sets it as an external network)."},{"line_number":66,"context_line":" Requires the \"external-net\" extension to be enabled."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afc51ec_c5dcb7e6","line":63,"in_reply_to":"3afc51ec_a7c8a823","updated":"2016-03-15 01:59:53.000000000","message":"Okay, I see that \"List\" CLI also uses --external, so will use that only","commit_id":"771c415b0ba21d1eb09abf0c32955a15b4c0fff0"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c10588fad5b55427b31d780f837d6acd81ab809f","unresolved":false,"context_lines":[{"line_number":65,"context_line":" Set the type of network (True sets it as an external network)."},{"line_number":66,"context_line":" Requires the \"external-net\" extension to be enabled."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":".. option:: --is-default"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":" Specify if this network should be used as"},{"line_number":71,"context_line":" the default external network."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afc51ec_87164ca5","line":68,"updated":"2016-03-14 16:25:27.000000000","message":"--is-default needs a complementary --is-not-default (or similar)\n\nThe --no- prefix is a standard that we should use if an obvious word is not otherwise available (like enable|disable).","commit_id":"771c415b0ba21d1eb09abf0c32955a15b4c0fff0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6bf1bfab8acfe8567d53735a5a579bb0a80c5f87","unresolved":false,"context_lines":[{"line_number":65,"context_line":" Set the type of network (True sets it as an external network)."},{"line_number":66,"context_line":" Requires the \"external-net\" extension to be enabled."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":".. option:: --is-default"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":" Specify if this network should be used as"},{"line_number":71,"context_line":" the default external network."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3afc51ec_e5e1f39b","line":68,"in_reply_to":"3afc51ec_87164ca5","updated":"2016-03-15 01:59:53.000000000","message":"Agreed, will do that in the upcoming patch","commit_id":"771c415b0ba21d1eb09abf0c32955a15b4c0fff0"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"535f5177df2182ff713153d92c65065cf61db180","unresolved":false,"context_lines":[{"line_number":61,"context_line":" IPv4 subnet for fixed IPs (in CIDR notation)"},{"line_number":62,"context_line":" (Compute v2 network only)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. option:: --external"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":" Set the type of network (True sets it as an external network)."},{"line_number":67,"context_line":" Requires the \"external-net\" extension to be enabled."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_2fd5751b","line":64,"range":{"start_line":64,"start_character":14,"end_line":64,"end_character":22},"updated":"2016-03-15 05:37:05.000000000","message":"Should we also write which one of them is the default value ? But I can see that some other commands don\u0027t do so. I think it is better to give a default value in a exclusive group.","commit_id":"dda573126abaebfefd0ca0a309efd1ea58b95af7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6686916ddb798cfb4f351dcc7978664194126fe2","unresolved":false,"context_lines":[{"line_number":61,"context_line":" IPv4 subnet for fixed IPs (in CIDR notation)"},{"line_number":62,"context_line":" (Compute v2 network only)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. option:: --external"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":" Set the type of network (True sets it as an external network)."},{"line_number":67,"context_line":" Requires the \"external-net\" extension to be enabled."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_afa505a3","line":64,"range":{"start_line":64,"start_character":14,"end_line":64,"end_character":22},"in_reply_to":"3afc51ec_2fd5751b","updated":"2016-03-15 05:48:44.000000000","message":"Hi Tang, I am not sure if there is any relation in defining a default value and an exclusive group.\nA group can be exclusive to stop user to define two contradictory options together.However, it does not mean one of them has to be default.\n\nIn this case, I have left the implementation to the API end, similar to what has been done in NeutronClient.\nAPI is smart enough to set a value if none is passed by the CLI","commit_id":"dda573126abaebfefd0ca0a309efd1ea58b95af7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"535f5177df2182ff713153d92c65065cf61db180","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. option:: --external"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":" Set the type of network (True sets it as an external network)."},{"line_number":67,"context_line":" Requires the \"external-net\" extension to be enabled."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. option:: --internal"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_cfecd1f5","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":16},"updated":"2016-03-15 05:37:05.000000000","message":"I\u0027m not sure \"type\" is the proper word for this option here. I\u0027m work on a patch to add --type option, which is used to specified \"vlan, gre, ......\". \n\nJust my concern. We can fix it later when we find a proper word.","commit_id":"dda573126abaebfefd0ca0a309efd1ea58b95af7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6686916ddb798cfb4f351dcc7978664194126fe2","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. option:: --external"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":" Set the type of network (True sets it as an external network)."},{"line_number":67,"context_line":" Requires the \"external-net\" extension to be enabled."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. option:: --internal"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_6f977d3a","line":66,"range":{"start_line":66,"start_character":12,"end_line":66,"end_character":16},"in_reply_to":"3afc51ec_cfecd1f5","updated":"2016-03-15 05:48:44.000000000","message":"Okay, I agree a bit that the \"type\" word here is not too convincing.","commit_id":"dda573126abaebfefd0ca0a309efd1ea58b95af7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"535f5177df2182ff713153d92c65065cf61db180","unresolved":false,"context_lines":[{"line_number":69,"context_line":".. option:: --internal"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":" Set the type of network (True sets it as an internal network)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. option:: --is-default"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_0f3359ac","line":72,"updated":"2016-03-15 05:37:05.000000000","message":"One redundant new line here.","commit_id":"dda573126abaebfefd0ca0a309efd1ea58b95af7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6686916ddb798cfb4f351dcc7978664194126fe2","unresolved":false,"context_lines":[{"line_number":69,"context_line":".. option:: --internal"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":" Set the type of network (True sets it as an internal network)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. option:: --is-default"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afc51ec_4f9c415d","line":72,"in_reply_to":"3afc51ec_0f3359ac","updated":"2016-03-15 05:48:44.000000000","message":"Fixing in the next patch","commit_id":"dda573126abaebfefd0ca0a309efd1ea58b95af7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fd6cbba50d2e435c6f3891620e2cf5d3b6f3da69","unresolved":false,"context_lines":[{"line_number":17,"context_line":" [--enable | --disable]"},{"line_number":18,"context_line":" [--share | --no-share]"},{"line_number":19,"context_line":" [--availability-zone-hint \u003cavailability-zone\u003e]"},{"line_number":20,"context_line":" [--external | --internal]"},{"line_number":21,"context_line":" [--is-default | --is-not-default]"},{"line_number":22,"context_line":" \u003cname\u003e"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1af94dfe_b02f9ef5","line":20,"updated":"2016-03-15 13:26:37.000000000","message":"The documentation below should note which is the default.","commit_id":"12a56282fa78e3e64b442d45e7219eb2fcbbc0c7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fd6cbba50d2e435c6f3891620e2cf5d3b6f3da69","unresolved":false,"context_lines":[{"line_number":18,"context_line":" [--share | --no-share]"},{"line_number":19,"context_line":" [--availability-zone-hint \u003cavailability-zone\u003e]"},{"line_number":20,"context_line":" [--external | --internal]"},{"line_number":21,"context_line":" [--is-default | --is-not-default]"},{"line_number":22,"context_line":" \u003cname\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1af94dfe_503f3a25","line":21,"updated":"2016-03-15 13:26:37.000000000","message":"The documentation below should note which is the default.","commit_id":"12a56282fa78e3e64b442d45e7219eb2fcbbc0c7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fd6cbba50d2e435c6f3891620e2cf5d3b6f3da69","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. option:: --external"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":" Set the nature of network (True sets it as an external network)."},{"line_number":67,"context_line":" Requires the \"external-net\" extension to be enabled."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. option:: --internal"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1af94dfe_9090a297","line":66,"updated":"2016-03-15 13:26:37.000000000","message":"A user does not specify true. This is a general comment that impacts the help text.","commit_id":"12a56282fa78e3e64b442d45e7219eb2fcbbc0c7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2023a12187d343992e2593da387668cd6d19ae0d","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. option:: --is-not-default"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":" Do not use the network as the default external network( default )"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. _network_create-name:"},{"line_number":83,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1af94dfe_d6341d4b","line":80,"range":{"start_line":80,"start_character":50,"end_line":80,"end_character":68},"updated":"2016-03-18 15:47:43.000000000","message":"spacing is funny here:\n\n network (default)","commit_id":"5bc09ba697a4ea6e9d01f7aec1e306ab66e0277e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"daa94261d8c354fe7873a18ced9ec0700e13edce","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. option:: --is-not-default"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":" Do not use the network as the default external network(default)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. _network_create-name:"},{"line_number":83,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1af94dfe_e1618b06","line":80,"updated":"2016-03-18 19:24:12.000000000","message":"space before \"(default)\"","commit_id":"11f2b83a9fceeafb86290ce9f6e305cf56673d97"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"fb2fb00d150a1c24894241336e8b3d0cb4226929","unresolved":false,"context_lines":[{"line_number":61,"context_line":" IPv4 subnet for fixed IPs (in CIDR notation)"},{"line_number":62,"context_line":" (Compute v2 network only)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. option:: --external"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":" Set this network as an external network."},{"line_number":67,"context_line":" Requires the \"external-net\" extension to be enabled."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. option:: --internal"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":" Set this network as an internal network (default)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. option:: --is-default"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":" Specify if this network should be used as"},{"line_number":76,"context_line":" the default external network"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. option:: --is-not-default"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":" Do not use the network as the default external network (default)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. _network_create-name:"},{"line_number":83,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":17,"id":"da0c15f0_9d6348dc","line":80,"range":{"start_line":64,"start_character":0,"end_line":80,"end_character":67},"updated":"2016-03-28 07:49:01.000000000","message":"Are all these 4 options are for Network v2 ? If so, please add (Network v2 only) for them.","commit_id":"920825746e1f7ab1233511294412e676d2142e66"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d5bf027527ae7cf3bc06efd43ac3b6954c7910ff","unresolved":false,"context_lines":[{"line_number":61,"context_line":" IPv4 subnet for fixed IPs (in CIDR notation)"},{"line_number":62,"context_line":" (Compute v2 network only)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. option:: --external"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":" Set this network as an external network."},{"line_number":67,"context_line":" Requires the \"external-net\" extension to be enabled."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. option:: --internal"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":" Set this network as an internal network (default)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":".. option:: --is-default"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":" Specify if this network should be used as"},{"line_number":76,"context_line":" the default external network"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. option:: --is-not-default"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":" Do not use the network as the default external network (default)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. _network_create-name:"},{"line_number":83,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":17,"id":"da0c15f0_7d2ab37f","line":80,"range":{"start_line":64,"start_character":0,"end_line":80,"end_character":67},"in_reply_to":"da0c15f0_9d6348dc","updated":"2016-03-28 08:08:21.000000000","message":"Okay","commit_id":"920825746e1f7ab1233511294412e676d2142e66"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fea47140a3363920ea1bd3b55483f351f5fa922d","unresolved":false,"context_lines":[{"line_number":18,"context_line":" [--share | --no-share]"},{"line_number":19,"context_line":" [--availability-zone-hint \u003cavailability-zone\u003e]"},{"line_number":20,"context_line":" [--external | --internal]"},{"line_number":21,"context_line":" [--is-default | --is-not-default]"},{"line_number":22,"context_line":" \u003cname\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba0121b8_2627bc13","line":21,"updated":"2016-03-29 12:57:29.000000000","message":"Since default applies to external networks only, I think the option name should reflect that such as --default-external.","commit_id":"38ed7029cbc81629ccb92a560a264bc95faa5ab0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3f085422fb8ee15d85f613eefb4be8303badb45d","unresolved":false,"context_lines":[{"line_number":18,"context_line":" [--share | --no-share]"},{"line_number":19,"context_line":" [--availability-zone-hint \u003cavailability-zone\u003e]"},{"line_number":20,"context_line":" [--external | --internal]"},{"line_number":21,"context_line":" [--is-default | --is-not-default]"},{"line_number":22,"context_line":" \u003cname\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba0121b8_e1710aaa","line":21,"in_reply_to":"ba0121b8_2627bc13","updated":"2016-03-30 02:06:21.000000000","message":"--default-external can be a valid option, but I am thinking what would its negation be?\nI am thinking of changing it below:\n\n[--external [--default | --not-default] | --internal]\n\nIMO This makes more sense","commit_id":"38ed7029cbc81629ccb92a560a264bc95faa5ab0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0f61eb65de8bd5759d5a4b13d54cd55781d51ae5","unresolved":false,"context_lines":[{"line_number":18,"context_line":" [--share | --no-share]"},{"line_number":19,"context_line":" [--availability-zone-hint \u003cavailability-zone\u003e]"},{"line_number":20,"context_line":" [--external | --internal]"},{"line_number":21,"context_line":" [--is-default | --is-not-default]"},{"line_number":22,"context_line":" \u003cname\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba0121b8_0cb96e79","line":21,"in_reply_to":"ba0121b8_e1710aaa","updated":"2016-03-31 15:41:04.000000000","message":"Makes sense to me. I think this is good.","commit_id":"38ed7029cbc81629ccb92a560a264bc95faa5ab0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fea47140a3363920ea1bd3b55483f351f5fa922d","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. option:: --is-default"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":" Specify if this network should be used as"},{"line_number":78,"context_line":" the default external network"},{"line_number":79,"context_line":" (Network v2 only)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba0121b8_a6746c9c","line":77,"updated":"2016-03-29 12:57:29.000000000","message":"nit...indent one more space","commit_id":"38ed7029cbc81629ccb92a560a264bc95faa5ab0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3f085422fb8ee15d85f613eefb4be8303badb45d","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. option:: --is-default"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":" Specify if this network should be used as"},{"line_number":78,"context_line":" the default external network"},{"line_number":79,"context_line":" (Network v2 only)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba0121b8_615e9a13","line":77,"in_reply_to":"ba0121b8_a6746c9c","updated":"2016-03-30 02:06:21.000000000","message":"Done","commit_id":"38ed7029cbc81629ccb92a560a264bc95faa5ab0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fea47140a3363920ea1bd3b55483f351f5fa922d","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. option:: --is-not-default"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":" Do not use the network as the default external network (default)"},{"line_number":84,"context_line":" (Network v2 only)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. _network_create-name:"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba0121b8_86796896","line":83,"updated":"2016-03-29 12:57:29.000000000","message":"nit...indent one more space","commit_id":"38ed7029cbc81629ccb92a560a264bc95faa5ab0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3f085422fb8ee15d85f613eefb4be8303badb45d","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. option:: --is-not-default"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":" Do not use the network as the default external network (default)"},{"line_number":84,"context_line":" (Network v2 only)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. _network_create-name:"}],"source_content_type":"text/x-rst","patch_set":18,"id":"ba0121b8_c19b26c8","line":83,"in_reply_to":"ba0121b8_86796896","updated":"2016-03-30 02:06:21.000000000","message":"Done","commit_id":"38ed7029cbc81629ccb92a560a264bc95faa5ab0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"90125d6cc7a9a3c5c0e0285b0ae864c1656ce551","unresolved":false,"context_lines":[{"line_number":77,"context_line":" the default external network"},{"line_number":78,"context_line":" (Network v2 only)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. option:: --not-default"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":" Do not use the network as the default external network."},{"line_number":83,"context_line":" By default, no network is set as an external network."}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba0121b8_0c3e8ed9","line":80,"updated":"2016-03-31 15:45:53.000000000","message":"Use --no-default per devref on boolean options?","commit_id":"ec67176df06569ae2ea8708f8527a4c75d140280"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"62d919ea23b00bb93d07a411ec65ebd70c8a214e","unresolved":false,"context_lines":[{"line_number":77,"context_line":" the default external network"},{"line_number":78,"context_line":" (Network v2 only)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. option:: --not-default"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":" Do not use the network as the default external network."},{"line_number":83,"context_line":" By default, no network is set as an external network."}],"source_content_type":"text/x-rst","patch_set":19,"id":"ba0121b8_293408dc","line":80,"in_reply_to":"ba0121b8_0c3e8ed9","updated":"2016-04-01 01:39:44.000000000","message":"I am going with you in this comment, but let me just state what I think.\nIMHO, \"no\" seems a good option, but lets not be completely restrictive.\n\"--no-default\" makes a little less grammatical sense than \"--not-default\". The question comes here is which is more important for the user , the Grammar or the Devref.\nIMHO, we can be a bit flexible over the options which we can present to the developer in our devref to be more in sync with the user.\nWe can keep more than one option and allow the developer to choose the best fit. This is however my opinion...","commit_id":"ec67176df06569ae2ea8708f8527a4c75d140280"}],"openstackclient/network/v2/network.py":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"c10588fad5b55427b31d780f837d6acd81ab809f","unresolved":false,"context_lines":[{"line_number":78,"context_line":" if \"is_default\" in parsed_args and \\"},{"line_number":79,"context_line":" parsed_args.is_default is not None:"},{"line_number":80,"context_line":" attrs[\u0027is_default\u0027] \u003d parsed_args.is_default"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":" return attrs"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_c77174e2","line":81,"updated":"2016-03-14 16:25:27.000000000","message":"If these only apply to one of the classes calling this function, then the value of extracting these into a common function is totally lost. Put them where they are actually used.","commit_id":"771c415b0ba21d1eb09abf0c32955a15b4c0fff0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6bf1bfab8acfe8567d53735a5a579bb0a80c5f87","unresolved":false,"context_lines":[{"line_number":78,"context_line":" if \"is_default\" in parsed_args and \\"},{"line_number":79,"context_line":" parsed_args.is_default is not None:"},{"line_number":80,"context_line":" attrs[\u0027is_default\u0027] \u003d parsed_args.is_default"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":" return attrs"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_4561c738","line":81,"in_reply_to":"3afc51ec_c77174e2","updated":"2016-03-15 01:59:53.000000000","message":"I had a reason for this, would have been evident in a future patch.\nBut its ok, I can re-arrange it for now.","commit_id":"771c415b0ba21d1eb09abf0c32955a15b4c0fff0"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"535f5177df2182ff713153d92c65065cf61db180","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":" def take_action_network(self, client, parsed_args):"},{"line_number":182,"context_line":" attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":183,"context_line":" if \"external\" in parsed_args and parsed_args.external is not None:"},{"line_number":184,"context_line":" attrs[\u0027router:external\u0027] \u003d parsed_args.external"},{"line_number":185,"context_line":" if \"is_default\" in parsed_args and \\"},{"line_number":186,"context_line":" parsed_args.is_default is not None:"},{"line_number":187,"context_line":" attrs[\u0027is_default\u0027] \u003d parsed_args.is_default"},{"line_number":188,"context_line":" obj \u003d client.create_network(**attrs)"},{"line_number":189,"context_line":" columns \u003d _get_columns(obj)"},{"line_number":190,"context_line":" data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_4fb721f5","line":187,"range":{"start_line":183,"start_character":0,"end_line":187,"end_character":56},"updated":"2016-03-15 05:37:05.000000000","message":"Shall we put this in _get_attrs() ?","commit_id":"dda573126abaebfefd0ca0a309efd1ea58b95af7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6686916ddb798cfb4f351dcc7978664194126fe2","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":" def take_action_network(self, client, parsed_args):"},{"line_number":182,"context_line":" attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":183,"context_line":" if \"external\" in parsed_args and parsed_args.external is not None:"},{"line_number":184,"context_line":" attrs[\u0027router:external\u0027] \u003d parsed_args.external"},{"line_number":185,"context_line":" if \"is_default\" in parsed_args and \\"},{"line_number":186,"context_line":" parsed_args.is_default is not None:"},{"line_number":187,"context_line":" attrs[\u0027is_default\u0027] \u003d parsed_args.is_default"},{"line_number":188,"context_line":" obj \u003d client.create_network(**attrs)"},{"line_number":189,"context_line":" columns \u003d _get_columns(obj)"},{"line_number":190,"context_line":" data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_4fb3a1e9","line":187,"range":{"start_line":183,"start_character":0,"end_line":187,"end_character":56},"in_reply_to":"3afc51ec_4fb721f5","updated":"2016-03-15 05:48:44.000000000","message":"Not now, see Dean\u0027s comment in PS#3","commit_id":"dda573126abaebfefd0ca0a309efd1ea58b95af7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fd6cbba50d2e435c6f3891620e2cf5d3b6f3da69","unresolved":false,"context_lines":[{"line_number":144,"context_line":" )"},{"line_number":145,"context_line":" external_router_grp \u003d parser.add_mutually_exclusive_group()"},{"line_number":146,"context_line":" external_router_grp.add_argument("},{"line_number":147,"context_line":" \u0027--external\u0027,"},{"line_number":148,"context_line":" action\u003d\u0027store_true\u0027,"},{"line_number":149,"context_line":" help\u003d\u0027Set the nature of network \u0027"},{"line_number":150,"context_line":" \u0027(True sets it as an external network). \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1af94dfe_30ceee5a","line":147,"updated":"2016-03-15 13:26:37.000000000","message":"I wonder if \"provider network\" should be used instead of \"external network\".","commit_id":"12a56282fa78e3e64b442d45e7219eb2fcbbc0c7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d197b6df1e98533ef3d73b739e3f9e2705669d69","unresolved":false,"context_lines":[{"line_number":144,"context_line":" )"},{"line_number":145,"context_line":" external_router_grp \u003d parser.add_mutually_exclusive_group()"},{"line_number":146,"context_line":" external_router_grp.add_argument("},{"line_number":147,"context_line":" \u0027--external\u0027,"},{"line_number":148,"context_line":" action\u003d\u0027store_true\u0027,"},{"line_number":149,"context_line":" help\u003d\u0027Set the nature of network \u0027"},{"line_number":150,"context_line":" \u0027(True sets it as an external network). \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1af94dfe_77b967e9","line":147,"in_reply_to":"1af94dfe_30ceee5a","updated":"2016-03-16 02:18:55.000000000","message":"I think external network serves a more apt information , as it is not necessary that the provider network is connected to the Internet( for eg) , but an external network would definitely mean that it has connection outside the box..","commit_id":"12a56282fa78e3e64b442d45e7219eb2fcbbc0c7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fd6cbba50d2e435c6f3891620e2cf5d3b6f3da69","unresolved":false,"context_lines":[{"line_number":159,"context_line":" default_router_grp.add_argument("},{"line_number":160,"context_line":" \u0027--is-default\u0027,"},{"line_number":161,"context_line":" action\u003d\u0027store_true\u0027,"},{"line_number":162,"context_line":" help\u003d\u0027Specify if this network should be used as\u0027"},{"line_number":163,"context_line":" \u0027the default external network.\u0027"},{"line_number":164,"context_line":" \u0027(True sets it as the default external network).\u0027)"},{"line_number":165,"context_line":" default_router_grp.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"1af94dfe_50f9fac7","line":162,"updated":"2016-03-15 13:26:37.000000000","message":"Does this require the \"external-net\" extension as well?","commit_id":"12a56282fa78e3e64b442d45e7219eb2fcbbc0c7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2023a12187d343992e2593da387668cd6d19ae0d","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":" def take_action_network(self, client, parsed_args):"},{"line_number":180,"context_line":" attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":181,"context_line":" # ToDo ( reedip ): After the review of"},{"line_number":182,"context_line":" # https://review.openstack.org/#/c/137279/, the default"},{"line_number":183,"context_line":" # values of router:external and is_default can change"},{"line_number":184,"context_line":" attrs[\u0027router:external\u0027] \u003d parsed_args.external"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_361bc1cb","line":181,"range":{"start_line":181,"start_character":10,"end_line":181,"end_character":26},"updated":"2016-03-18 15:47:43.000000000","message":"# TODO(reedip): After the review ...","commit_id":"5bc09ba697a4ea6e9d01f7aec1e306ab66e0277e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"daa94261d8c354fe7873a18ced9ec0700e13edce","unresolved":false,"context_lines":[{"line_number":146,"context_line":" external_router_grp.add_argument("},{"line_number":147,"context_line":" \u0027--external\u0027,"},{"line_number":148,"context_line":" action\u003d\u0027store_true\u0027,"},{"line_number":149,"context_line":" default\u003dTrue,"},{"line_number":150,"context_line":" help\u003d\u0027Set this network as an external network (default). \u0027"},{"line_number":151,"context_line":" \u0027Requires the \"external-net\" extension to be enabled\u0027)"},{"line_number":152,"context_line":" external_router_grp.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_14e5d3a6","line":149,"updated":"2016-03-18 19:24:12.000000000","message":"This changes behavior which was not external by default. I don\u0027t think we should change behavior.","commit_id":"11f2b83a9fceeafb86290ce9f6e305cf56673d97"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"db3344ce25318b501460dfe83744898dda89536b","unresolved":false,"context_lines":[{"line_number":146,"context_line":" external_router_grp.add_argument("},{"line_number":147,"context_line":" \u0027--external\u0027,"},{"line_number":148,"context_line":" action\u003d\u0027store_true\u0027,"},{"line_number":149,"context_line":" default\u003dTrue,"},{"line_number":150,"context_line":" help\u003d\u0027Set this network as an external network (default). \u0027"},{"line_number":151,"context_line":" \u0027Requires the \"external-net\" extension to be enabled\u0027)"},{"line_number":152,"context_line":" external_router_grp.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_6df60590","line":149,"in_reply_to":"1af94dfe_14e5d3a6","updated":"2016-03-22 03:23:54.000000000","message":"Okay, I will keep --internal as default","commit_id":"11f2b83a9fceeafb86290ce9f6e305cf56673d97"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"daa94261d8c354fe7873a18ced9ec0700e13edce","unresolved":false,"context_lines":[{"line_number":159,"context_line":" \u0027--is-default\u0027,"},{"line_number":160,"context_line":" action\u003d\u0027store_true\u0027,"},{"line_number":161,"context_line":" help\u003d\u0027Specify if this network should be used as \u0027"},{"line_number":162,"context_line":" \u0027the default external network (default)\u0027)"},{"line_number":163,"context_line":" default_router_grp.add_argument("},{"line_number":164,"context_line":" \u0027--is-not-default\u0027,"},{"line_number":165,"context_line":" dest\u003d\u0027is_default\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_74289733","line":162,"updated":"2016-03-18 19:24:12.000000000","message":"Doc lists this as the default.","commit_id":"11f2b83a9fceeafb86290ce9f6e305cf56673d97"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"daa94261d8c354fe7873a18ced9ec0700e13edce","unresolved":false,"context_lines":[{"line_number":165,"context_line":" dest\u003d\u0027is_default\u0027,"},{"line_number":166,"context_line":" action\u003d\u0027store_false\u0027,"},{"line_number":167,"context_line":" default\u003dFalse,"},{"line_number":168,"context_line":" help\u003d\u0027Do not use the network as the default external network\u0027)"},{"line_number":169,"context_line":" return parser"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":" def update_parser_compute(self, parser):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_542f5b3e","line":168,"updated":"2016-03-18 19:24:12.000000000","message":"Doc lists this as the default.","commit_id":"11f2b83a9fceeafb86290ce9f6e305cf56673d97"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"daa94261d8c354fe7873a18ced9ec0700e13edce","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":" def take_action_network(self, client, parsed_args):"},{"line_number":180,"context_line":" attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":181,"context_line":" # ToDo(reedip): After the review of"},{"line_number":182,"context_line":" # https://review.openstack.org/#/c/137279/, the default"},{"line_number":183,"context_line":" # values of router:external and is_default can change"},{"line_number":184,"context_line":" attrs[\u0027router:external\u0027] \u003d parsed_args.external"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_74ea5775","line":181,"updated":"2016-03-18 19:24:12.000000000","message":"I don\u0027t understand why osc depends on the review?","commit_id":"11f2b83a9fceeafb86290ce9f6e305cf56673d97"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"db3344ce25318b501460dfe83744898dda89536b","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":" def take_action_network(self, client, parsed_args):"},{"line_number":180,"context_line":" attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":181,"context_line":" # ToDo(reedip): After the review of"},{"line_number":182,"context_line":" # https://review.openstack.org/#/c/137279/, the default"},{"line_number":183,"context_line":" # values of router:external and is_default can change"},{"line_number":184,"context_line":" attrs[\u0027router:external\u0027] \u003d parsed_args.external"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_2d37dd4d","line":181,"in_reply_to":"1af94dfe_74ea5775","updated":"2016-03-22 03:23:54.000000000","message":"I raised the concern on http://lists.openstack.org/pipermail/openstack-dev/2016-March/089747.html , which you have already responded, I guess.\nOnce the default values of --router:External and others are finalized, I can keep the same values here.... that is the intention","commit_id":"11f2b83a9fceeafb86290ce9f6e305cf56673d97"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"a938383108f1afcca41f3f1b0900dbbb8a176123","unresolved":false,"context_lines":[{"line_number":151,"context_line":" external_router_grp.add_argument("},{"line_number":152,"context_line":" \u0027--internal\u0027,"},{"line_number":153,"context_line":" dest\u003d\"external\","},{"line_number":154,"context_line":" action\u003d\u0027store_false\u0027,"},{"line_number":155,"context_line":" default\u003dFalse,"},{"line_number":156,"context_line":" help\u003d\u0027Set this network as an internal network (default)\u0027)"},{"line_number":157,"context_line":" default_router_grp \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":10,"id":"1af94dfe_f04f8568","line":154,"range":{"start_line":154,"start_character":20,"end_line":154,"end_character":31},"updated":"2016-03-19 07:33:33.000000000","message":"Please follow the rules in this doc.\nhttp://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options","commit_id":"43c14c675df38bedb8f0c272c8a91345ff0b6625"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b4c6438a8778267cbcb3def625badcd5889ec821","unresolved":false,"context_lines":[{"line_number":151,"context_line":" external_router_grp.add_argument("},{"line_number":152,"context_line":" \u0027--internal\u0027,"},{"line_number":153,"context_line":" dest\u003d\"external\","},{"line_number":154,"context_line":" action\u003d\u0027store_false\u0027,"},{"line_number":155,"context_line":" default\u003dFalse,"},{"line_number":156,"context_line":" help\u003d\u0027Set this network as an internal network (default)\u0027)"},{"line_number":157,"context_line":" default_router_grp \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa0719c6_24a51b04","line":154,"range":{"start_line":154,"start_character":20,"end_line":154,"end_character":31},"in_reply_to":"1af94dfe_f04f8568","updated":"2016-03-21 01:31:05.000000000","message":"Okay....","commit_id":"43c14c675df38bedb8f0c272c8a91345ff0b6625"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"a938383108f1afcca41f3f1b0900dbbb8a176123","unresolved":false,"context_lines":[{"line_number":159,"context_line":" \u0027--is-default\u0027,"},{"line_number":160,"context_line":" action\u003d\u0027store_true\u0027,"},{"line_number":161,"context_line":" help\u003d\u0027Specify if this network should be used as \u0027"},{"line_number":162,"context_line":" \u0027the default external network\u0027)"},{"line_number":163,"context_line":" default_router_grp.add_argument("},{"line_number":164,"context_line":" \u0027--is-not-default\u0027,"},{"line_number":165,"context_line":" dest\u003d\u0027is_default\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1af94dfe_90456144","line":162,"range":{"start_line":162,"start_character":30,"end_line":162,"end_character":38},"updated":"2016-03-19 07:33:33.000000000","message":"Since --is-default and --is-not-default are used for external network, is there any way to check if --external is specified when using these two options ?","commit_id":"43c14c675df38bedb8f0c272c8a91345ff0b6625"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b4c6438a8778267cbcb3def625badcd5889ec821","unresolved":false,"context_lines":[{"line_number":159,"context_line":" \u0027--is-default\u0027,"},{"line_number":160,"context_line":" action\u003d\u0027store_true\u0027,"},{"line_number":161,"context_line":" help\u003d\u0027Specify if this network should be used as \u0027"},{"line_number":162,"context_line":" \u0027the default external network\u0027)"},{"line_number":163,"context_line":" default_router_grp.add_argument("},{"line_number":164,"context_line":" \u0027--is-not-default\u0027,"},{"line_number":165,"context_line":" dest\u003d\u0027is_default\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa0719c6_0473b7b2","line":162,"range":{"start_line":162,"start_character":30,"end_line":162,"end_character":38},"in_reply_to":"1af94dfe_90456144","updated":"2016-03-21 01:31:05.000000000","message":"That can be handled by the API itself.","commit_id":"43c14c675df38bedb8f0c272c8a91345ff0b6625"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7bef64e45c90eb7b72ef55ecb0e65ffee4dda1bb","unresolved":false,"context_lines":[{"line_number":159,"context_line":" \u0027--is-default\u0027,"},{"line_number":160,"context_line":" action\u003d\u0027store_true\u0027,"},{"line_number":161,"context_line":" help\u003d\u0027Specify if this network should be used as \u0027"},{"line_number":162,"context_line":" \u0027the default external network\u0027)"},{"line_number":163,"context_line":" default_router_grp.add_argument("},{"line_number":164,"context_line":" \u0027--is-not-default\u0027,"},{"line_number":165,"context_line":" dest\u003d\u0027is_default\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa0719c6_c5c9847a","line":162,"range":{"start_line":162,"start_character":30,"end_line":162,"end_character":38},"in_reply_to":"fa0719c6_0473b7b2","updated":"2016-03-22 03:23:59.000000000","message":"I have added it in line#183","commit_id":"43c14c675df38bedb8f0c272c8a91345ff0b6625"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"a938383108f1afcca41f3f1b0900dbbb8a176123","unresolved":false,"context_lines":[{"line_number":163,"context_line":" default_router_grp.add_argument("},{"line_number":164,"context_line":" \u0027--is-not-default\u0027,"},{"line_number":165,"context_line":" dest\u003d\u0027is_default\u0027,"},{"line_number":166,"context_line":" action\u003d\u0027store_false\u0027,"},{"line_number":167,"context_line":" default\u003dFalse,"},{"line_number":168,"context_line":" help\u003d\u0027Do not use the network as the default \u0027"},{"line_number":169,"context_line":" \u0027external network (default)\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1af94dfe_d0524912","line":166,"range":{"start_line":166,"start_character":20,"end_line":166,"end_character":31},"updated":"2016-03-19 07:33:33.000000000","message":"ditto","commit_id":"43c14c675df38bedb8f0c272c8a91345ff0b6625"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7bef64e45c90eb7b72ef55ecb0e65ffee4dda1bb","unresolved":false,"context_lines":[{"line_number":163,"context_line":" default_router_grp.add_argument("},{"line_number":164,"context_line":" \u0027--is-not-default\u0027,"},{"line_number":165,"context_line":" dest\u003d\u0027is_default\u0027,"},{"line_number":166,"context_line":" action\u003d\u0027store_false\u0027,"},{"line_number":167,"context_line":" default\u003dFalse,"},{"line_number":168,"context_line":" help\u003d\u0027Do not use the network as the default \u0027"},{"line_number":169,"context_line":" \u0027external network (default)\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa0719c6_a5c4505f","line":166,"range":{"start_line":166,"start_character":20,"end_line":166,"end_character":31},"in_reply_to":"1af94dfe_d0524912","updated":"2016-03-22 03:23:59.000000000","message":"Done","commit_id":"43c14c675df38bedb8f0c272c8a91345ff0b6625"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"9b61bfd919b58fef6b4fb18e273592bdf4510d48","unresolved":false,"context_lines":[{"line_number":152,"context_line":" \u0027--internal\u0027,"},{"line_number":153,"context_line":" action\u003d\u0027store_true\u0027,"},{"line_number":154,"context_line":" default\u003dTrue,"},{"line_number":155,"context_line":" help\u003d\u0027Set this network as an internal network (default)\u0027)"},{"line_number":156,"context_line":" default_router_grp \u003d parser.add_mutually_exclusive_group()"},{"line_number":157,"context_line":" default_router_grp.add_argument("},{"line_number":158,"context_line":" \u0027--is-default\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_89cc536b","line":155,"updated":"2016-03-23 21:05:04.000000000","message":"nit...extra space before (default)","commit_id":"9be66be915a4e5dcfefe507d57d7abfbacc53f61"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"9b61bfd919b58fef6b4fb18e273592bdf4510d48","unresolved":false,"context_lines":[{"line_number":164,"context_line":" action\u003d\u0027store_true\u0027,"},{"line_number":165,"context_line":" default\u003dTrue,"},{"line_number":166,"context_line":" help\u003d\u0027Do not use the network as the default \u0027"},{"line_number":167,"context_line":" \u0027external network (default)\u0027)"},{"line_number":168,"context_line":" return parser"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":" def update_parser_compute(self, parser):"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_a9bf97a8","line":167,"updated":"2016-03-23 21:05:04.000000000","message":"nit...extra space before (default)","commit_id":"9be66be915a4e5dcfefe507d57d7abfbacc53f61"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"9b61bfd919b58fef6b4fb18e273592bdf4510d48","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":" def take_action_network(self, client, parsed_args):"},{"line_number":179,"context_line":" attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":180,"context_line":" # ToDo(reedip): After the review of"},{"line_number":181,"context_line":" # https://review.openstack.org/#/c/137279/, the default"},{"line_number":182,"context_line":" # values of router:external and is_default can change"},{"line_number":183,"context_line":" if parsed_args.external:"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_e98eaf2c","line":180,"updated":"2016-03-23 21:05:04.000000000","message":"Why would osc change the defaults based on that review?","commit_id":"9be66be915a4e5dcfefe507d57d7abfbacc53f61"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"90c861b36a86813b4071d4aa2dffa33efc38f907","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":" def take_action_network(self, client, parsed_args):"},{"line_number":179,"context_line":" attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":180,"context_line":" # ToDo(reedip): After the review of"},{"line_number":181,"context_line":" # https://review.openstack.org/#/c/137279/, the default"},{"line_number":182,"context_line":" # values of router:external and is_default can change"},{"line_number":183,"context_line":" if parsed_args.external:"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_1edc8d11","line":180,"updated":"2016-03-25 11:28:53.000000000","message":"Hi Reedip, I\u0027m still unclear about this comment and why changes to neutronclient should change the behavior of OSC...or why neutornclient would want to change behavior in the first place. Can you please explain?","commit_id":"8a2022221a17378d5c81f23801adb375ba1a9281"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c1f12429f9db167e61b40eebbf10574ec505d989","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":" def take_action_network(self, client, parsed_args):"},{"line_number":179,"context_line":" attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":180,"context_line":" # ToDo(reedip): After the review of"},{"line_number":181,"context_line":" # https://review.openstack.org/#/c/137279/, the default"},{"line_number":182,"context_line":" # values of router:external and is_default can change"},{"line_number":183,"context_line":" if parsed_args.external:"}],"source_content_type":"text/x-python","patch_set":16,"id":"da0c15f0_e1b91ecd","line":180,"in_reply_to":"da0c15f0_1edc8d11","updated":"2016-03-27 03:42:34.000000000","message":"Hi Richard,\nI wanted Nuetron COre reviewers to reply to http://lists.openstack.org/pipermail/openstack-dev/2016-March/089747.html to finalize the default behavior, and I wanted to keep the implementation of OSC and NeutronClient as close as possible.\nThats why I commented here.\nBut I can remove it, and based on the final outcome of the MailThread, can change the implementation.","commit_id":"8a2022221a17378d5c81f23801adb375ba1a9281"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"fb2fb00d150a1c24894241336e8b3d0cb4226929","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":" def take_action_network(self, client, parsed_args):"},{"line_number":179,"context_line":" attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":180,"context_line":" if parsed_args.external:"},{"line_number":181,"context_line":" attrs[\u0027router:external\u0027] \u003d True"},{"line_number":182,"context_line":" if parsed_args.is_default:"},{"line_number":183,"context_line":" attrs[\u0027is_default\u0027] \u003d True"},{"line_number":184,"context_line":" elif parsed_args.is_not_default:"},{"line_number":185,"context_line":" attrs[\u0027is_default\u0027] \u003d False"},{"line_number":186,"context_line":" elif parsed_args.internal:"},{"line_number":187,"context_line":" attrs[\u0027router:external\u0027] \u003d False"},{"line_number":188,"context_line":" obj \u003d client.create_network(**attrs)"},{"line_number":189,"context_line":" columns \u003d _get_columns(obj)"},{"line_number":190,"context_line":" data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"}],"source_content_type":"text/x-python","patch_set":17,"id":"da0c15f0_9da068a1","line":187,"range":{"start_line":180,"start_character":0,"end_line":187,"end_character":44},"updated":"2016-03-28 07:49:01.000000000","message":"Why not move this code into _get_attrs() ?","commit_id":"920825746e1f7ab1233511294412e676d2142e66"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d5bf027527ae7cf3bc06efd43ac3b6954c7910ff","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":" def take_action_network(self, client, parsed_args):"},{"line_number":179,"context_line":" attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":180,"context_line":" if parsed_args.external:"},{"line_number":181,"context_line":" attrs[\u0027router:external\u0027] \u003d True"},{"line_number":182,"context_line":" if parsed_args.is_default:"},{"line_number":183,"context_line":" attrs[\u0027is_default\u0027] \u003d True"},{"line_number":184,"context_line":" elif parsed_args.is_not_default:"},{"line_number":185,"context_line":" attrs[\u0027is_default\u0027] \u003d False"},{"line_number":186,"context_line":" elif parsed_args.internal:"},{"line_number":187,"context_line":" attrs[\u0027router:external\u0027] \u003d False"},{"line_number":188,"context_line":" obj \u003d client.create_network(**attrs)"},{"line_number":189,"context_line":" columns \u003d _get_columns(obj)"},{"line_number":190,"context_line":" data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"}],"source_content_type":"text/x-python","patch_set":17,"id":"da0c15f0_bd5bab2d","line":187,"range":{"start_line":180,"start_character":0,"end_line":187,"end_character":44},"in_reply_to":"da0c15f0_9da068a1","updated":"2016-03-28 08:08:21.000000000","message":"I would move it when I begin working on the network update","commit_id":"920825746e1f7ab1233511294412e676d2142e66"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fea47140a3363920ea1bd3b55483f351f5fa922d","unresolved":false,"context_lines":[{"line_number":180,"context_line":" if parsed_args.external:"},{"line_number":181,"context_line":" attrs[\u0027router:external\u0027] \u003d True"},{"line_number":182,"context_line":" if parsed_args.is_default:"},{"line_number":183,"context_line":" attrs[\u0027is_default\u0027] \u003d True"},{"line_number":184,"context_line":" elif parsed_args.is_not_default:"},{"line_number":185,"context_line":" attrs[\u0027is_default\u0027] \u003d False"},{"line_number":186,"context_line":" elif parsed_args.internal:"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_e6e8247f","line":183,"updated":"2016-03-29 12:57:29.000000000","message":"Please add this new attribute to FakeNetwork. Why try to have the fake resource accurately reflect the real resource.","commit_id":"38ed7029cbc81629ccb92a560a264bc95faa5ab0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"90125d6cc7a9a3c5c0e0285b0ae864c1656ce551","unresolved":false,"context_lines":[{"line_number":181,"context_line":" attrs[\u0027router:external\u0027] \u003d True"},{"line_number":182,"context_line":" if parsed_args.default:"},{"line_number":183,"context_line":" attrs[\u0027is_default\u0027] \u003d True"},{"line_number":184,"context_line":" elif parsed_args.not_default:"},{"line_number":185,"context_line":" attrs[\u0027is_default\u0027] \u003d False"},{"line_number":186,"context_line":" elif parsed_args.internal:"},{"line_number":187,"context_line":" attrs[\u0027router:external\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_47405f34","line":184,"updated":"2016-03-31 15:45:53.000000000","message":"Use if per boolean option devref with no default value.","commit_id":"ec67176df06569ae2ea8708f8527a4c75d140280"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"90125d6cc7a9a3c5c0e0285b0ae864c1656ce551","unresolved":false,"context_lines":[{"line_number":183,"context_line":" attrs[\u0027is_default\u0027] \u003d True"},{"line_number":184,"context_line":" elif parsed_args.not_default:"},{"line_number":185,"context_line":" attrs[\u0027is_default\u0027] \u003d False"},{"line_number":186,"context_line":" elif parsed_args.internal:"},{"line_number":187,"context_line":" attrs[\u0027router:external\u0027] \u003d False"},{"line_number":188,"context_line":" obj \u003d client.create_network(**attrs)"},{"line_number":189,"context_line":" columns \u003d _get_columns(obj)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_075ae729","line":186,"updated":"2016-03-31 15:45:53.000000000","message":"Use if per boolean option devref with no default value.","commit_id":"ec67176df06569ae2ea8708f8527a4c75d140280"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6ef266a0cab6c933c1d32e67910518dbecbfbc68","unresolved":false,"context_lines":[{"line_number":176,"context_line":" def take_action_network(self, client, parsed_args):"},{"line_number":177,"context_line":" attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":178,"context_line":" # By Default, all routers are Internal routers"},{"line_number":179,"context_line":" attrs[\u0027router:external\u0027] \u003d False"},{"line_number":180,"context_line":" if parsed_args.external:"},{"line_number":181,"context_line":" attrs[\u0027router:external\u0027] \u003d True"},{"line_number":182,"context_line":" # By Default, no external router is made a default external router"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba0121b8_afa3d4b0","line":179,"updated":"2016-04-01 18:03:31.000000000","message":"Why not follow devref for boolean options? Otherwise, what is the purpose of the --internal option since it isn\u0027t used?","commit_id":"34b5de7cff3ab3ff994baeb43ecf71bad800dc0b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6ef266a0cab6c933c1d32e67910518dbecbfbc68","unresolved":false,"context_lines":[{"line_number":180,"context_line":" if parsed_args.external:"},{"line_number":181,"context_line":" attrs[\u0027router:external\u0027] \u003d True"},{"line_number":182,"context_line":" # By Default, no external router is made a default external router"},{"line_number":183,"context_line":" attrs[\u0027is_default\u0027] \u003d False"},{"line_number":184,"context_line":" if parsed_args.default:"},{"line_number":185,"context_line":" attrs[\u0027is_default\u0027] \u003d True"},{"line_number":186,"context_line":" obj \u003d client.create_network(**attrs)"}],"source_content_type":"text/x-python","patch_set":23,"id":"ba0121b8_2f986477","line":183,"updated":"2016-04-01 18:03:31.000000000","message":"Why not follow devref for boolean options? Otherwise, what is the purpose of the --no-default option since it isn\u0027t used?","commit_id":"34b5de7cff3ab3ff994baeb43ecf71bad800dc0b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"baa51e8746dfe7826ac2f411c394565bc657612a","unresolved":false,"context_lines":[{"line_number":149,"context_line":" \u0027--external\u0027,"},{"line_number":150,"context_line":" action\u003d\u0027store_true\u0027,"},{"line_number":151,"context_line":" help\u003d\u0027Set this network as an external network. \u0027"},{"line_number":152,"context_line":" \u0027Requires the \"external-net\" extension to be enabled,\u0027)"},{"line_number":153,"context_line":" external_router_grp.add_argument("},{"line_number":154,"context_line":" \u0027--internal\u0027,"},{"line_number":155,"context_line":" action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a061dce_e7a30e9d","line":152,"updated":"2016-04-04 18:35:20.000000000","message":"nit...comma should be a period","commit_id":"5c16f0ff4e2df8353c4f50ba2834a806df67b85b"}],"openstackclient/tests/network/v2/fakes.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"90125d6cc7a9a3c5c0e0285b0ae864c1656ce551","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":" # Set default methods."},{"line_number":162,"context_line":" network_methods \u003d {"},{"line_number":163,"context_line":" \u0027keys\u0027: [\u0027id\u0027, \u0027name\u0027, \u0027admin_state_up\u0027, \u0027router_external\u0027,"},{"line_number":164,"context_line":" \u0027status\u0027, \u0027subnets\u0027, \u0027tenant_id\u0027, \u0027availability_zones\u0027,"},{"line_number":165,"context_line":" \u0027availability_zone_hints\u0027],"},{"line_number":166,"context_line":" }"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba0121b8_2c427268","line":163,"updated":"2016-03-31 15:45:53.000000000","message":"Please add is_default here as well.","commit_id":"ec67176df06569ae2ea8708f8527a4c75d140280"}],"openstackclient/tests/network/v2/test_network.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"fb2fb00d150a1c24894241336e8b3d0cb4226929","unresolved":false,"context_lines":[{"line_number":163,"context_line":" \u0027name\u0027: self._network.name,"},{"line_number":164,"context_line":" \u0027shared\u0027: True,"},{"line_number":165,"context_line":" \u0027tenant_id\u0027: identity_fakes_v3.project_id,"},{"line_number":166,"context_line":" \u0027is_default\u0027: True,"},{"line_number":167,"context_line":" \u0027router:external\u0027: True,"},{"line_number":168,"context_line":" })"},{"line_number":169,"context_line":" self.assertEqual(self.columns, columns)"}],"source_content_type":"text/x-python","patch_set":17,"id":"da0c15f0_7dc0f42a","line":166,"range":{"start_line":166,"start_character":13,"end_line":166,"end_character":23},"updated":"2016-03-28 07:49:01.000000000","message":"\"is_default\" is not in FakeNetwork. Shall we add it ?","commit_id":"920825746e1f7ab1233511294412e676d2142e66"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d5bf027527ae7cf3bc06efd43ac3b6954c7910ff","unresolved":false,"context_lines":[{"line_number":163,"context_line":" \u0027name\u0027: self._network.name,"},{"line_number":164,"context_line":" \u0027shared\u0027: True,"},{"line_number":165,"context_line":" \u0027tenant_id\u0027: identity_fakes_v3.project_id,"},{"line_number":166,"context_line":" \u0027is_default\u0027: True,"},{"line_number":167,"context_line":" \u0027router:external\u0027: True,"},{"line_number":168,"context_line":" })"},{"line_number":169,"context_line":" self.assertEqual(self.columns, columns)"}],"source_content_type":"text/x-python","patch_set":17,"id":"da0c15f0_fd6403e6","line":166,"range":{"start_line":166,"start_character":13,"end_line":166,"end_character":23},"in_reply_to":"da0c15f0_7dc0f42a","updated":"2016-03-28 08:08:21.000000000","message":"arg_list will update this in the FakeNetwork.\nSo I do not think it is absolutely necessary to be updated.\nI think if the new options added in any CLI are optional, we can skip updates of fake.py for those options.","commit_id":"920825746e1f7ab1233511294412e676d2142e66"}],"releasenotes/notes/add-external-options-7a66219d263bb1e5.yaml":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"535f5177df2182ff713153d92c65065cf61db180","unresolved":false,"context_lines":[{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" New options have been added to the ``openstack network create`` CLI"},{"line_number":5,"context_line":" to support external network functionality. The new options are"},{"line_number":6,"context_line":" \"--external/--internal\" and \"--is-default/--is-not-default\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3afc51ec_8f4ac924","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":63},"updated":"2016-03-15 05:37:05.000000000","message":"Please also link the bug here.\n\nSomething like this: \n\n[Bug `1545537 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1545537\u003e`_]","commit_id":"dda573126abaebfefd0ca0a309efd1ea58b95af7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6686916ddb798cfb4f351dcc7978664194126fe2","unresolved":false,"context_lines":[{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" New options have been added to the ``openstack network create`` CLI"},{"line_number":5,"context_line":" to support external network functionality. The new options are"},{"line_number":6,"context_line":" \"--external/--internal\" and \"--is-default/--is-not-default\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3afc51ec_8fc9295c","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":63},"in_reply_to":"3afc51ec_8f4ac924","updated":"2016-03-15 05:48:44.000000000","message":"Oh, I missed it...","commit_id":"dda573126abaebfefd0ca0a309efd1ea58b95af7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2023a12187d343992e2593da387668cd6d19ae0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" New options have been added to the ``openstack network create`` CLI"},{"line_number":5,"context_line":" to support external network functionality. The new options are"},{"line_number":6,"context_line":" \"--external/--internal\" and \"--is-default/--is-not-default\""},{"line_number":7,"context_line":" [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1af94dfe_d6e7fda9","line":4,"range":{"start_line":4,"start_character":41,"end_line":4,"end_character":50},"updated":"2016-03-18 15:47:43.000000000","message":"remove \"openstack\" we don\u0027t have it for any other release notes","commit_id":"5bc09ba697a4ea6e9d01f7aec1e306ab66e0277e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2023a12187d343992e2593da387668cd6d19ae0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" New options have been added to the ``openstack network create`` CLI"},{"line_number":5,"context_line":" to support external network functionality. The new options are"},{"line_number":6,"context_line":" \"--external/--internal\" and \"--is-default/--is-not-default\""},{"line_number":7,"context_line":" [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1af94dfe_9698d51d","line":4,"range":{"start_line":4,"start_character":68,"end_line":4,"end_character":71},"updated":"2016-03-18 15:47:43.000000000","message":"remove CLI, this whole project is a CLI :)","commit_id":"5bc09ba697a4ea6e9d01f7aec1e306ab66e0277e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2023a12187d343992e2593da387668cd6d19ae0d","unresolved":false,"context_lines":[{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" New options have been added to the ``openstack network create`` CLI"},{"line_number":5,"context_line":" to support external network functionality. The new options are"},{"line_number":6,"context_line":" \"--external/--internal\" and \"--is-default/--is-not-default\""},{"line_number":7,"context_line":" [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1af94dfe_f68799b2","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":63},"updated":"2016-03-18 15:47:43.000000000","message":"put the options in single backtick (`) instead of double quotes (\")","commit_id":"5bc09ba697a4ea6e9d01f7aec1e306ab66e0277e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"daa94261d8c354fe7873a18ced9ec0700e13edce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" New options have been added to the ``network create``"},{"line_number":5,"context_line":" to support external network functionality. The new options are"},{"line_number":6,"context_line":" `--external/--internal` and `--is-default/--is-not-default`"},{"line_number":7,"context_line":" [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1af94dfe_a1fdc36f","line":4,"updated":"2016-03-18 19:24:12.000000000","message":"I think you intended to add \"command\" after ``network create``.","commit_id":"11f2b83a9fceeafb86290ce9f6e305cf56673d97"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"daa94261d8c354fe7873a18ced9ec0700e13edce","unresolved":false,"context_lines":[{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" New options have been added to the ``network create``"},{"line_number":5,"context_line":" to support external network functionality. The new options are"},{"line_number":6,"context_line":" `--external/--internal` and `--is-default/--is-not-default`"},{"line_number":7,"context_line":" [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1af94dfe_41e31fd9","line":6,"updated":"2016-03-18 19:24:12.000000000","message":"Please use double ``.","commit_id":"11f2b83a9fceeafb86290ce9f6e305cf56673d97"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"baa51e8746dfe7826ac2f411c394565bc657612a","unresolved":false,"context_lines":[{"line_number":4,"context_line":" New options have been added to the ``network create`` command"},{"line_number":5,"context_line":" to support external network functionality. The new options are"},{"line_number":6,"context_line":" ``--external/--internal`` and suboptions to ``external``:"},{"line_number":7,"context_line":" ``--default/--no-default``"},{"line_number":8,"context_line":" [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9a061dce_87033273","line":7,"updated":"2016-04-04 18:35:20.000000000","message":"Should we note these options are for Network v2 only?","commit_id":"5c16f0ff4e2df8353c4f50ba2834a806df67b85b"}]}