)]}'
{"doc/source/command-objects/volume-type.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"96233f38bbe29d4e1f60db6bc0bd8ee95c297b9d","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":".. option:: --project \u003cproject\u003e"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    Set volume type access to project(name or ID) (admin only)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    *Volume version 2 only*"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa0719c6_fb1492e9","line":110,"updated":"2016-03-24 13:42:38.000000000","message":"nit...space after project","commit_id":"06d4ec47271162822b7244436cff453936213c42"}],"openstackclient/tests/volume/v2/test_type.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ae41472f2bdddee4ffe32140471dc046827c7de1","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        self.assertIn(\u0027myprop\u0027, result)"},{"line_number":302,"context_line":"        self.assertEqual(\u0027myvalue\u0027, result[\u0027myprop\u0027])"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def test_type_set_project_access(self):"},{"line_number":305,"context_line":"        arglist \u003d ["},{"line_number":306,"context_line":"            \u0027--project\u0027, identity_fakes.project_id,"},{"line_number":307,"context_line":"            volume_fakes.type_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a061dce_ea7a00bc","line":304,"updated":"2016-04-07 14:59:17.000000000","message":"It would be nice to have a unit test for the error handling as well.","commit_id":"83916ae2b16411f4a5acab4aa43cca1a6a8ba3b7"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"772e94293b80fa338c168dde1d0812468fda3669","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        self.assertIn(\u0027myprop\u0027, result)"},{"line_number":302,"context_line":"        self.assertEqual(\u0027myvalue\u0027, result[\u0027myprop\u0027])"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def test_type_set_project_access(self):"},{"line_number":305,"context_line":"        arglist \u003d ["},{"line_number":306,"context_line":"            \u0027--project\u0027, identity_fakes.project_id,"},{"line_number":307,"context_line":"            volume_fakes.type_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a061dce_4bc969ab","line":304,"in_reply_to":"9a061dce_ea7a00bc","updated":"2016-04-07 16:23:51.000000000","message":"Ok, I will add test case for exception cases","commit_id":"83916ae2b16411f4a5acab4aa43cca1a6a8ba3b7"}],"openstackclient/volume/v2/volume_type.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"344e1d2e8bef0c538f5a55f4417d6fe5560def1e","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":158,"context_line":"        )"},{"line_number":159,"context_line":"        parser.add_argument("},{"line_number":160,"context_line":"            \u0027--project\u0027,"},{"line_number":161,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":162,"context_line":"            help\u003d\u0027Set volume type access to project\u0027,"},{"line_number":163,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_8bd57e1d","line":160,"updated":"2016-03-17 19:42:04.000000000","message":"Do you need identity_common.add_project_domain_option_to_parser(parser) to go along with this option?  See other commands for examples.","commit_id":"6bcb55b0fcfd961ff72f83af5547678876ec4b29"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"7242168919c71fb23c72d64d812d1a75709b018d","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                 \u0027(repeat option to set multiple properties)\u0027,"},{"line_number":158,"context_line":"        )"},{"line_number":159,"context_line":"        parser.add_argument("},{"line_number":160,"context_line":"            \u0027--project\u0027,"},{"line_number":161,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":162,"context_line":"            help\u003d\u0027Set volume type access to project\u0027,"},{"line_number":163,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_4b4896cc","line":160,"in_reply_to":"1af94dfe_8bd57e1d","updated":"2016-03-18 09:03:30.000000000","message":"will check if required... I am not getting exact usage for use of this identity_common and adding extra argument etc..","commit_id":"6bcb55b0fcfd961ff72f83af5547678876ec4b29"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"344e1d2e8bef0c538f5a55f4417d6fe5560def1e","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if parsed_args.property:"},{"line_number":191,"context_line":"            volume_type.set_keys(parsed_args.property)"},{"line_number":192,"context_line":"        if parsed_args.project:"},{"line_number":193,"context_line":"            volume_client.volume_type_access.add_project_access("},{"line_number":194,"context_line":"                volume_type.id, parsed_args.project)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_ebe6c213","line":193,"updated":"2016-03-17 19:42:04.000000000","message":"I think https://github.com/openstack/python-openstackclient/blob/master/doc/source/command-errors.rst should be followed here.","commit_id":"6bcb55b0fcfd961ff72f83af5547678876ec4b29"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"7242168919c71fb23c72d64d812d1a75709b018d","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if parsed_args.property:"},{"line_number":191,"context_line":"            volume_type.set_keys(parsed_args.property)"},{"line_number":192,"context_line":"        if parsed_args.project:"},{"line_number":193,"context_line":"            volume_client.volume_type_access.add_project_access("},{"line_number":194,"context_line":"                volume_type.id, parsed_args.project)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_1b9d25bc","line":193,"in_reply_to":"1af94dfe_ebe6c213","updated":"2016-03-18 09:03:30.000000000","message":"This is fair suggestion to add exception handling here..\nI will update accoringly.\nThank you!!!","commit_id":"6bcb55b0fcfd961ff72f83af5547678876ec4b29"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"96233f38bbe29d4e1f60db6bc0bd8ee95c297b9d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":163,"context_line":"            help\u003d\u0027Set volume type access to project(name or ID) (admin only)\u0027,"},{"line_number":164,"context_line":"        )"},{"line_number":165,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        return parser"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa0719c6_1bc86673","line":165,"updated":"2016-03-24 13:42:38.000000000","message":"This is missing from the doc.","commit_id":"06d4ec47271162822b7244436cff453936213c42"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"4da84288418fdf39ad0374d286f9e31d16ef7492","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":163,"context_line":"            help\u003d\u0027Set volume type access to project(name or ID) (admin only)\u0027,"},{"line_number":164,"context_line":"        )"},{"line_number":165,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        return parser"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_fe58b458","line":165,"in_reply_to":"fa0719c6_1bc86673","updated":"2016-03-25 13:33:18.000000000","message":"ok, added.","commit_id":"06d4ec47271162822b7244436cff453936213c42"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"96233f38bbe29d4e1f60db6bc0bd8ee95c297b9d","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                parsed_args.project,"},{"line_number":202,"context_line":"                parsed_args.project_domain)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            volume_client.volume_type_access.add_project_access("},{"line_number":205,"context_line":"                volume_type.id, project_info.id)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa0719c6_1b76a63d","line":204,"updated":"2016-03-24 13:42:38.000000000","message":"I think https://github.com/openstack/python-openstackclient/blob/master/doc/source/command-errors.rst should be followed.","commit_id":"06d4ec47271162822b7244436cff453936213c42"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0ffd58f15a6153d6ad7b0871b9fc02ebfbe2e366","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                parsed_args.project,"},{"line_number":202,"context_line":"                parsed_args.project_domain)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            volume_client.volume_type_access.add_project_access("},{"line_number":205,"context_line":"                volume_type.id, project_info.id)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_34ffed02","line":204,"in_reply_to":"da0c15f0_de2cd0ad","updated":"2016-03-25 13:48:51.000000000","message":"This is what I was thinking might work:\n\n\ntry: \n    volume_client.volume_type_access.add_project_access(\n        volume_type.id, project_info.id)\nexcept Exception as e:\n    self.app.log.error(\"Add project failed: \"  + str(e))","commit_id":"06d4ec47271162822b7244436cff453936213c42"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"4da84288418fdf39ad0374d286f9e31d16ef7492","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                parsed_args.project,"},{"line_number":202,"context_line":"                parsed_args.project_domain)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            volume_client.volume_type_access.add_project_access("},{"line_number":205,"context_line":"                volume_type.id, project_info.id)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da0c15f0_de2cd0ad","line":204,"in_reply_to":"fa0719c6_1b76a63d","updated":"2016-03-25 13:33:18.000000000","message":"I tried to add exception handling but that seemed to have supressed warnings from cinder client..\n\nfor ex,\n\nopenstack volume type set --project 5541d9eba64f4f139fd3963e4bab5484 0d27d781-83a7-4679-8deb-25e91c598d0b\nNo tenant with a name or ID of \u00275541d9eba64f4f139fd3963e4bab5484\u0027 exists\nwill be suppressed if we try to implement our own exceptions.\n\nIt will be helpful if you can explain a bit more what kind of implementation is expected here for exception handling.","commit_id":"06d4ec47271162822b7244436cff453936213c42"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"739ab0212955919a544575a6fcc5d46e094e4708","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        parser.add_argument("},{"line_number":161,"context_line":"            \u0027--project\u0027,"},{"line_number":162,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":163,"context_line":"            help\u003d\u0027Set volume type access to project(name or ID) (admin only)\u0027,"},{"line_number":164,"context_line":"        )"},{"line_number":165,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_be39b6d9","line":163,"range":{"start_line":163,"start_character":44,"end_line":163,"end_character":63},"updated":"2016-03-30 18:55:04.000000000","message":"missing a space here, between project and (name","commit_id":"d3b6e81575025f1984ecdcbe5aac00b1394ddac1"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"27c87956705fe15643be06f2809bb56937bb1b76","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        parser.add_argument("},{"line_number":161,"context_line":"            \u0027--project\u0027,"},{"line_number":162,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":163,"context_line":"            help\u003d\u0027Set volume type access to project(name or ID) (admin only)\u0027,"},{"line_number":164,"context_line":"        )"},{"line_number":165,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_5ed21a5d","line":163,"range":{"start_line":163,"start_character":44,"end_line":163,"end_character":63},"in_reply_to":"ba0121b8_be39b6d9","updated":"2016-03-30 19:01:06.000000000","message":"Done","commit_id":"d3b6e81575025f1984ecdcbe5aac00b1394ddac1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3a711c063dfe8b0e8937863de2c10a786a5a2e21","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        parser.add_argument("},{"line_number":161,"context_line":"            \u0027--project\u0027,"},{"line_number":162,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":163,"context_line":"            help\u003d\u0027Set volume type access to project (Name or ID) (admin only)\u0027,"},{"line_number":164,"context_line":"        )"},{"line_number":165,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba0121b8_ecd19a58","line":163,"updated":"2016-03-31 15:35:41.000000000","message":"nit...lowercase \"name\" to match the doc","commit_id":"56669151eee58c2731667f7be413d8ee70439e4c"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"8cffc702a1fd0551454133734aa0e1fbe5bd05be","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        parser.add_argument("},{"line_number":161,"context_line":"            \u0027--project\u0027,"},{"line_number":162,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":163,"context_line":"            help\u003d\u0027Set volume type access to project (Name or ID) (admin only)\u0027,"},{"line_number":164,"context_line":"        )"},{"line_number":165,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba0121b8_dfe54f09","line":163,"in_reply_to":"ba0121b8_ecd19a58","updated":"2016-03-31 17:44:29.000000000","message":"Done","commit_id":"56669151eee58c2731667f7be413d8ee70439e4c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3a711c063dfe8b0e8937863de2c10a786a5a2e21","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        if kwargs:"},{"line_number":190,"context_line":"            volume_client.volume_types.update("},{"line_number":191,"context_line":"                volume_type.id,"},{"line_number":192,"context_line":"                **kwargs"},{"line_number":193,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba0121b8_0cb7aef5","line":190,"updated":"2016-03-31 15:35:41.000000000","message":"Per the devref, exception handling is needed here too.","commit_id":"56669151eee58c2731667f7be413d8ee70439e4c"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"8cffc702a1fd0551454133734aa0e1fbe5bd05be","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        if kwargs:"},{"line_number":190,"context_line":"            volume_client.volume_types.update("},{"line_number":191,"context_line":"                volume_type.id,"},{"line_number":192,"context_line":"                **kwargs"},{"line_number":193,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba0121b8_1fece7f1","line":190,"in_reply_to":"ba0121b8_0cb7aef5","updated":"2016-03-31 17:44:29.000000000","message":"Done","commit_id":"56669151eee58c2731667f7be413d8ee70439e4c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3a711c063dfe8b0e8937863de2c10a786a5a2e21","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            )"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if parsed_args.property:"},{"line_number":196,"context_line":"            volume_type.set_keys(parsed_args.property)"},{"line_number":197,"context_line":"        if parsed_args.project:"},{"line_number":198,"context_line":"            project_info \u003d None"},{"line_number":199,"context_line":"            project_info \u003d identity_common.find_project("}],"source_content_type":"text/x-python","patch_set":10,"id":"ba0121b8_6cd0ea1f","line":196,"updated":"2016-03-31 15:35:41.000000000","message":"Per the devref, exception handling is needed here too.","commit_id":"56669151eee58c2731667f7be413d8ee70439e4c"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"8cffc702a1fd0551454133734aa0e1fbe5bd05be","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            )"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if parsed_args.property:"},{"line_number":196,"context_line":"            volume_type.set_keys(parsed_args.property)"},{"line_number":197,"context_line":"        if parsed_args.project:"},{"line_number":198,"context_line":"            project_info \u003d None"},{"line_number":199,"context_line":"            project_info \u003d identity_common.find_project("}],"source_content_type":"text/x-python","patch_set":10,"id":"ba0121b8_5fc01f50","line":196,"in_reply_to":"ba0121b8_6cd0ea1f","updated":"2016-03-31 17:44:29.000000000","message":"Done","commit_id":"56669151eee58c2731667f7be413d8ee70439e4c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3a711c063dfe8b0e8937863de2c10a786a5a2e21","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            volume_type.set_keys(parsed_args.property)"},{"line_number":197,"context_line":"        if parsed_args.project:"},{"line_number":198,"context_line":"            project_info \u003d None"},{"line_number":199,"context_line":"            project_info \u003d identity_common.find_project("},{"line_number":200,"context_line":"                identity_client,"},{"line_number":201,"context_line":"                parsed_args.project,"},{"line_number":202,"context_line":"                parsed_args.project_domain)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba0121b8_ac5322e1","line":199,"updated":"2016-03-31 15:35:41.000000000","message":"This should be in the try block in case the project cannot be found.","commit_id":"56669151eee58c2731667f7be413d8ee70439e4c"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"8cffc702a1fd0551454133734aa0e1fbe5bd05be","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            volume_type.set_keys(parsed_args.property)"},{"line_number":197,"context_line":"        if parsed_args.project:"},{"line_number":198,"context_line":"            project_info \u003d None"},{"line_number":199,"context_line":"            project_info \u003d identity_common.find_project("},{"line_number":200,"context_line":"                identity_client,"},{"line_number":201,"context_line":"                parsed_args.project,"},{"line_number":202,"context_line":"                parsed_args.project_domain)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba0121b8_5fa77fbc","line":199,"in_reply_to":"ba0121b8_ac5322e1","updated":"2016-03-31 17:44:29.000000000","message":"Done","commit_id":"56669151eee58c2731667f7be413d8ee70439e4c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3a711c063dfe8b0e8937863de2c10a786a5a2e21","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                volume_client.volume_type_access.add_project_access("},{"line_number":206,"context_line":"                    volume_type.id, project_info.id)"},{"line_number":207,"context_line":"            except Exception as e:"},{"line_number":208,"context_line":"                self.app.log.error(\"Setting volume type access failed: \" +"},{"line_number":209,"context_line":"                                   str(e))"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba0121b8_ac18421f","line":208,"updated":"2016-03-31 15:35:41.000000000","message":"Per the devref, this requires existing with a non-zero return code.","commit_id":"56669151eee58c2731667f7be413d8ee70439e4c"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"8cffc702a1fd0551454133734aa0e1fbe5bd05be","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                volume_client.volume_type_access.add_project_access("},{"line_number":206,"context_line":"                    volume_type.id, project_info.id)"},{"line_number":207,"context_line":"            except Exception as e:"},{"line_number":208,"context_line":"                self.app.log.error(\"Setting volume type access failed: \" +"},{"line_number":209,"context_line":"                                   str(e))"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba0121b8_ff98137a","line":208,"in_reply_to":"ba0121b8_ac18421f","updated":"2016-03-31 17:44:29.000000000","message":"Done","commit_id":"56669151eee58c2731667f7be413d8ee70439e4c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f8a0ce33deff143ebd0271abe2c925d3b7fb6ab5","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                    **kwargs"},{"line_number":196,"context_line":"                )"},{"line_number":197,"context_line":"            except Exception as e:"},{"line_number":198,"context_line":"                raise exceptions.CommandError(\"Command Failed: \" +"},{"line_number":199,"context_line":"                                              str(e))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        if parsed_args.property:"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a061dce_e2265c15","line":198,"updated":"2016-04-04 18:54:19.000000000","message":"The command should continue to the next update and just log the error like is done for project.","commit_id":"6c615272f4af1fd6bea08e4ac7a2557b7db7409b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f8a0ce33deff143ebd0271abe2c925d3b7fb6ab5","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            try:"},{"line_number":203,"context_line":"                volume_type.set_keys(parsed_args.property)"},{"line_number":204,"context_line":"            except Exception as e:"},{"line_number":205,"context_line":"                raise exceptions.CommandError(\"Command Failed: \" +"},{"line_number":206,"context_line":"                                              str(e))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        if parsed_args.project:"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a061dce_c2235804","line":205,"updated":"2016-04-04 18:54:19.000000000","message":"The command should continue to the next update and just log the error like is done for project.","commit_id":"6c615272f4af1fd6bea08e4ac7a2557b7db7409b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f8a0ce33deff143ebd0271abe2c925d3b7fb6ab5","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        if parsed_args.project:"},{"line_number":209,"context_line":"            project_info \u003d None"},{"line_number":210,"context_line":"            try:"},{"line_number":211,"context_line":"                project_info \u003d identity_common.find_project("},{"line_number":212,"context_line":"                    identity_client,"},{"line_number":213,"context_line":"                    parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a061dce_027550f8","line":210,"updated":"2016-04-04 18:54:19.000000000","message":"I think a single try block is sufficient since if find fails there\u0027s no reason to try the add_project_access.","commit_id":"6c615272f4af1fd6bea08e4ac7a2557b7db7409b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ae41472f2bdddee4ffe32140471dc046827c7de1","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                    **kwargs"},{"line_number":196,"context_line":"                )"},{"line_number":197,"context_line":"            except Exception as e:"},{"line_number":198,"context_line":"                self.app.log.error(\"Failed to update volume type: \" +"},{"line_number":199,"context_line":"                                   str(e))"},{"line_number":200,"context_line":"                result +\u003d 1"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a061dce_6ab9d0cb","line":198,"updated":"2016-04-07 14:59:17.000000000","message":"I think that the message here is a little too generic since a caller may think that the entire operation failed.  Consider including kwargs in the message to note the items that failed to be updated.","commit_id":"83916ae2b16411f4a5acab4aa43cca1a6a8ba3b7"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"772e94293b80fa338c168dde1d0812468fda3669","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                    **kwargs"},{"line_number":196,"context_line":"                )"},{"line_number":197,"context_line":"            except Exception as e:"},{"line_number":198,"context_line":"                self.app.log.error(\"Failed to update volume type: \" +"},{"line_number":199,"context_line":"                                   str(e))"},{"line_number":200,"context_line":"                result +\u003d 1"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a061dce_cb8f3973","line":198,"in_reply_to":"9a061dce_6ab9d0cb","updated":"2016-04-07 16:23:51.000000000","message":"\"Failed to update volume type name or description\"\nThis is inline with next message\n\"Failed to set volume type property\"","commit_id":"83916ae2b16411f4a5acab4aa43cca1a6a8ba3b7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ae41472f2bdddee4ffe32140471dc046827c7de1","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                volume_client.volume_type_access.add_project_access("},{"line_number":219,"context_line":"                    volume_type.id, project_info.id)"},{"line_number":220,"context_line":"            except Exception as e:"},{"line_number":221,"context_line":"                self.app.log.error(\"Failed to set volume type access: \" +"},{"line_number":222,"context_line":"                                   str(e))"},{"line_number":223,"context_line":"                result +\u003d 1"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a061dce_6a2ef0fb","line":221,"updated":"2016-04-07 14:59:17.000000000","message":"I suggest changing \"access\" to \"project\" to match the option name.","commit_id":"83916ae2b16411f4a5acab4aa43cca1a6a8ba3b7"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"772e94293b80fa338c168dde1d0812468fda3669","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                volume_client.volume_type_access.add_project_access("},{"line_number":219,"context_line":"                    volume_type.id, project_info.id)"},{"line_number":220,"context_line":"            except Exception as e:"},{"line_number":221,"context_line":"                self.app.log.error(\"Failed to set volume type access: \" +"},{"line_number":222,"context_line":"                                   str(e))"},{"line_number":223,"context_line":"                result +\u003d 1"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a061dce_abb3e54b","line":221,"in_reply_to":"9a061dce_6a2ef0fb","updated":"2016-04-07 16:23:51.000000000","message":"\"Failed to set volume type access to project\"","commit_id":"83916ae2b16411f4a5acab4aa43cca1a6a8ba3b7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ae41472f2bdddee4ffe32140471dc046827c7de1","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                result +\u003d 1"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if result \u003e 0:"},{"line_number":226,"context_line":"            raise exceptions.CommandError(\"Command Failed\")"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"class ShowVolumeType(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a061dce_6a98b01c","line":226,"updated":"2016-04-07 14:59:17.000000000","message":"I suggest improving the message to note that the command only partially failed.  Some updates may have been successful.","commit_id":"83916ae2b16411f4a5acab4aa43cca1a6a8ba3b7"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"772e94293b80fa338c168dde1d0812468fda3669","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                result +\u003d 1"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if result \u003e 0:"},{"line_number":226,"context_line":"            raise exceptions.CommandError(\"Command Failed\")"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"class ShowVolumeType(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a061dce_cb61f9d4","line":226,"in_reply_to":"9a061dce_6a98b01c","updated":"2016-04-07 16:23:51.000000000","message":"\"Command Failed: Some or All of the operations failed\"","commit_id":"83916ae2b16411f4a5acab4aa43cca1a6a8ba3b7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8554847ee5a8699d719ca6ff451f5e64a06aeaae","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                result +\u003d 1"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if result \u003e 0:"},{"line_number":226,"context_line":"            raise exceptions.CommandError(\"Command Failed: Some or All of the\""},{"line_number":227,"context_line":"                                          \" operations failed\")"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a061dce_c1406d38","line":226,"range":{"start_line":226,"start_character":59,"end_line":226,"end_character":70},"updated":"2016-04-08 21:47:01.000000000","message":"suggestion...\"One or more\"","commit_id":"806ad9055ab28d06e5d830484d236dba91d80e2f"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"39ffa12499bfdbeb2bdb43993e5adbaf8b01ca06","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                result +\u003d 1"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if result \u003e 0:"},{"line_number":226,"context_line":"            raise exceptions.CommandError(\"Command Failed: Some or All of the\""},{"line_number":227,"context_line":"                                          \" operations failed\")"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a061dce_6ecb441f","line":226,"range":{"start_line":226,"start_character":59,"end_line":226,"end_character":70},"in_reply_to":"9a061dce_c1406d38","updated":"2016-04-09 13:37:21.000000000","message":"Done","commit_id":"806ad9055ab28d06e5d830484d236dba91d80e2f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6a5d4c5c79fdc4592bde112a628ec1a5aa564fea","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                result +\u003d 1"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if result \u003e 0:"},{"line_number":226,"context_line":"            raise exceptions.CommandError(\"Command Failed: One or More of the\""},{"line_number":227,"context_line":"                                          \" operations failed\")"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"7a1b2928_646d3d04","line":226,"range":{"start_line":226,"start_character":66,"end_line":226,"end_character":70},"updated":"2016-04-11 12:39:14.000000000","message":"This should be lowercase...\"more\"","commit_id":"b0a361254fd434777ebf9926257e0b2b140f79de"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a8782eea3981e170f390b9b0e6fe100947bba4ce","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        if parsed_args.description:"},{"line_number":189,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        if kwargs:"},{"line_number":192,"context_line":"            try:"},{"line_number":193,"context_line":"                volume_client.volume_types.update("},{"line_number":194,"context_line":"                    volume_type.id,"},{"line_number":195,"context_line":"                    **kwargs"},{"line_number":196,"context_line":"                )"},{"line_number":197,"context_line":"            except Exception as e:"},{"line_number":198,"context_line":"                self.app.log.error(\"Failed to update volume type name or\""},{"line_number":199,"context_line":"                                   \" description: \" + str(e))"},{"line_number":200,"context_line":"                result +\u003d 1"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        if parsed_args.property:"},{"line_number":203,"context_line":"            try:"},{"line_number":204,"context_line":"                volume_type.set_keys(parsed_args.property)"},{"line_number":205,"context_line":"            except Exception as e:"},{"line_number":206,"context_line":"                self.app.log.error(\"Failed to set volume type property: \" +"},{"line_number":207,"context_line":"                                   str(e))"},{"line_number":208,"context_line":"                result +\u003d 1"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        if parsed_args.project:"},{"line_number":211,"context_line":"            project_info \u003d None"},{"line_number":212,"context_line":"            try:"},{"line_number":213,"context_line":"                project_info \u003d identity_common.find_project("},{"line_number":214,"context_line":"                    identity_client,"},{"line_number":215,"context_line":"                    parsed_args.project,"},{"line_number":216,"context_line":"                    parsed_args.project_domain)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"                volume_client.volume_type_access.add_project_access("},{"line_number":219,"context_line":"                    volume_type.id, project_info.id)"},{"line_number":220,"context_line":"            except Exception as e:"},{"line_number":221,"context_line":"                self.app.log.error(\"Failed to set volume type access to\""},{"line_number":222,"context_line":"                                   \" project: \" + str(e))"},{"line_number":223,"context_line":"                result +\u003d 1"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if result \u003e 0:"},{"line_number":226,"context_line":"            raise exceptions.CommandError(\"Command Failed: One or more of the\""},{"line_number":227,"context_line":"                                          \" operations failed\")"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"class ShowVolumeType(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a18252c_a65f3d71","line":227,"range":{"start_line":191,"start_character":0,"end_line":227,"end_character":63},"updated":"2016-04-12 21:22:01.000000000","message":"i love this pattern!","commit_id":"be2d2a1b8da02d6b8ab05240e4ab61b26f65e442"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"4fcbba18260754b84df5bb6ce238574c4442b675","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        if parsed_args.description:"},{"line_number":189,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        if kwargs:"},{"line_number":192,"context_line":"            try:"},{"line_number":193,"context_line":"                volume_client.volume_types.update("},{"line_number":194,"context_line":"                    volume_type.id,"},{"line_number":195,"context_line":"                    **kwargs"},{"line_number":196,"context_line":"                )"},{"line_number":197,"context_line":"            except Exception as e:"},{"line_number":198,"context_line":"                self.app.log.error(\"Failed to update volume type name or\""},{"line_number":199,"context_line":"                                   \" description: \" + str(e))"},{"line_number":200,"context_line":"                result +\u003d 1"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        if parsed_args.property:"},{"line_number":203,"context_line":"            try:"},{"line_number":204,"context_line":"                volume_type.set_keys(parsed_args.property)"},{"line_number":205,"context_line":"            except Exception as e:"},{"line_number":206,"context_line":"                self.app.log.error(\"Failed to set volume type property: \" +"},{"line_number":207,"context_line":"                                   str(e))"},{"line_number":208,"context_line":"                result +\u003d 1"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        if parsed_args.project:"},{"line_number":211,"context_line":"            project_info \u003d None"},{"line_number":212,"context_line":"            try:"},{"line_number":213,"context_line":"                project_info \u003d identity_common.find_project("},{"line_number":214,"context_line":"                    identity_client,"},{"line_number":215,"context_line":"                    parsed_args.project,"},{"line_number":216,"context_line":"                    parsed_args.project_domain)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"                volume_client.volume_type_access.add_project_access("},{"line_number":219,"context_line":"                    volume_type.id, project_info.id)"},{"line_number":220,"context_line":"            except Exception as e:"},{"line_number":221,"context_line":"                self.app.log.error(\"Failed to set volume type access to\""},{"line_number":222,"context_line":"                                   \" project: \" + str(e))"},{"line_number":223,"context_line":"                result +\u003d 1"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        if result \u003e 0:"},{"line_number":226,"context_line":"            raise exceptions.CommandError(\"Command Failed: One or more of the\""},{"line_number":227,"context_line":"                                          \" operations failed\")"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"class ShowVolumeType(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_1491099a","line":227,"range":{"start_line":191,"start_character":0,"end_line":227,"end_character":63},"in_reply_to":"5a18252c_a65f3d71","updated":"2016-04-16 17:46:48.000000000","message":":)","commit_id":"be2d2a1b8da02d6b8ab05240e4ab61b26f65e442"}],"releasenotes/notes/add_volume_type_access-32ba8d4bfb0f5f3d.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8554847ee5a8699d719ca6ff451f5e64a06aeaae","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    To control access to a private volume type, user needs to add access"},{"line_number":10,"context_line":"    of a private volume type to project."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    So, this patchset enables user to add private volume type access to a"},{"line_number":13,"context_line":"    project using below command"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    ``volume type set --project \u003cproject\u003e \u003cvolume_type\u003e``."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9a061dce_0190a594","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":21},"updated":"2016-04-08 21:47:01.000000000","message":"suggest changing to \"feature\"","commit_id":"806ad9055ab28d06e5d830484d236dba91d80e2f"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"39ffa12499bfdbeb2bdb43993e5adbaf8b01ca06","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    To control access to a private volume type, user needs to add access"},{"line_number":10,"context_line":"    of a private volume type to project."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    So, this patchset enables user to add private volume type access to a"},{"line_number":13,"context_line":"    project using below command"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    ``volume type set --project \u003cproject\u003e \u003cvolume_type\u003e``."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9a061dce_0e544852","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":21},"in_reply_to":"9a061dce_0190a594","updated":"2016-04-09 13:37:21.000000000","message":"Done","commit_id":"806ad9055ab28d06e5d830484d236dba91d80e2f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8554847ee5a8699d719ca6ff451f5e64a06aeaae","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    ``volume type set --project \u003cproject\u003e \u003cvolume_type\u003e``."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    [Bug \u0027https://bugs.launchpad.net/python-openstackclient/+bug/1554889\u0027_]"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9a061dce_617241af","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":9},"updated":"2016-04-08 21:47:01.000000000","message":"This should include the bug number.","commit_id":"806ad9055ab28d06e5d830484d236dba91d80e2f"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"39ffa12499bfdbeb2bdb43993e5adbaf8b01ca06","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    ``volume type set --project \u003cproject\u003e \u003cvolume_type\u003e``."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    [Bug \u0027https://bugs.launchpad.net/python-openstackclient/+bug/1554889\u0027_]"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9a061dce_ee50f460","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":9},"in_reply_to":"9a061dce_617241af","updated":"2016-04-09 13:37:21.000000000","message":"Done","commit_id":"806ad9055ab28d06e5d830484d236dba91d80e2f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6a5d4c5c79fdc4592bde112a628ec1a5aa564fea","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    ``volume type set --project \u003cproject\u003e \u003cvolume_type\u003e``."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    [1554889 \u0027https://bugs.launchpad.net/python-openstackclient/+bug/1554889\u0027_]"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a1b2928_044f2993","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":12},"updated":"2016-04-11 12:39:14.000000000","message":"Add \"Bug\" back here.","commit_id":"b0a361254fd434777ebf9926257e0b2b140f79de"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"be9082d19389188e1ae8c87f3345446a61b753b5","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    ``volume type set --project \u003cproject\u003e \u003cvolume_type\u003e``."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    [Bug \u0027https://bugs.launchpad.net/python-openstackclient/+bug/1554889\u0027_]"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a1b2928_5fdd6e41","line":17,"updated":"2016-04-11 12:47:34.000000000","message":"Sorry for the confusion here...this should be \"Bug 1554889\".","commit_id":"5e73a5efbd88c4da49521582f9c6ce42ca4e8080"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"312fd160ec0544bfc397353f939445209617c473","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    ``volume type set --project \u003cproject\u003e \u003cvolume_type\u003e``."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    [Bug \u0027https://bugs.launchpad.net/python-openstackclient/+bug/1554889\u0027_]"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7a1b2928_5fe8ce7c","line":17,"in_reply_to":"7a1b2928_5fdd6e41","updated":"2016-04-11 12:54:35.000000000","message":"Oh thanks for pointing out..","commit_id":"5e73a5efbd88c4da49521582f9c6ce42ca4e8080"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"84f472e785a04078deca8249d0b3b7dd6ca87892","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    By default, volumes types are public."},{"line_number":7,"context_line":"    To create a private volume type, user needs to set is_public boolean"},{"line_number":8,"context_line":"    field to false at volume type creation time."},{"line_number":9,"context_line":"    To control access to a private volume type, user needs to add access"},{"line_number":10,"context_line":"    of a private volume type to project."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5a18252c_89821251","line":8,"updated":"2016-04-12 21:35:11.000000000","message":"This should be put in terms of the CLI, not the REST API:\n\nTo create a private volume type the ``--private`` option must be included in the ``volume type create`` command.","commit_id":"be2d2a1b8da02d6b8ab05240e4ab61b26f65e442"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"4fcbba18260754b84df5bb6ce238574c4442b675","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    By default, volumes types are public."},{"line_number":7,"context_line":"    To create a private volume type, user needs to set is_public boolean"},{"line_number":8,"context_line":"    field to false at volume type creation time."},{"line_number":9,"context_line":"    To control access to a private volume type, user needs to add access"},{"line_number":10,"context_line":"    of a private volume type to project."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a122d0e_d4ddd171","line":8,"in_reply_to":"5a18252c_89821251","updated":"2016-04-16 17:46:48.000000000","message":"ok, should i update it in seperate patch?","commit_id":"be2d2a1b8da02d6b8ab05240e4ab61b26f65e442"}],"releasenotes/notes/add_volume_type_access-7093cc4281093125.yaml":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"a3232c5b383bdf9ec4f17e676a30dfcff867159a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for setting volume type access to project."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    By default, volumes are public."},{"line_number":7,"context_line":"    To create a private volume, user need to set is_public boolean field"},{"line_number":8,"context_line":"    to false at volume creation time."},{"line_number":9,"context_line":"    To control access to a private volume, user needs to add access of a"},{"line_number":10,"context_line":"    private volume type to project."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    So, this fix enables user to add private volume type access to a"},{"line_number":13,"context_line":"    project using below command:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1af94dfe_35094dde","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":35},"updated":"2016-03-17 09:15:45.000000000","message":"looks like all of the \"volume\" should be \"volume type\" in the section.","commit_id":"cc6fdfc954d990637b4ca9e34cf97f2effe328df"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"78c6d0a37906c26899b7074171d0ac68473885d9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for setting volume type access to project."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    By default, volumes are public."},{"line_number":7,"context_line":"    To create a private volume, user need to set is_public boolean field"},{"line_number":8,"context_line":"    to false at volume creation time."},{"line_number":9,"context_line":"    To control access to a private volume, user needs to add access of a"},{"line_number":10,"context_line":"    private volume type to project."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    So, this fix enables user to add private volume type access to a"},{"line_number":13,"context_line":"    project using below command:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1af94dfe_c3e65caf","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":35},"in_reply_to":"1af94dfe_35094dde","updated":"2016-03-17 16:09:21.000000000","message":"right, missed it.","commit_id":"cc6fdfc954d990637b4ca9e34cf97f2effe328df"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"96233f38bbe29d4e1f60db6bc0bd8ee95c297b9d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for setting volume type access to project."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa0719c6_bbc85a56","line":2,"updated":"2016-03-24 13:42:38.000000000","message":"feature instead of fix","commit_id":"06d4ec47271162822b7244436cff453936213c42"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"4da84288418fdf39ad0374d286f9e31d16ef7492","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for setting volume type access to project."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"da0c15f0_8109592f","line":2,"in_reply_to":"fa0719c6_bbc85a56","updated":"2016-03-25 13:33:18.000000000","message":"ok.","commit_id":"06d4ec47271162822b7244436cff453936213c42"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"6adbc136078249107a52f42e67331defd16ee4f7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    To control access to a private volume type, user needs to add access"},{"line_number":10,"context_line":"    of a private volume type to project."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    So, this fix enables user to add private volume type access to a"},{"line_number":13,"context_line":"    project using below command"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    ``volume type set --project \u003cproject\u003e \u003cvolume_type\u003e``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa0719c6_163c6d92","line":12,"updated":"2016-03-21 16:13:22.000000000","message":"In the docs you mention \u0027admin only\u0027, should \u0027user\u0027 not be used here?","commit_id":"06d4ec47271162822b7244436cff453936213c42"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"3a6ff867cc8326880a7469b6cb9783d27970a338","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    To control access to a private volume type, user needs to add access"},{"line_number":10,"context_line":"    of a private volume type to project."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    So, this fix enables user to add private volume type access to a"},{"line_number":13,"context_line":"    project using below command"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    ``volume type set --project \u003cproject\u003e \u003cvolume_type\u003e``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa0719c6_f620d9f9","line":12,"in_reply_to":"fa0719c6_163c6d92","updated":"2016-03-21 16:19:47.000000000","message":"You mean to use \"user\" instead of \"project\", right?\n\nIf yes, then this command is to add access to project not user; but this command can only be run by admin user.\n\nLet me know in case i misunderstood your question.","commit_id":"06d4ec47271162822b7244436cff453936213c42"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"fc96dd4f048620cf45eea2e5cb7d388ddb6b8212","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    To control access to a private volume type, user needs to add access"},{"line_number":10,"context_line":"    of a private volume type to project."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    So, this fix enables user to add private volume type access to a"},{"line_number":13,"context_line":"    project using below command"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    ``volume type set --project \u003cproject\u003e \u003cvolume_type\u003e``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa0719c6_11c91779","line":12,"in_reply_to":"fa0719c6_567265e6","updated":"2016-03-21 16:29:53.000000000","message":"Right but admin is also an user.. is not it :)\n\nActually i am pointing to user everywhere in this note.\nThis is obviously pointing to admin because volume_type is only accessed by admin, normal user does not have access to it.\ndoes it make sense?","commit_id":"06d4ec47271162822b7244436cff453936213c42"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"1220f1d1246a786800861efb6f7810511e695d1e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    To control access to a private volume type, user needs to add access"},{"line_number":10,"context_line":"    of a private volume type to project."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    So, this fix enables user to add private volume type access to a"},{"line_number":13,"context_line":"    project using below command"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    ``volume type set --project \u003cproject\u003e \u003cvolume_type\u003e``."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa0719c6_567265e6","line":12,"in_reply_to":"fa0719c6_f620d9f9","updated":"2016-03-21 16:22:48.000000000","message":"You say \u0027this fix enables user to add private volume\u0027, but the command is actually admin only, so it doesn\u0027t really enable the user. It enables the admin.","commit_id":"06d4ec47271162822b7244436cff453936213c42"}]}