)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ec7e44e5863ef97503e2cee5ec8acde5447748b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following patch adds the provider network options"},{"line_number":10,"context_line":"to \"osc net create\" CLI"},{"line_number":11,"context_line":"Provider Network options include:-"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib8449c00ee4b4285889588f03ddd7a686ce8f987"},{"line_number":14,"context_line":"Partial-Bug: #1545537"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1af94dfe_67a93490","line":11,"updated":"2016-03-18 06:49:27.000000000","message":"Forgot to add the info here...","commit_id":"568649d57686ace5e63becdacdb843fc26014ca8"}],"doc/source/command-objects/network.rst":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"5f64e63ed92cf6389fd59cd4242fc2aba2e62c90","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. option:: --provider-network-type \u003cnetwork_type\u003e"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"   The physical mechanism by which the virtual network is implemented"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. option:: --provider-physical-network \u003cphysical_network_name\u003e"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da0c15f0_82ff65a9","line":87,"range":{"start_line":87,"start_character":3,"end_line":87,"end_character":69},"updated":"2016-03-28 07:13:17.000000000","message":"Shall we list up all the types here ?\n\nflat, geneve, gre, local, vxlan, vlan","commit_id":"58208da0e48b9297f7a482dae943a81a9cf810b1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0cef5fe03824085c59108f232666da455604a366","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. option:: --provider-network-type \u003cnetwork_type\u003e"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"   The physical mechanism by which the virtual network is implemented"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. option:: --provider-physical-network \u003cphysical_network_name\u003e"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da0c15f0_7de1149a","line":87,"range":{"start_line":87,"start_character":3,"end_line":87,"end_character":69},"in_reply_to":"da0c15f0_82ff65a9","updated":"2016-03-28 07:59:13.000000000","message":"They can be mentioned as a choice","commit_id":"58208da0e48b9297f7a482dae943a81a9cf810b1"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"5f64e63ed92cf6389fd59cd4242fc2aba2e62c90","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":".. option:: --provider-seg-id \u003csegmentation_id\u003e"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"   VLAN ID for VLAN networks or tunnel-id for GRE/VXLAN networks"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. _network_create-name:"},{"line_number":98,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da0c15f0_421c2d13","line":95,"range":{"start_line":95,"start_character":46,"end_line":95,"end_character":56},"updated":"2016-03-28 07:13:17.000000000","message":"Is this correct ?  I think tunnel id for gre, but also for vxlan ?\n\nAnd all these 3 options are for Network v2 only.","commit_id":"58208da0e48b9297f7a482dae943a81a9cf810b1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0cef5fe03824085c59108f232666da455604a366","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":".. option:: --provider-seg-id \u003csegmentation_id\u003e"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"   VLAN ID for VLAN networks or tunnel-id for GRE/VXLAN networks"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":".. _network_create-name:"},{"line_number":98,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da0c15f0_7df8f449","line":95,"range":{"start_line":95,"start_character":46,"end_line":95,"end_character":56},"in_reply_to":"da0c15f0_421c2d13","updated":"2016-03-28 07:59:13.000000000","message":"\u003eIs this correct ?  I think tunnel id for gre, but also for vxlan ?\nThis is taken from the current NeutronClient code.\n\nYes, all are for Networkv2","commit_id":"58208da0e48b9297f7a482dae943a81a9cf810b1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4a00fe8324c2b6d4da38147a4b9f1ad3d8bfef91","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        [--share | --no-share]"},{"line_number":19,"context_line":"        [--availability-zone-hint \u003cavailability-zone\u003e]"},{"line_number":20,"context_line":"        [--external [--default | --not-default] | --internal]"},{"line_number":21,"context_line":"        [--provider-network-type \u003cnetwork_type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cphysical_network_name\u003e]"},{"line_number":23,"context_line":"        [--provider-seg-id \u003csegmentation_id\u003e]"},{"line_number":24,"context_line":"        \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba0121b8_7e57a926","line":21,"range":{"start_line":21,"start_character":34,"end_line":21,"end_character":46},"updated":"2016-04-01 19:48:13.000000000","message":"provider-network-type ... similar comment throughout","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b6b8023a46ec132e33ceea4a7a2ab4bf5365a3fe","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        [--share | --no-share]"},{"line_number":19,"context_line":"        [--availability-zone-hint \u003cavailability-zone\u003e]"},{"line_number":20,"context_line":"        [--external [--default | --not-default] | --internal]"},{"line_number":21,"context_line":"        [--provider-network-type \u003cnetwork_type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cphysical_network_name\u003e]"},{"line_number":23,"context_line":"        [--provider-seg-id \u003csegmentation_id\u003e]"},{"line_number":24,"context_line":"        \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba0121b8_77ce8eb5","line":21,"range":{"start_line":21,"start_character":34,"end_line":21,"end_character":46},"in_reply_to":"ba0121b8_7e57a926","updated":"2016-04-04 02:27:47.000000000","message":"Done","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4a00fe8324c2b6d4da38147a4b9f1ad3d8bfef91","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        [--availability-zone-hint \u003cavailability-zone\u003e]"},{"line_number":20,"context_line":"        [--external [--default | --not-default] | --internal]"},{"line_number":21,"context_line":"        [--provider-network-type \u003cnetwork_type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cphysical_network_name\u003e]"},{"line_number":23,"context_line":"        [--provider-seg-id \u003csegmentation_id\u003e]"},{"line_number":24,"context_line":"        \u003cname\u003e"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba0121b8_811ce06b","line":22,"range":{"start_line":22,"start_character":38,"end_line":22,"end_character":59},"updated":"2016-04-01 19:48:13.000000000","message":"provider-physical-network ... similar comment throughout","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4a00fe8324c2b6d4da38147a4b9f1ad3d8bfef91","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        [--external [--default | --not-default] | --internal]"},{"line_number":21,"context_line":"        [--provider-network-type \u003cnetwork_type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cphysical_network_name\u003e]"},{"line_number":23,"context_line":"        [--provider-seg-id \u003csegmentation_id\u003e]"},{"line_number":24,"context_line":"        \u003cname\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba0121b8_e15afc29","line":23,"range":{"start_line":23,"start_character":9,"end_line":23,"end_character":44},"updated":"2016-04-01 19:48:13.000000000","message":"--provider-segmentation-id \u003cprovider-segmentation-id\u003e ... similar comment throughout","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b6b8023a46ec132e33ceea4a7a2ab4bf5365a3fe","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        [--external [--default | --not-default] | --internal]"},{"line_number":21,"context_line":"        [--provider-network-type \u003cnetwork_type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cphysical_network_name\u003e]"},{"line_number":23,"context_line":"        [--provider-seg-id \u003csegmentation_id\u003e]"},{"line_number":24,"context_line":"        \u003cname\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba0121b8_97c9a2af","line":23,"range":{"start_line":23,"start_character":9,"end_line":23,"end_character":44},"in_reply_to":"ba0121b8_e15afc29","updated":"2016-04-04 02:27:47.000000000","message":"Done","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4a00fe8324c2b6d4da38147a4b9f1ad3d8bfef91","unresolved":false,"context_lines":[{"line_number":89,"context_line":".. option:: --provider-network-type \u003cnetwork_type\u003e"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    The physical mechanism by which the virtual network is implemented."},{"line_number":92,"context_line":"    The supported options are : flat, gre, local, vlan, vxlan"},{"line_number":93,"context_line":"    (Network v2 only)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":".. option:: --provider-physical-network \u003cphysical_network_name\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba0121b8_017bb07c","line":92,"updated":"2016-04-01 19:48:13.000000000","message":"nit...no space needed before colon","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b6b8023a46ec132e33ceea4a7a2ab4bf5365a3fe","unresolved":false,"context_lines":[{"line_number":89,"context_line":".. option:: --provider-network-type \u003cnetwork_type\u003e"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    The physical mechanism by which the virtual network is implemented."},{"line_number":92,"context_line":"    The supported options are : flat, gre, local, vlan, vxlan"},{"line_number":93,"context_line":"    (Network v2 only)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":".. option:: --provider-physical-network \u003cphysical_network_name\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba0121b8_b7c0267e","line":92,"in_reply_to":"ba0121b8_017bb07c","updated":"2016-04-04 02:27:47.000000000","message":"Done","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1d1d133e1d6e1cfb55d847fbe55a51295a560407","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    By default, no network is set as an external network."},{"line_number":87,"context_line":"    (Network v2 only)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. option:: --provider-network-type \u003cnetwork_type\u003e"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    The physical mechanism by which the virtual network is implemented."},{"line_number":92,"context_line":"    The supported options are :flat, gre, local, vlan, vxlan"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a061dce_a2caa49f","line":89,"range":{"start_line":89,"start_character":36,"end_line":89,"end_character":50},"updated":"2016-04-04 18:50:50.000000000","message":"This should be \u003cprovider-network-type\u003e","commit_id":"b8e342bf8e69374045afee05e40f1ef57c874b14"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1d1d133e1d6e1cfb55d847fbe55a51295a560407","unresolved":false,"context_lines":[{"line_number":89,"context_line":".. option:: --provider-network-type \u003cnetwork_type\u003e"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    The physical mechanism by which the virtual network is implemented."},{"line_number":92,"context_line":"    The supported options are :flat, gre, local, vlan, vxlan"},{"line_number":93,"context_line":"    (Network v2 only)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":".. option:: --provider-physical-network \u003cphysical_network_name\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a061dce_c2487830","line":92,"range":{"start_line":92,"start_character":26,"end_line":92,"end_character":35},"updated":"2016-04-04 18:50:50.000000000","message":"This should be \"are: flat\"","commit_id":"b8e342bf8e69374045afee05e40f1ef57c874b14"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1d1d133e1d6e1cfb55d847fbe55a51295a560407","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    The supported options are :flat, gre, local, vlan, vxlan"},{"line_number":93,"context_line":"    (Network v2 only)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":".. option:: --provider-physical-network \u003cphysical_network_name\u003e"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    Name of the physical network over which the virtual network is implemented"},{"line_number":98,"context_line":"    (Network v2 only)"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a061dce_e2c49c93","line":95,"range":{"start_line":95,"start_character":40,"end_line":95,"end_character":63},"updated":"2016-04-04 18:50:50.000000000","message":"This should be \u003cprovider-physical-network\u003e","commit_id":"b8e342bf8e69374045afee05e40f1ef57c874b14"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1d1d133e1d6e1cfb55d847fbe55a51295a560407","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    Name of the physical network over which the virtual network is implemented"},{"line_number":98,"context_line":"    (Network v2 only)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":".. option:: --provider-seg-id \u003csegmentation_id\u003e"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    VLAN ID for VLAN networks or tunnel-id for GRE/VXLAN networks"},{"line_number":103,"context_line":"    (Network v2 only)"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a061dce_02bc3004","line":100,"range":{"start_line":100,"start_character":30,"end_line":100,"end_character":47},"updated":"2016-04-04 18:50:50.000000000","message":"This should be \u003cprovider-segmentation-id\u003e","commit_id":"b8e342bf8e69374045afee05e40f1ef57c874b14"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"c84858de37f0d502c7da92685cf1ed1abfb17a65","unresolved":false,"context_lines":[{"line_number":89,"context_line":".. option:: --provider-network-type \u003cprovider-network-type\u003e"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    The physical mechanism by which the virtual network is implemented."},{"line_number":92,"context_line":"    The supported options are:flat, gre, local, vlan, vxlan"},{"line_number":93,"context_line":"    (Network v2 only)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":".. option:: --provider-physical-network \u003cprovider-physical-network\u003e"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9a061dce_1576bf05","line":92,"updated":"2016-04-06 13:48:19.000000000","message":"nit...space after colon","commit_id":"6ae822b8f2b50cd3703ed349a9a3618e5ea72fae"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4d777f865daaceb0d9ddd68df2f8da69634010b3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        [--external [--default | --no-default] | --internal]"},{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segmentation-id \u003cprovider-segmentation-id\u003e]"},{"line_number":24,"context_line":"        \u003cname\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a061dce_29f8bdc2","line":23,"updated":"2016-04-06 18:02:50.000000000","message":"We try to avoid using \u0027-id\u0027 in option names, someday it might be acceptable to use a name or other attribute if/when lookup abilities are added.  However, --provider-segmentation is not good.  --provider-segment doesn\u0027t sound right to me either.","commit_id":"1b351e16956563916cdf4f27071653e4b69569c2"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"185ba2075722080a429e5b738819c8d041234311","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        [--external [--default | --no-default] | --internal]"},{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segmentation-id \u003cprovider-segmentation-id\u003e]"},{"line_number":24,"context_line":"        \u003cname\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a061dce_41d67c28","line":23,"in_reply_to":"9a061dce_24473278","updated":"2016-04-07 13:10:33.000000000","message":"If there\u0027s a better alternative, why wait?  We can just document that the option takes ID only now.  It is much easier to change the option help text than it is to change the option name.  There is a similar option coming in https://review.openstack.org/#/c/302395/ which I\u0027d like to be consistent with this.  Although, I\u0027m not sure provider-segment is the right choice either given a network segment object is coming in Newton.","commit_id":"1b351e16956563916cdf4f27071653e4b69569c2"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2a7dc1ffbfbe6551f7d7f8236983b398fc2478f3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        [--external [--default | --no-default] | --internal]"},{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segmentation-id \u003cprovider-segmentation-id\u003e]"},{"line_number":24,"context_line":"        \u003cname\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a061dce_24473278","line":23,"in_reply_to":"9a061dce_29f8bdc2","updated":"2016-04-07 04:45:44.000000000","message":"Actually, provider-segment makes some sense.But lets wait till we start having names for the provider segments","commit_id":"1b351e16956563916cdf4f27071653e4b69569c2"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9b0f2ee596ec0adb8febb70f5768f77a0e300c3a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        [--external [--default | --no-default] | --internal]"},{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segmentation-id \u003cprovider-segmentation-id\u003e]"},{"line_number":24,"context_line":"        \u003cname\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a061dce_5298e477","line":23,"in_reply_to":"9a061dce_41d67c28","updated":"2016-04-08 00:57:27.000000000","message":"Okay Richard, let me draft a Trivial fix for this now","commit_id":"1b351e16956563916cdf4f27071653e4b69569c2"}],"openstackclient/network/v2/network.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"08f8847b7ca2e23cc441ec03336cec210aa14942","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            default\u003dTrue,"},{"line_number":166,"context_line":"            help\u003d\u0027Do not use the network as the default \u0027"},{"line_number":167,"context_line":"                 \u0027external network  (default)\u0027)"},{"line_number":168,"context_line":"        parser.add_argument("},{"line_number":169,"context_line":"            \u0027--provider-network-type\u0027,"},{"line_number":170,"context_line":"            metavar\u003d\u0027\u003cnetwork_type\u003e\u0027,"},{"line_number":171,"context_line":"            help\u003d\u0027The physical mechanism by which the virtual network \u0027"},{"line_number":172,"context_line":"                 \u0027is implemented\u0027)"},{"line_number":173,"context_line":"        parser.add_argument("},{"line_number":174,"context_line":"            \u0027--provider-physical-network\u0027,"},{"line_number":175,"context_line":"            metavar\u003d\u0027\u003cphysical_network_name\u003e\u0027,"},{"line_number":176,"context_line":"            dest\u003d\u0027physical_nw\u0027,"},{"line_number":177,"context_line":"            help\u003d\u0027Name of the physical network over which the virtual \u0027"},{"line_number":178,"context_line":"                 \u0027network is implemented\u0027)"},{"line_number":179,"context_line":"        parser.add_argument("},{"line_number":180,"context_line":"            \u0027--provider-seg-id\u0027,"},{"line_number":181,"context_line":"            metavar\u003d\u0027\u003csegmentation_id\u003e\u0027,"},{"line_number":182,"context_line":"            help\u003d\u0027VLAN ID for VLAN networks or tunnel-id for GRE/VXLAN \u0027"},{"line_number":183,"context_line":"                 \u0027networks\u0027)"},{"line_number":184,"context_line":"        return parser"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def update_parser_compute(self, parser):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_8cf1f36d","line":183,"range":{"start_line":168,"start_character":0,"end_line":183,"end_character":28},"updated":"2016-03-24 06:41:04.000000000","message":"I was thinking of making a similar patch. My idea is: \n\n--provider type\u003d\u003ctype\u003e,segmentation-id\u003d\u003csegmentation-id\u003e,physical-network\u003d\u003cphysical-network\u003e\n\nHow do you think about it ?","commit_id":"3fc9fcb2cd1fc513f199cc36d34276e455e11caf"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"8eb897f40e8cfcf73cbd1243d2c5ec18614efb8d","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            default\u003dTrue,"},{"line_number":166,"context_line":"            help\u003d\u0027Do not use the network as the default \u0027"},{"line_number":167,"context_line":"                 \u0027external network  (default)\u0027)"},{"line_number":168,"context_line":"        parser.add_argument("},{"line_number":169,"context_line":"            \u0027--provider-network-type\u0027,"},{"line_number":170,"context_line":"            metavar\u003d\u0027\u003cnetwork_type\u003e\u0027,"},{"line_number":171,"context_line":"            help\u003d\u0027The physical mechanism by which the virtual network \u0027"},{"line_number":172,"context_line":"                 \u0027is implemented\u0027)"},{"line_number":173,"context_line":"        parser.add_argument("},{"line_number":174,"context_line":"            \u0027--provider-physical-network\u0027,"},{"line_number":175,"context_line":"            metavar\u003d\u0027\u003cphysical_network_name\u003e\u0027,"},{"line_number":176,"context_line":"            dest\u003d\u0027physical_nw\u0027,"},{"line_number":177,"context_line":"            help\u003d\u0027Name of the physical network over which the virtual \u0027"},{"line_number":178,"context_line":"                 \u0027network is implemented\u0027)"},{"line_number":179,"context_line":"        parser.add_argument("},{"line_number":180,"context_line":"            \u0027--provider-seg-id\u0027,"},{"line_number":181,"context_line":"            metavar\u003d\u0027\u003csegmentation_id\u003e\u0027,"},{"line_number":182,"context_line":"            help\u003d\u0027VLAN ID for VLAN networks or tunnel-id for GRE/VXLAN \u0027"},{"line_number":183,"context_line":"                 \u0027networks\u0027)"},{"line_number":184,"context_line":"        return parser"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def update_parser_compute(self, parser):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_07765c6f","line":183,"range":{"start_line":168,"start_character":0,"end_line":183,"end_character":28},"in_reply_to":"fa0719c6_47be94ff","updated":"2016-03-24 06:56:56.000000000","message":"Sure. :)\n\nAnd BTW, if we do it in your way, please also add a \"choices\" in parser.add_argument() for \"network_type\" to check the available keys, like vlan, gre, ......","commit_id":"3fc9fcb2cd1fc513f199cc36d34276e455e11caf"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cf7bfe260b43a52c5c05e5459a5c7d1512838bfd","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            default\u003dTrue,"},{"line_number":166,"context_line":"            help\u003d\u0027Do not use the network as the default \u0027"},{"line_number":167,"context_line":"                 \u0027external network  (default)\u0027)"},{"line_number":168,"context_line":"        parser.add_argument("},{"line_number":169,"context_line":"            \u0027--provider-network-type\u0027,"},{"line_number":170,"context_line":"            metavar\u003d\u0027\u003cnetwork_type\u003e\u0027,"},{"line_number":171,"context_line":"            help\u003d\u0027The physical mechanism by which the virtual network \u0027"},{"line_number":172,"context_line":"                 \u0027is implemented\u0027)"},{"line_number":173,"context_line":"        parser.add_argument("},{"line_number":174,"context_line":"            \u0027--provider-physical-network\u0027,"},{"line_number":175,"context_line":"            metavar\u003d\u0027\u003cphysical_network_name\u003e\u0027,"},{"line_number":176,"context_line":"            dest\u003d\u0027physical_nw\u0027,"},{"line_number":177,"context_line":"            help\u003d\u0027Name of the physical network over which the virtual \u0027"},{"line_number":178,"context_line":"                 \u0027network is implemented\u0027)"},{"line_number":179,"context_line":"        parser.add_argument("},{"line_number":180,"context_line":"            \u0027--provider-seg-id\u0027,"},{"line_number":181,"context_line":"            metavar\u003d\u0027\u003csegmentation_id\u003e\u0027,"},{"line_number":182,"context_line":"            help\u003d\u0027VLAN ID for VLAN networks or tunnel-id for GRE/VXLAN \u0027"},{"line_number":183,"context_line":"                 \u0027networks\u0027)"},{"line_number":184,"context_line":"        return parser"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def update_parser_compute(self, parser):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_47be94ff","line":183,"range":{"start_line":168,"start_character":0,"end_line":183,"end_character":28},"in_reply_to":"fa0719c6_8cf1f36d","updated":"2016-03-24 06:53:49.000000000","message":"I am trying to keep the options as close to the NeutronClient implementation as possible.\nBut yes, your options can also work.\nLet us take a consensus for this from others including Dean","commit_id":"3fc9fcb2cd1fc513f199cc36d34276e455e11caf"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"5f64e63ed92cf6389fd59cd4242fc2aba2e62c90","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        parser.add_argument("},{"line_number":169,"context_line":"            \u0027--provider-network-type\u0027,"},{"line_number":170,"context_line":"            metavar\u003d\u0027\u003cnetwork_type\u003e\u0027,"},{"line_number":171,"context_line":"            choices\u003d[\u0027gre\u0027, \u0027vlan\u0027, \u0027vxlan\u0027],"},{"line_number":172,"context_line":"            help\u003d\u0027The physical mechanism by which the virtual network \u0027"},{"line_number":173,"context_line":"                 \u0027is implemented\u0027)"},{"line_number":174,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_62cb3154","line":171,"range":{"start_line":171,"start_character":21,"end_line":171,"end_character":43},"updated":"2016-03-28 07:13:17.000000000","message":"I think not only these. But not sure if flat, local and geneve are meanful.","commit_id":"58208da0e48b9297f7a482dae943a81a9cf810b1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0cef5fe03824085c59108f232666da455604a366","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        parser.add_argument("},{"line_number":169,"context_line":"            \u0027--provider-network-type\u0027,"},{"line_number":170,"context_line":"            metavar\u003d\u0027\u003cnetwork_type\u003e\u0027,"},{"line_number":171,"context_line":"            choices\u003d[\u0027gre\u0027, \u0027vlan\u0027, \u0027vxlan\u0027],"},{"line_number":172,"context_line":"            help\u003d\u0027The physical mechanism by which the virtual network \u0027"},{"line_number":173,"context_line":"                 \u0027is implemented\u0027)"},{"line_number":174,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_1dd298d2","line":171,"range":{"start_line":171,"start_character":21,"end_line":171,"end_character":43},"in_reply_to":"da0c15f0_62cb3154","updated":"2016-03-28 07:59:13.000000000","message":"I checked the neutron code and tried some experiments on neutronclient.\nLocal and flat are also inputs, but geneve does not sem to be the case.","commit_id":"58208da0e48b9297f7a482dae943a81a9cf810b1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4a00fe8324c2b6d4da38147a4b9f1ad3d8bfef91","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                attrs[\u0027is_default\u0027] \u003d False"},{"line_number":205,"context_line":"        elif parsed_args.internal:"},{"line_number":206,"context_line":"            attrs[\u0027router:external\u0027] \u003d False"},{"line_number":207,"context_line":"        if (\u0027provider_network_type\u0027 in parsed_args and"},{"line_number":208,"context_line":"           parsed_args.provider_network_type is not None):"},{"line_number":209,"context_line":"            attrs[\u0027provider:network_type\u0027] \u003d parsed_args.provider_network_type"},{"line_number":210,"context_line":"        if (\u0027physical_nw\u0027 in parsed_args and"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba0121b8_2147d41e","line":207,"updated":"2016-04-01 19:48:13.000000000","message":"I don\u0027t think you need to check if these are in parsed_args.","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b6b8023a46ec132e33ceea4a7a2ab4bf5365a3fe","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                attrs[\u0027is_default\u0027] \u003d False"},{"line_number":205,"context_line":"        elif parsed_args.internal:"},{"line_number":206,"context_line":"            attrs[\u0027router:external\u0027] \u003d False"},{"line_number":207,"context_line":"        if (\u0027provider_network_type\u0027 in parsed_args and"},{"line_number":208,"context_line":"           parsed_args.provider_network_type is not None):"},{"line_number":209,"context_line":"            attrs[\u0027provider:network_type\u0027] \u003d parsed_args.provider_network_type"},{"line_number":210,"context_line":"        if (\u0027physical_nw\u0027 in parsed_args and"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba0121b8_d7dcba76","line":207,"in_reply_to":"ba0121b8_2147d41e","updated":"2016-04-04 02:27:47.000000000","message":"Done","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4a00fe8324c2b6d4da38147a4b9f1ad3d8bfef91","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            attrs[\u0027provider:physical_network\u0027] \u003d parsed_args.physical_nw"},{"line_number":213,"context_line":"        if (\u0027provider_seg_id\u0027 in parsed_args and"},{"line_number":214,"context_line":"           parsed_args.provider_seg_id is not None):"},{"line_number":215,"context_line":"            attrs[\u0027provider:segmentation-id\u0027] \u003d parsed_args.provider_seg_id"},{"line_number":216,"context_line":"        obj \u003d client.create_network(**attrs)"},{"line_number":217,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":218,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba0121b8_a16124ab","line":215,"updated":"2016-04-01 19:48:13.000000000","message":"This should be provider:segmentation_id","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b6b8023a46ec132e33ceea4a7a2ab4bf5365a3fe","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            attrs[\u0027provider:physical_network\u0027] \u003d parsed_args.physical_nw"},{"line_number":213,"context_line":"        if (\u0027provider_seg_id\u0027 in parsed_args and"},{"line_number":214,"context_line":"           parsed_args.provider_seg_id is not None):"},{"line_number":215,"context_line":"            attrs[\u0027provider:segmentation-id\u0027] \u003d parsed_args.provider_seg_id"},{"line_number":216,"context_line":"        obj \u003d client.create_network(**attrs)"},{"line_number":217,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":218,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d_formatters)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba0121b8_b7d94686","line":215,"in_reply_to":"ba0121b8_a16124ab","updated":"2016-04-04 02:27:47.000000000","message":"Done","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1d1d133e1d6e1cfb55d847fbe55a51295a560407","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            choices\u003d[\u0027flat\u0027, \u0027gre\u0027, \u0027local\u0027,"},{"line_number":172,"context_line":"                     \u0027vlan\u0027, \u0027vxlan\u0027],"},{"line_number":173,"context_line":"            help\u003d\u0027The physical mechanism by which the virtual network \u0027"},{"line_number":174,"context_line":"                 \u0027is implemented.The supported options are :\u0027"},{"line_number":175,"context_line":"                 \u0027flat, gre, local, vlan, vxlan\u0027)"},{"line_number":176,"context_line":"        parser.add_argument("},{"line_number":177,"context_line":"            \u0027--provider-physical-network\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_a258e4fb","line":174,"updated":"2016-04-04 18:50:50.000000000","message":"space needed after period and colon and no space before colon","commit_id":"b8e342bf8e69374045afee05e40f1ef57c874b14"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1d1d133e1d6e1cfb55d847fbe55a51295a560407","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        parser.add_argument("},{"line_number":177,"context_line":"            \u0027--provider-physical-network\u0027,"},{"line_number":178,"context_line":"            metavar\u003d\u0027\u003cprovider-physical-network\u003e\u0027,"},{"line_number":179,"context_line":"            dest\u003d\u0027physical_network\u0027,"},{"line_number":180,"context_line":"            help\u003d\u0027Name of the physical network over which the virtual \u0027"},{"line_number":181,"context_line":"                 \u0027network is implemented\u0027)"},{"line_number":182,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_02743033","line":179,"updated":"2016-04-04 18:50:50.000000000","message":"Why not use the default destination?","commit_id":"b8e342bf8e69374045afee05e40f1ef57c874b14"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1d1d133e1d6e1cfb55d847fbe55a51295a560407","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--provider-segmentation-id\u0027,"},{"line_number":184,"context_line":"            metavar\u003d\u0027\u003cprovider-segmentation-id\u003e\u0027,"},{"line_number":185,"context_line":"            dest\u003d\u0027segmentation_id\u0027,"},{"line_number":186,"context_line":"            help\u003d\u0027VLAN ID for VLAN networks or tunnel-id for GRE/VXLAN \u0027"},{"line_number":187,"context_line":"                 \u0027networks\u0027)"},{"line_number":188,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_628fec23","line":185,"updated":"2016-04-04 18:50:50.000000000","message":"Why not use the default destination?","commit_id":"b8e342bf8e69374045afee05e40f1ef57c874b14"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"c84858de37f0d502c7da92685cf1ed1abfb17a65","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            choices\u003d[\u0027flat\u0027, \u0027gre\u0027, \u0027local\u0027,"},{"line_number":172,"context_line":"                     \u0027vlan\u0027, \u0027vxlan\u0027],"},{"line_number":173,"context_line":"            help\u003d\u0027The physical mechanism by which the virtual network \u0027"},{"line_number":174,"context_line":"                 \u0027is implemented. The supported options are:\u0027"},{"line_number":175,"context_line":"                 \u0027flat, gre, local, vlan, vxlan\u0027)"},{"line_number":176,"context_line":"        parser.add_argument("},{"line_number":177,"context_line":"            \u0027--provider-physical-network\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_f5498bb8","line":174,"updated":"2016-04-06 13:48:19.000000000","message":"nit...space after colon","commit_id":"6ae822b8f2b50cd3703ed349a9a3618e5ea72fae"}],"openstackclient/tests/network/v2/test_network.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"5f64e63ed92cf6389fd59cd4242fc2aba2e62c90","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            (\u0027shared\u0027, None),"},{"line_number":121,"context_line":"            (\u0027project\u0027, None),"},{"line_number":122,"context_line":"            (\u0027external\u0027, False),"},{"line_number":123,"context_line":"            (\u0027is_default\u0027, False),"},{"line_number":124,"context_line":"        ]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_624051a6","side":"PARENT","line":123,"range":{"start_line":123,"start_character":27,"end_line":123,"end_character":32},"updated":"2016-03-28 07:13:17.000000000","message":"I think if you change it from False to True, you should test it is True here, not just remove it.","commit_id":"40469e3be98268fbfae1e923e375bc3f08b4c32b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0cef5fe03824085c59108f232666da455604a366","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            (\u0027shared\u0027, None),"},{"line_number":121,"context_line":"            (\u0027project\u0027, None),"},{"line_number":122,"context_line":"            (\u0027external\u0027, False),"},{"line_number":123,"context_line":"            (\u0027is_default\u0027, False),"},{"line_number":124,"context_line":"        ]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_9d94e8e2","side":"PARENT","line":123,"range":{"start_line":123,"start_character":27,"end_line":123,"end_character":32},"in_reply_to":"da0c15f0_624051a6","updated":"2016-03-28 07:59:13.000000000","message":"Setting it to true will result in a new test case as it would result in an exception as is_default can be True only if external is true. If external is false, passing is_Default would make an incorrect Body resulting in an HTTP Bad Request.\nThats why I skipped it.","commit_id":"40469e3be98268fbfae1e923e375bc3f08b4c32b"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"75fcc1a91e568150ff427635192bd045a93a38ca","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            \u0027tenant_id\u0027: identity_fakes_v3.project_id,"},{"line_number":172,"context_line":"            \u0027is_default\u0027: True,"},{"line_number":173,"context_line":"            \u0027router:external\u0027: True,"},{"line_number":174,"context_line":"            \u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":175,"context_line":"            \u0027provider:physical_network\u0027: \u0027physnet1\u0027,"},{"line_number":176,"context_line":"            \u0027provider:segmentation-id\u0027: \u0027400\u0027,"},{"line_number":177,"context_line":"        })"},{"line_number":178,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":179,"context_line":"        self.assertEqual(self.data, data)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_7dee34b5","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":46},"updated":"2016-03-28 07:51:09.000000000","message":"\u0027provider:physical_network\u0027 and \u0027provider:segmentation-id\u0027 are not in FakeNetwork. Shall we add them ?","commit_id":"58208da0e48b9297f7a482dae943a81a9cf810b1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0cef5fe03824085c59108f232666da455604a366","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            \u0027tenant_id\u0027: identity_fakes_v3.project_id,"},{"line_number":172,"context_line":"            \u0027is_default\u0027: True,"},{"line_number":173,"context_line":"            \u0027router:external\u0027: True,"},{"line_number":174,"context_line":"            \u0027provider:network_type\u0027: \u0027vlan\u0027,"},{"line_number":175,"context_line":"            \u0027provider:physical_network\u0027: \u0027physnet1\u0027,"},{"line_number":176,"context_line":"            \u0027provider:segmentation-id\u0027: \u0027400\u0027,"},{"line_number":177,"context_line":"        })"},{"line_number":178,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":179,"context_line":"        self.assertEqual(self.data, data)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_1d6e1801","line":176,"range":{"start_line":174,"start_character":0,"end_line":176,"end_character":46},"in_reply_to":"da0c15f0_7dee34b5","updated":"2016-03-28 07:59:13.000000000","message":"Not required, I think.\nThats because the when we append the new parameters to create_one_network, these values would automatically be added","commit_id":"58208da0e48b9297f7a482dae943a81a9cf810b1"}],"releasenotes/notes/add-provider-options-12bbf01d2280dd2f.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4a00fe8324c2b6d4da38147a4b9f1ad3d8bfef91","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    New options have been added to the ``openstack network create`` CLI"},{"line_number":5,"context_line":"    to support provider network functionality."},{"line_number":6,"context_line":"    [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba0121b8_5e7d85b0","line":4,"updated":"2016-04-01 19:48:13.000000000","message":"I recommend listing the new options.","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b6b8023a46ec132e33ceea4a7a2ab4bf5365a3fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    New options have been added to the ``openstack network create`` CLI"},{"line_number":5,"context_line":"    to support provider network functionality."},{"line_number":6,"context_line":"    [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba0121b8_f7e3be31","line":4,"in_reply_to":"ba0121b8_5e7d85b0","updated":"2016-04-04 02:27:47.000000000","message":"Done","commit_id":"84b25c9c767937a4303ff52233a9e5e0ccbee542"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1d1d133e1d6e1cfb55d847fbe55a51295a560407","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    New options have been added to the ``openstack network create`` CLI"},{"line_number":5,"context_line":"    to support provider network functionality."},{"line_number":6,"context_line":"    These options are \"--provider-network-type\", \"--provider-physical-network\","},{"line_number":7,"context_line":"    and \"--provider-segmentation-id\"."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a061dce_22ba1424","line":4,"updated":"2016-04-04 18:50:50.000000000","message":"We usually drop \"openstack\" from the command name and use \"command\" instead of \"CLI\"/","commit_id":"b8e342bf8e69374045afee05e40f1ef57c874b14"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1d1d133e1d6e1cfb55d847fbe55a51295a560407","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    New options have been added to the ``openstack network create`` CLI"},{"line_number":5,"context_line":"    to support provider network functionality."},{"line_number":6,"context_line":"    These options are \"--provider-network-type\", \"--provider-physical-network\","},{"line_number":7,"context_line":"    and \"--provider-segmentation-id\"."},{"line_number":8,"context_line":"    [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a061dce_2291749a","line":6,"updated":"2016-04-04 18:50:50.000000000","message":"Please use `` instead of \"\" around the option names.","commit_id":"b8e342bf8e69374045afee05e40f1ef57c874b14"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1d1d133e1d6e1cfb55d847fbe55a51295a560407","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    New options have been added to the ``openstack network create`` CLI"},{"line_number":5,"context_line":"    to support provider network functionality."},{"line_number":6,"context_line":"    These options are \"--provider-network-type\", \"--provider-physical-network\","},{"line_number":7,"context_line":"    and \"--provider-segmentation-id\"."},{"line_number":8,"context_line":"    [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a061dce_62e9ac1a","line":7,"updated":"2016-04-04 18:50:50.000000000","message":"I suggest noting that these are for Network v2 only.","commit_id":"b8e342bf8e69374045afee05e40f1ef57c874b14"}]}