)]}'
{"id":"openstack%2Fpython-openstackclient~294709","triplet_id":"openstack%2Fpython-openstackclient~master~I7a299a542d9df543bff43d3ea1e7907fc8c5f640","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1559125","hashtags":[],"change_id":"I7a299a542d9df543bff43d3ea1e7907fc8c5f640","subject":"Fix keypair create --public-key","status":"MERGED","created":"2016-03-18 16:43:24.000000000","updated":"2016-03-18 20:55:57.000000000","submitted":"2016-03-18 20:55:57.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"527465779e852ddb03132882b74f4de2b4704ba8","_number":294709,"virtual_id_number":294709,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-03-18 20:55:57.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-03-18 17:48:47.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-03-18 19:31:35.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-03-18 19:31:35.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-18 17:24:33.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-03-18 17:48:47.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-03-18 19:31:35.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2016-03-18 20:55:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f45ee581dbb3485318fe67eeee06d9a7d48558f8","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-03-18 16:43:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8b41e054384f5a6de35a25f4a3befaba37777519","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-18 17:24:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"15b5708bb596bd855ce4427736e190e00a664e10","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-03-18 17:41:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"31da28a77119ded07ed8ef95993337b65d1eba8c","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-03-18 17:48:39.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"0ad491d0adae262d9cdafc261361b4fb9419544c","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-03-18 17:48:47.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b0ab397e2766802bd842fbf69075381732761cf3","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-03-18 17:48:55.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"688321afb874dfe9fc6a8c529e664b7e8c22e2ce","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2016-03-18 19:31:35.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"a7ef508cf8b7c9cbb6523d575dbeafbfef7e2298","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 19:47:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/09/294709/2/check/gate-python-openstackclient-docs/178a248//doc/build/html/ : SUCCESS in 4m 59s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/09/294709/2/check/gate-python-openstackclient-pep8/a046b19/ : SUCCESS in 3m 45s\n- gate-python-openstackclient-python27 http://logs.openstack.org/09/294709/2/check/gate-python-openstackclient-python27/0e3a38c/ : SUCCESS in 5m 50s\n- gate-python-openstackclient-python34 http://logs.openstack.org/09/294709/2/check/gate-python-openstackclient-python34/49bd724/ : SUCCESS in 3m 06s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/09/294709/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/30ac4c7/ : SUCCESS in 57m 34s\n- check-osc-plugins http://logs.openstack.org/09/294709/2/check/check-osc-plugins/102a03f/ : SUCCESS in 2m 36s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/09/294709/2/check/gate-osc-dsvm-functional/cfd2585/ : SUCCESS in 31m 19s","accounts_in_message":[],"_revision_number":2},{"id":"46224c17941b1c1c2dbebf6954e8ba911d13a31a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 19:50:14.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"8c45e6fe82a5cc0c6922c4af50c7ff9ec99ad2f2","date":"2016-03-18 20:55:57.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"cc2dba98d9fa5a82d5468f0b9ec350ef26b76ffd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 20:55:57.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/09/294709/2/gate/gate-python-openstackclient-docs/53d1316//doc/build/html/ : SUCCESS in 5m 07s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/09/294709/2/gate/gate-python-openstackclient-pep8/335bb03/ : SUCCESS in 3m 12s\n- gate-python-openstackclient-python27 http://logs.openstack.org/09/294709/2/gate/gate-python-openstackclient-python27/0944e7e/ : SUCCESS in 2m 27s\n- gate-python-openstackclient-python34 http://logs.openstack.org/09/294709/2/gate/gate-python-openstackclient-python34/83da4b2/ : SUCCESS in 4m 07s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/09/294709/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/ecb7b61/ : SUCCESS in 1h 04m 29s\n- gate-osc-dsvm-functional http://logs.openstack.org/09/294709/2/gate/gate-osc-dsvm-functional/316e517/ : SUCCESS in 33m 42s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"21e414d860347b080ba98fc023029caa16d686f4","revisions":{"15543b1fe76bbcbdfe899aaff285a03dfc3bdc51":{"kind":"REWORK","_number":1,"created":"2016-03-18 16:43:24.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/09/294709/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/09/294709/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/09/294709/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/09/294709/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/09/294709/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/09/294709/1"}}},"commit":{"parents":[{"commit":"3ccc4f7d06234ad901c0090870b4ec7070caec50","subject":"Trivial-Fix : Add a \u0027 to the choices documentation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3ccc4f7d06234ad901c0090870b4ec7070caec50"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2016-03-18 16:36:33.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2016-03-18 16:36:36.000000000","tz":-300},"subject":"Fix keypair create --public-key","message":"Fix keypair create --public-key\n\nCommit Id702ccaad239b916340bb17014d1ede0a28aaec9 changed the keypair\ncreate --public-key to use io.open but incorrectly reads the file\nin binary mode, which causes JSON serialization to fail.\n\nThe unit tests mock out io.ioen (the reason for adding it in the first\nplace actually) so any testing for this specific problem would have to\nbe done in functional tests...yet to come.\n\nCloses-bug: 1559125\nChange-Id: I7a299a542d9df543bff43d3ea1e7907fc8c5f640\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/15543b1fe76bbcbdfe899aaff285a03dfc3bdc51"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/15543b1fe76bbcbdfe899aaff285a03dfc3bdc51"}]},"branch":"refs/heads/master"},"21e414d860347b080ba98fc023029caa16d686f4":{"kind":"REWORK","_number":2,"created":"2016-03-18 17:48:39.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/09/294709/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/09/294709/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/09/294709/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/09/294709/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/09/294709/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/09/294709/2"}}},"commit":{"parents":[{"commit":"3ccc4f7d06234ad901c0090870b4ec7070caec50","subject":"Trivial-Fix : Add a \u0027 to the choices documentation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3ccc4f7d06234ad901c0090870b4ec7070caec50"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2016-03-18 16:36:33.000000000","tz":-300},"committer":{"name":"Steve Martinelli","email":"stevemar@ca.ibm.com","date":"2016-03-18 17:48:36.000000000","tz":0},"subject":"Fix keypair create --public-key","message":"Fix keypair create --public-key\n\nCommit Id702ccaad239b916340bb17014d1ede0a28aaec9 changed the keypair\ncreate --public-key to use io.open but incorrectly reads the file\nin binary mode, which causes JSON serialization to fail.\n\nThe unit tests mock out io.ioen (the reason for adding it in the first\nplace actually) so any testing for this specific problem would have to\nbe done in functional tests...yet to come.\n\nCloses-bug: 1559125\nChange-Id: I7a299a542d9df543bff43d3ea1e7907fc8c5f640\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/21e414d860347b080ba98fc023029caa16d686f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/21e414d860347b080ba98fc023029caa16d686f4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}