)]}'
{"id":"openstack%2Fpython-openstackclient~294893","triplet_id":"openstack%2Fpython-openstackclient~master~Id05055bb90592d218826732259ed84fc366734ce","project":"openstack/python-openstackclient","branch":"master","topic":"called-once-20160319","hashtags":[],"change_id":"Id05055bb90592d218826732259ed84fc366734ce","subject":"Use assert_called_once_with() instead of assert_called_with()","status":"MERGED","created":"2016-03-19 06:48:41.000000000","updated":"2016-03-22 15:19:14.000000000","submitted":"2016-03-22 15:19:14.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9d8f63900b0b8c4be71953353229dd90d48e7cb4","_number":294893,"virtual_id_number":294893,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-03-22 15:19:14.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":2,"date":"2016-03-22 14:23:49.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":2,"date":"2016-03-22 11:22:36.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":1,"date":"2016-03-22 14:23:49.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-22 01:51:53.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-03-22 11:22:36.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-03-22 14:23:49.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-03-22 15:19:14.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"06a9394029b87408047ad4bc69c3fa2e9300ec4b","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-19 06:48:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7e92e5f7e8558bd2cc5073189626358273c04f78","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-19 07:58:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/294893/1/check/gate-python-openstackclient-docs/c40971f//doc/build/html/ : SUCCESS in 5m 55s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/294893/1/check/gate-python-openstackclient-pep8/bac35b6/ : SUCCESS in 3m 35s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/294893/1/check/gate-python-openstackclient-python27/acbc0ba/ : SUCCESS in 4m 58s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/294893/1/check/gate-python-openstackclient-python34/36125d2/ : SUCCESS in 4m 30s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/294893/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/4a3224c/ : SUCCESS in 59m 37s\n- check-osc-plugins http://logs.openstack.org/93/294893/1/check/check-osc-plugins/4b2426a/ : SUCCESS in 3m 12s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/93/294893/1/check/gate-osc-dsvm-functional/ef9b21c/ : SUCCESS in 28m 52s","accounts_in_message":[],"_revision_number":1},{"id":"ff6262ca9a8dae9036d5478622a1aaf36c00fe30","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-21 13:00:53.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"359df23a7b65636178796fb334ce3924b442edd4","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-03-22 01:01:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ac0d41cb5132007115cb010f87b439b0b362fd8f","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-22 01:01:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7e5f66f0619265af69113861dd65a495851ff77a","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-03-22 01:51:53.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"1ecf350a9db20672c8a17012d68aaa972d9cb6b0","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-22 02:11:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"da8da4685799568a2cec880ef67496db4ea9c849","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-03-22 02:15:15.000000000","message":"Patch Set 2:\n\nUpdated patch to follow Richard\u0027s comment.","accounts_in_message":[],"_revision_number":2},{"id":"0f68f2bdc56221883e714d2e7d1a9ea2b92be9f2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-22 04:54:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/294893/2/check/gate-python-openstackclient-docs/b55a68e//doc/build/html/ : SUCCESS in 3m 34s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/294893/2/check/gate-python-openstackclient-pep8/280ffb6/ : SUCCESS in 2m 51s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/294893/2/check/gate-python-openstackclient-python27/eaf914f/ : SUCCESS in 3m 16s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/294893/2/check/gate-python-openstackclient-python34/212055f/ : SUCCESS in 4m 45s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/294893/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/a34c7d5/ : SUCCESS in 1h 24m 01s\n- check-osc-plugins http://logs.openstack.org/93/294893/2/check/check-osc-plugins/00fdc0b/ : SUCCESS in 4m 01s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/93/294893/2/check/gate-osc-dsvm-functional/2848b1e/ : SUCCESS in 35m 11s","accounts_in_message":[],"_revision_number":2},{"id":"5c84498de53469bd5f7a639955b82f89b8a30f95","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-22 11:22:36.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a32fde8350ba18bc24b97af75ebd449bbe2e601f","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-03-22 14:23:49.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"d7c5c1092739eb20d1cd98c51a79953c831fb32c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-22 14:25:57.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"156f3115e43b72825b47051c458150cd4c97275c","date":"2016-03-22 15:19:14.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"d606101a2221a469095f70108f46c5630a81fb8d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-22 15:19:14.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/294893/2/gate/gate-python-openstackclient-docs/5ae0864//doc/build/html/ : SUCCESS in 2m 24s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/294893/2/gate/gate-python-openstackclient-pep8/a3dfc78/ : SUCCESS in 1m 57s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/294893/2/gate/gate-python-openstackclient-python27/1539dac/ : SUCCESS in 2m 19s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/294893/2/gate/gate-python-openstackclient-python34/66731b8/ : SUCCESS in 4m 37s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/294893/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/a38cd2c/ : SUCCESS in 52m 02s\n- gate-osc-dsvm-functional http://logs.openstack.org/93/294893/2/gate/gate-osc-dsvm-functional/e7b3930/ : SUCCESS in 39m 50s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"41853985bb654e8417e5c9850ed1eeccd9828a73","revisions":{"5da31d5b088fc75a8742aaf69c94793a2f05ffe6":{"kind":"REWORK","_number":1,"created":"2016-03-19 06:48:41.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/93/294893/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/93/294893/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/294893/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/294893/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/294893/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/93/294893/1"}}},"commit":{"parents":[{"commit":"f9f6abe56414a56ea28863ad5824a5c176a75b33","subject":"Merge \"Fix keypair create --public-key\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f9f6abe56414a56ea28863ad5824a5c176a75b33"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-03-19 02:56:43.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-03-19 02:56:43.000000000","tz":480},"subject":"Use assert_called_once_with() instead of assert_called_with()","message":"Use assert_called_once_with() instead of assert_called_with()\n\nIf one API is only called once, we\u0027d better use assert_called_once_with()\nto check the call.\n\nChange-Id: Id05055bb90592d218826732259ed84fc366734ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5da31d5b088fc75a8742aaf69c94793a2f05ffe6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5da31d5b088fc75a8742aaf69c94793a2f05ffe6"}]},"branch":"refs/heads/master"},"41853985bb654e8417e5c9850ed1eeccd9828a73":{"kind":"REWORK","_number":2,"created":"2016-03-22 02:11:01.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/93/294893/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/93/294893/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/294893/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/294893/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/294893/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/93/294893/2"}}},"commit":{"parents":[{"commit":"98dc781e94a5e61d0d28e157495528efafc368e3","subject":"Merge \"Remove superfluous variable assignment statements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/98dc781e94a5e61d0d28e157495528efafc368e3"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-03-19 02:56:43.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-03-22 02:08:51.000000000","tz":480},"subject":"Use assert_called_once_with() instead of assert_called_with()","message":"Use assert_called_once_with() instead of assert_called_with()\n\nIf one API is only called once, we\u0027d better use assert_called_once_with()\nto check the call.\n\nChange-Id: Id05055bb90592d218826732259ed84fc366734ce\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/41853985bb654e8417e5c9850ed1eeccd9828a73"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/41853985bb654e8417e5c9850ed1eeccd9828a73"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}