)]}'
{"doc/source/command-objects/volume-service.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b147e51f0e092a3c3445cc87cdec720047342ec2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"volume service"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da0c15f0_d49031ef","line":1,"updated":"2016-03-25 14:03:50.000000000","message":"nit...extra \u003d","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"6ef21388a637409dc99b5319278693e692e61d44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"volume service"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da0c15f0_05970391","line":1,"in_reply_to":"da0c15f0_d49031ef","updated":"2016-03-25 20:21:04.000000000","message":"Done","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b147e51f0e092a3c3445cc87cdec720047342ec2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"volume service"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Volume v1, v2"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da0c15f0_b45e5d43","line":2,"updated":"2016-03-25 14:03:50.000000000","message":"Please add this as a new command object in the doc.","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"6ef21388a637409dc99b5319278693e692e61d44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"volume service"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Volume v1, v2"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da0c15f0_85883324","line":2,"in_reply_to":"da0c15f0_b45e5d43","updated":"2016-03-25 20:21:04.000000000","message":"This is inside doc directory/source/command-objects/ itself\nPlease let me know if anything else is required for this comment.","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b147e51f0e092a3c3445cc87cdec720047342ec2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"volume service"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Volume v1, v2"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da0c15f0_b4893dcd","line":3,"updated":"2016-03-25 14:03:50.000000000","message":"nit...extra \u003d","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"6ef21388a637409dc99b5319278693e692e61d44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"volume service"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Volume v1, v2"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da0c15f0_4591fb98","line":3,"in_reply_to":"da0c15f0_b4893dcd","updated":"2016-03-25 20:21:04.000000000","message":"Done","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b147e51f0e092a3c3445cc87cdec720047342ec2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Volume v1, v2"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"volume service list"},{"line_number":8,"context_line":"--------------------"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"List service command"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da0c15f0_14f3c974","line":8,"updated":"2016-03-25 14:03:50.000000000","message":"nit...extra dash","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"6ef21388a637409dc99b5319278693e692e61d44","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Volume v1, v2"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"volume service list"},{"line_number":8,"context_line":"--------------------"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"List service command"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da0c15f0_258e8778","line":8,"in_reply_to":"da0c15f0_14f3c974","updated":"2016-03-25 20:21:04.000000000","message":"Done","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b147e51f0e092a3c3445cc87cdec720047342ec2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"volume service list"},{"line_number":8,"context_line":"--------------------"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"List service command"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. program:: volume service list"},{"line_number":13,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da0c15f0_d47e71ad","line":10,"updated":"2016-03-25 14:03:50.000000000","message":"I suggest \"List volume service\" instead.  I don\u0027t think \"command\" is necessary.","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"6ef21388a637409dc99b5319278693e692e61d44","unresolved":false,"context_lines":[{"line_number":7,"context_line":"volume service list"},{"line_number":8,"context_line":"--------------------"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"List service command"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. program:: volume service list"},{"line_number":13,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da0c15f0_85e9531d","line":10,"in_reply_to":"da0c15f0_d47e71ad","updated":"2016-03-25 20:21:04.000000000","message":"Done","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d58e5a0dfd9d0452ec01cb4f26e262c2e2542709","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        [--long]"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":".. _volume-service-list:"},{"line_number":21,"context_line":".. describe:: --host \u003chost\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    Name of host"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da0c15f0_c46348db","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":11},"updated":"2016-03-26 00:53:18.000000000","message":"nit: This should be \"option\". \"describe\" is for position arguments, and \"option\" is for options.","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"3bd7f30866457a708a3b09da08158d74a7eea8fb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        [--long]"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":".. _volume-service-list:"},{"line_number":21,"context_line":".. describe:: --host \u003chost\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    Name of host"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_1c6f392c","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":11},"in_reply_to":"da0c15f0_c46348db","updated":"2016-03-30 08:39:00.000000000","message":"Done","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d58e5a0dfd9d0452ec01cb4f26e262c2e2542709","unresolved":false,"context_lines":[{"line_number":20,"context_line":".. _volume-service-list:"},{"line_number":21,"context_line":".. describe:: --host \u003chost\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    Name of host"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":".. describe:: --service \u003cservice\u003e"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da0c15f0_24ce84b4","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":16},"updated":"2016-03-26 00:53:18.000000000","message":"This comment is not very clear and helpful. I suggest something like:\n\n\"List only services on this host (name only)\"","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"3bd7f30866457a708a3b09da08158d74a7eea8fb","unresolved":false,"context_lines":[{"line_number":20,"context_line":".. _volume-service-list:"},{"line_number":21,"context_line":".. describe:: --host \u003chost\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    Name of host"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":".. describe:: --service \u003cservice\u003e"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_fc69a526","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":16},"in_reply_to":"da0c15f0_24ce84b4","updated":"2016-03-30 08:39:00.000000000","message":"Done","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d58e5a0dfd9d0452ec01cb4f26e262c2e2542709","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    Name of host"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":".. describe:: --service \u003cservice\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Name of service"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da0c15f0_a45e1410","line":25,"range":{"start_line":25,"start_character":3,"end_line":25,"end_character":11},"updated":"2016-03-26 00:53:18.000000000","message":"ditto","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"3bd7f30866457a708a3b09da08158d74a7eea8fb","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    Name of host"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":".. describe:: --service \u003cservice\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Name of service"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_5c79b1f5","line":25,"range":{"start_line":25,"start_character":3,"end_line":25,"end_character":11},"in_reply_to":"da0c15f0_a45e1410","updated":"2016-03-30 08:39:00.000000000","message":"Done","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d58e5a0dfd9d0452ec01cb4f26e262c2e2542709","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":".. describe:: --service \u003cservice\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Name of service"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. describe:: --long"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da0c15f0_84c5d08f","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":19},"updated":"2016-03-26 00:53:18.000000000","message":"ditto","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"3bd7f30866457a708a3b09da08158d74a7eea8fb","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":".. describe:: --service \u003cservice\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Name of service"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. describe:: --long"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_9c61893c","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":19},"in_reply_to":"da0c15f0_84c5d08f","updated":"2016-03-30 08:39:00.000000000","message":"Done","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d58e5a0dfd9d0452ec01cb4f26e262c2e2542709","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Name of service"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. describe:: --long"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    List additional fields in output"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da0c15f0_049c20bf","line":29,"range":{"start_line":29,"start_character":3,"end_line":29,"end_character":11},"updated":"2016-03-26 00:53:18.000000000","message":"ditto","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"3bd7f30866457a708a3b09da08158d74a7eea8fb","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Name of service"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. describe:: --long"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    List additional fields in output"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba0121b8_dc5b0186","line":29,"range":{"start_line":29,"start_character":3,"end_line":29,"end_character":11},"in_reply_to":"da0c15f0_049c20bf","updated":"2016-03-30 08:39:00.000000000","message":"Done","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4956fc406af2644f7a44bf1a9bd2c11bfcc46762","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"volume service"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Volume v1, v2"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba0121b8_3fb9fd79","line":2,"updated":"2016-03-31 13:11:32.000000000","message":"Please add this object to doc/source/commands.rst","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"ce65f4468626758c343b35adb29c595d9aa118b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"volume service"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Volume v1, v2"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a061dce_5927e8b5","line":2,"in_reply_to":"ba0121b8_3fb9fd79","updated":"2016-04-10 07:40:22.000000000","message":"Done","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"}],"openstackclient/tests/volume/v1/fakes.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"14bdb691f995d00abe794841662e966631c29237","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    \u0027associations\u0027: [qos_association]"},{"line_number":129,"context_line":"}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"service_host \u003d \u0027host_test\u0027"},{"line_number":132,"context_line":"service_binary \u003d \u0027cinder_test\u0027"},{"line_number":133,"context_line":"service_status \u003d \u0027enabled\u0027"},{"line_number":134,"context_line":"service_disabled_reason \u003d \u0027LongHoliday-GoldenWeek\u0027"},{"line_number":135,"context_line":"service_zone \u003d \u0027fake_zone\u0027"},{"line_number":136,"context_line":"service_updated_at \u003d \u0027fake_date\u0027"},{"line_number":137,"context_line":"service_state \u003d \u0027fake_state\u0027"},{"line_number":138,"context_line":"SERVICE \u003d {"},{"line_number":139,"context_line":"    \u0027host\u0027: service_host,"},{"line_number":140,"context_line":"    \u0027binary\u0027: service_binary,"},{"line_number":141,"context_line":"    \u0027status\u0027: service_status,"},{"line_number":142,"context_line":"    \u0027disabled_reason\u0027: service_disabled_reason,"},{"line_number":143,"context_line":"    \u0027zone\u0027: service_zone,"},{"line_number":144,"context_line":"    \u0027updated_at\u0027: service_updated_at,"},{"line_number":145,"context_line":"    \u0027state\u0027: service_state,"},{"line_number":146,"context_line":"}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"class FakeService(object):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_4230ec56","line":146,"range":{"start_line":131,"start_character":0,"end_line":146,"end_character":1},"updated":"2016-04-12 14:18:57.000000000","message":"This isn\u0027t needed given the FakeService class below.  You can put the data in the class.","commit_id":"dd78abd3b33bc6eb69b7673280b76a16f32c8e34"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"14bdb691f995d00abe794841662e966631c29237","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    \"\"\"Fake one or more Services.\"\"\""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    @staticmethod"},{"line_number":153,"context_line":"    def create_one_service(attrs\u003d{}):"},{"line_number":154,"context_line":"        \"\"\"Create a fake service."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        :param Dictionary attrs:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_62eec88c","line":153,"range":{"start_line":153,"start_character":33,"end_line":153,"end_character":35},"updated":"2016-04-12 14:18:57.000000000","message":"The default should be None.  Please see https://bugs.launchpad.net/python-openstackclient/+bug/1550320.  The comment applies throughout this part.","commit_id":"dd78abd3b33bc6eb69b7673280b76a16f32c8e34"}],"openstackclient/tests/volume/v1/test_service.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4956fc406af2644f7a44bf1a9bd2c11bfcc46762","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            self.fakeService.service_binary,"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.assertNotIn(\"Disabled Reason\", columns)"},{"line_number":70,"context_line":"        self.assertNotIn(self.fakeService.service_disabled_reason,"},{"line_number":71,"context_line":"                         list(data)[0])"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_bf9a2d6c","line":69,"updated":"2016-03-31 13:11:32.000000000","message":"This should assert that all of the information correct.","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"ce65f4468626758c343b35adb29c595d9aa118b2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            self.fakeService.service_binary,"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.assertNotIn(\"Disabled Reason\", columns)"},{"line_number":70,"context_line":"        self.assertNotIn(self.fakeService.service_disabled_reason,"},{"line_number":71,"context_line":"                         list(data)[0])"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_13ee29ec","line":69,"in_reply_to":"ba0121b8_bf9a2d6c","updated":"2016-04-10 07:40:22.000000000","message":"Done","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4956fc406af2644f7a44bf1a9bd2c11bfcc46762","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.assertNotIn(\"Disabled Reason\", columns)"},{"line_number":70,"context_line":"        self.assertNotIn(self.fakeService.service_disabled_reason,"},{"line_number":71,"context_line":"                         list(data)[0])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_service_list_with_long_option(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_9f7e4917","line":70,"updated":"2016-03-31 13:11:32.000000000","message":"This should assert that all of the information correct.","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"ce65f4468626758c343b35adb29c595d9aa118b2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.assertNotIn(\"Disabled Reason\", columns)"},{"line_number":70,"context_line":"        self.assertNotIn(self.fakeService.service_disabled_reason,"},{"line_number":71,"context_line":"                         list(data)[0])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_service_list_with_long_option(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_73b965ec","line":70,"in_reply_to":"ba0121b8_9f7e4917","updated":"2016-04-10 07:40:22.000000000","message":"Done","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4956fc406af2644f7a44bf1a9bd2c11bfcc46762","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        # containing the data to be listed."},{"line_number":89,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.assertIn(\"Disabled Reason\", columns)"},{"line_number":92,"context_line":"        self.assertIn(self.fakeService.service_disabled_reason, list(data)[0])"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_1f919947","line":91,"updated":"2016-03-31 13:11:32.000000000","message":"This should assert that all of the information correct.","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"ce65f4468626758c343b35adb29c595d9aa118b2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        # containing the data to be listed."},{"line_number":89,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.assertIn(\"Disabled Reason\", columns)"},{"line_number":92,"context_line":"        self.assertIn(self.fakeService.service_disabled_reason, list(data)[0])"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_53bee1d4","line":91,"in_reply_to":"ba0121b8_1f919947","updated":"2016-04-10 07:40:22.000000000","message":"Done","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4956fc406af2644f7a44bf1a9bd2c11bfcc46762","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.assertIn(\"Disabled Reason\", columns)"},{"line_number":92,"context_line":"        self.assertIn(self.fakeService.service_disabled_reason, list(data)[0])"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_3f9c5d5c","line":92,"updated":"2016-03-31 13:11:32.000000000","message":"This should assert that all of the information correct.","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"ce65f4468626758c343b35adb29c595d9aa118b2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.assertIn(\"Disabled Reason\", columns)"},{"line_number":92,"context_line":"        self.assertIn(self.fakeService.service_disabled_reason, list(data)[0])"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_b3b3fd09","line":92,"in_reply_to":"ba0121b8_3f9c5d5c","updated":"2016-04-10 07:40:22.000000000","message":"Done","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"14bdb691f995d00abe794841662e966631c29237","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def setUp(self):"},{"line_number":43,"context_line":"        super(TestServiceList, self).setUp()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.service_mock.list.return_value \u003d [fakes.FakeResource("},{"line_number":46,"context_line":"            None,"},{"line_number":47,"context_line":"            copy.deepcopy(service_fakes.SERVICE),"},{"line_number":48,"context_line":"            loaded\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_2d5681d2","line":45,"range":{"start_line":45,"start_character":47,"end_line":45,"end_character":65},"updated":"2016-04-12 14:18:57.000000000","message":"The FakeService class should be used.","commit_id":"dd78abd3b33bc6eb69b7673280b76a16f32c8e34"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"14bdb691f995d00abe794841662e966631c29237","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_service_list(self):"},{"line_number":55,"context_line":"        arglist \u003d ["},{"line_number":56,"context_line":"            \u0027--host\u0027, service_fakes.service_host,"},{"line_number":57,"context_line":"            \u0027--service\u0027, service_fakes.service_binary,"},{"line_number":58,"context_line":"        ]"},{"line_number":59,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_ede76910","line":56,"range":{"start_line":56,"start_character":22,"end_line":56,"end_character":48},"updated":"2016-04-12 14:18:57.000000000","message":"This should use the FakeService created for the test.  This is a general comment throughout this part.  Please see network command unit tests for examples on how to use the fake resources.","commit_id":"dd78abd3b33bc6eb69b7673280b76a16f32c8e34"}],"openstackclient/tests/volume/v2/fakes.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b147e51f0e092a3c3445cc87cdec720047342ec2","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    \u0027links\u0027: extension_links,"},{"line_number":232,"context_line":"}"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"service_host \u003d \u0027host_test\u0027"},{"line_number":235,"context_line":"service_binary \u003d \u0027cinder_test\u0027"},{"line_number":236,"context_line":"service_status \u003d \u0027enabled\u0027"},{"line_number":237,"context_line":"service_disabled_reason \u003d \u0027LongHoliday-GoldenWeek\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_7499656e","line":234,"updated":"2016-03-25 14:03:50.000000000","message":"Please create a fake resource class for this.","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"6ef21388a637409dc99b5319278693e692e61d44","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    \u0027links\u0027: extension_links,"},{"line_number":232,"context_line":"}"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"service_host \u003d \u0027host_test\u0027"},{"line_number":235,"context_line":"service_binary \u003d \u0027cinder_test\u0027"},{"line_number":236,"context_line":"service_status \u003d \u0027enabled\u0027"},{"line_number":237,"context_line":"service_disabled_reason \u003d \u0027LongHoliday-GoldenWeek\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_c5418b0d","line":234,"in_reply_to":"da0c15f0_7499656e","updated":"2016-03-25 20:21:04.000000000","message":"may be we avoid writing class for just some variables.","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d58e5a0dfd9d0452ec01cb4f26e262c2e2542709","unresolved":false,"context_lines":[{"line_number":235,"context_line":"service_binary \u003d \u0027cinder_test\u0027"},{"line_number":236,"context_line":"service_status \u003d \u0027enabled\u0027"},{"line_number":237,"context_line":"service_disabled_reason \u003d \u0027LongHoliday-GoldenWeek\u0027"},{"line_number":238,"context_line":"SERVICE \u003d {"},{"line_number":239,"context_line":"    \u0027host\u0027: service_host,"},{"line_number":240,"context_line":"    \u0027binary\u0027: service_binary,"},{"line_number":241,"context_line":"    \u0027status\u0027: service_status,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_c477c838","line":238,"range":{"start_line":238,"start_character":0,"end_line":238,"end_character":7},"updated":"2016-03-26 00:53:18.000000000","message":"Please refer to class FakeVolume.\n\nNow, we use classes like FakeXXX in unit tests. This kind of class make us easier to fake one or more test objects in tests. \n\nSome of the tests like volumes and images are not doing this because they are not improved yet. So if you add new commands and new unit tests like service list, please make the FakeService class and use it in the tests.\n\n:)","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"3ec93436eb0af5b8b8f63951c48314d43fecb79f","unresolved":false,"context_lines":[{"line_number":235,"context_line":"service_binary \u003d \u0027cinder_test\u0027"},{"line_number":236,"context_line":"service_status \u003d \u0027enabled\u0027"},{"line_number":237,"context_line":"service_disabled_reason \u003d \u0027LongHoliday-GoldenWeek\u0027"},{"line_number":238,"context_line":"SERVICE \u003d {"},{"line_number":239,"context_line":"    \u0027host\u0027: service_host,"},{"line_number":240,"context_line":"    \u0027binary\u0027: service_binary,"},{"line_number":241,"context_line":"    \u0027status\u0027: service_status,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_f1608ad1","line":238,"range":{"start_line":238,"start_character":0,"end_line":238,"end_character":7},"in_reply_to":"ba0121b8_dc45c170","updated":"2016-03-30 15:42:22.000000000","message":"Done.\nI have added fake class for same.\nThanks!!","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"3bd7f30866457a708a3b09da08158d74a7eea8fb","unresolved":false,"context_lines":[{"line_number":235,"context_line":"service_binary \u003d \u0027cinder_test\u0027"},{"line_number":236,"context_line":"service_status \u003d \u0027enabled\u0027"},{"line_number":237,"context_line":"service_disabled_reason \u003d \u0027LongHoliday-GoldenWeek\u0027"},{"line_number":238,"context_line":"SERVICE \u003d {"},{"line_number":239,"context_line":"    \u0027host\u0027: service_host,"},{"line_number":240,"context_line":"    \u0027binary\u0027: service_binary,"},{"line_number":241,"context_line":"    \u0027status\u0027: service_status,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_dc45c170","line":238,"range":{"start_line":238,"start_character":0,"end_line":238,"end_character":7},"in_reply_to":"da0c15f0_c477c838","updated":"2016-03-30 08:39:00.000000000","message":"Dear Tang Chen,\nPlease consider current patch for now.\nI will update all in one go for improvement in separate patchset for image, volume, service etc.","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4956fc406af2644f7a44bf1a9bd2c11bfcc46762","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        return mock.MagicMock(side_effect\u003dvolumes)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"class FakeService(object):"},{"line_number":359,"context_line":"    \"\"\"Fake services.\"\"\""},{"line_number":360,"context_line":"    def __init__(self):"},{"line_number":361,"context_line":"        self.service_host \u003d \u0027host_test\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_bf150de6","line":358,"updated":"2016-03-31 13:11:32.000000000","message":"This fake should following the example of other fake resources (e.g. FakeVolume)","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"ce65f4468626758c343b35adb29c595d9aa118b2","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        return mock.MagicMock(side_effect\u003dvolumes)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"class FakeService(object):"},{"line_number":359,"context_line":"    \"\"\"Fake services.\"\"\""},{"line_number":360,"context_line":"    def __init__(self):"},{"line_number":361,"context_line":"        self.service_host \u003d \u0027host_test\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_f3cd7587","line":358,"in_reply_to":"ba0121b8_bf150de6","updated":"2016-04-10 07:40:22.000000000","message":"Done","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"14bdb691f995d00abe794841662e966631c29237","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    \u0027links\u0027: extension_links,"},{"line_number":232,"context_line":"}"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"service_host \u003d \u0027host_test\u0027"},{"line_number":235,"context_line":"service_binary \u003d \u0027cinder_test\u0027"},{"line_number":236,"context_line":"service_status \u003d \u0027enabled\u0027"},{"line_number":237,"context_line":"service_disabled_reason \u003d \u0027LongHoliday-GoldenWeek\u0027"},{"line_number":238,"context_line":"service_zone \u003d \u0027fake_zone\u0027"},{"line_number":239,"context_line":"service_updated_at \u003d \u0027fake_date\u0027"},{"line_number":240,"context_line":"service_state \u003d \u0027fake_state\u0027"},{"line_number":241,"context_line":"SERVICE \u003d {"},{"line_number":242,"context_line":"    \u0027host\u0027: service_host,"},{"line_number":243,"context_line":"    \u0027binary\u0027: service_binary,"},{"line_number":244,"context_line":"    \u0027status\u0027: service_status,"},{"line_number":245,"context_line":"    \u0027disabled_reason\u0027: service_disabled_reason,"},{"line_number":246,"context_line":"    \u0027zone\u0027: service_zone,"},{"line_number":247,"context_line":"    \u0027updated_at\u0027: service_updated_at,"},{"line_number":248,"context_line":"    \u0027state\u0027: service_state,"},{"line_number":249,"context_line":"}"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"class FakeService(object):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_0d1bc573","line":249,"range":{"start_line":234,"start_character":0,"end_line":249,"end_character":1},"updated":"2016-04-12 14:18:57.000000000","message":"This isn\u0027t needed given the FakeService class below.  You can put the data in the class.","commit_id":"dd78abd3b33bc6eb69b7673280b76a16f32c8e34"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"14bdb691f995d00abe794841662e966631c29237","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    \"\"\"Fake one or more Services.\"\"\""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @staticmethod"},{"line_number":256,"context_line":"    def create_one_service(attrs\u003d{}):"},{"line_number":257,"context_line":"        \"\"\"Create a fake service."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        :param Dictionary attrs:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_ad573101","line":256,"range":{"start_line":256,"start_character":27,"end_line":256,"end_character":35},"updated":"2016-04-12 14:18:57.000000000","message":"The default should be None.  Please see https://bugs.launchpad.net/python-openstackclient/+bug/1550320.  The comment applies throughout this part.","commit_id":"dd78abd3b33bc6eb69b7673280b76a16f32c8e34"}],"openstackclient/tests/volume/v2/test_service.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4956fc406af2644f7a44bf1a9bd2c11bfcc46762","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            self.fakeService.service_binary,"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.assertNotIn(\"Disabled Reason\", columns)"},{"line_number":70,"context_line":"        self.assertNotIn(self.fakeService.service_disabled_reason,"},{"line_number":71,"context_line":"                         list(data)[0])"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_bfbfcda8","line":69,"updated":"2016-03-31 13:11:32.000000000","message":"This should assert that all of the information correct.","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"ce65f4468626758c343b35adb29c595d9aa118b2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            self.fakeService.service_binary,"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.assertNotIn(\"Disabled Reason\", columns)"},{"line_number":70,"context_line":"        self.assertNotIn(self.fakeService.service_disabled_reason,"},{"line_number":71,"context_line":"                         list(data)[0])"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_13c5895a","line":69,"in_reply_to":"ba0121b8_bfbfcda8","updated":"2016-04-10 07:40:22.000000000","message":"Done","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4956fc406af2644f7a44bf1a9bd2c11bfcc46762","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.assertNotIn(\"Disabled Reason\", columns)"},{"line_number":70,"context_line":"        self.assertNotIn(self.fakeService.service_disabled_reason,"},{"line_number":71,"context_line":"                         list(data)[0])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_service_list_with_long_option(self):"},{"line_number":74,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_ffbca5bc","line":71,"updated":"2016-03-31 13:11:32.000000000","message":"This should assert that all of the information correct.","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"ce65f4468626758c343b35adb29c595d9aa118b2","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        self.assertNotIn(\"Disabled Reason\", columns)"},{"line_number":70,"context_line":"        self.assertNotIn(self.fakeService.service_disabled_reason,"},{"line_number":71,"context_line":"                         list(data)[0])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_service_list_with_long_option(self):"},{"line_number":74,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_53a541b3","line":71,"in_reply_to":"ba0121b8_ffbca5bc","updated":"2016-04-10 07:40:22.000000000","message":"Done","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4956fc406af2644f7a44bf1a9bd2c11bfcc46762","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        # containing the data to be listed."},{"line_number":89,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.assertIn(\"Disabled Reason\", columns)"},{"line_number":92,"context_line":"        self.assertIn(self.fakeService.service_disabled_reason, list(data)[0])"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_5fe5d1d9","line":91,"updated":"2016-03-31 13:11:32.000000000","message":"This should assert that all of the information correct.","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"ce65f4468626758c343b35adb29c595d9aa118b2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        # containing the data to be listed."},{"line_number":89,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.assertIn(\"Disabled Reason\", columns)"},{"line_number":92,"context_line":"        self.assertIn(self.fakeService.service_disabled_reason, list(data)[0])"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_73a045a6","line":91,"in_reply_to":"ba0121b8_5fe5d1d9","updated":"2016-04-10 07:40:22.000000000","message":"Done","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4956fc406af2644f7a44bf1a9bd2c11bfcc46762","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.assertIn(\"Disabled Reason\", columns)"},{"line_number":92,"context_line":"        self.assertIn(self.fakeService.service_disabled_reason, list(data)[0])"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_5fae7181","line":92,"updated":"2016-03-31 13:11:32.000000000","message":"This should assert that all of the information correct.","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"ce65f4468626758c343b35adb29c595d9aa118b2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.assertIn(\"Disabled Reason\", columns)"},{"line_number":92,"context_line":"        self.assertIn(self.fakeService.service_disabled_reason, list(data)[0])"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_93afd993","line":92,"in_reply_to":"ba0121b8_5fae7181","updated":"2016-04-10 07:40:22.000000000","message":"Done","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"14bdb691f995d00abe794841662e966631c29237","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def setUp(self):"},{"line_number":43,"context_line":"        super(TestServiceList, self).setUp()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.service_mock.list.return_value \u003d [fakes.FakeResource("},{"line_number":46,"context_line":"            None,"},{"line_number":47,"context_line":"            copy.deepcopy(service_fakes.SERVICE),"},{"line_number":48,"context_line":"            loaded\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_edcac94e","line":45,"range":{"start_line":45,"start_character":47,"end_line":45,"end_character":65},"updated":"2016-04-12 14:18:57.000000000","message":"The FakeService class should be used.","commit_id":"dd78abd3b33bc6eb69b7673280b76a16f32c8e34"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"14bdb691f995d00abe794841662e966631c29237","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_service_list(self):"},{"line_number":55,"context_line":"        arglist \u003d ["},{"line_number":56,"context_line":"            \u0027--host\u0027, service_fakes.service_host,"},{"line_number":57,"context_line":"            \u0027--service\u0027, service_fakes.service_binary,"},{"line_number":58,"context_line":"        ]"},{"line_number":59,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":10,"id":"5a18252c_0d746533","line":56,"range":{"start_line":56,"start_character":22,"end_line":56,"end_character":48},"updated":"2016-04-12 14:18:57.000000000","message":"This should use the FakeService created for the test.  This is a general comment throughout this part.  Please see network command unit tests for examples on how to use the fake resources.","commit_id":"dd78abd3b33bc6eb69b7673280b76a16f32c8e34"}],"openstackclient/volume/v1/service.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b147e51f0e092a3c3445cc87cdec720047342ec2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2013 OpenStack, LLC."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_54038173","line":1,"updated":"2016-03-25 14:03:50.000000000","message":"Please fix the copyright date.","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"6ef21388a637409dc99b5319278693e692e61d44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2013 OpenStack, LLC."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_054c2341","line":1,"in_reply_to":"da0c15f0_54038173","updated":"2016-03-25 20:21:04.000000000","message":"Done","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"431585ae303f1bbfcbc27a902348a034068a5380","unresolved":false,"context_lines":[{"line_number":27,"context_line":"            \"--host\","},{"line_number":28,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":29,"context_line":"            help\u003d\"List services on specified host (name only)\")"},{"line_number":30,"context_line":"        parser.add_argument("},{"line_number":31,"context_line":"            \"--service\","},{"line_number":32,"context_line":"            metavar\u003d\"\u003cservice\u003e\","},{"line_number":33,"context_line":"            help\u003d\"List only specified service (name only)\")"},{"line_number":34,"context_line":"        parser.add_argument("},{"line_number":35,"context_line":"            \"--long\","},{"line_number":36,"context_line":"            action\u003d\"store_true\","}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_de746a69","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":59},"updated":"2016-03-30 19:01:28.000000000","message":"looks like cinderclient calls this a binary, is that the same thing as a service?\n\nhttps://github.com/openstack/python-cinderclient/blob/master/cinderclient/v1/services.py#L31-L37","commit_id":"e76b520f7c6e9cefec02c7c392c7896fbbc65709"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"e56960ef14325cace2ce1a04db4235d5ef24dc09","unresolved":false,"context_lines":[{"line_number":27,"context_line":"            \"--host\","},{"line_number":28,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":29,"context_line":"            help\u003d\"List services on specified host (name only)\")"},{"line_number":30,"context_line":"        parser.add_argument("},{"line_number":31,"context_line":"            \"--service\","},{"line_number":32,"context_line":"            metavar\u003d\"\u003cservice\u003e\","},{"line_number":33,"context_line":"            help\u003d\"List only specified service (name only)\")"},{"line_number":34,"context_line":"        parser.add_argument("},{"line_number":35,"context_line":"            \"--long\","},{"line_number":36,"context_line":"            action\u003d\"store_true\","}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_5eb85ac8","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":59},"in_reply_to":"ba0121b8_de746a69","updated":"2016-03-30 19:14:16.000000000","message":"yes.","commit_id":"e76b520f7c6e9cefec02c7c392c7896fbbc65709"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e4aaa66c6e48cba4af062bf03855dfdde9d4eb34","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                \"Zone\","},{"line_number":50,"context_line":"                \"Status\","},{"line_number":51,"context_line":"                \"State\","},{"line_number":52,"context_line":"                \"Updated At\","},{"line_number":53,"context_line":"                \"Disabled Reason\""},{"line_number":54,"context_line":"            ]"},{"line_number":55,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_7038fb3d","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":29},"updated":"2016-04-25 16:51:37.000000000","message":"\"Updated At\" should also be included in the else block to match the output of compute service list","commit_id":"17a222d0a998ed463461a9307c0c834b520cbf63"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"7d8e1b28ed0a55b3b0f1d969b068ae4308f734bb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                \"Zone\","},{"line_number":50,"context_line":"                \"Status\","},{"line_number":51,"context_line":"                \"State\","},{"line_number":52,"context_line":"                \"Updated At\","},{"line_number":53,"context_line":"                \"Disabled Reason\""},{"line_number":54,"context_line":"            ]"},{"line_number":55,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_0e3528d9","line":52,"range":{"start_line":52,"start_character":16,"end_line":52,"end_character":29},"in_reply_to":"1a122d0e_7038fb3d","updated":"2016-04-25 18:03:44.000000000","message":"I removed this in patchset 4 after suggestion in review comment.\nBut yes its ok to keep updated At for consistency with compute service list.","commit_id":"17a222d0a998ed463461a9307c0c834b520cbf63"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e4aaa66c6e48cba4af062bf03855dfdde9d4eb34","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def take_action(self, parsed_args):"},{"line_number":43,"context_line":"        service_client \u003d self.app.client_manager.volume"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if parsed_args.long:"},{"line_number":46,"context_line":"            columns \u003d ["},{"line_number":47,"context_line":"                \"Binary\","},{"line_number":48,"context_line":"                \"Host\","},{"line_number":49,"context_line":"                \"Zone\","},{"line_number":50,"context_line":"                \"Status\","},{"line_number":51,"context_line":"                \"State\","},{"line_number":52,"context_line":"                \"Updated At\","},{"line_number":53,"context_line":"                \"Disabled Reason\""},{"line_number":54,"context_line":"            ]"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            columns \u003d ["},{"line_number":57,"context_line":"                \"Binary\","},{"line_number":58,"context_line":"                \"Host\","},{"line_number":59,"context_line":"                \"Zone\","},{"line_number":60,"context_line":"                \"Status\","},{"line_number":61,"context_line":"                \"State\""},{"line_number":62,"context_line":"            ]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        data \u003d service_client.services.list(parsed_args.host,"},{"line_number":65,"context_line":"                                            parsed_args.service)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_70011b6a","line":62,"range":{"start_line":45,"start_character":0,"end_line":62,"end_character":13},"updated":"2016-04-25 16:51:37.000000000","message":"do we need an ID column too? so it matches the compute service list?","commit_id":"17a222d0a998ed463461a9307c0c834b520cbf63"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"7d8e1b28ed0a55b3b0f1d969b068ae4308f734bb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def take_action(self, parsed_args):"},{"line_number":43,"context_line":"        service_client \u003d self.app.client_manager.volume"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if parsed_args.long:"},{"line_number":46,"context_line":"            columns \u003d ["},{"line_number":47,"context_line":"                \"Binary\","},{"line_number":48,"context_line":"                \"Host\","},{"line_number":49,"context_line":"                \"Zone\","},{"line_number":50,"context_line":"                \"Status\","},{"line_number":51,"context_line":"                \"State\","},{"line_number":52,"context_line":"                \"Updated At\","},{"line_number":53,"context_line":"                \"Disabled Reason\""},{"line_number":54,"context_line":"            ]"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            columns \u003d ["},{"line_number":57,"context_line":"                \"Binary\","},{"line_number":58,"context_line":"                \"Host\","},{"line_number":59,"context_line":"                \"Zone\","},{"line_number":60,"context_line":"                \"Status\","},{"line_number":61,"context_line":"                \"State\""},{"line_number":62,"context_line":"            ]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        data \u003d service_client.services.list(parsed_args.host,"},{"line_number":65,"context_line":"                                            parsed_args.service)"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_ce13305b","line":62,"range":{"start_line":45,"start_character":0,"end_line":62,"end_character":13},"in_reply_to":"1a122d0e_70011b6a","updated":"2016-04-25 18:03:44.000000000","message":"As discussed, cinder service-list does not have ID in output.\nRefer below\ncinder service-list \n+------------------+-------------------+------+---------+-------+----------------------------+-----------------+\n|      Binary      |        Host       | Zone |  Status | State |         Updated_at         | Disabled Reason |\n+------------------+-------------------+------+---------+-------+----------------------------+-----------------+\n|  cinder-backup   |       sheel       | nova | enabled |  down | 2016-04-24T06:36:01.000000 |        -        |\n| cinder-scheduler |       sheel       | nova | enabled |  down | 2016-04-24T06:35:55.000000 |        -        |\n|  cinder-volume   | sheel@lvmdriver-1 | nova | enabled |  down | 2016-04-24T06:36:38.000000 |        -        |\n+------------------+-------------------+------+---------+-------+----------------------------+-----------------+","commit_id":"17a222d0a998ed463461a9307c0c834b520cbf63"}],"openstackclient/volume/v2/service.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b147e51f0e092a3c3445cc87cdec720047342ec2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2013 OpenStack, LLC."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"da0c15f0_545f0172","line":1,"updated":"2016-03-25 14:03:50.000000000","message":"Please fix the copyright date.","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d58e5a0dfd9d0452ec01cb4f26e262c2e2542709","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        parser.add_argument("},{"line_number":28,"context_line":"            \"--host\","},{"line_number":29,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":30,"context_line":"            help\u003d\"Name of host\")"},{"line_number":31,"context_line":"        parser.add_argument("},{"line_number":32,"context_line":"            \"--service\","},{"line_number":33,"context_line":"            metavar\u003d\"\u003cservice\u003e\","}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_84faf0bb","line":30,"range":{"start_line":30,"start_character":18,"end_line":30,"end_character":30},"updated":"2016-03-26 00:53:18.000000000","message":"Please remember update this help to keep consistence with the doc in rst file.","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"3bd7f30866457a708a3b09da08158d74a7eea8fb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        parser.add_argument("},{"line_number":28,"context_line":"            \"--host\","},{"line_number":29,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":30,"context_line":"            help\u003d\"Name of host\")"},{"line_number":31,"context_line":"        parser.add_argument("},{"line_number":32,"context_line":"            \"--service\","},{"line_number":33,"context_line":"            metavar\u003d\"\u003cservice\u003e\","}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_fc21a5b5","line":30,"range":{"start_line":30,"start_character":18,"end_line":30,"end_character":30},"in_reply_to":"da0c15f0_84faf0bb","updated":"2016-03-30 08:39:00.000000000","message":"Done","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d58e5a0dfd9d0452ec01cb4f26e262c2e2542709","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        parser.add_argument("},{"line_number":32,"context_line":"            \"--service\","},{"line_number":33,"context_line":"            metavar\u003d\"\u003cservice\u003e\","},{"line_number":34,"context_line":"            help\u003d\"Name of service\")"},{"line_number":35,"context_line":"        parser.add_argument("},{"line_number":36,"context_line":"            \"--long\","},{"line_number":37,"context_line":"            action\u003d\"store_true\","}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_64f51cca","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":33},"updated":"2016-03-26 00:53:18.000000000","message":"ditto","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"3bd7f30866457a708a3b09da08158d74a7eea8fb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        parser.add_argument("},{"line_number":32,"context_line":"            \"--service\","},{"line_number":33,"context_line":"            metavar\u003d\"\u003cservice\u003e\","},{"line_number":34,"context_line":"            help\u003d\"Name of service\")"},{"line_number":35,"context_line":"        parser.add_argument("},{"line_number":36,"context_line":"            \"--long\","},{"line_number":37,"context_line":"            action\u003d\"store_true\","}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_5c31b104","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":33},"in_reply_to":"da0c15f0_64f51cca","updated":"2016-03-30 08:39:00.000000000","message":"Done","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d58e5a0dfd9d0452ec01cb4f26e262c2e2542709","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                \"Zone\","},{"line_number":60,"context_line":"                \"Status\","},{"line_number":61,"context_line":"                \"State\","},{"line_number":62,"context_line":"                \"Updated At\""},{"line_number":63,"context_line":"            )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        data \u003d volume_client.services.list(parsed_args.host,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_04d4201e","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":28},"updated":"2016-03-26 00:53:18.000000000","message":"I suggest remove display this only when --long is specified.","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"3bd7f30866457a708a3b09da08158d74a7eea8fb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                \"Zone\","},{"line_number":60,"context_line":"                \"Status\","},{"line_number":61,"context_line":"                \"State\","},{"line_number":62,"context_line":"                \"Updated At\""},{"line_number":63,"context_line":"            )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        data \u003d volume_client.services.list(parsed_args.host,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_3c2cbdaa","line":62,"range":{"start_line":62,"start_character":16,"end_line":62,"end_character":28},"in_reply_to":"da0c15f0_04d4201e","updated":"2016-03-30 08:39:00.000000000","message":"Done","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e4aaa66c6e48cba4af062bf03855dfdde9d4eb34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1a122d0e_b03a9332","updated":"2016-04-25 16:51:37.000000000","message":"same comments as v1","commit_id":"17a222d0a998ed463461a9307c0c834b520cbf63"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"7d8e1b28ed0a55b3b0f1d969b068ae4308f734bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1a122d0e_53186984","in_reply_to":"1a122d0e_b03a9332","updated":"2016-04-25 18:03:44.000000000","message":"Done","commit_id":"17a222d0a998ed463461a9307c0c834b520cbf63"}],"releasenotes/notes/volume_service-5e352a71dfbc828d.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b147e51f0e092a3c3445cc87cdec720047342ec2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for volume service list."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da0c15f0_148d8931","line":2,"updated":"2016-03-25 14:03:50.000000000","message":"This is a feature not a fix.","commit_id":"e1bad6c967ce11d55336c3ec69218e01227813ea"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d58e5a0dfd9d0452ec01cb4f26e262c2e2542709","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for volume service list."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    In Cinder we have facility for listing available"},{"line_number":7,"context_line":"    services."},{"line_number":8,"context_line":"    But this facility is not present in OSC client."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    So, this patchset enables user to list available services"},{"line_number":11,"context_line":"    using below commands"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    ``volume service list``."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    [Bug \u0027https://bugs.launchpad.net/python-openstackclient/+bug/1550999\u0027_]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da0c15f0_a451f4da","line":13,"range":{"start_line":4,"start_character":0,"end_line":13,"end_character":28},"updated":"2016-03-26 00:53:18.000000000","message":"I think we can make this more simple, like:\n\n\"Add ``volume service list`` command support.\" or something similar. \n\nBut I\u0027m also OK with this detailed release note. Not a big deal. :)","commit_id":"40c2cae61ed669b527596991990426e134a0d8bf"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4956fc406af2644f7a44bf1a9bd2c11bfcc46762","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for volume service list."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    In Cinder we have facility for listing available"},{"line_number":7,"context_line":"    services."},{"line_number":8,"context_line":"    But this facility is not present in OSC client."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ba0121b8_dfbc4108","line":6,"updated":"2016-03-31 13:11:32.000000000","message":"You can simply state the command that was added.  However, if you prefer this additional explanation, please reference cinder client as having the command for listing available services.","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"ce65f4468626758c343b35adb29c595d9aa118b2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for volume service list."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    In Cinder we have facility for listing available"},{"line_number":7,"context_line":"    services."},{"line_number":8,"context_line":"    But this facility is not present in OSC client."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a061dce_399f94b5","line":6,"in_reply_to":"ba0121b8_dfbc4108","updated":"2016-04-10 07:40:22.000000000","message":"Done","commit_id":"6aed7306cac955ec2f489929f123ff653db4f3d9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"14bdb691f995d00abe794841662e966631c29237","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for volume service list."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    In Cinder we have facility for listing available"},{"line_number":7,"context_line":"    services using ``cinder service-list`` command."},{"line_number":8,"context_line":"    But this facility is not present in OSC client."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a18252c_825cc426","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":21},"updated":"2016-04-12 14:18:57.000000000","message":"Suggestion...\"Cinder has the\"","commit_id":"dd78abd3b33bc6eb69b7673280b76a16f32c8e34"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"14bdb691f995d00abe794841662e966631c29237","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    services using ``cinder service-list`` command."},{"line_number":8,"context_line":"    But this facility is not present in OSC client."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    So, this patchset enables user to list available services"},{"line_number":11,"context_line":"    using below commands"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    ``volume service list``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a18252c_a26e20c7","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":21},"updated":"2016-04-12 14:18:57.000000000","message":"Suggestion...\"feature\"","commit_id":"dd78abd3b33bc6eb69b7673280b76a16f32c8e34"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"14bdb691f995d00abe794841662e966631c29237","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    So, this patchset enables user to list available services"},{"line_number":11,"context_line":"    using below commands"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    ``volume service list``."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    [Bug \u0027https://bugs.launchpad.net/python-openstackclient/+bug/1550999\u0027_]"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a18252c_22ba1024","line":13,"range":{"start_line":13,"start_character":27,"end_line":13,"end_character":28},"updated":"2016-04-12 14:18:57.000000000","message":"You can remove this period.","commit_id":"dd78abd3b33bc6eb69b7673280b76a16f32c8e34"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"14bdb691f995d00abe794841662e966631c29237","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    ``volume service list``."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    [Bug \u0027https://bugs.launchpad.net/python-openstackclient/+bug/1550999\u0027_]"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a18252c_c2107c51","line":15,"range":{"start_line":15,"start_character":5,"end_line":15,"end_character":8},"updated":"2016-04-12 14:18:57.000000000","message":"This should be \"Bug 1550999\".","commit_id":"dd78abd3b33bc6eb69b7673280b76a16f32c8e34"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e4aaa66c6e48cba4af062bf03855dfdde9d4eb34","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for volume service list."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    Cinder has the facility for listing available"},{"line_number":7,"context_line":"    services using ``cinder service-list`` command."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a122d0e_f01b6bc8","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":42},"updated":"2016-04-25 16:51:37.000000000","message":"Suggest: \"Add support for listing volume services\"","commit_id":"17a222d0a998ed463461a9307c0c834b520cbf63"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"7d8e1b28ed0a55b3b0f1d969b068ae4308f734bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for volume service list."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    Cinder has the facility for listing available"},{"line_number":7,"context_line":"    services using ``cinder service-list`` command."}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a122d0e_d32599c2","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":42},"in_reply_to":"1a122d0e_f01b6bc8","updated":"2016-04-25 18:03:44.000000000","message":"Done","commit_id":"17a222d0a998ed463461a9307c0c834b520cbf63"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e4aaa66c6e48cba4af062bf03855dfdde9d4eb34","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for volume service list."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    Cinder has the facility for listing available"},{"line_number":7,"context_line":"    services using ``cinder service-list`` command."},{"line_number":8,"context_line":"    But this facility is not present in OSC client."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    So, this feature enables user to list available services"},{"line_number":11,"context_line":"    using below commands"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a122d0e_d06d8f33","line":8,"range":{"start_line":6,"start_character":4,"end_line":8,"end_character":51},"updated":"2016-04-25 16:51:37.000000000","message":"i don\u0027t think this is needed","commit_id":"17a222d0a998ed463461a9307c0c834b520cbf63"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"7d8e1b28ed0a55b3b0f1d969b068ae4308f734bb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for volume service list."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    Cinder has the facility for listing available"},{"line_number":7,"context_line":"    services using ``cinder service-list`` command."},{"line_number":8,"context_line":"    But this facility is not present in OSC client."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    So, this feature enables user to list available services"},{"line_number":11,"context_line":"    using below commands"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a122d0e_b320ddb1","line":8,"range":{"start_line":6,"start_character":4,"end_line":8,"end_character":51},"in_reply_to":"1a122d0e_d06d8f33","updated":"2016-04-25 18:03:44.000000000","message":"Done","commit_id":"17a222d0a998ed463461a9307c0c834b520cbf63"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e4aaa66c6e48cba4af062bf03855dfdde9d4eb34","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    services using ``cinder service-list`` command."},{"line_number":8,"context_line":"    But this facility is not present in OSC client."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    So, this feature enables user to list available services"},{"line_number":11,"context_line":"    using below commands"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    ``volume service list``"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    [Bug 1550999 \u0027https://bugs.launchpad.net/python-openstackclient/+bug/1550999\u0027_]"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a122d0e_104f07be","line":13,"range":{"start_line":10,"start_character":4,"end_line":13,"end_character":27},"updated":"2016-04-25 16:51:37.000000000","message":"Suggest:\n\nA user can list available volume services by using:\n\n  ``volume service list``","commit_id":"17a222d0a998ed463461a9307c0c834b520cbf63"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"7d8e1b28ed0a55b3b0f1d969b068ae4308f734bb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    services using ``cinder service-list`` command."},{"line_number":8,"context_line":"    But this facility is not present in OSC client."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    So, this feature enables user to list available services"},{"line_number":11,"context_line":"    using below commands"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    ``volume service list``"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    [Bug 1550999 \u0027https://bugs.launchpad.net/python-openstackclient/+bug/1550999\u0027_]"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1a122d0e_1330b100","line":13,"range":{"start_line":10,"start_character":4,"end_line":13,"end_character":27},"in_reply_to":"1a122d0e_104f07be","updated":"2016-04-25 18:03:44.000000000","message":"Done","commit_id":"17a222d0a998ed463461a9307c0c834b520cbf63"}]}