)]}'
{"openstackclient/network/v2/network.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8f6d8fe9ec8336dea1c724e241aa8fe058835af0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":55,"context_line":"    if parsed_args.disable:"},{"line_number":56,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d False"},{"line_number":57,"context_line":"    elif parsed_args.enable:"},{"line_number":58,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d True"},{"line_number":59,"context_line":"    if parsed_args.share:"},{"line_number":60,"context_line":"        attrs[\u0027shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_aa7e11ac","line":57,"updated":"2016-03-28 21:25:50.000000000","message":"Devref uses if not elif, but probably not a big deal.  Similar comment applies throughout this part.","commit_id":"45adde5e51b9501d58ec99c3a4cc4823bf714b5e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"300d56345fc36d2660316e7dd02df5c8df3fa75f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":55,"context_line":"    if parsed_args.disable:"},{"line_number":56,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d False"},{"line_number":57,"context_line":"    elif parsed_args.enable:"},{"line_number":58,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d True"},{"line_number":59,"context_line":"    if parsed_args.share:"},{"line_number":60,"context_line":"        attrs[\u0027shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_c49374f9","line":57,"in_reply_to":"ba0121b8_aa7e11ac","updated":"2016-03-29 01:30:59.000000000","message":"This is not a deal breaker.\nWe can use elif here because there is no DEFAULT value for disable/enable or share/no_share\n\nIf disable is not specified, it would be given the value False.\nSame goes for all the other 3 options.\n\nIf however, we had a default value present ( for example, if \"disable\" option had \"default\u003dTrue\") then elif should have been changed to \"if\"\n\nI think this is not a major issue, and is mainly attributed to the code, and can be seen as a branch point for the devref","commit_id":"45adde5e51b9501d58ec99c3a4cc4823bf714b5e"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"5c63eeb511aa60ea510e75281376036ba13c110f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":55,"context_line":"    if parsed_args.disable:"},{"line_number":56,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d False"},{"line_number":57,"context_line":"    elif parsed_args.enable:"},{"line_number":58,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d True"},{"line_number":59,"context_line":"    if parsed_args.share:"},{"line_number":60,"context_line":"        attrs[\u0027shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_faccd76b","line":57,"in_reply_to":"ba0121b8_c49374f9","updated":"2016-03-30 20:22:45.000000000","message":"The reason for not using elif is to be defensive against other changes.  Making assumptions about defaults breaks when this code gets copied elsewhere and these assumptions are not documented.","commit_id":"45adde5e51b9501d58ec99c3a4cc4823bf714b5e"}],"openstackclient/network/v2/router.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8f6d8fe9ec8336dea1c724e241aa8fe058835af0","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        distribute_group.add_argument("},{"line_number":251,"context_line":"            \u0027--distributed\u0027,"},{"line_number":252,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":253,"context_line":"            default\u003dNone,"},{"line_number":254,"context_line":"            help\u003d\"Set router to distributed mode (disabled router only)\","},{"line_number":255,"context_line":"        )"},{"line_number":256,"context_line":"        distribute_group.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_0d4d9772","line":253,"updated":"2016-03-28 21:25:50.000000000","message":"I don\u0027t think this is needed per the devref.","commit_id":"45adde5e51b9501d58ec99c3a4cc4823bf714b5e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"300d56345fc36d2660316e7dd02df5c8df3fa75f","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        distribute_group.add_argument("},{"line_number":251,"context_line":"            \u0027--distributed\u0027,"},{"line_number":252,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":253,"context_line":"            default\u003dNone,"},{"line_number":254,"context_line":"            help\u003d\"Set router to distributed mode (disabled router only)\","},{"line_number":255,"context_line":"        )"},{"line_number":256,"context_line":"        distribute_group.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_247230e6","line":253,"in_reply_to":"ba0121b8_0d4d9772","updated":"2016-03-29 01:30:59.000000000","message":"Again, this is not a deal breaker IMHO.\nif --distributed is not specified, instead of being evaluated to False, it will be converted to None.\nThis is just a carry forward from how the option was earlier implemented, and doesnt impact the devref\u0027s overall policy.","commit_id":"45adde5e51b9501d58ec99c3a4cc4823bf714b5e"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"095e2dcc918cba2e8b2827ba4cafb88583078589","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d True"},{"line_number":58,"context_line":"    if parsed_args.disable:"},{"line_number":59,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d False"},{"line_number":60,"context_line":"    if \u0027centralized\u0027 in parsed_args and parsed_args.centralized:"},{"line_number":61,"context_line":"        attrs[\u0027distributed\u0027] \u003d False"},{"line_number":62,"context_line":"    if parsed_args.distributed is not None:"},{"line_number":63,"context_line":"        attrs[\u0027distributed\u0027] \u003d parsed_args.distributed"},{"line_number":64,"context_line":"    if (\u0027availability_zone_hints\u0027 in parsed_args"},{"line_number":65,"context_line":"            and parsed_args.availability_zone_hints is not None):"},{"line_number":66,"context_line":"        attrs[\u0027availability_zone_hints\u0027] \u003d parsed_args.availability_zone_hints"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_70657bb3","line":63,"range":{"start_line":60,"start_character":0,"end_line":63,"end_character":54},"updated":"2016-03-31 03:35:00.000000000","message":"I think the following code have same effect:\n\n    if parsed_args.distributed:\n        attrs[\u0027distributed\u0027] \u003d True\n    if parsed_args.centralized:\n        attrs[\u0027distributed\u0027] \u003d False","commit_id":"f6cbcdda14b89b6a85f7de97934e6414fb07e694"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"890f8d1556c24f48820a71a8ae817232a6e3ebe8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d True"},{"line_number":58,"context_line":"    if parsed_args.disable:"},{"line_number":59,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d False"},{"line_number":60,"context_line":"    if \u0027centralized\u0027 in parsed_args and parsed_args.centralized:"},{"line_number":61,"context_line":"        attrs[\u0027distributed\u0027] \u003d False"},{"line_number":62,"context_line":"    if parsed_args.distributed is not None:"},{"line_number":63,"context_line":"        attrs[\u0027distributed\u0027] \u003d parsed_args.distributed"},{"line_number":64,"context_line":"    if (\u0027availability_zone_hints\u0027 in parsed_args"},{"line_number":65,"context_line":"            and parsed_args.availability_zone_hints is not None):"},{"line_number":66,"context_line":"        attrs[\u0027availability_zone_hints\u0027] \u003d parsed_args.availability_zone_hints"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_90976feb","line":63,"range":{"start_line":60,"start_character":0,"end_line":63,"end_character":54},"in_reply_to":"ba0121b8_70657bb3","updated":"2016-03-31 03:57:31.000000000","message":"I agree with the distributed comment in Line#253, and its impace in Line#62.\nFor Line#60, I would stay with the current proposed code","commit_id":"f6cbcdda14b89b6a85f7de97934e6414fb07e694"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"2ad4875523b8c52f0c6cc30c7bece9e8a3096d13","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d True"},{"line_number":58,"context_line":"    if parsed_args.disable:"},{"line_number":59,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d False"},{"line_number":60,"context_line":"    if \u0027centralized\u0027 in parsed_args and parsed_args.centralized:"},{"line_number":61,"context_line":"        attrs[\u0027distributed\u0027] \u003d False"},{"line_number":62,"context_line":"    if parsed_args.distributed is not None:"},{"line_number":63,"context_line":"        attrs[\u0027distributed\u0027] \u003d parsed_args.distributed"},{"line_number":64,"context_line":"    if (\u0027availability_zone_hints\u0027 in parsed_args"},{"line_number":65,"context_line":"            and parsed_args.availability_zone_hints is not None):"},{"line_number":66,"context_line":"        attrs[\u0027availability_zone_hints\u0027] \u003d parsed_args.availability_zone_hints"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_eb67e0e6","line":63,"range":{"start_line":60,"start_character":0,"end_line":63,"end_character":54},"in_reply_to":"ba0121b8_70657bb3","updated":"2016-03-31 04:06:46.000000000","message":"my fault, forget the create_router logic need these. some comments may be helpful, remind others like me :-)","commit_id":"f6cbcdda14b89b6a85f7de97934e6414fb07e694"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"095e2dcc918cba2e8b2827ba4cafb88583078589","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        distribute_group.add_argument("},{"line_number":251,"context_line":"            \u0027--distributed\u0027,"},{"line_number":252,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":253,"context_line":"            default\u003dNone,"},{"line_number":254,"context_line":"            help\u003d\"Set router to distributed mode (disabled router only)\","},{"line_number":255,"context_line":"        )"},{"line_number":256,"context_line":"        distribute_group.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_f07b4b26","line":253,"range":{"start_line":253,"start_character":12,"end_line":253,"end_character":25},"updated":"2016-03-31 03:35:00.000000000","message":"I think about these in several minutes. 3 cases exist in bool option, True, False, \u0027distributed\u0027 no-present in kwargs(neutron server side decide). so IMO default\u003dNone isn\u0027t necessary if we follow the devref[1], maybe we can remove it in split patches.\n\n\n[1]: http://docs.openstack.org/developer/python-openstackclient/command-options.html#implementation","commit_id":"f6cbcdda14b89b6a85f7de97934e6414fb07e694"}]}