)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3b2887b3401d9c3426b7a99dbcd4c2b910a80efe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tang Chen \u003cchen.tang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-23 11:27:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Subnet pool] Add --project support to \"subnet pool create\" command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds --project and --project-domain options to"},{"line_number":10,"context_line":"\"subnet pool create\" command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_1e654db4","line":7,"updated":"2016-03-23 07:36:34.000000000","message":"this could be shortened though to 50 characters","commit_id":"c484b611baf3ccfd20e0d3b1818b7755d1d35666"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ba9000e53ef984cb77d9c792e990c7132630ea21","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tang Chen \u003cchen.tang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-23 11:27:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Subnet pool] Add --project support to \"subnet pool create\" command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds --project and --project-domain options to"},{"line_number":10,"context_line":"\"subnet pool create\" command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_19ce072e","line":7,"in_reply_to":"fa0719c6_1e654db4","updated":"2016-03-23 08:13:56.000000000","message":"Done","commit_id":"c484b611baf3ccfd20e0d3b1818b7755d1d35666"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ef1101af0a11dcc16632db1af75f99a9ec5eefbd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tang Chen \u003cchen.tang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-23 11:27:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Subnet pool] Add --project support to \"subnet pool create\" command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds --project and --project-domain options to"},{"line_number":10,"context_line":"\"subnet pool create\" command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_df674fb5","line":7,"in_reply_to":"fa0719c6_1e654db4","updated":"2016-03-23 08:47:36.000000000","message":"Hi Reedip, 50 characters are too short, I think. Usually I cannot make a sentence that short to tell what I want to say. Can we limit it in 80 ?","commit_id":"c484b611baf3ccfd20e0d3b1818b7755d1d35666"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bc44d04245123295a6b3bff197b8e28bd68a085e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tang Chen \u003cchen.tang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-23 11:27:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Subnet pool] Add --project support to \"subnet pool create\" command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds --project and --project-domain options to"},{"line_number":10,"context_line":"\"subnet pool create\" command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_1161bbd3","line":7,"in_reply_to":"fa0719c6_df674fb5","updated":"2016-03-23 09:02:38.000000000","message":"You can remove[ subnet pool ] as it is evident from the  \"subnet pool create\" .\nAlso, you can remove the \"command\" at the end of sentence.","commit_id":"c484b611baf3ccfd20e0d3b1818b7755d1d35666"}],"openstackclient/tests/network/v2/test_subnet_pool.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"422b69d63c4f6aab5652968988810048b8d741d6","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.assertRaises(argparse.ArgumentTypeError, self.check_parser,"},{"line_number":145,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_create_project_identity_v2(self):"},{"line_number":148,"context_line":"        # Set identity client v2. And get a shortcut to Identity client."},{"line_number":149,"context_line":"        identity_client \u003d identity_fakes_v2.FakeIdentityv2Client("},{"line_number":150,"context_line":"            endpoint\u003dfakes.AUTH_URL,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_c9894128","line":147,"updated":"2016-03-23 15:24:23.000000000","message":"Do we really need to run unit tests for v2 and v3?  Is v3 sufficient?","commit_id":"457c38226bb6b51114839491a79dc9114bfd6896"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"d7ed95f1dd1cad9fa3a6328cd285e53d49b843c3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.assertRaises(argparse.ArgumentTypeError, self.check_parser,"},{"line_number":145,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_create_project_identity_v2(self):"},{"line_number":148,"context_line":"        # Set identity client v2. And get a shortcut to Identity client."},{"line_number":149,"context_line":"        identity_client \u003d identity_fakes_v2.FakeIdentityv2Client("},{"line_number":150,"context_line":"            endpoint\u003dfakes.AUTH_URL,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_5443d612","line":147,"in_reply_to":"fa0719c6_4f34eadc","updated":"2016-03-24 11:37:42.000000000","message":"This was discussed some here: https://review.openstack.org/#/c/279273/12/openstackclient/tests/network/v2/test_subnet.py\n\nIf there is unique value in v2 and v3 tests for this command then I think they should be kept, otherwise dropped.","commit_id":"457c38226bb6b51114839491a79dc9114bfd6896"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"449c157dd40ddc8f5e06fe960895ffe9d44f3cb3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        self.assertRaises(argparse.ArgumentTypeError, self.check_parser,"},{"line_number":145,"context_line":"                          self.cmd, arglist, verifylist)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def test_create_project_identity_v2(self):"},{"line_number":148,"context_line":"        # Set identity client v2. And get a shortcut to Identity client."},{"line_number":149,"context_line":"        identity_client \u003d identity_fakes_v2.FakeIdentityv2Client("},{"line_number":150,"context_line":"            endpoint\u003dfakes.AUTH_URL,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_4f34eadc","line":147,"in_reply_to":"fa0719c6_c9894128","updated":"2016-03-24 08:20:54.000000000","message":"Well, I was following the tests of \"network create\". It tested identity v2 and v3. \n\nAnd also, many productions are still using  identity v2. But since it is just unit test, I think it is OK that we don\u0027t test identity v2.\n\nLet\u0027s wait Dean and Steve\u0027s suggestion on this. :)\nIf we don\u0027t need to test identity v2 in unit tests, I\u0027ll do a refactor for network create tests.","commit_id":"457c38226bb6b51114839491a79dc9114bfd6896"}],"releasenotes/notes/bug-1544586-0e6ca9a09dac0726.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"422b69d63c4f6aab5652968988810048b8d741d6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``subnet pool create`` command."},{"line_number":4,"context_line":"    [Bug `1544586 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544586\u003e`_]"},{"line_number":5,"context_line":"  - Command ``subnet pool create`` now supports --project and --project-domain"},{"line_number":6,"context_line":"    options."},{"line_number":7,"context_line":"    [Bug `1544586 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544586\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa0719c6_29255d08","line":5,"updated":"2016-03-23 15:24:23.000000000","message":"Many release notes use `` around options as well.","commit_id":"457c38226bb6b51114839491a79dc9114bfd6896"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"449c157dd40ddc8f5e06fe960895ffe9d44f3cb3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``subnet pool create`` command."},{"line_number":4,"context_line":"    [Bug `1544586 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544586\u003e`_]"},{"line_number":5,"context_line":"  - Command ``subnet pool create`` now supports --project and --project-domain"},{"line_number":6,"context_line":"    options."},{"line_number":7,"context_line":"    [Bug `1544586 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544586\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa0719c6_7c188ed3","line":5,"in_reply_to":"fa0719c6_29255d08","updated":"2016-03-24 08:20:54.000000000","message":"Done","commit_id":"457c38226bb6b51114839491a79dc9114bfd6896"}]}
