)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"adbe6ec465b7c39b5626e8c682842eede8c77d61","unresolved":false,"context_lines":[{"line_number":10,"context_line":"commands, and --no-address-scope option to \"subnet pool set\""},{"line_number":11,"context_line":"command to clear the address scope setting."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch also removes the release notes for ``subnet pool create/set``"},{"line_number":14,"context_line":"because a big release note will be added to cover them all."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie2c370a50b52574fa6ec268083ad013b7544361e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9a061dce_2f24cfad","line":13,"updated":"2016-04-08 12:24:45.000000000","message":"I don\u0027t understand why this patch set is removing the release note.  Dean just cleaned up the release note and I haven\u0027t seen a patch set to add this back.","commit_id":"dd5eb9b27f1b2a5eb8c1131feac01d0d3fdd430c"}],"doc/source/command-objects/subnet-pool.rst":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"f8d0c3d0dec256104b5b6bb5bd23ed1d84d9d671","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":".. option:: --address-scope \u003caddress-scope\u003e"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    Set address scope associated with the subnet pool"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":".. option:: --clear-address-scope"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da0c15f0_7cb03f8c","line":131,"updated":"2016-03-25 04:15:12.000000000","message":"Add \"ID only\" to this to keep it consistent with the create call","commit_id":"32fbb77dab515809257b04e13aeb06f4b04a5ff9"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"163062ba9af3b4d137b7b1763e07d0489d5ebac0","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":".. option:: --address-scope \u003caddress-scope\u003e"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    Set address scope associated with the subnet pool"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":".. option:: --clear-address-scope"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da0c15f0_e476713d","line":131,"in_reply_to":"da0c15f0_7cb03f8c","updated":"2016-03-25 08:19:45.000000000","message":"Done","commit_id":"32fbb77dab515809257b04e13aeb06f4b04a5ff9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"31a9795152a59bd97b7c18b280b9d22dbac8a901","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        [--default-prefix-length \u003cdefault-prefix-length\u003e]"},{"line_number":103,"context_line":"        [--min-prefix-length \u003cmin-prefix-length\u003e]"},{"line_number":104,"context_line":"        [--max-prefix-length \u003cmax-prefix-length\u003e]"},{"line_number":105,"context_line":"        [--address-scope \u003caddress-scope\u003e | --no-address-scope]"},{"line_number":106,"context_line":"        \u003csubnet-pool\u003e"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba0121b8_f8dbd14d","line":105,"updated":"2016-04-01 18:44:58.000000000","message":"Since --address-scope is not an option with multiple values, I wonder if this should have an unset action.  I\u0027m okay with --no here, but would like Dean to comment.","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"82338b51dc3cd95de3e63ca3aeb99a9316ceea27","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        [--default-prefix-length \u003cdefault-prefix-length\u003e]"},{"line_number":103,"context_line":"        [--min-prefix-length \u003cmin-prefix-length\u003e]"},{"line_number":104,"context_line":"        [--max-prefix-length \u003cmax-prefix-length\u003e]"},{"line_number":105,"context_line":"        [--address-scope \u003caddress-scope\u003e | --no-address-scope]"},{"line_number":106,"context_line":"        \u003csubnet-pool\u003e"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a061dce_142c4a01","line":105,"in_reply_to":"9a061dce_0e6e082f","updated":"2016-04-05 11:32:25.000000000","message":"Hi Richard,\n\nI opened a bug for address scope CRUD. \n\nhttps://bugs.launchpad.net/python-openstackclient/+bug/1566269","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"dbeb836e9858a2b5e8740da7d59f50d1496461a0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        [--default-prefix-length \u003cdefault-prefix-length\u003e]"},{"line_number":103,"context_line":"        [--min-prefix-length \u003cmin-prefix-length\u003e]"},{"line_number":104,"context_line":"        [--max-prefix-length \u003cmax-prefix-length\u003e]"},{"line_number":105,"context_line":"        [--address-scope \u003caddress-scope\u003e | --no-address-scope]"},{"line_number":106,"context_line":"        \u003csubnet-pool\u003e"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a061dce_0e6e082f","line":105,"in_reply_to":"ba0121b8_be0301be","updated":"2016-04-05 10:14:24.000000000","message":"Shall we make a decision for this point ? If we try to clear an attribute, what should we do, set it to None or \"\" ? And add the rule to the doc. But this could be specific to the implementation on the server side.","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cc591c9e969696212c7dc83d0d249e041f5fbd0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        [--default-prefix-length \u003cdefault-prefix-length\u003e]"},{"line_number":103,"context_line":"        [--min-prefix-length \u003cmin-prefix-length\u003e]"},{"line_number":104,"context_line":"        [--max-prefix-length \u003cmax-prefix-length\u003e]"},{"line_number":105,"context_line":"        [--address-scope \u003caddress-scope\u003e | --no-address-scope]"},{"line_number":106,"context_line":"        \u003csubnet-pool\u003e"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"9a061dce_851a216d","line":105,"in_reply_to":"ba0121b8_be0301be","updated":"2016-04-04 12:35:01.000000000","message":"Thanks Dean.  I suspect --no is needed here and that blank is not sufficient.  Another follow-up question...are you okay with \"address scope\" being the OSC object name for the related CRUD commands?","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"9df06f5392c76fac5152d88c8883654579c85249","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        [--default-prefix-length \u003cdefault-prefix-length\u003e]"},{"line_number":103,"context_line":"        [--min-prefix-length \u003cmin-prefix-length\u003e]"},{"line_number":104,"context_line":"        [--max-prefix-length \u003cmax-prefix-length\u003e]"},{"line_number":105,"context_line":"        [--address-scope \u003caddress-scope\u003e | --no-address-scope]"},{"line_number":106,"context_line":"        \u003csubnet-pool\u003e"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba0121b8_be0301be","line":105,"in_reply_to":"ba0121b8_f8dbd14d","updated":"2016-04-01 19:32:01.000000000","message":"In a set command, how would you remove an existing address scope otherwise?  Assuming that \"\" !\u003d None !\u003d \u003cdata-not-present\u003e","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"}],"openstackclient/network/v2/subnet_pool.py":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"f8d0c3d0dec256104b5b6bb5bd23ed1d84d9d671","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        attrs[\u0027min_prefix_length\u0027] \u003d parsed_args.min_prefix_length"},{"line_number":46,"context_line":"    if parsed_args.max_prefix_length is not None:"},{"line_number":47,"context_line":"        attrs[\u0027max_prefix_length\u0027] \u003d parsed_args.max_prefix_length"},{"line_number":48,"context_line":"    if parsed_args.address_scope is not None:"},{"line_number":49,"context_line":"        attrs[\u0027address_scope_id\u0027] \u003d parsed_args.address_scope"},{"line_number":50,"context_line":"    if \u0027clear_address_scope\u0027 in parsed_args and \\"},{"line_number":51,"context_line":"       parsed_args.clear_address_scope:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_1c72e3e5","line":48,"updated":"2016-03-25 04:15:12.000000000","message":"Consider adding a comment explaining that when the SDK supports looking up an address scope by name, that this code should be enhanced to take in address scope names and convert them to the ID.","commit_id":"32fbb77dab515809257b04e13aeb06f4b04a5ff9"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"163062ba9af3b4d137b7b1763e07d0489d5ebac0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        attrs[\u0027min_prefix_length\u0027] \u003d parsed_args.min_prefix_length"},{"line_number":46,"context_line":"    if parsed_args.max_prefix_length is not None:"},{"line_number":47,"context_line":"        attrs[\u0027max_prefix_length\u0027] \u003d parsed_args.max_prefix_length"},{"line_number":48,"context_line":"    if parsed_args.address_scope is not None:"},{"line_number":49,"context_line":"        attrs[\u0027address_scope_id\u0027] \u003d parsed_args.address_scope"},{"line_number":50,"context_line":"    if \u0027clear_address_scope\u0027 in parsed_args and \\"},{"line_number":51,"context_line":"       parsed_args.clear_address_scope:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_84921556","line":48,"in_reply_to":"da0c15f0_1c72e3e5","updated":"2016-03-25 08:19:45.000000000","message":"Done","commit_id":"32fbb77dab515809257b04e13aeb06f4b04a5ff9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f3c1969d6b4b1398d2290bda1a311cbdc60735be","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        attrs[\u0027min_prefix_length\u0027] \u003d parsed_args.min_prefix_length"},{"line_number":46,"context_line":"    if parsed_args.max_prefix_length is not None:"},{"line_number":47,"context_line":"        attrs[\u0027max_prefix_length\u0027] \u003d parsed_args.max_prefix_length"},{"line_number":48,"context_line":"    if parsed_args.address_scope is not None:"},{"line_number":49,"context_line":"        attrs[\u0027address_scope_id\u0027] \u003d parsed_args.address_scope"},{"line_number":50,"context_line":"    if \u0027clear_address_scope\u0027 in parsed_args and \\"},{"line_number":51,"context_line":"       parsed_args.clear_address_scope:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_9eca5da0","line":48,"in_reply_to":"da0c15f0_84921556","updated":"2016-03-25 11:21:03.000000000","message":"SDK address scope support is hopefully coming soon: https://review.openstack.org/#/c/291886/","commit_id":"32fbb77dab515809257b04e13aeb06f4b04a5ff9"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"f8d0c3d0dec256104b5b6bb5bd23ed1d84d9d671","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            help\u003d\u0027Set subnet pool name\u0027,"},{"line_number":212,"context_line":"        )"},{"line_number":213,"context_line":"        _add_prefix_options(parser)"},{"line_number":214,"context_line":"        routes_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":215,"context_line":"        routes_group.add_argument("},{"line_number":216,"context_line":"            \u0027--address-scope\u0027,"},{"line_number":217,"context_line":"            metavar\u003d\u0027\u003caddress-scope\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_1cf823e5","line":214,"updated":"2016-03-25 04:15:12.000000000","message":"Why routes_group?  It seems confusing to name it this, maybe change it to scope_group?","commit_id":"32fbb77dab515809257b04e13aeb06f4b04a5ff9"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"163062ba9af3b4d137b7b1763e07d0489d5ebac0","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            help\u003d\u0027Set subnet pool name\u0027,"},{"line_number":212,"context_line":"        )"},{"line_number":213,"context_line":"        _add_prefix_options(parser)"},{"line_number":214,"context_line":"        routes_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":215,"context_line":"        routes_group.add_argument("},{"line_number":216,"context_line":"            \u0027--address-scope\u0027,"},{"line_number":217,"context_line":"            metavar\u003d\u0027\u003caddress-scope\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_048d6531","line":214,"in_reply_to":"da0c15f0_1cf823e5","updated":"2016-03-25 08:19:45.000000000","message":"...Yes, the copy thing. :)","commit_id":"32fbb77dab515809257b04e13aeb06f4b04a5ff9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"56d1222f658088ae558e874d0e0217f682c13f62","unresolved":false,"context_lines":[{"line_number":221,"context_line":"            help\u003d\"Set address scope associated with the subnet pool (ID only)\","},{"line_number":222,"context_line":"        )"},{"line_number":223,"context_line":"        address_scope_group.add_argument("},{"line_number":224,"context_line":"            \u0027--clear-address-scope\u0027,"},{"line_number":225,"context_line":"            dest\u003d\u0027clear_address_scope\u0027,"},{"line_number":226,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":227,"context_line":"            default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_289aea14","line":224,"updated":"2016-03-25 15:09:53.000000000","message":"Please see https://review.openstack.org/#/c/297718/ where we are deciding how to handle such options.","commit_id":"e0817dcf75cbc9e17289cd187ec2f05a7c9ffdab"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ad25b50fece739e61dacce62401d046cd526de2e","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        address_scope_group.add_argument("},{"line_number":219,"context_line":"            \u0027--address-scope\u0027,"},{"line_number":220,"context_line":"            metavar\u003d\u0027\u003caddress-scope\u003e\u0027,"},{"line_number":221,"context_line":"            help\u003d\"Set address scope associated with the subnet pool (ID only)\","},{"line_number":222,"context_line":"        )"},{"line_number":223,"context_line":"        address_scope_group.add_argument("},{"line_number":224,"context_line":"            \u0027--clear-address-scope\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_f176353d","line":221,"updated":"2016-03-29 03:12:15.000000000","message":"Can we keep the help information similar with CreateSubnetPool?","commit_id":"6eb6a7c96e38aba58f26b7185ea3272db3f603b1"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ae8f04aa74a45ba0b4d0a7ba1c47add5f166d4c6","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        address_scope_group.add_argument("},{"line_number":219,"context_line":"            \u0027--address-scope\u0027,"},{"line_number":220,"context_line":"            metavar\u003d\u0027\u003caddress-scope\u003e\u0027,"},{"line_number":221,"context_line":"            help\u003d\"Set address scope associated with the subnet pool (ID only)\","},{"line_number":222,"context_line":"        )"},{"line_number":223,"context_line":"        address_scope_group.add_argument("},{"line_number":224,"context_line":"            \u0027--clear-address-scope\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_4087490f","line":221,"in_reply_to":"ba0121b8_f176353d","updated":"2016-03-29 06:52:44.000000000","message":"Done","commit_id":"6eb6a7c96e38aba58f26b7185ea3272db3f603b1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ad25b50fece739e61dacce62401d046cd526de2e","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        )"},{"line_number":223,"context_line":"        address_scope_group.add_argument("},{"line_number":224,"context_line":"            \u0027--clear-address-scope\u0027,"},{"line_number":225,"context_line":"            dest\u003d\u0027clear_address_scope\u0027,"},{"line_number":226,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":227,"context_line":"            default\u003dFalse,"},{"line_number":228,"context_line":"            help\u003d\"Clear address scope associated with the subnet pool\","}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_318f0d25","line":225,"updated":"2016-03-29 03:12:15.000000000","message":"No need for dest.","commit_id":"6eb6a7c96e38aba58f26b7185ea3272db3f603b1"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ae8f04aa74a45ba0b4d0a7ba1c47add5f166d4c6","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        )"},{"line_number":223,"context_line":"        address_scope_group.add_argument("},{"line_number":224,"context_line":"            \u0027--clear-address-scope\u0027,"},{"line_number":225,"context_line":"            dest\u003d\u0027clear_address_scope\u0027,"},{"line_number":226,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":227,"context_line":"            default\u003dFalse,"},{"line_number":228,"context_line":"            help\u003d\"Clear address scope associated with the subnet pool\","}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_45259ba9","line":225,"in_reply_to":"ba0121b8_318f0d25","updated":"2016-03-29 06:52:44.000000000","message":"Done","commit_id":"6eb6a7c96e38aba58f26b7185ea3272db3f603b1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ad25b50fece739e61dacce62401d046cd526de2e","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            \u0027--clear-address-scope\u0027,"},{"line_number":225,"context_line":"            dest\u003d\u0027clear_address_scope\u0027,"},{"line_number":226,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":227,"context_line":"            default\u003dFalse,"},{"line_number":228,"context_line":"            help\u003d\"Clear address scope associated with the subnet pool\","},{"line_number":229,"context_line":"        )"},{"line_number":230,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_b1a31d9e","line":227,"updated":"2016-03-29 03:12:15.000000000","message":"no need for default.\nIf you do not pass --clear-address-scope in the CLI and the action is \u0027store_true\u0027 , argparse will send clear_address_scope as False.","commit_id":"6eb6a7c96e38aba58f26b7185ea3272db3f603b1"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ae8f04aa74a45ba0b4d0a7ba1c47add5f166d4c6","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            \u0027--clear-address-scope\u0027,"},{"line_number":225,"context_line":"            dest\u003d\u0027clear_address_scope\u0027,"},{"line_number":226,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":227,"context_line":"            default\u003dFalse,"},{"line_number":228,"context_line":"            help\u003d\"Clear address scope associated with the subnet pool\","},{"line_number":229,"context_line":"        )"},{"line_number":230,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_254d0773","line":227,"in_reply_to":"ba0121b8_b1a31d9e","updated":"2016-03-29 06:52:44.000000000","message":"Done","commit_id":"6eb6a7c96e38aba58f26b7185ea3272db3f603b1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"682e1cc48f803a722fc88204320bf919140e59d0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    if parsed_args.max_prefix_length is not None:"},{"line_number":47,"context_line":"        attrs[\u0027max_prefixlen\u0027] \u003d parsed_args.max_prefix_length"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    # TODO(tangchen): When the SDK supports find an address scope by name,"},{"line_number":50,"context_line":"    # need to support lookup address scope by name here."},{"line_number":51,"context_line":"    if parsed_args.address_scope is not None:"},{"line_number":52,"context_line":"        attrs[\u0027address_scope_id\u0027] \u003d parsed_args.address_scope"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_588f5dcc","line":49,"updated":"2016-04-01 18:48:43.000000000","message":"No need to wait, address scopes are in the SDK now: https://review.openstack.org/#/c/291886/.  Brian should be providing a new release of the SDK soon.","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"dbeb836e9858a2b5e8740da7d59f50d1496461a0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    if parsed_args.max_prefix_length is not None:"},{"line_number":47,"context_line":"        attrs[\u0027max_prefixlen\u0027] \u003d parsed_args.max_prefix_length"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    # TODO(tangchen): When the SDK supports find an address scope by name,"},{"line_number":50,"context_line":"    # need to support lookup address scope by name here."},{"line_number":51,"context_line":"    if parsed_args.address_scope is not None:"},{"line_number":52,"context_line":"        attrs[\u0027address_scope_id\u0027] \u003d parsed_args.address_scope"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_443581d8","line":49,"in_reply_to":"ba0121b8_01c9f0ac","updated":"2016-04-05 10:14:24.000000000","message":"OK, thanks for the quick patch. :)","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fcade0781e5e752252317a1f68a4387f33c24f55","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    if parsed_args.max_prefix_length is not None:"},{"line_number":47,"context_line":"        attrs[\u0027max_prefixlen\u0027] \u003d parsed_args.max_prefix_length"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    # TODO(tangchen): When the SDK supports find an address scope by name,"},{"line_number":50,"context_line":"    # need to support lookup address scope by name here."},{"line_number":51,"context_line":"    if parsed_args.address_scope is not None:"},{"line_number":52,"context_line":"        attrs[\u0027address_scope_id\u0027] \u003d parsed_args.address_scope"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_01c9f0ac","line":49,"in_reply_to":"ba0121b8_588f5dcc","updated":"2016-04-01 19:44:14.000000000","message":"Release is available: https://pypi.python.org/pypi/openstacksdk/0.8.4","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fce51540255b40ab36ac3a06eb1db9688e56fff2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    if parsed_args.max_prefix_length is not None:"},{"line_number":49,"context_line":"        attrs[\u0027max_prefixlen\u0027] \u003d parsed_args.max_prefix_length"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    if parsed_args.address_scope is not None:"},{"line_number":52,"context_line":"        attrs[\u0027address_scope_id\u0027] \u003d network_client.find_address_scope("},{"line_number":53,"context_line":"            parsed_args.address_scope, ignore_missing\u003dFalse).id"},{"line_number":54,"context_line":"    if \u0027no_address_scope\u0027 in parsed_args and parsed_args.no_address_scope:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a18252c_a0e39c32","line":51,"updated":"2016-04-13 01:38:05.000000000","message":"Why dont you do parsed_args.address_scope ?\nThis is just my opinion","commit_id":"b3649a54cd59dc069c76cbbcd876a1610aee00c0"}],"openstackclient/tests/network/v2/test_subnet_pool.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"31a9795152a59bd97b7c18b280b9d22dbac8a901","unresolved":false,"context_lines":[{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    def test_set_address_scope(self):"},{"line_number":411,"context_line":"        arglist \u003d ["},{"line_number":412,"context_line":"            self._subnet_pool.name,"},{"line_number":413,"context_line":"            \u0027--address-scope\u0027, self._subnet_pool.address_scope_id,"},{"line_number":414,"context_line":"        ]"},{"line_number":415,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_d80fed86","line":412,"updated":"2016-04-01 18:44:58.000000000","message":"Options are usually before positional arguments.","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"dbeb836e9858a2b5e8740da7d59f50d1496461a0","unresolved":false,"context_lines":[{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    def test_set_address_scope(self):"},{"line_number":411,"context_line":"        arglist \u003d ["},{"line_number":412,"context_line":"            self._subnet_pool.name,"},{"line_number":413,"context_line":"            \u0027--address-scope\u0027, self._subnet_pool.address_scope_id,"},{"line_number":414,"context_line":"        ]"},{"line_number":415,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_0edc48e3","line":412,"in_reply_to":"ba0121b8_d80fed86","updated":"2016-04-05 10:14:24.000000000","message":"Done","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"31a9795152a59bd97b7c18b280b9d22dbac8a901","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def test_set_no_address_scope(self):"},{"line_number":431,"context_line":"        arglist \u003d ["},{"line_number":432,"context_line":"            self._subnet_pool.name,"},{"line_number":433,"context_line":"            \u0027--address-scope\u0027, self._subnet_pool.address_scope_id,"},{"line_number":434,"context_line":"            \u0027--no-address-scope\u0027,"},{"line_number":435,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_9815759d","line":432,"updated":"2016-04-01 18:44:58.000000000","message":"Options are usually before positional arguments.","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"dbeb836e9858a2b5e8740da7d59f50d1496461a0","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def test_set_no_address_scope(self):"},{"line_number":431,"context_line":"        arglist \u003d ["},{"line_number":432,"context_line":"            self._subnet_pool.name,"},{"line_number":433,"context_line":"            \u0027--address-scope\u0027, self._subnet_pool.address_scope_id,"},{"line_number":434,"context_line":"            \u0027--no-address-scope\u0027,"},{"line_number":435,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_eed8f4f1","line":432,"in_reply_to":"ba0121b8_9815759d","updated":"2016-04-05 10:14:24.000000000","message":"Done","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5fbbb2718e31f392c6c0c7cf22dc9bc1f3a60e80","unresolved":false,"context_lines":[{"line_number":438,"context_line":"            self._subnet_pool, **attrs)"},{"line_number":439,"context_line":"        self.assertIsNone(result)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def test_set_no_address_scope(self):"},{"line_number":442,"context_line":"        arglist \u003d ["},{"line_number":443,"context_line":"            \u0027--address-scope\u0027, self._address_scope.id,"},{"line_number":444,"context_line":"            \u0027--no-address-scope\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a061dce_96c8d056","line":441,"updated":"2016-04-07 14:40:03.000000000","message":"Did you intend to have this test verify --no-address-scope since that is what the test name implies?","commit_id":"884f3b0332c62f030e49f44a02f6a06428503e6c"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"03588e0e8e771722a510f1190b04a57bfbdb870d","unresolved":false,"context_lines":[{"line_number":438,"context_line":"            self._subnet_pool, **attrs)"},{"line_number":439,"context_line":"        self.assertIsNone(result)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def test_set_no_address_scope(self):"},{"line_number":442,"context_line":"        arglist \u003d ["},{"line_number":443,"context_line":"            \u0027--address-scope\u0027, self._address_scope.id,"},{"line_number":444,"context_line":"            \u0027--no-address-scope\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a061dce_fa9d8a0a","line":441,"in_reply_to":"9a061dce_96c8d056","updated":"2016-04-08 04:02:49.000000000","message":"OK, the name is misleading. Will add a case to test --no-address-scope option.","commit_id":"884f3b0332c62f030e49f44a02f6a06428503e6c"}],"releasenotes/notes/bug-1544586-0e6ca9a09dac0726.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"31a9795152a59bd97b7c18b280b9d22dbac8a901","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ``--project-domain`` options."},{"line_number":7,"context_line":"    [Bug `1544586 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544586\u003e`_]"},{"line_number":8,"context_line":"  - Command ``subnet pool create`` now supports ``--address-scope`` option."},{"line_number":9,"context_line":"    Only address scope id is supported for now because OpenStack SDK does not"},{"line_number":10,"context_line":"    support find an address scope with a name."},{"line_number":11,"context_line":"    [Bug `1544586 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544586\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ba0121b8_d8ea4dac","line":9,"updated":"2016-04-01 18:44:58.000000000","message":"I don\u0027t think this needs to be mentioned.","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"dbeb836e9858a2b5e8740da7d59f50d1496461a0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ``--project-domain`` options."},{"line_number":7,"context_line":"    [Bug `1544586 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544586\u003e`_]"},{"line_number":8,"context_line":"  - Command ``subnet pool create`` now supports ``--address-scope`` option."},{"line_number":9,"context_line":"    Only address scope id is supported for now because OpenStack SDK does not"},{"line_number":10,"context_line":"    support find an address scope with a name."},{"line_number":11,"context_line":"    [Bug `1544586 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544586\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a061dce_3a498760","line":9,"in_reply_to":"ba0121b8_7ef049ca","updated":"2016-04-05 10:14:24.000000000","message":"Done","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"9df06f5392c76fac5152d88c8883654579c85249","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    ``--project-domain`` options."},{"line_number":7,"context_line":"    [Bug `1544586 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544586\u003e`_]"},{"line_number":8,"context_line":"  - Command ``subnet pool create`` now supports ``--address-scope`` option."},{"line_number":9,"context_line":"    Only address scope id is supported for now because OpenStack SDK does not"},{"line_number":10,"context_line":"    support find an address scope with a name."},{"line_number":11,"context_line":"    [Bug `1544586 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544586\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ba0121b8_7ef049ca","line":9,"in_reply_to":"ba0121b8_d8ea4dac","updated":"2016-04-01 19:32:01.000000000","message":"Correct.  These are user notes, not developer notes","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"}],"releasenotes/notes/bug-1544591-267fd16cc5efffe6.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"31a9795152a59bd97b7c18b280b9d22dbac8a901","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    [Bug `1544591 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544591\u003e`_]"},{"line_number":5,"context_line":"  - Command ``subnet pool set`` now supports ``--address-scope`` and"},{"line_number":6,"context_line":"    ``--clear-address-scope`` options."},{"line_number":7,"context_line":"    Only address scope id is supported for now because OpenStack SDK does not"},{"line_number":8,"context_line":"    support find an address scope with a name."},{"line_number":9,"context_line":"    [Bug `1544591 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544591\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ba0121b8_d801ad6c","line":7,"updated":"2016-04-01 18:44:58.000000000","message":"I don\u0027t think this needs to be mentioned.","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"dbeb836e9858a2b5e8740da7d59f50d1496461a0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    [Bug `1544591 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544591\u003e`_]"},{"line_number":5,"context_line":"  - Command ``subnet pool set`` now supports ``--address-scope`` and"},{"line_number":6,"context_line":"    ``--clear-address-scope`` options."},{"line_number":7,"context_line":"    Only address scope id is supported for now because OpenStack SDK does not"},{"line_number":8,"context_line":"    support find an address scope with a name."},{"line_number":9,"context_line":"    [Bug `1544591 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544591\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9a061dce_1a3be3d2","line":7,"in_reply_to":"ba0121b8_d801ad6c","updated":"2016-04-05 10:14:24.000000000","message":"Done","commit_id":"cabd0fe81307eba3d342e1bcc68764bba25c3662"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"7913a10acaf83a86d28993a49e8063b8a9a1a08f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Add ``subnet pool set`` command."},{"line_number":4,"context_line":"    [Bug `1544591 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544591\u003e`_]"},{"line_number":5,"context_line":"  - Command ``subnet pool set`` now supports ``--address-scope`` and"},{"line_number":6,"context_line":"    ``--clear-address-scope`` options."},{"line_number":7,"context_line":"    [Bug `1544591 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544591\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a061dce_1876d3a3","line":6,"updated":"2016-04-07 00:51:05.000000000","message":"Nit: --no-address-scope","commit_id":"b4c0aab1503706cd6588e97a6705e1f2339a5b34"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"c231a2951f23d9ccc3fd6cc28b68efd1c504278b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Add ``subnet pool set`` command."},{"line_number":4,"context_line":"    [Bug `1544591 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544591\u003e`_]"},{"line_number":5,"context_line":"  - Command ``subnet pool set`` now supports ``--address-scope`` and"},{"line_number":6,"context_line":"    ``--clear-address-scope`` options."},{"line_number":7,"context_line":"    [Bug `1544591 \u003chttps://bugs.launchpad.net/python-openstackclient/+bug/1544591\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9a061dce_1862533e","line":6,"in_reply_to":"9a061dce_1876d3a3","updated":"2016-04-07 01:19:21.000000000","message":"Done","commit_id":"b4c0aab1503706cd6588e97a6705e1f2339a5b34"}]}